Skip to contentSkip to conversation

tc6393xb: fix wrong goto labels for error handling

PATCH Applied Axel Lin 3 participants 4 messages Aug 3, 2010 Multifunction devices (MFD)

lore
Share & tools
lore

Axel Lin

author
#0 lore raw

PATCH 1/1 tc6393xb: fix wrong goto labels for error handling

This patch corrects the error handling path.

---
 drivers/mfd/tc6393xb.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)
drivers/mfd/tc6393xb.c +2 -2
index fcf9068..ef6c42c 100644
@@ -732,9 +732,9 @@ err_gpio_add:
 	if (tc6393xb->gpio.base != -1)
 		temp = gpiochip_remove(&tc6393xb->gpio);
 	tcpd->disable(dev);
-err_clk_enable:
-	clk_disable(tc6393xb->clk);
 err_enable:
+	clk_disable(tc6393xb->clk);
+err_clk_enable:
 	iounmap(tc6393xb->scr);
 err_ioremap:
 	release_resource(&tc6393xb->rscr);
Signature · 1 line
1.5.4.3
Applied
#1 lore raw
Quoted 1 line · Axel Lin

This patch corrects the error handling path.

Applied, thanks.

Cheers,
Samuel.

Signature · 2 lines
Intel Open Source Technology Centre
http://oss.intel.com/
#2 lore raw

Whoops, didnt see your message Samuel :)

Quoted 11 lines · Samuel Ortiz
Quoted 1 line · Axel Lin

This patch corrects the error handling path.

Applied, thanks.

Cheers,
Samuel.

--
Intel Open Source Technology Centre
http://oss.intel.com/

Acked-by on v1 1/1
#3 lore raw
In reply to Axel Lin
Quoted 29 lines · Axel Lin

This patch corrects the error handling path.

---
 drivers/mfd/tc6393xb.c |    4 ++--

 1 files changed, 2 insertions(+), 2 deletions(-)
drivers/mfd/tc6393xb.c +0 -2
index fcf9068..ef6c42c 100644
@@ -732,9 +732,9 @@ err_gpio_add:
        if (tc6393xb->gpio.base != -1)
                temp = gpiochip_remove(&tc6393xb->gpio);
        tcpd->disable(dev);
-err_clk_enable:
-       clk_disable(tc6393xb->clk);

 err_enable:
+       clk_disable(tc6393xb->clk);
+err_clk_enable:
       iounmap(tc6393xb->scr);
 err_ioremap:
       release_resource(&tc6393xb->rscr);
--
1.5.4.3