agp: intel-agp: do not use PCI resources before pci_enable_device()
Subsystems (2)
PATCH 2/11 agp: intel-agp: do not use PCI resources before pci_enable_device()
IRQ and resource[] may not have correct values until after PCI hotplug setup occurs at pci_enable_device() time.
The semantic match that finds this problem is as follows:
// <smpl>
@@
identifier x;
identifier request ~= "pci_request.*|pci_resource.*"; @@
(
* x->irq
|
* x->resource
|
* request(x, ...)
)
...*pci_enable_device(x)
// </smpl>
Signed-off-by Kulikov Vasiliy <[email protected]>
--- drivers/char/agp/intel-agp.c | 22 +++++++++++----------- 1 files changed, 11 insertions(+), 11 deletions(-)
drivers/char/agp/intel-agp.c +11 -11
@@ -908,6 +908,17 @@ static int __devinit agp_intel_probe(struct pci_dev *pdev,dev_info (&pdev->dev,"Intel %s Chipset\n" , intel_agp_chipsets[i].name);/* +* If the device has not been properly setup, the following will catch +* the problem and should stop the system from crashing. +* 20030610 - [email protected] +*/ +if (pci_enable_device (pdev)) { +dev_err (&pdev->dev,"can't enable PCI device\n" ); +agp_put_bridge (bridge); +return -ENODEV ; + } + +/* * The following fixes the case where the BIOS has "forgotten" to * provide an address range for the GART. * 20030610 - [email protected]
@@ -921,17 +932,6 @@ static int __devinit agp_intel_probe(struct pci_dev *pdev, } } -/* -* If the device has not been properly setup, the following will catch -* the problem and should stop the system from crashing. -* 20030610 - [email protected] -*/ -if (pci_enable_device (pdev)) { -dev_err (&pdev->dev,"can't enable PCI device\n" ); -agp_put_bridge (bridge); -return -ENODEV ; - } -/* Fill in the mode register */ if (cap_ptr) { pci_read_config_dword(pdev,
Signature · 1 line
1.7.0.4