via-velocity: do not use PCI resources before pci_enable_device()
Subsystems (3)
PATCH 5/11 via-velocity: do not use PCI resources before pci_enable_device()
IRQ and resource[] may not have correct values until after PCI hotplug setup occurs at pci_enable_device() time.
The semantic match that finds this problem is as follows:
// <smpl>
@@
identifier x;
identifier request ~= "pci_request.*|pci_resource.*"; @@
(
* x->irq
|
* x->resource
|
* request(x, ...)
)
...*pci_enable_device(x)
// </smpl>
Signed-off-by Kulikov Vasiliy <[email protected]>
--- drivers/net/via-velocity.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-)
drivers/net/via-velocity.c +2 -2
@@ -2763,12 +2763,12 @@ static int __devinit velocity_found1(struct pci_dev *pdev, const struct pci_devi vptr->dev = dev; - dev->irq = pdev->irq; - ret =pci_enable_device (pdev);if (ret <0 ) goto err_free_dev; + dev->irq = pdev->irq; + ret =velocity_get_pci_info (vptr, pdev);if (ret <0 ) {/* error message already printed */
Signature · 1 line
1.7.0.4