staging: vt6655: do not use PCI resources before pci_enable_device()
Subsystems (2)
PATCH 9/11 staging: vt6655: do not use PCI resources before pci_enable_device()
IRQ and resource[] may not have correct values until after PCI hotplug setup occurs at pci_enable_device() time.
The semantic match that finds this problem is as follows:
// <smpl>
@@
identifier x;
identifier request ~= "pci_request.*|pci_resource.*"; @@
(
* x->irq
|
* x->resource
|
* request(x, ...)
)
...*pci_enable_device(x)
// </smpl>
Signed-off-by Kulikov Vasiliy <[email protected]>
--- drivers/staging/vt6655/device_main.c | 3 ++- 1 files changed, 2 insertions(+), 1 deletions(-)
drivers/staging/vt6655/device_main.c +2 -1
@@ -955,12 +955,13 @@ vt6655_probe(struct pci_dev *pcid, const struct pci_device_id *ent) pDevice->dev = dev; pDevice->next_module = root_device_dev; root_device_dev = dev; - dev->irq = pcid->irq;if (pci_enable_device (pcid)) {device_free_info (pDevice);return -ENODEV ; } + dev->irq = pcid->irq; +#ifdef DEBUG printk ("Before get pci_info memaddr is %x\n" ,pDevice->memaddr);#endif
Signature · 1 line
1.7.0.4