Skip to contentSkip to conversation

V4L/DVB: ir-code: Add missing "select BITREVERSE"

PATCH In review H. Peter Anvin 2 participants 2 messages Aug 3, 2010 Media (V4L/DVB)

lore
Share & tools
lore

H. Peter Anvin

author
#0 lore raw

PATCH 1/1 V4L/DVB: ir-code: Add missing "select BITREVERSE"

The Sony and JVC IR drivers use bitreverse but don't properly encode the dependency.

Found by randconfig builds.

Signed-off-by H. Peter Anvin <[email protected]>
Cc David Härdeman <[email protected]>
Cc Mauro Carvalho Chehab <[email protected]>
---
 drivers/media/IR/Kconfig |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)
drivers/media/IR/Kconfig +2 -0
index d22a8ec..6cd93b4 100644
@@ -42,6 +42,7 @@ config IR_RC6_DECODER
 config IR_JVC_DECODER
 	tristate "Enable IR raw decoder for the JVC protocol"
 	depends on IR_CORE
+	select BITREVERSE
 	default y
 
 	---help---

@@ -51,6 +52,7 @@ config IR_JVC_DECODER
 config IR_SONY_DECODER
 	tristate "Enable IR raw decoder for the Sony protocol"
 	depends on IR_CORE
+	select BITREVERSE
 	default y
 
 	---help---
Signature · 1 line
1.7.2
#1 lore raw
Quoted 4 lines · On Tue, 3 Aug 2010 11:18:28 -0700 H. Peter Anvin wrote:

The Sony and JVC IR drivers use bitreverse but don't properly encode the dependency.

Found by randconfig builds.

Hi,

These are already merged into linux-next... and Mauro has sent a pull request that includes these patches.

Quoted 34 lines
Signed-off-by H. Peter Anvin <[email protected]>
Cc David Härdeman <[email protected]>
Cc Mauro Carvalho Chehab <[email protected]>
---
 drivers/media/IR/Kconfig |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)
drivers/media/IR/Kconfig +2 -0
index d22a8ec..6cd93b4 100644
@@ -42,6 +42,7 @@ config IR_RC6_DECODER
 config IR_JVC_DECODER
 	tristate "Enable IR raw decoder for the JVC protocol"
 	depends on IR_CORE
+	select BITREVERSE
 	default y
 
 	---help---

@@ -51,6 +52,7 @@ config IR_JVC_DECODER
 config IR_SONY_DECODER
 	tristate "Enable IR raw decoder for the Sony protocol"
 	depends on IR_CORE
+	select BITREVERSE
 	default y
 
 	---help---
Signature · 6 lines
1.7.2

--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

---
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***