Skip to contentSkip to conversation

padata: add missing __percpu markup in include/linux/padata.h

PATCH Superseded Namhyung Kim 4 participants 6 messages Aug 7, 2010 – Sep 3, 2010 Padata parallel execution mechanism

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 padata: add missing __percpu markup in include/linux/padata.h

parallel_data->queue is a percpu pointer but was missing __percpu markup. Add it.

---
 include/linux/padata.h |   18 +++++++++---------
 1 files changed, 9 insertions(+), 9 deletions(-)
include/linux/padata.h +9 -9
index 8d84062..67df560 100644
@@ -96,15 +96,15 @@ struct padata_queue {
  * @timer: Reorder timer.
  */
 struct parallel_data {
-	struct padata_instance	*pinst;
-	struct padata_queue	*queue;
-	atomic_t		seq_nr;
-	atomic_t		reorder_objects;
-	atomic_t                refcnt;
-	unsigned int		max_seq_nr;
-	cpumask_var_t		cpumask;
-	spinlock_t              lock;
-	struct timer_list       timer;
+	struct padata_instance		*pinst;
+	struct padata_queue __percpu	*queue;
+	atomic_t			seq_nr;
+	atomic_t			reorder_objects;
+	atomic_t                	refcnt;
+	unsigned int			max_seq_nr;
+	cpumask_var_t			cpumask;
+	spinlock_t              	lock;
+	struct timer_list       	timer;
 };
 
 /**
Signature · 1 line
1.7.0.4
maintainer
#2 lore raw
In reply to Namhyung Kim
Quoted 3 lines · Namhyung Kim

parallel_data->queue is a percpu pointer but was missing __percpu markup. Add it.

The patch does not apply, please respin against linux-2.6 git current.

Thanks,

Steffen

#3 lore raw

PATCH RESEND 1/1 padata: add missing __percpu markup in include/linux/padata.h

parallel_data->queue is a percpu pointer but was missing __percpu markup. Add it.

---
 include/linux/padata.h |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)
include/linux/padata.h +2 -2
index bdcd1e9..4633b2f 100644
@@ -127,8 +127,8 @@ struct padata_cpumask {
  */
 struct parallel_data {
 	struct padata_instance		*pinst;
-	struct padata_parallel_queue	*pqueue;
-	struct padata_serial_queue	*squeue;
+	struct padata_parallel_queue	__percpu *pqueue;
+	struct padata_serial_queue	__percpu *squeue;
 	atomic_t			seq_nr;
 	atomic_t			reorder_objects;
 	atomic_t			refcnt;
Signature · 1 line
1.7.0.4