Skip to contentSkip to conversation

regulator: tps6507x - add missing platform_set_drvdata in tps6507x_pmic_probe

PATCH RESEND Applied Axel Lin 3 participants 3 messages Aug 9, 2010 – Aug 10, 2010 Voltage and current regulator framework

lore
Share & tools
lore

Axel Lin

author
#0 lore raw

PATCH RESEND 1/1 regulator: tps6507x - add missing platform_set_drvdata in tps6507x_pmic_probe

We should call platform_set_drvdata() before calling platform_get_drvdata().

Signed-off-by Axel Lin <[email protected]>

---
Per Mark's comment, this resend remove platform_set_drvdata(pdev, NULL) in tps6507x_pmic_remove.

 drivers/regulator/tps6507x-regulator.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)
drivers/regulator/tps6507x-regulator.c +1 -0
index 8152d65..c239f42 100644
@@ -614,6 +614,7 @@ int tps6507x_pmic_probe(struct platform_device *pdev)
 	}
 
 	tps6507x_dev->pmic = tps;
+	platform_set_drvdata(pdev, tps6507x_dev);
 
 	return 0;
Signature · 1 line
1.5.4.3
Applied
#2 lore raw
Quoted 7 lines · Mark Brown
Quoted 3 lines · Axel Lin

We should call platform_set_drvdata() before calling platform_get_drvdata().

Signed-off-by Axel Lin <[email protected]>
Acked-by Mark Brown <[email protected]>

--

Applied.

Thanks

Liam

Signature · 3 lines
Freelance Developer, SlimLogic Ltd
ASoC and Voltage Regulator Maintainer.
http://www.slimlogic.co.uk