Skip to contentSkip to conversation

ACPI, APEI, ERST debug support

PATCH In review Huang Ying 2 participants 2 messages Aug 11, 2010

Subsystems (2)
lore
Share & tools
lore

Huang Ying

author
#0 lore raw

PATCH 1/1 ACPI, APEI, ERST debug support

Hi, Len,

There is build error on i386 in the previous version. This new version fixed it, please replace it in acpi-test.git.

Best Regards,
Huang Ying
------------------------------->
This patch adds debugging/testing support to ERST. A misc device is implemented to export raw ERST read/write/clear etc operations to user space. With this patch, we can add ERST testing support to linuxfirmwarekit ISO (linuxfirmwarekit.org) to verify the kernel support and the firmware implementation.

v2:

- Fix build error on i386

---
 drivers/acpi/apei/Kconfig    |    9 +
 drivers/acpi/apei/Makefile   |    1 
 drivers/acpi/apei/erst-dbg.c |  207 +++++++++++++++++++++++++++++++++++++++++++
 3 files changed, 217 insertions(+)
 create mode 100644 drivers/acpi/apei/erst-dbg.c
drivers/acpi/apei/Kconfig +9 -0
@@ -28,3 +28,12 @@ config ACPI_APEI_EINJ
 	  EINJ provides a hardware error injection mechanism, it is
 	  mainly used for debugging and testing the other parts of
 	  APEI and some other RAS features.
+
+config ACPI_APEI_ERST_DEBUG
+	tristate "APEI Error Record Serialization Table (ERST) Debug Support"
+	depends on ACPI_APEI
+	help
+	  ERST is a way provided by APEI to save and retrieve hardware
+	  error infomation to and from a persistent store. Enable this
+	  if you want to debugging and testing the ERST kernel support
+	  and firmware implementation.
drivers/acpi/apei/Makefile +1 -0
@@ -1,5 +1,6 @@
 obj-$(CONFIG_ACPI_APEI)		+= apei.o
 obj-$(CONFIG_ACPI_APEI_GHES)	+= ghes.o
 obj-$(CONFIG_ACPI_APEI_EINJ)	+= einj.o
+obj-$(CONFIG_ACPI_APEI_ERST_DEBUG) += erst-dbg.o
 
 apei-y := apei-base.o hest.o cper.o erst.o
drivers/acpi/apei/erst-dbg.c new file +207 -0

207 lines not on this page · raw message

Acked-by on v1 1/1
#1 lore raw
Quoted 18 lines · Huang Ying

Hi, Len,

There is build error on i386 in the previous version. This new version fixed it, please replace it in acpi-test.git.

Best Regards,
Huang Ying
------------------------------->
This patch adds debugging/testing support to ERST. A misc device is implemented to export raw ERST read/write/clear etc operations to user space. With this patch, we can add ERST testing support to linuxfirmwarekit ISO (linuxfirmwarekit.org) to verify the kernel support and the firmware implementation.

v2:

- Fix build error on i386

Quoted 8 lines
---
 drivers/acpi/apei/Kconfig    |    9 +
 drivers/acpi/apei/Makefile   |    1 
 drivers/acpi/apei/erst-dbg.c |  207 +++++++++++++++++++++++++++++++++++++++++++
 3 files changed, 217 insertions(+)
 create mode 100644 drivers/acpi/apei/erst-dbg.c

A patch against linux-next (or some acpi tree) would have been better for testing, but anyway, I fixed that little problem.

Thanks.

Signature · 2 lines
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***