staging: adis16255: fix sysfs leak

PATCH New Kulikov Vasiliy 1 participant 1 message Aug 11, 2010

Subsystems (2)

Staging Kernel janitors

lore

Share & tools

lore

Kulikov Vasiliy

author

2010-08-11 08:00 UTC #0 lore raw

PATCH 1/1 staging: adis16255: fix sysfs leak

Original code does not call sysfs_remove_group() on error. This can lead to NULL dereference.

Signed-off-by Kulikov Vasiliy <[email protected]>

---
 drivers/staging/adis16255/adis16255.c |    4 +++-
 1 files changed, 3 insertions(+), 1 deletions(-)

drivers/staging/adis16255/adis16255.c +3 -1

index c3e6a4d..8d4d7cb 100644
@@ -406,12 +406,14 @@ static int __devinit spi_adis16255_probe(struct spi_device *spi)
 
 	status = spi_adis16255_bringup(spiadis);
 	if (status != 0)
-		goto irq_err;
+		goto sysfs_err;
 
 	dev_info(&spi->dev, "spi_adis16255 driver added!\n");
 
 	return status;
 
+sysfs_err:
+	sysfs_remove_group(&spiadis->spi->dev.kobj, &adis16255_attr_group);
 irq_err:
 	free_irq(spiadis->irq, spiadis);
 gpio_err:

Signature · 1 line

1.7.0.4