Skip to contentSkip to conversation

A few fixes (resend, hopefully not munged this time)

PATCH In review [email protected] 2 participants 7 messages Aug 12, 2010

lore
Share & tools
lore
#0 lore raw

Hi,

Sorry for the delay resubmitting these. Please find attached the following patches we added to OE during bringing up our tree. Our actual patch series runs to around 14 patches but I assume your not interested in more non-consumer boards or patches that "work for us". However I'm happy to send them to the mailing list or privately if someone wants to review them. A number of the patches were from Phil Blundel and I believe have already worked their way upstream from his trees.

[PATCH 1/2] freetype: include perl-native dependancy [PATCH 2/2] recode: Fix configure step.

--
Alex.

#1 lore raw

PATCH 1/2 freetype: include perl-native dependancy

From: Alex Bennee <[email protected]>

Freetype requires a native perl to build during it's configure step. I'm unsure how it built before unless other uses had brought in perl-native through another dependancy (our GTK setup is fairly minimal).

---
 recipes/freetype/freetype_2.3.11.bb |    3 +++
 1 files changed, 3 insertions(+), 0 deletions(-)
recipes/freetype/freetype_2.3.11.bb +3 -0
index 1474bb9..8d3ca63 100644
@@ -11,12 +11,15 @@ SRC_URI = "\
 "
 S = "${WORKDIR}/freetype-${PV}"
 
+DEPENDS	     = "perl-native"
+
 inherit autotools pkgconfig binconfig
 
 LIBTOOL = "${HOST_SYS}-libtool"
 EXTRA_OEMAKE = "'LIBTOOL=${LIBTOOL}'"
 EXTRA_OECONF = "--without-zlib"
 
+
 do_configure() {
 	cd builds/unix
 	libtoolize --force --copy
Signature · 1 line
1.7.2.1
#2 lore raw

Re: [PATCH 1/2] freetype: include perl-native dependancy

Quoted 8 lines · [email protected] wrote:

From: Alex Bennee <[email protected]>

Freetype requires a native perl to build during it's configure step. I'm unsure how it built before unless other uses had brought in perl-native through another dependancy (our GTK setup is fairly minimal).

OE assumes that there is a host perl already. perl-native is mainly provided for some very special cases (such as building perl for the target).

Signature · 2 lines
Tom Rini
Mentor Graphics Corporation
#3 lore raw

Re: [PATCH 1/2] freetype: include perl-native dependancy

Quoted 9 lines · Tom Rini
Quoted 8 lines · [email protected] wrote:

From: Alex Bennee <[email protected]>

Freetype requires a native perl to build during it's configure step. I'm unsure how it built before unless other uses had brought in perl-native through another dependancy (our GTK setup is fairly minimal).

Quoted 4 lines
Quoted 1 line

OE assumes that there is a host perl already.  perl-native is mainly provided for some very special cases (such as building perl for the target).

How odd, I couldn't get configure to run without a perl-native. Maybe because I was building for i686 on an x86_64. I guess it relegates that patch to a "works for us" status.

Signature · 2 lines
Alex, homepage: http://www.bennee.com/~alex/
http://www.half-llama.co.uk
#4 lore raw

Re: [PATCH 1/2] freetype: include perl-native dependancy

Quoted 9 lines · Alex Bennee
Quoted 8 lines · Tom Rini
Quoted 7 lines · [email protected] wrote:

From: Alex Bennee <[email protected]>

Freetype requires a native perl to build during it's configure step. I'm unsure how it built before unless other uses had brought in perl-native through another dependancy (our GTK setup is fairly minimal).

Quoted 7 lines
Quoted 3 lines
Quoted 1 line

OE assumes that there is a host perl already. perl-native is mainly provided for some very special cases (such as building perl for the target).

How odd, I couldn't get configure to run without a perl-native. Maybe because I was building for i686 on an x86_64. I guess it relegates that patch to a "works for us" status.

So, were you building for say MACHINE=qemux86

Signature · 2 lines
Tom Rini
Mentor Graphics Corporation
#5 lore raw

PATCH 2/2 recode: Fix configure step.

In reply to [email protected]

From: Alex Bennee <[email protected]>

Add space to appended CC/CXX otherwise configure fails

---
 recipes/recode/recode_3.6.bb |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
recipes/recode/recode_3.6.bb +1 -1
index 3e7c6cd..0cdd43d 100644
@@ -8,7 +8,7 @@ SRC_URI = "${GNU_MIRROR}/recode/recode-${PV}.tar.gz \
 
 inherit autotools
 
-TARGET_CC_ARCH_append = "${LDFLAGS}"
+TARGET_CC_ARCH_append = " ${LDFLAGS}"
 
 do_configure() {
 	gnu-configize
Signature · 1 line
1.7.2.1
#6 lore raw

Re: [PATCH 2/2] recode: Fix configure step.

Quoted 14 lines · [email protected] wrote:

From: Alex Bennee <[email protected]>

Add space to appended CC/CXX otherwise configure fails

---
 recipes/recode/recode_3.6.bb |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
recipes/recode/recode_3.6.bb +0 -0
index 3e7c6cd..0cdd43d 100644

recipes/recode/recode_3.6.bb SRC_URI = "${GNU_MIRROR}/recode/recode-${PV}.tar.gz \ · line 14

Quoted 8 lines
recipes/recode/recode_3.6.bb +1 -1
@@ -8,7 +8,7 @@ SRC_URI = "${GNU_MIRROR}/recode/recode-${PV}.tar.gz \
 
 inherit autotools
 
-TARGET_CC_ARCH_append = "${LDFLAGS}"
+TARGET_CC_ARCH_append = " ${LDFLAGS}"
 
 do_configure() {
 	gnu-configize

iirc this should become TARGET_CC_ARCH += "${LDFLAGS}" as then the space will be added and it looks cleaner.

Signature · 2 lines
Tom Rini
Mentor Graphics Corporation