Skip to contentSkip to conversation

cxgbi iscsi driver

PATCH Superseded [email protected] 3 participants 3 messages Aug 13, 2010

Subsystems (3)

v2 of 4 Superseded Latest is v4 →

lore
Share & tools
lore
#0 lore raw

v2 cover cxgbi iscsi driver

[PATCH v2 0/3] cxgbi iscsi driver

From: Karen Xie <[email protected]>

Re-submission, missed netdev list last time.

This patchset includes:

1. added libcxgbi as the common library for both cxgb4i and cxgb3i driver
2. added cxgb4i iscsi initiator v5.
3. changed cxgb3i to use libcxgbi.

The version 2 includes the following changes:
- Made dbg_level static to avoid compiling errors when both cxgb3i and cxgb4i are built into the kernel.
- Deleted cxgbi_fill_iscsi_transport() and cxgbi_fill_scsi_host_template(). The iscsi_transport and scsi_host_template are initialized in the drivers instead of being filled in by the library at runtime..
- Only register with iscsi class transport once per driver type.

Thanks.
Karen

#1 lore raw
Quoted 3 lines · On Fri, 2010-08-13 at 08:19 -0700, [email protected] wrote:

[PATCH v2 0/3] cxgbi iscsi driver
From: Karen Xie <[email protected]>
Re-submission, missed netdev list last time.

Hi Karen.

I presume this is not to be applied as you've
already received some feedback on it and that
you are sending it to netdev for any additional
comments.

Reviewed-by on the v2 series
#2 lore raw
In reply to [email protected]
Quoted 12 lines · On 08/13/2010 10:19 AM, [email protected] wrote:

[PATCH v2 0/3] cxgbi iscsi driver

From: Karen Xie<[email protected]>

Re-submission, missed netdev list last time.

This patchset includes:

1. added libcxgbi as the common library for both cxgb4i and cxgb3i driver
2. added cxgb4i iscsi initiator v5.
3. changed cxgb3i to use libcxgbi.

Quoted 8 lines

The version 2 includes the following changes:
- Made dbg_level static to avoid compiling errors when both cxgb3i and cxgb4i are built into the kernel.
- Deleted cxgbi_fill_iscsi_transport() and cxgbi_fill_scsi_host_template(). The iscsi_transport and scsi_host_template are initialized in the drivers instead of being filled in by the library at runtime..
- Only register with iscsi class transport once per driver type.

iSCSI and SCSI parts look ok now. The network code should be reviewed by the netdev people, because I am not qualified to review that. Thanks for your work Karen.