Skip to contentSkip to conversation

More t_client.sh updates - exit with SKIP when we want to skip

PATCH In review David Sommerseth 4 participants 4 messages Aug 18, 2010 – Aug 20, 2010

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 More t_client.sh updates - exit with SKIP when we want to skip

Several places we exited with 0 instead of 77 when we want to indicate that we should skip this test.

---
 t_client.sh.in |    6 +++---
 1 files changed, 3 insertions(+), 3 deletions(-)
t_client.sh.in +3 -3
index d3a4295..b273964 100755
@@ -36,12 +36,12 @@ fi
 
 if [ -z "$CA_CERT" ] ; then
     echo "CA_CERT not defined in 't_client.rc'. SKIP test." >&2
-    exit 0
+    exit 77
 fi
 
 if [ -z "$TEST_RUN_LIST" ] ; then
     echo "TEST_RUN_LIST empty, no tests defined.  SKIP test." >&2
-    exit 0
+    exit 77
 fi
 
 # make sure we have permissions to run ifconfig/route from OpenVPN
@@ -51,7 +51,7 @@ if expr "$ID" : "uid=0" >/dev/null
 then :
 else
     echo "$0: this test must run be as root. SKIP." >&2
-    exit 0
+    exit 77
 fi
 
 LOGDIR=t_client-`hostname`-`date +%Y%m%d-%H%M%S`
Signature · 1 line
1.7.2.1
#1 lore raw

Hi,

Quoted 2 lines · David Sommerseth

Several places we exited with 0 instead of 77 when we want to indicate that we should skip this test.

ACK. Thanks to Matthias for pointing this out.

gert

Signature · 4 lines
USENET is *not* the non-clickable part of WWW!
                                                           //www.muc.de/~gert/
Gert Doering - Munich, Germany                             [email protected]...
fax: +49-89-35655025                        [email protected]...
#2 lore raw

Am 18.08.2010 17:12, schrieb Gert Doering:

Quoted 7 lines

Hi,

Quoted 2 lines · David Sommerseth

Several places we exited with 0 instead of 77 when we want to indicate that we should skip this test.

ACK. Thanks to Matthias for pointing this out.

My pleasure.

Signature · 1 line
Matthias Andree
#3 lore raw
In reply to David Sommerseth

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Quoted 4 lines · David Sommerseth

Several places we exited with 0 instead of 77 when we want to indicate that we should skip this test.

Late response, but it got applied to bugfix2.1, merged into allmerged and beta2.2.

commit 30e37820dcb8a0549cc68ed17f1684c4bac1530b

Author: David Sommerseth <[email protected]...>
Date:   Wed Aug 18 17:05:09 2010 +0200
    Signed-off-by: David Sommerseth <[email protected]...>
    Acked-by: Gert Doering <[email protected]...>

Kind regards,

David Sommerseth
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.10 (GNU/Linux)
Comment: Using GnuPG with Fedora - http://enigmail.mozdev.org/

iEYEARECAAYFAkxuiFkACgkQDC186MBRfrp9agCgofQ3PB7JoA/f+Tsn/S1xyxoy ZRIAniFS0CNJFKl6JJByHKz5zV9+4kXf
=exS9
-----END PGP SIGNATURE-----