Skip to contentSkip to conversation

lockup_detector: Make callback function static

PATCH In review Lin Ming 2 participants 3 messages Aug 20, 2010

lore
Share & tools
lore

Lin Ming

author
#0 lore raw

PATCH 1/1 lockup_detector: Make callback function static

watchdog_overflow_callback is only used in kernel/watchdog.c.

Signed-off-by Lin Ming <[email protected]>
---
 kernel/watchdog.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
kernel/watchdog.c +1 -1
index 613bc1f..b60e2a8 100644
@@ -202,7 +202,7 @@ static struct perf_event_attr wd_hw_attr = {
 };
 
 /* Callback function for perf event subsystem */
-void watchdog_overflow_callback(struct perf_event *event, int nmi,
+static void watchdog_overflow_callback(struct perf_event *event, int nmi,
 		 struct perf_sample_data *data,
 		 struct pt_regs *regs)
 {
Acked-by on v1 1/1
#1 lore raw
Quoted 1 line · Lin Ming

watchdog_overflow_callback is only used in kernel/watchdog.c.

Acked-by Don Zickus <[email protected]>
Quoted 21 lines
Signed-off-by Lin Ming <[email protected]>
---
 kernel/watchdog.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
kernel/watchdog.c +1 -1
index 613bc1f..b60e2a8 100644
@@ -202,7 +202,7 @@ static struct perf_event_attr wd_hw_attr = {
 };
 
 /* Callback function for perf event subsystem */
-void watchdog_overflow_callback(struct perf_event *event, int nmi,
+static void watchdog_overflow_callback(struct perf_event *event, int nmi,
 		 struct perf_sample_data *data,
 		 struct pt_regs *regs)
 {
author
#2 lore raw
In reply to Lin Ming
Commit-ID:  277b199800ac90811ac86d215063df1984f51619
Gitweb:     http://git.kernel.org/tip/277b199800ac90811ac86d215063df1984f51619
Author:     Lin Ming <[email protected]>
AuthorDate: Fri, 20 Aug 2010 11:03:51 +0800
Committer:  Ingo Molnar <[email protected]>
CommitDate: Fri, 20 Aug 2010 10:09:41 +0200

lockup_detector: Make callback function static

watchdog_overflow_callback() is only used in kernel/watchdog.c.

Signed-off-by Lin Ming <[email protected]>
Cc Peter Zijlstra <[email protected]>
Cc Don Zickus <[email protected]>

LKML-Reference: <[email protected]>

Signed-off-by Ingo Molnar <[email protected]>
---
 kernel/watchdog.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
kernel/watchdog.c +1 -1
index 613bc1f..b60e2a8 100644
@@ -202,7 +202,7 @@ static struct perf_event_attr wd_hw_attr = {
 };
 
 /* Callback function for perf event subsystem */
-void watchdog_overflow_callback(struct perf_event *event, int nmi,
+static void watchdog_overflow_callback(struct perf_event *event, int nmi,
 		 struct perf_sample_data *data,
 		 struct pt_regs *regs)
 {