ARM: Define __raw_readX and __raw_writeX

PATCH New Marek Vasut 3 participants 28 messages Aug 10, 2010 – Sep 7, 2010

Subsystems (3)

Arm (32-bit) Kbuild Arm/actions semi architecture

lore

Share & tools

lore

Marek Vasut

author

2010-08-10 04:50 UTC #0 lore raw

PATCH 1/9 ARM: Define __raw_readX and __raw_writeX

These functions are undefined on ARM when using __io. These are the commonly used versions and can be redefined.

Signed-off-by Marek Vasut <[email protected]>

---
 arch/arm/include/asm/io.h |   46 +++++++++++++++++++++++++++++++++++++++-----
 1 files changed, 40 insertions(+), 6 deletions(-)

arch/arm/include/asm/io.h +40 -6

index e8f3eb1..ff1518e 100644
@@ -75,13 +75,47 @@ static inline phys_addr_t virt_to_phys(void * vaddr)
 #define __arch_putw(v,a)		(*(volatile unsigned short *)(a) = (v))
 #define __arch_putl(v,a)		(*(volatile unsigned int *)(a) = (v))
 
-extern void __raw_writesb(unsigned int addr, const void *data, int bytelen);
-extern void __raw_writesw(unsigned int addr, const void *data, int wordlen);
-extern void __raw_writesl(unsigned int addr, const void *data, int longlen);
+extern inline void __raw_writesb(unsigned int addr, const void *data, int bytelen)
+{
+	uint8_t *buf = (uint8_t *)data;
+	while(bytelen--)
+		__arch_putb(*buf++, addr);
+}
+
+extern inline void __raw_writesw(unsigned int addr, const void *data, int wordlen)
+{
+	uint16_t *buf = (uint16_t *)data;
+	while(wordlen--)
+		__arch_putw(*buf++, addr);
+}
+
+extern inline void __raw_writesl(unsigned int addr, const void *data, int longlen)
+{
+	uint32_t *buf = (uint32_t *)data;
+	while(longlen--)
+		__arch_putl(*buf++, addr);
+}
 
-extern void __raw_readsb(unsigned int addr, void *data, int bytelen);
-extern void __raw_readsw(unsigned int addr, void *data, int wordlen);
-extern void __raw_readsl(unsigned int addr, void *data, int longlen);
+extern inline void __raw_readsb(unsigned int addr, void *data, int bytelen)
+{
+	uint8_t *buf = (uint8_t *)data;
+	while(bytelen--)
+		*buf++ = __arch_getb(addr);
+}
+
+extern inline void __raw_readsw(unsigned int addr, void *data, int wordlen)
+{
+	uint16_t *buf = (uint16_t *)data;
+	while(wordlen--)
+		*buf++ = __arch_getw(addr);
+}
+
+extern inline void __raw_readsl(unsigned int addr, void *data, int longlen)
+{
+	uint32_t *buf = (uint32_t *)data;
+	while(longlen--)
+		*buf++ = __arch_getl(addr);
+}
 
 #define __raw_writeb(v,a)		__arch_putb(v,a)
 #define __raw_writew(v,a)		__arch_putw(v,a)

Signature · 1 line

1.7.1

Marek Vasut

author

2010-08-10 04:50 UTC #1 lore raw

PATCH 2/9 PXA: pxafb: Add ACX517AKN support

ACX517AKN LCD panel is found in Palm Tungsten|C

Signed-off-by Marek Vasut <[email protected]>

---
 arch/arm/cpu/pxa/pxafb.c |   34 ++++++++++++++++++++++++++++++++++
 1 files changed, 34 insertions(+), 0 deletions(-)

arch/arm/cpu/pxa/pxafb.c +34 -0

index 524a03b..328fa7a 100644
@@ -215,6 +215,40 @@ vidinfo_t panel_info = {
 
 /*----------------------------------------------------------------------*/
 
+#ifdef CONFIG_ACX517AKN
+
+# define LCD_BPP	LCD_COLOR8
+
+/* you have to set lccr0 and lccr3 (including pcd) */
+# define REG_LCCR0	0x003008f9
+# define REG_LCCR3	0x03700006
+
+vidinfo_t panel_info = {
+	vl_col:		320,
+	vl_row:		320,
+	vl_width:	320,
+	vl_height:	320,
+	vl_clkp:	CONFIG_SYS_HIGH,
+	vl_oep:		CONFIG_SYS_LOW,
+	vl_hsp:		CONFIG_SYS_LOW,
+	vl_vsp:		CONFIG_SYS_LOW,
+	vl_dp:		CONFIG_SYS_HIGH,
+	vl_bpix:	LCD_BPP,
+	vl_lbw:		0,
+	vl_splt:	1,
+	vl_clor:	1,
+	vl_tft:		1,
+	vl_hpw:		0x04,
+	vl_blw:		0x1c,
+	vl_elw:		0x08,
+	vl_vpw:		0x01,
+	vl_bfw:		0x07,
+	vl_efw:		0x08,
+};
+#endif /* CONFIG_ACX517AKN */
+
+/*----------------------------------------------------------------------*/
+
 #if LCD_BPP == LCD_COLOR8
 void lcd_setcolreg (ushort regno, ushort red, ushort green, ushort blue);
 #endif

Signature · 1 line

1.7.1

Wolfgang Denk

2010-08-10 21:45 UTC #2 lore raw

PATCH 2/9 PXA: pxafb: Add ACX517AKN support

Dear Marek Vasut,

Quoted 6 lines · In message <[email protected]> you wrote:

ACX517AKN LCD panel is found in Palm Tungsten|C
Signed-off-by Marek Vasut <[email protected]>
---
 arch/arm/cpu/pxa/pxafb.c |   34 ++++++++++++++++++++++++++++++++++
 1 files changed, 34 insertions(+), 0 deletions(-)

This is a resubmission, right?

Why do you not mark the patch version in the subject, like "[PATCH 2/9 v2]" or so?

And why is there no thread information present? (i. e. why are the
In-reply-to: and References: headers not set to point to the previous versions of the patch?)

And why did you not include any information what has been changed between the previous version and this one?

I do not intend to run diff over your patches.

Please document your changes to the patches!

Best regards,

Wolfgang Denk

Signature · 4 lines

DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Many aligators will be slain, but the swamp will remain.

Marek Vasut

author

2010-08-10 23:56 UTC #3 lore raw

PATCH 2/9 PXA: pxafb: Add ACX517AKN support

Dne ?t 10. srpna 2010 23:45:05 Wolfgang Denk napsal(a):

Quoted 3 lines

Dear Marek Vasut,
In message <[email protected]> you

Quoted 17 lines · wrote:

Quoted 7 lines
ACX517AKN LCD panel is found in Palm Tungsten|C
Signed-off-by Marek Vasut <[email protected]>
---
 arch/arm/cpu/pxa/pxafb.c |   34 ++++++++++++++++++++++++++++++++++
 1 files changed, 34 insertions(+), 0 deletions(-)
This is a resubmission, right?
Why do you not mark the patch version in the subject, like "[PATCH 2/9 v2]" or so?
And why is there no thread information present? (i. e. why are the
In-reply-to: and References: headers not set to point to the previous versions of the patch?)

Quoted 7 lines

And why did you not include any information what has been changed between the previous version and this one?
I do not intend to run diff over your patches.
Please document your changes to the patches!

Ok, there's nothing changed in this one. I'll document it properly in the next round. Sorry for the trouble.

Quoted 4 lines

Best regards,
Wolfgang Denk

Marek Vasut

author

2010-08-20 09:31 UTC #4 lore raw

PATCH 1/8 PXA: pxafb: Add ACX517AKN support

In reply to Marek Vasut

ACX517AKN LCD panel is found in Palm Tungsten|C

Signed-off-by Marek Vasut <[email protected]>

---
No changes

 arch/arm/cpu/pxa/pxafb.c |   34 ++++++++++++++++++++++++++++++++++
 1 files changed, 34 insertions(+), 0 deletions(-)

arch/arm/cpu/pxa/pxafb.c +34 -0

index 524a03b..328fa7a 100644
@@ -215,6 +215,40 @@ vidinfo_t panel_info = {
 
 /*----------------------------------------------------------------------*/
 
+#ifdef CONFIG_ACX517AKN
+
+# define LCD_BPP	LCD_COLOR8
+
+/* you have to set lccr0 and lccr3 (including pcd) */
+# define REG_LCCR0	0x003008f9
+# define REG_LCCR3	0x03700006
+
+vidinfo_t panel_info = {
+	vl_col:		320,
+	vl_row:		320,
+	vl_width:	320,
+	vl_height:	320,
+	vl_clkp:	CONFIG_SYS_HIGH,
+	vl_oep:		CONFIG_SYS_LOW,
+	vl_hsp:		CONFIG_SYS_LOW,
+	vl_vsp:		CONFIG_SYS_LOW,
+	vl_dp:		CONFIG_SYS_HIGH,
+	vl_bpix:	LCD_BPP,
+	vl_lbw:		0,
+	vl_splt:	1,
+	vl_clor:	1,
+	vl_tft:		1,
+	vl_hpw:		0x04,
+	vl_blw:		0x1c,
+	vl_elw:		0x08,
+	vl_vpw:		0x01,
+	vl_bfw:		0x07,
+	vl_efw:		0x08,
+};
+#endif /* CONFIG_ACX517AKN */
+
+/*----------------------------------------------------------------------*/
+
 #if LCD_BPP == LCD_COLOR8
 void lcd_setcolreg (ushort regno, ushort red, ushort green, ushort blue);
 #endif

Signature · 1 line

1.7.1

Marek Vasut

author

2010-08-20 09:31 UTC #5 lore raw

PATCH 2/8 common: Enable serial for PXA250

In reply to Marek Vasut

Signed-off-by Marek Vasut <[email protected]>

---
No changes

 common/serial.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

common/serial.c +1 -1

index fceabfa..7148cb9 100644
@@ -30,7 +30,7 @@ DECLARE_GLOBAL_DATA_PTR;
 static struct serial_device *serial_devices = NULL;
 static struct serial_device *serial_current = NULL;
 
-#if !defined(CONFIG_LWMON) && !defined(CONFIG_PXA27X)
+#if !defined(CONFIG_LWMON) && !defined(CONFIG_PXA27X) && !defined(CONFIG_PXA250)
 struct serial_device *__default_serial_console (void)
 {
 #if defined(CONFIG_8xx_CONS_SMC1) || defined(CONFIG_8xx_CONS_SMC2)

Signature · 1 line

1.7.1

Marek Vasut

author

2010-08-20 09:31 UTC #6 lore raw

PATCH v2 3/8 PXA: Palm Tungsten|C Support

In reply to Marek Vasut

This patch adds support for the Palm Tungsten|C PXA255 board. The support includes:
- LCD
- MMC
- UART
- NOR

Signed-off-by Marek Vasut <[email protected]>

---
Fix line-over-80s
Fix off-tree build
Fix buggy comments
Add missing MAINTAINERS and MAKEALL entries
(the above is true for the rest of patches adding new platforms)

 MAINTAINERS                  |    4 +
 MAKEALL                      |    1 +
 board/palmtc/Makefile        |   49 +++++++++
 board/palmtc/config.mk       |    1 +
 board/palmtc/lowlevel_init.S |   39 +++++++
 board/palmtc/palmtc.c        |   58 ++++++++++
 board/palmtc/u-boot.lds      |   56 ++++++++++
 boards.cfg                   |    1 +
 include/configs/palmtc.h     |  247 ++++++++++++++++++++++++++++++++++++++++++
 9 files changed, 456 insertions(+), 0 deletions(-)
 create mode 100644 board/palmtc/Makefile
 create mode 100644 board/palmtc/config.mk
 create mode 100644 board/palmtc/lowlevel_init.S
 create mode 100644 board/palmtc/palmtc.c
 create mode 100644 board/palmtc/u-boot.lds
 create mode 100644 include/configs/palmtc.h

MAINTAINERS +4 -0

index 4b91b0f..70f03fb 100644
@@ -796,6 +796,10 @@ Greg Ungerer <[email protected]>
 	cm4116		ks8695p
 	cm4148		ks8695p
 
+Marek Vasut <[email protected]>
+
+	palmtc		xscale
+
 Hugo Villeneuve <[email protected]>
 
 	SFFSDR		ARM926EJS

MAKEALL +1 -0

index b34ae33..b871976 100755
@@ -713,6 +713,7 @@ LIST_pxa="		\
 	delta		\
 	innokom		\
 	lubbock		\
+	palmtc		\
 	pleb2		\
 	polaris		\
 	pxa255_idp	\

board/palmtc/Makefile new file +49 -0

49 lines not on this page · raw message

board/palmtc/config.mk new file +1 -0

new file mode 100644
index 0000000..1d650ac
@@ -0,0 +1 @@
+TEXT_BASE = 0xa1000000

board/palmtc/lowlevel_init.S new file +39 -0

new file mode 100644
index 0000000..74050dc
@@ -0,0 +1,39 @@
+/*
+ * Palm Tungsten|C Lowlevel Hardware Initialization
+ *
+ * Copyright (C) 2010 Marek Vasut <[email protected]>
+ *
+ * See file CREDITS for list of people who contributed to this
+ * project.
+ *
+ * This program is free software; you can redistribute it and/or
+ * modify it under the terms of the GNU General Public License as
+ * published by the Free Software Foundation; either version 2 of
+ * the License, or (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with this program; if not, write to the Free Software
+ * Foundation, Inc., 59 Temple Place, Suite 330, Boston,
+ * MA 02111-1307 USA
+ */
+
+#include <config.h>
+#include <version.h>
+#include <asm/arch/pxa-regs.h>
+#include <asm/arch/macro.h>
+
+.globl lowlevel_init
+lowlevel_init:
+	pxa_gpio_setup
+	pxa_wait_ticks	0x8000
+	pxa_mem_setup
+	pxa_wakeup
+	pxa_intr_setup
+	pxa_clock_setup
+
+	mov	pc, lr

board/palmtc/palmtc.c new file +58 -0

58 lines not on this page · raw message

board/palmtc/u-boot.lds new file +56 -0

56 lines not on this page · raw message

boards.cfg +1 -0

index 69c6897..c6263c9 100644
@@ -59,6 +59,7 @@ delta		arm	pxa
 innokom		arm	pxa
 logodl		arm	pxa
 lubbock		arm	pxa
+palmtc		arm	pxa
 pleb2		arm	pxa
 xaeniax		arm	pxa
 xm250		arm	pxa

include/configs/palmtc.h new file +247 -0

247 lines not on this page · raw message

Signature · 1 line

1.7.1

Marek Vasut

author

2010-08-20 09:31 UTC #7 lore raw

PATCH 4/8 PXA: pxafb: Add support for Sharp LQ038J7DH53

In reply to Marek Vasut

This LCD panel is found in Palm LifeDrive handheld

Signed-off-by Marek Vasut <[email protected]>

---
No changes

 arch/arm/cpu/pxa/pxafb.c |   34 ++++++++++++++++++++++++++++++++++
 1 files changed, 34 insertions(+), 0 deletions(-)

arch/arm/cpu/pxa/pxafb.c +34 -0

index 328fa7a..066f49e 100644
@@ -249,6 +249,40 @@ vidinfo_t panel_info = {
 
 /*----------------------------------------------------------------------*/
 
+#ifdef CONFIG_LQ038J7DH53
+
+# define LCD_BPP	LCD_COLOR8
+
+/* you have to set lccr0 and lccr3 (including pcd) */
+# define REG_LCCR0	0x003008f9
+# define REG_LCCR3	0x03700004
+
+vidinfo_t panel_info = {
+	vl_col:		320,
+	vl_row:		480,
+	vl_width:	320,
+	vl_height:	480,
+	vl_clkp:	CONFIG_SYS_HIGH,
+	vl_oep:		CONFIG_SYS_LOW,
+	vl_hsp:		CONFIG_SYS_LOW,
+	vl_vsp:		CONFIG_SYS_LOW,
+	vl_dp:		CONFIG_SYS_HIGH,
+	vl_bpix:	LCD_BPP,
+	vl_lbw:		0,
+	vl_splt:	1,
+	vl_clor:	1,
+	vl_tft:		1,
+	vl_hpw:		0x04,
+	vl_blw:		0x20,
+	vl_elw:		0x01,
+	vl_vpw:		0x01,
+	vl_bfw:		0x04,
+	vl_efw:		0x01,
+};
+#endif /* CONFIG_ACX517AKN */
+
+/*----------------------------------------------------------------------*/
+
 #if LCD_BPP == LCD_COLOR8
 void lcd_setcolreg (ushort regno, ushort red, ushort green, ushort blue);
 #endif

Signature · 1 line

1.7.1

Marek Vasut

author

2010-08-20 09:31 UTC #8 lore raw

PATCH 5/8 PXA: Add initial Palm LifeDrive support

In reply to Marek Vasut

Signed-off-by Marek Vasut <[email protected]>

---
Changes same as in PalmTC

 MAINTAINERS                  |    1 +
 MAKEALL                      |    1 +
 board/palmld/Makefile        |   49 ++++++++
 board/palmld/config.mk       |    1 +
 board/palmld/lowlevel_init.S |   45 +++++++
 board/palmld/palmld.c        |   68 +++++++++++
 board/palmld/u-boot.lds      |   56 +++++++++
 boards.cfg                   |    1 +
 include/configs/palmld.h     |  273 ++++++++++++++++++++++++++++++++++++++++++
 9 files changed, 495 insertions(+), 0 deletions(-)
 create mode 100644 board/palmld/Makefile
 create mode 100644 board/palmld/config.mk
 create mode 100644 board/palmld/lowlevel_init.S
 create mode 100644 board/palmld/palmld.c
 create mode 100644 board/palmld/u-boot.lds
 create mode 100644 include/configs/palmld.h

MAINTAINERS +1 -0

index 70f03fb..5d20dca 100644
@@ -798,6 +798,7 @@ Greg Ungerer <[email protected]>
 
 Marek Vasut <[email protected]>
 
+	palmld		xscale
 	palmtc		xscale
 
 Hugo Villeneuve <[email protected]>

MAKEALL +1 -0

index b871976..1642abe 100755
@@ -713,6 +713,7 @@ LIST_pxa="		\
 	delta		\
 	innokom		\
 	lubbock		\
+	palmld		\
 	palmtc		\
 	pleb2		\
 	polaris		\

board/palmld/Makefile new file +49 -0

49 lines not on this page · raw message

board/palmld/config.mk new file +1 -0

new file mode 100644
index 0000000..1d650ac
@@ -0,0 +1 @@
+TEXT_BASE = 0xa1000000

board/palmld/lowlevel_init.S new file +45 -0

45 lines not on this page · raw message

board/palmld/palmld.c new file +68 -0

68 lines not on this page · raw message

board/palmld/u-boot.lds new file +56 -0

56 lines not on this page · raw message

boards.cfg +1 -0

index c6263c9..b5ee531 100644
@@ -59,6 +59,7 @@ delta		arm	pxa
 innokom		arm	pxa
 logodl		arm	pxa
 lubbock		arm	pxa
+palmld		arm	pxa
 palmtc		arm	pxa
 pleb2		arm	pxa
 xaeniax		arm	pxa

include/configs/palmld.h new file +273 -0

273 lines not on this page · raw message

Signature · 1 line

1.7.1

Marek Vasut

author

2010-08-20 09:31 UTC #9 lore raw

PATCH 6/8 PXA: Voipac270 improvements

In reply to Marek Vasut

128MB NOR module support.
Define __io to get harddrive working. Fix saving of environment into OneNAND. Boot from harddrive when possible. Add missing MAINTAINERS entry.

Signed-off-by Marek Vasut <[email protected]>

---
Changes same as in PalmTC

 MAINTAINERS                   |    1 +
 MAKEALL                       |    3 +-
 Makefile                      |    7 ++-
 board/vpac270/Makefile        |    7 +--
 board/vpac270/lowlevel_init.S |    1 -
 board/vpac270/vpac270.c       |   41 ++++++----------
 include/configs/vpac270.h     |  106 +++++++++++++++++++++++-----------------
 7 files changed, 87 insertions(+), 79 deletions(-)

MAINTAINERS +1 -0

index 5d20dca..c35a277 100644
@@ -800,6 +800,7 @@ Marek Vasut <[email protected]>
 
 	palmld		xscale
 	palmtc		xscale
+	vpac270		xscale
 
 Hugo Villeneuve <[email protected]>

MAKEALL +2 -1

index 1642abe..52472de 100755
@@ -719,7 +719,8 @@ LIST_pxa="		\
 	polaris		\
 	pxa255_idp	\
 	trizepsiv	\
-	vpac270_nor	\
+	vpac270_128M_nor\
+	vpac270_256M_nor\
 	vpac270_onenand	\
 	wepep250	\
 	xaeniax		\

Makefile +6 -1

index 4f1cb1b..3f2b304 100644
@@ -2180,13 +2180,18 @@ trizepsiv_config	:	unconfig
 	fi;
 	@$(MKCONFIG) -n $@ -a trizepsiv arm pxa trizepsiv
 
-vpac270_nor_config \
+vpac270_nor_256M_config \
+vpac270_nor_128M_config \
 vpac270_onenand_config	: unconfig
 	@mkdir -p $(obj)include
 	@if [ "$(findstring onenand,$@)" ] ; then \
 		echo "#define CONFIG_ONENAND_U_BOOT" \
 			>>$(obj)include/config.h ; \
 	fi;
+	@if [ "$(findstring 256M,$@)" ] ; then \
+		echo "#define CONFIG_256M_U_BOOT" \
+			>>$(obj)include/config.h ; \
+	fi;
 	@$(MKCONFIG) -n $@ -a vpac270 arm pxa vpac270
 
 #########################################################################

board/vpac270/Makefile +2 -5

index c6f4c7c..f5014fc 100644
@@ -1,10 +1,7 @@
-
 #
-# (C) Copyright 2000
-# Wolfgang Denk, DENX Software Engineering, wd at denx.de.
+# Voipac PXA270 Support
 #
-# See file CREDITS for list of people who contributed to this
-# project.
+# Copyright (C) 2010 Marek Vasut <[email protected]>
 #
 # This program is free software; you can redistribute it and/or
 # modify it under the terms of the GNU General Public License as

board/vpac270/lowlevel_init.S +0 -1

index ec0d12c..c40d12f 100644
@@ -3,7 +3,6 @@
  *
  * Copyright (C) 2010 Marek Vasut <[email protected]>
  *
- *
  * See file CREDITS for list of people who contributed to this
  * project.
  *

board/vpac270/vpac270.c +15 ~~-26~~

83 lines not on this page · raw message

include/configs/vpac270.h +61 ~~-45~~

244 lines not on this page · raw message

Signature · 1 line

1.7.1

Wolfgang Denk

2010-09-07 21:13 UTC #10 lore raw

PATCH 6/8 PXA: Voipac270 improvements

Dear Marek Vasut,

Quoted 36 lines · In message <[email protected]> you wrote:

128MB NOR module support.
Define __io to get harddrive working. Fix saving of environment into OneNAND. Boot from harddrive when possible. Add missing MAINTAINERS entry.

Signed-off-by Marek Vasut <[email protected]>

---
Changes same as in PalmTC

 MAINTAINERS                   |    1 +
 MAKEALL                       |    3 +-
 Makefile                      |    7 ++-
 board/vpac270/Makefile        |    7 +--
 board/vpac270/lowlevel_init.S |    1 -
 board/vpac270/vpac270.c       |   41 ++++++----------
 include/configs/vpac270.h     |  106 +++++++++++++++++++++++-----------------
 7 files changed, 87 insertions(+), 79 deletions(-)

MAINTAINERS +1 -0

index 5d20dca..c35a277 100644
@@ -800,6 +800,7 @@ Marek Vasut <[email protected]>
 
 	palmld		xscale
 	palmtc		xscale
+	vpac270		xscale
 
 Hugo Villeneuve <[email protected]>

Makefile +0 -0

index 4f1cb1b..3f2b304 100644

Makefile trizepsiv_config : unconfig · line 2185

Quoted 7 lines

Makefile +2 -1

@@ -2180,13 +2180,18 @@ trizepsiv_config	:	unconfig
 	fi;
 	@$(MKCONFIG) -n $@ -a trizepsiv arm pxa trizepsiv
 
-vpac270_nor_config \
+vpac270_nor_256M_config \
+vpac270_nor_128M_config \
 vpac270_onenand_config	: unconfig

Um... we don't accept such changes to the Makefile any more. Such configuration should be moved to the boards.cfg file instead.

...

Quoted 15 lines

board/vpac270/Makefile +2 -5

@@ -1,10 +1,7 @@
-
 #
-# (C) Copyright 2000
-# Wolfgang Denk, DENX Software Engineering, wd at denx.de.
+# Voipac PXA270 Support
 #
-# See file CREDITS for list of people who contributed to this
-# project.
+# Copyright (C) 2010 Marek Vasut <[email protected]>
 #
 # This program is free software; you can redistribute it and/or
 # modify it under the terms of the GNU General Public License as

...

Quoted 10 lines

board/vpac270/vpac270.c +1 -2

index 18e47e2..2d01e22 100644
@@ -1,16 +1,7 @@
 /*
- * (C) Copyright 2004
- * Robert Whaley, Applied Data Systems, Inc. rwhaley at applieddata.net
+ * Voipac PXA270 Support
  *

board/vpac270/vpac270.c line 4

Quoted 10 lines

board/vpac270/vpac270.c +1 -9

- * (C) Copyright 2002
- * Kyle Harris, Nexus Technologies, Inc. kharris at nexus-tech.net
- *
- * (C) Copyright 2002
- * Sysgo Real-Time Solutions, GmbH <www.elinos.com>
- * Marius Groeger <[email protected]>
- *
- * See file CREDITS for list of people who contributed to this
- * project.
+ * Copyright (C) 2010 Marek Vasut <[email protected]>

What makes you think it was legitimate to delete these old Copyright notices?

Best regards,

Wolfgang Denk

Signature · 6 lines

DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
HEALTH WARNING: Care Should Be Taken When Lifting This Product, Since
Its Mass, and Thus Its Weight, Is Dependent on Its Velocity  Relative
to the User.

Marek Vasut

2010-09-07 21:30 UTC #11 lore raw

PATCH 6/8 PXA: Voipac270 improvements

N900 again, sorry.
----- P?vodn? zpr?va -----

Quoted 44 lines

Dear Marek Vasut,
In message <[email protected]> you
Quoted 40 lines · wrote:
128MB NOR module support.
Define __io to get harddrive working.
Fix saving of environment into OneNAND.
Boot from harddrive when possible.
Add missing MAINTAINERS entry.
Signed-off-by Marek Vasut <[email protected]>
---
Changes same as in PalmTC
MAINTAINERS? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? |? ? ? 1 + MAKEALL? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? |? ? ? 3 +- Makefile? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? |? ? ? 7 ++- board/vpac270/Makefile? ? ? ? ? ? ? |? ? ? 7 +-- board/vpac270/lowlevel_init.S |? ? ? 1 - board/vpac270/vpac270.c? ? ? ? ? ? |? ? 41 ++++++---------- include/configs/vpac270.h? ? ? ? |? 106 +++++++++++++++++++++++----------------- 7 files changed, 87 insertions(+), 79 deletions(-)
MAINTAINERS +0 -0
index 5d20dca..c35a277 100644
@@ -800,6 +800,7 @@ Marek Vasut <[email protected]>
 
??? palmld??? ??? xscale
??? palmtc??? ??? xscale
+??? vpac270??? ??? xscale
Hugo Villeneuve <[email protected]>
Makefile +0 -0
index 4f1cb1b..3f2b304 100644
@@ -2180,13 +2180,18 @@ trizepsiv_config??? :??? unconfig
 ??? fi;
??? @$(MKCONFIG) -n $@ -a trizepsiv arm pxa trizepsiv

Quoted 7 lines

Quoted 4 lines
Makefile +2 -1
-vpac270_nor_config \
+vpac270_nor_256M_config \
+vpac270_nor_128M_config \
vpac270_onenand_config??? : unconfig
Um... we don't accept such changes to the Makefile any more. Such configuration should be moved to the boards.cfg file instead.

I'm aware of this. Though I have to admit I don't know how to do it through boards.cfg. I will take a look when I get home (in about 1 hour). Or if you'd be so kind to point me in some direction?

Thanks

Quoted 54 lines

...

Quoted 15 lines

board/vpac270/Makefile +2 -5

@@ -1,10 +1,7 @@
-
 #
-# (C) Copyright 2000
-# Wolfgang Denk, DENX Software Engineering, wd at denx.de.
+# Voipac PXA270 Support
 #
-# See file CREDITS for list of people who contributed to this
-# project.
+# Copyright (C) 2010 Marek Vasut <[email protected]>
 #
 # This program is free software; you can redistribute it and/or
 # modify it under the terms of the GNU General Public License as

...

Quoted 10 lines

board/vpac270/vpac270.c +1 -2

index 18e47e2..2d01e22 100644
@@ -1,16 +1,7 @@
 /*
- * (C) Copyright 2004
- * Robert Whaley, Applied Data Systems, Inc. rwhaley at applieddata.net
+ * Voipac PXA270 Support
 *

board/vpac270/vpac270.c line 4

Quoted 10 lines

board/vpac270/vpac270.c +1 -9

- * (C) Copyright 2002
- * Kyle Harris, Nexus Technologies, Inc. kharris at nexus-tech.net
- *
- * (C) Copyright 2002
- * Sysgo Real-Time Solutions, GmbH <www.elinos.com>
- * Marius Groeger <[email protected]>
- *
- * See file CREDITS for list of people who contributed to this
- * project.
+ * Copyright (C) 2010 Marek Vasut <[email protected]>

What makes you think it was legitimate to delete these old Copyright notices?

Best regards,

Wolfgang Denk

Signature · 6 lines

DENX Software Engineering GmbH,? ? ? ?  MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
HEALTH WARNING: Care Should Be Taken When Lifting This Product, Since
Its Mass, and Thus Its Weight, Is Dependent on Its Velocity?  Relative
to the User.

Marek Vasut

author

2010-09-07 22:34 UTC #12 lore raw

PATCH 6/8 PXA: Voipac270 improvements

Dne ?t 7. z??? 2010 23:30:16 Marek Vasut napsal(a):

Quoted 56 lines

N900 again, sorry.
----- P?vodn? zpr?va -----
Quoted 45 lines
Dear Marek Vasut,
In message <[email protected]> you
Quoted 40 lines · wrote:
128MB NOR module support.
Define __io to get harddrive working. Fix saving of environment into OneNAND. Boot from harddrive when possible. Add missing MAINTAINERS entry.
Signed-off-by Marek Vasut <[email protected]>
---
Changes same as in PalmTC
MAINTAINERS | 1 +
MAKEALL | 3 +-
Makefile | 7 ++-
board/vpac270/Makefile | 7 +--
board/vpac270/lowlevel_init.S | 1 -
board/vpac270/vpac270.c | 41 ++++++----------
include/configs/vpac270.h | 106
+++++++++++++++++++++++----------------- 7 files changed, 87 insertions(+), 79 deletions(-)
MAINTAINERS +1 -0
index 5d20dca..c35a277 100644
@@ -800,6 +800,7 @@ Marek Vasut <[email protected]>
 
    palmld        xscale
    palmtc        xscale
+    vpac270        xscale
 
Hugo Villeneuve <[email protected]>
Makefile +0 -0
index 4f1cb1b..3f2b304 100644
@@ -2180,13 +2180,18 @@ trizepsiv_config    :    unconfig
    fi;
    @$(MKCONFIG) -n $@ -a trizepsiv arm pxa trizepsiv
 
Quoted 7 lines
Quoted 4 lines
Makefile +2 -1
-vpac270_nor_config \
+vpac270_nor_256M_config \
+vpac270_nor_128M_config \
vpac270_onenand_config : unconfig
Um... we don't accept such changes to the Makefile any more. Such configuration should be moved to the boards.cfg file instead.

Quoted 50 lines

I'm aware of this. Though I have to admit I don't know how to do it through boards.cfg. I will take a look when I get home (in about 1 hour). Or if you'd be so kind to point me in some direction?
Thanks
Quoted 44 lines
...
Quoted 15 lines
board/vpac270/Makefile +2 -5
@@ -1,10 +1,7 @@
-
 #
-# (C) Copyright 2000
-# Wolfgang Denk, DENX Software Engineering, wd at denx.de.
+# Voipac PXA270 Support
 #
-# See file CREDITS for list of people who contributed to this
-# project.
+# Copyright (C) 2010 Marek Vasut <[email protected]>
 #
 # This program is free software; you can redistribute it and/or
 # modify it under the terms of the GNU General Public License as
...
Quoted 10 lines
board/vpac270/vpac270.c +1 -2
index 18e47e2..2d01e22 100644
@@ -1,16 +1,7 @@
 /*
- * (C) Copyright 2004
- * Robert Whaley, Applied Data Systems, Inc. rwhaley at applieddata.net
+ * Voipac PXA270 Support
 *
board/vpac270/vpac270.c line 4
Quoted 10 lines
board/vpac270/vpac270.c +1 -9
- * (C) Copyright 2002
- * Kyle Harris, Nexus Technologies, Inc. kharris at nexus-tech.net
- *
- * (C) Copyright 2002
- * Sysgo Real-Time Solutions, GmbH <www.elinos.com>
- * Marius Groeger <[email protected]>
- *
- * See file CREDITS for list of people who contributed to this
- * project.
+ * Copyright (C) 2010 Marek Vasut <[email protected]>
What makes you think it was legitimate to delete these old Copyright notices?

btw. this file never had anything to do with these people ... it's just a fix for a copy-paste thing/mistake.

Quoted 4 lines

Quoted 4 lines
Best regards,
Wolfgang Denk

Marek Vasut

author

2010-08-20 09:31 UTC #13 lore raw

PATCH 7/8 PXA: Balloon3 board support

In reply to Marek Vasut

The following hardware is currently supported:
- UART
- USB Host
- FPGA

Signed-off-by Marek Vasut <[email protected]>

---
Changes same as in PalmTC

 MAINTAINERS                    |    1 +
 MAKEALL                        |    1 +
 board/balloon3/Makefile        |   49 +++++++
 board/balloon3/balloon3.c      |  224 +++++++++++++++++++++++++++++++++
 board/balloon3/config.mk       |    1 +
 board/balloon3/lowlevel_init.S |   36 ++++++
 board/balloon3/u-boot.lds      |   55 ++++++++
 boards.cfg                     |    1 +
 include/configs/balloon3.h     |  269 ++++++++++++++++++++++++++++++++++++++++
 9 files changed, 637 insertions(+), 0 deletions(-)
 create mode 100644 board/balloon3/Makefile
 create mode 100644 board/balloon3/balloon3.c
 create mode 100644 board/balloon3/config.mk
 create mode 100644 board/balloon3/lowlevel_init.S
 create mode 100644 board/balloon3/u-boot.lds
 create mode 100644 include/configs/balloon3.h

MAINTAINERS +1 -0

index c35a277..433eae4 100644
@@ -798,6 +798,7 @@ Greg Ungerer <[email protected]>
 
 Marek Vasut <[email protected]>
 
+	balloon3	xscale
 	palmld		xscale
 	palmtc		xscale
 	vpac270		xscale

MAKEALL +1 -0

index 52472de..9d149e2 100755
@@ -706,6 +706,7 @@ LIST_at91="			\
 #########################################################################
 
 LIST_pxa="		\
+	balloon3	\
 	cerf250		\
 	colibri_pxa270	\
 	cradle		\

board/balloon3/Makefile new file +49 -0

49 lines not on this page · raw message

board/balloon3/balloon3.c new file +224 -0

224 lines not on this page · raw message

board/balloon3/config.mk new file +1 -0

new file mode 100644
index 0000000..1d650ac
@@ -0,0 +1 @@
+TEXT_BASE = 0xa1000000

board/balloon3/lowlevel_init.S new file +36 -0

new file mode 100644
index 0000000..d7b5be6
@@ -0,0 +1,36 @@
+/*
+ * Balloon3 Lowlevel Hardware Initialization
+ *
+ * Copyright (C) 2010 Marek Vasut <[email protected]>
+ *
+ * This program is free software; you can redistribute it and/or
+ * modify it under the terms of the GNU General Public License as
+ * published by the Free Software Foundation; either version 2 of
+ * the License, or (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with this program; if not, write to the Free Software
+ * Foundation, Inc., 59 Temple Place, Suite 330, Boston,
+ * MA 02111-1307 USA
+ */
+
+#include <config.h>
+#include <version.h>
+#include <asm/arch/pxa-regs.h>
+#include <asm/arch/macro.h>
+
+.globl lowlevel_init
+lowlevel_init:
+	pxa_gpio_setup
+	pxa_wait_ticks	0x8000
+	pxa_mem_setup
+	pxa_wakeup
+	pxa_intr_setup
+	pxa_clock_setup
+
+	mov	pc, lr

board/balloon3/u-boot.lds new file +55 -0

55 lines not on this page · raw message

boards.cfg +1 -0

index b5ee531..04ca7de 100644
@@ -51,6 +51,7 @@ actux2		arm	ixp
 actux3		arm	ixp
 actux4		arm	ixp
 ixdp425		arm	ixp
+balloon3	arm	pxa
 cerf250		arm	pxa
 colibri_pxa270	arm	pxa
 cradle		arm	pxa

include/configs/balloon3.h new file +269 -0

269 lines not on this page · raw message

Signature · 1 line

1.7.1

Wolfgang Denk

2010-09-07 21:17 UTC #14 lore raw

PATCH 7/8 PXA: Balloon3 board support

Dear Marek Vasut,

Quoted 4 lines · In message <[email protected]> you wrote:

The following hardware is currently supported:
- UART
- USB Host
- FPGA

...

Quoted 14 lines

board/balloon3/balloon3.c new file +14 -0

+int usb_board_init(void)
+{
+	UHCHR = (UHCHR | UHCHR_PCPL | UHCHR_PSPL) &
+		~(UHCHR_SSEP0 | UHCHR_SSEP1 | UHCHR_SSEP2 | UHCHR_SSE);
+
+	UHCHR |= UHCHR_FSBIR;
+
+	while (UHCHR & UHCHR_FSBIR);
+
+	UHCHR &= ~UHCHR_SSE;
+	UHCHIE = (UHCHIE_UPRIE | UHCHIE_RWIE);
+
+	/* Clear any OTG Pin Hold */
+	if (PSSR & PSSR_OTGPH)

board/balloon3/balloon3.c line 93

Quoted 10 lines

board/balloon3/balloon3.c new file +10 -0

+		PSSR |= PSSR_OTGPH;
+
+	UHCRHDA &= ~(0x200);
+	UHCRHDA |= 0x100;
+
+	/* Set port power control mask bits, only 3 ports. */
+	UHCRHDB |= (0x7<<17);
+
+	/* enable port 2 */
+	UP2OCR |= UP2OCR_HXOE | UP2OCR_HXS | UP2OCR_DMPDE | UP2OCR_DPPDE;

Why aren't you using I/O accessors here?

board/balloon3/balloon3.c line 112

Quoted 10 lines

board/balloon3/balloon3.c new file +10 -0

+void usb_board_stop(void)
+{
+	UHCHR |= UHCHR_FHR;
+	udelay(11);
+	UHCHR &= ~UHCHR_FHR;
+
+	UHCCOMS |= 1;
+	udelay(10);
+
+	CKEN &= ~CKEN10_USBHOST;

And here, and so on?

Best regards,

Wolfgang Denk

Signature · 5 lines

DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Don't tell me how hard you work.  Tell me how much you get done.
                                                     -- James J. Ling

Marek Vasut

2010-09-07 21:27 UTC #15 lore raw

PATCH 7/8 PXA: Balloon3 board support

N900 mailclient is stupid ... Bear with it please. ----- P?vodn? zpr?va -----

Quoted 27 lines

Dear Marek Vasut,

In message <[email protected]> you

Quoted 4 lines · wrote:

The following hardware is currently supported:
- UART
- USB Host
- FPGA

...

Quoted 18 lines

(quoted diff) +18 -0

+int usb_board_init(void)
+{
+??? UHCHR = (UHCHR | UHCHR_PCPL | UHCHR_PSPL) &
+??? ??? ~(UHCHR_SSEP0 | UHCHR_SSEP1 | UHCHR_SSEP2 | UHCHR_SSE);
+
+??? UHCHR |= UHCHR_FSBIR;
+
+??? while (UHCHR & UHCHR_FSBIR);
+
+??? UHCHR &= ~UHCHR_SSE;
+??? UHCHIE = (UHCHIE_UPRIE | UHCHIE_RWIE);
+
+??? /* Clear any OTG Pin Hold */
+??? if (PSSR & PSSR_OTGPH)
+??? ??? PSSR |= PSSR_OTGPH;
+
+??? UHCRHDA &= ~(0x200);
+??? UHCRHDA |= 0x100;

Quoted 9 lines

Review

Quoted 6 lines

(quoted diff) +6 -0

+
+??? /* Set port power control mask bits, only 3 ports. */
+??? UHCRHDB |= (0x7<<17);
+
+??? /* enable port 2 */
+??? UP2OCR |= UP2OCR_HXOE | UP2OCR_HXS | UP2OCR_DMPDE | UP2OCR_DPPDE;

Why aren't you using I/O accessors here?

Hey Wolfgang,

we already discussed this somewhere. Check how arch/arm/include/mach-pxa/pxa-regs.h is done. It's ripped off the linux kernel. We already came to a conclusion that it needs to be reworked (remove the _REG() macro crud and use io accessors).

Though I'd like to propose if we could get this stuff in prior to reworking pxa-regs.h as the change will be very intrusive. To have a stable revision where the boards work in case something went wrong.

Quoted 24 lines

Review

Quoted 10 lines

(quoted diff) +10 -0

+void usb_board_stop(void)
+{
+??? UHCHR |= UHCHR_FHR;
+??? udelay(11);
+??? UHCHR &= ~UHCHR_FHR;
+
+??? UHCCOMS |= 1;
+??? udelay(10);
+
+??? CKEN &= ~CKEN10_USBHOST;

And here, and so on?

Best regards,

Wolfgang Denk

Signature · 5 lines

DENX Software Engineering GmbH,? ? ? ?  MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Don't tell me how hard you work.?  Tell me how much you get done.
? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ?  -- James J. Ling

Marek Vasut

author

2010-08-20 09:31 UTC #16 lore raw

PATCH 8/8 PXA: Add missing MAINTAINERS entries

In reply to Marek Vasut

Signed-off-by Marek Vasut <[email protected]>

---
No changes

 MAINTAINERS |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)

MAINTAINERS +2 -0

index 433eae4..7d66f7d 100644
@@ -799,9 +799,11 @@ Greg Ungerer <[email protected]>
 Marek Vasut <[email protected]>
 
 	balloon3	xscale
+	colibri_pxa270	xscale
 	palmld		xscale
 	palmtc		xscale
 	vpac270		xscale
+	zipitz2		xscale
 
 Hugo Villeneuve <[email protected]>

Signature · 1 line

1.7.1

Marek Vasut

author

2010-08-10 04:50 UTC #17 lore raw

PATCH 3/9 common: Enable serial for PXA250

In reply to Marek Vasut

Signed-off-by Marek Vasut <[email protected]>

---
 common/serial.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

common/serial.c +1 -1

index fceabfa..7148cb9 100644
@@ -30,7 +30,7 @@ DECLARE_GLOBAL_DATA_PTR;
 static struct serial_device *serial_devices = NULL;
 static struct serial_device *serial_current = NULL;
 
-#if !defined(CONFIG_LWMON) && !defined(CONFIG_PXA27X)
+#if !defined(CONFIG_LWMON) && !defined(CONFIG_PXA27X) && !defined(CONFIG_PXA250)
 struct serial_device *__default_serial_console (void)
 {
 #if defined(CONFIG_8xx_CONS_SMC1) || defined(CONFIG_8xx_CONS_SMC2)

Signature · 1 line

1.7.1

Marek Vasut

author

2010-08-10 04:50 UTC #18 lore raw

PATCH 4/9 PXA: Palm Tungsten|C Support

In reply to Marek Vasut

This patch adds support for the Palm Tungsten|C PXA255 board. The support includes:
- LCD
- MMC
- UART
- NOR

Signed-off-by Marek Vasut <[email protected]>

---
 MAKEALL                      |    1 +
 board/palmtc/Makefile        |   49 +++++++++
 board/palmtc/config.mk       |    1 +
 board/palmtc/lowlevel_init.S |   39 +++++++
 board/palmtc/palmtc.c        |   61 +++++++++++
 board/palmtc/u-boot.lds      |   56 ++++++++++
 boards.cfg                   |    1 +
 include/configs/palmtc.h     |  246 ++++++++++++++++++++++++++++++++++++++++++
 8 files changed, 454 insertions(+), 0 deletions(-)
 create mode 100644 board/palmtc/Makefile
 create mode 100644 board/palmtc/config.mk
 create mode 100644 board/palmtc/lowlevel_init.S
 create mode 100644 board/palmtc/palmtc.c
 create mode 100644 board/palmtc/u-boot.lds
 create mode 100644 include/configs/palmtc.h

MAKEALL +1 -0

index b34ae33..b871976 100755
@@ -713,6 +713,7 @@ LIST_pxa="		\
 	delta		\
 	innokom		\
 	lubbock		\
+	palmtc		\
 	pleb2		\
 	polaris		\
 	pxa255_idp	\

board/palmtc/Makefile new file +49 -0

49 lines not on this page · raw message

board/palmtc/config.mk new file +1 -0

new file mode 100644
index 0000000..1d650ac
@@ -0,0 +1 @@
+TEXT_BASE = 0xa1000000

board/palmtc/lowlevel_init.S new file +39 -0

new file mode 100644
index 0000000..74050dc
@@ -0,0 +1,39 @@
+/*
+ * Palm Tungsten|C Lowlevel Hardware Initialization
+ *
+ * Copyright (C) 2010 Marek Vasut <[email protected]>
+ *
+ * See file CREDITS for list of people who contributed to this
+ * project.
+ *
+ * This program is free software; you can redistribute it and/or
+ * modify it under the terms of the GNU General Public License as
+ * published by the Free Software Foundation; either version 2 of
+ * the License, or (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with this program; if not, write to the Free Software
+ * Foundation, Inc., 59 Temple Place, Suite 330, Boston,
+ * MA 02111-1307 USA
+ */
+
+#include <config.h>
+#include <version.h>
+#include <asm/arch/pxa-regs.h>
+#include <asm/arch/macro.h>
+
+.globl lowlevel_init
+lowlevel_init:
+	pxa_gpio_setup
+	pxa_wait_ticks	0x8000
+	pxa_mem_setup
+	pxa_wakeup
+	pxa_intr_setup
+	pxa_clock_setup
+
+	mov	pc, lr

board/palmtc/palmtc.c new file +61 -0

61 lines not on this page · raw message

board/palmtc/u-boot.lds new file +56 -0

56 lines not on this page · raw message

boards.cfg +1 -0

index 69c6897..c6263c9 100644
@@ -59,6 +59,7 @@ delta		arm	pxa
 innokom		arm	pxa
 logodl		arm	pxa
 lubbock		arm	pxa
+palmtc		arm	pxa
 pleb2		arm	pxa
 xaeniax		arm	pxa
 xm250		arm	pxa

include/configs/palmtc.h new file +246 -0

246 lines not on this page · raw message

Signature · 1 line

1.7.1

Marek Vasut

author

2010-08-10 04:50 UTC #19 lore raw

PATCH 5/9 PXA: pxafb: Add support for Sharp LQ038J7DH53

In reply to Marek Vasut

This LCD panel is found in Palm LifeDrive handheld

Signed-off-by Marek Vasut <[email protected]>

---
 arch/arm/cpu/pxa/pxafb.c |   34 ++++++++++++++++++++++++++++++++++
 1 files changed, 34 insertions(+), 0 deletions(-)

arch/arm/cpu/pxa/pxafb.c +34 -0

index 328fa7a..066f49e 100644
@@ -249,6 +249,40 @@ vidinfo_t panel_info = {
 
 /*----------------------------------------------------------------------*/
 
+#ifdef CONFIG_LQ038J7DH53
+
+# define LCD_BPP	LCD_COLOR8
+
+/* you have to set lccr0 and lccr3 (including pcd) */
+# define REG_LCCR0	0x003008f9
+# define REG_LCCR3	0x03700004
+
+vidinfo_t panel_info = {
+	vl_col:		320,
+	vl_row:		480,
+	vl_width:	320,
+	vl_height:	480,
+	vl_clkp:	CONFIG_SYS_HIGH,
+	vl_oep:		CONFIG_SYS_LOW,
+	vl_hsp:		CONFIG_SYS_LOW,
+	vl_vsp:		CONFIG_SYS_LOW,
+	vl_dp:		CONFIG_SYS_HIGH,
+	vl_bpix:	LCD_BPP,
+	vl_lbw:		0,
+	vl_splt:	1,
+	vl_clor:	1,
+	vl_tft:		1,
+	vl_hpw:		0x04,
+	vl_blw:		0x20,
+	vl_elw:		0x01,
+	vl_vpw:		0x01,
+	vl_bfw:		0x04,
+	vl_efw:		0x01,
+};
+#endif /* CONFIG_ACX517AKN */
+
+/*----------------------------------------------------------------------*/
+
 #if LCD_BPP == LCD_COLOR8
 void lcd_setcolreg (ushort regno, ushort red, ushort green, ushort blue);
 #endif

Signature · 1 line

1.7.1

Marek Vasut

author

2010-08-10 04:50 UTC #20 lore raw

PATCH 6/9 PXA: Add initial Palm LifeDrive support

In reply to Marek Vasut

Signed-off-by Marek Vasut <[email protected]>

---
 MAKEALL                      |    1 +
 board/palmld/Makefile        |   49 ++++++++
 board/palmld/config.mk       |    1 +
 board/palmld/lowlevel_init.S |   45 +++++++
 board/palmld/palmld.c        |   71 +++++++++++
 board/palmld/u-boot.lds      |   56 +++++++++
 boards.cfg                   |    1 +
 include/configs/palmld.h     |  272 ++++++++++++++++++++++++++++++++++++++++++
 8 files changed, 496 insertions(+), 0 deletions(-)
 create mode 100644 board/palmld/Makefile
 create mode 100644 board/palmld/config.mk
 create mode 100644 board/palmld/lowlevel_init.S
 create mode 100644 board/palmld/palmld.c
 create mode 100644 board/palmld/u-boot.lds
 create mode 100644 include/configs/palmld.h

MAKEALL +1 -0

index b871976..1642abe 100755
@@ -713,6 +713,7 @@ LIST_pxa="		\
 	delta		\
 	innokom		\
 	lubbock		\
+	palmld		\
 	palmtc		\
 	pleb2		\
 	polaris		\

board/palmld/Makefile new file +49 -0

49 lines not on this page · raw message

board/palmld/config.mk new file +1 -0

new file mode 100644
index 0000000..1d650ac
@@ -0,0 +1 @@
+TEXT_BASE = 0xa1000000

board/palmld/lowlevel_init.S new file +45 -0

45 lines not on this page · raw message

board/palmld/palmld.c new file +71 -0

71 lines not on this page · raw message

board/palmld/u-boot.lds new file +56 -0

56 lines not on this page · raw message

boards.cfg +1 -0

index c6263c9..b5ee531 100644
@@ -59,6 +59,7 @@ delta		arm	pxa
 innokom		arm	pxa
 logodl		arm	pxa
 lubbock		arm	pxa
+palmld		arm	pxa
 palmtc		arm	pxa
 pleb2		arm	pxa
 xaeniax		arm	pxa

include/configs/palmld.h new file +272 -0

272 lines not on this page · raw message

Signature · 1 line

1.7.1

Marek Vasut

author

2010-08-10 04:50 UTC #21 lore raw

PATCH 7/9 PXA: Voipac270 improvements

In reply to Marek Vasut

128MB NOR module support.
Define __io to get harddrive working. Fix saving of environment into OneNAND. Boot from harddrive when possible.

Signed-off-by Marek Vasut <[email protected]>

---
 MAKEALL                       |    3 +-
 Makefile                      |    7 +++-
 board/vpac270/Makefile        |    7 +--
 board/vpac270/lowlevel_init.S |    1 -
 board/vpac270/vpac270.c       |   41 +++++++-------------
 include/configs/vpac270.h     |   83 ++++++++++++++++++++++++----------------
 6 files changed, 75 insertions(+), 67 deletions(-)

MAKEALL +2 -1

index 1642abe..52472de 100755
@@ -719,7 +719,8 @@ LIST_pxa="		\
 	polaris		\
 	pxa255_idp	\
 	trizepsiv	\
-	vpac270_nor	\
+	vpac270_128M_nor\
+	vpac270_256M_nor\
 	vpac270_onenand	\
 	wepep250	\
 	xaeniax		\

Makefile +6 -1

index 4f1cb1b..3f2b304 100644
@@ -2180,13 +2180,18 @@ trizepsiv_config	:	unconfig
 	fi;
 	@$(MKCONFIG) -n $@ -a trizepsiv arm pxa trizepsiv
 
-vpac270_nor_config \
+vpac270_nor_256M_config \
+vpac270_nor_128M_config \
 vpac270_onenand_config	: unconfig
 	@mkdir -p $(obj)include
 	@if [ "$(findstring onenand,$@)" ] ; then \
 		echo "#define CONFIG_ONENAND_U_BOOT" \
 			>>$(obj)include/config.h ; \
 	fi;
+	@if [ "$(findstring 256M,$@)" ] ; then \
+		echo "#define CONFIG_256M_U_BOOT" \
+			>>$(obj)include/config.h ; \
+	fi;
 	@$(MKCONFIG) -n $@ -a vpac270 arm pxa vpac270
 
 #########################################################################

board/vpac270/Makefile +2 -5

index c6f4c7c..f5014fc 100644
@@ -1,10 +1,7 @@
-
 #
-# (C) Copyright 2000
-# Wolfgang Denk, DENX Software Engineering, wd at denx.de.
+# Voipac PXA270 Support
 #
-# See file CREDITS for list of people who contributed to this
-# project.
+# Copyright (C) 2010 Marek Vasut <[email protected]>
 #
 # This program is free software; you can redistribute it and/or
 # modify it under the terms of the GNU General Public License as

board/vpac270/lowlevel_init.S +0 -1

index ec0d12c..c40d12f 100644
@@ -3,7 +3,6 @@
  *
  * Copyright (C) 2010 Marek Vasut <[email protected]>
  *
- *
  * See file CREDITS for list of people who contributed to this
  * project.
  *

board/vpac270/vpac270.c +15 ~~-26~~

83 lines not on this page · raw message

include/configs/vpac270.h +50 ~~-33~~

201 lines not on this page · raw message

Signature · 1 line

1.7.1

Marek Vasut

author

2010-08-10 04:50 UTC #22 lore raw

PATCH 8/9 PXA: Balloon3 board support

In reply to Marek Vasut

The following hardware is currently supported:
- UART
- USB Host
- FPGA

Signed-off-by Marek Vasut <[email protected]>

---
 MAKEALL                        |    1 +
 board/balloon3/Makefile        |   49 +++++++
 board/balloon3/balloon3.c      |  227 +++++++++++++++++++++++++++++++++
 board/balloon3/config.mk       |    1 +
 board/balloon3/lowlevel_init.S |   36 ++++++
 board/balloon3/u-boot.lds      |   55 ++++++++
 boards.cfg                     |    1 +
 include/configs/balloon3.h     |  270 ++++++++++++++++++++++++++++++++++++++++
 8 files changed, 640 insertions(+), 0 deletions(-)
 create mode 100644 board/balloon3/Makefile
 create mode 100644 board/balloon3/balloon3.c
 create mode 100644 board/balloon3/config.mk
 create mode 100644 board/balloon3/lowlevel_init.S
 create mode 100644 board/balloon3/u-boot.lds
 create mode 100644 include/configs/balloon3.h

MAKEALL +1 -0

index 52472de..9d149e2 100755
@@ -706,6 +706,7 @@ LIST_at91="			\
 #########################################################################
 
 LIST_pxa="		\
+	balloon3	\
 	cerf250		\
 	colibri_pxa270	\
 	cradle		\

board/balloon3/Makefile new file +49 -0

49 lines not on this page · raw message

board/balloon3/balloon3.c new file +227 -0

227 lines not on this page · raw message

board/balloon3/config.mk new file +1 -0

new file mode 100644
index 0000000..1d650ac
@@ -0,0 +1 @@
+TEXT_BASE = 0xa1000000

board/balloon3/lowlevel_init.S new file +36 -0

new file mode 100644
index 0000000..d7b5be6
@@ -0,0 +1,36 @@
+/*
+ * Balloon3 Lowlevel Hardware Initialization
+ *
+ * Copyright (C) 2010 Marek Vasut <[email protected]>
+ *
+ * This program is free software; you can redistribute it and/or
+ * modify it under the terms of the GNU General Public License as
+ * published by the Free Software Foundation; either version 2 of
+ * the License, or (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with this program; if not, write to the Free Software
+ * Foundation, Inc., 59 Temple Place, Suite 330, Boston,
+ * MA 02111-1307 USA
+ */
+
+#include <config.h>
+#include <version.h>
+#include <asm/arch/pxa-regs.h>
+#include <asm/arch/macro.h>
+
+.globl lowlevel_init
+lowlevel_init:
+	pxa_gpio_setup
+	pxa_wait_ticks	0x8000
+	pxa_mem_setup
+	pxa_wakeup
+	pxa_intr_setup
+	pxa_clock_setup
+
+	mov	pc, lr

board/balloon3/u-boot.lds new file +55 -0

55 lines not on this page · raw message

boards.cfg +1 -0

index b5ee531..04ca7de 100644
@@ -51,6 +51,7 @@ actux2		arm	ixp
 actux3		arm	ixp
 actux4		arm	ixp
 ixdp425		arm	ixp
+balloon3	arm	pxa
 cerf250		arm	pxa
 colibri_pxa270	arm	pxa
 cradle		arm	pxa

include/configs/balloon3.h new file +270 -0

270 lines not on this page · raw message

Signature · 1 line

1.7.1

Wolfgang Denk

2010-08-10 21:52 UTC #23 lore raw

PATCH 8/9 PXA: Balloon3 board support

Dear Marek Vasut,

Quoted 6 lines · In message <[email protected]> you wrote:

The following hardware is currently supported:
- UART
- USB Host
- FPGA
Signed-off-by Marek Vasut <[email protected]>

Quoted 16 lines

---
 MAKEALL                        |    1 +
 board/balloon3/Makefile        |   49 +++++++
 board/balloon3/balloon3.c      |  227 +++++++++++++++++++++++++++++++++
 board/balloon3/config.mk       |    1 +
 board/balloon3/lowlevel_init.S |   36 ++++++
 board/balloon3/u-boot.lds      |   55 ++++++++
 boards.cfg                     |    1 +
 include/configs/balloon3.h     |  270 ++++++++++++++++++++++++++++++++++++++++
 8 files changed, 640 insertions(+), 0 deletions(-)
 create mode 100644 board/balloon3/Makefile
 create mode 100644 board/balloon3/balloon3.c
 create mode 100644 board/balloon3/config.mk
 create mode 100644 board/balloon3/lowlevel_init.S
 create mode 100644 board/balloon3/u-boot.lds
 create mode 100644 include/configs/balloon3.h

MAINTAINERS entry missing.

...

board/balloon3/balloon3.c line 40

Quoted 4 lines

board/balloon3/balloon3.c new file +4 -0

+int board_init (void)
+{
+	/* memory and cpu-speed are setup before relocation */
+	/* so we do _nothing_ here */

Nothing? This comment is wrong.

board/balloon3/balloon3.c line 49

Quoted 8 lines

board/balloon3/balloon3.c new file +8 -0

+	/* arch number of vpac270 */
+	gd->bd->bi_arch_number = MACH_TYPE_BALLOON3;
+
+	/* adress of boot parameters */
+	gd->bd->bi_boot_params = 0xa0000100;
+
+	/* Init the FPGA */
+	balloon3_init_fpga();

This is definitely more than nothing.

board/balloon3/balloon3.c line 78

Quoted 4 lines

board/balloon3/balloon3.c new file +4 -0

+	UHCHR = (UHCHR | UHCHR_PCPL | UHCHR_PSPL) &
+		~(UHCHR_SSEP0 | UHCHR_SSEP1 | UHCHR_SSEP2 | UHCHR_SSE);
+
+	UHCHR |= UHCHR_FSBIR;

Please use I/O accessors to access device registers. Please fix globally.

board/balloon3/balloon3.c line 80

Quoted 1 line

board/balloon3/balloon3.c new file +1 -0
+	while (UHCHR & UHCHR_FSBIR);

The semicolon goes to the next line.

include/configs/balloon3.h line 75

Quoted 2 lines

include/configs/balloon3.h new file +2 -0

+#ifdef	CONFIG_CMD_KGDB
+#define	CONFIG_KGDB_BAUDRATE		230400		/* speed to run kgdb serial port */

Line too long. Please fix globally.

I stop reviewing here. Please check the other patches for similar issues, and fix these as well. Please also re-read the review comments for the first patch series.

Best regards,

Wolfgang Denk

Signature · 5 lines

DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
I am not now, nor have I ever been, a member of the demigodic party.
                                                   -- Dennis Ritchie

Marek Vasut

author

2010-08-10 04:50 UTC #24 lore raw

PATCH 9/9 PXA: Add missing MAINTAINERS entries

In reply to Marek Vasut

Signed-off-by Marek Vasut <[email protected]>

---
 MAINTAINERS |    9 +++++++++
 1 files changed, 9 insertions(+), 0 deletions(-)

MAINTAINERS +9 -0

index 4b91b0f..f782f64 100644
@@ -815,6 +815,15 @@ Alex Z
 	lart		SA1100
 	dnp1110		SA1110
 
+Marek Vasut <[email protected]>
+
+	balloon3	xscale
+	colibri_pxa270	xscale
+	palmld		xscale
+	palmtc		xscale
+	vpac270		xscale
+	zipitz2		xscale
+
 -------------------------------------------------------------------------
 
 Unknown / orphaned boards:

Signature · 1 line

1.7.1

Wolfgang Denk

NAK

2010-08-10 21:48 UTC #25 lore raw

PATCH 9/9 PXA: Add missing MAINTAINERS entries

Dear Marek Vasut,

Quoted 10 lines · In message <[email protected]> you wrote:

Signed-off-by Marek Vasut <[email protected]>
---
 MAINTAINERS |    9 +++++++++
 1 files changed, 9 insertions(+), 0 deletions(-)
MAINTAINERS +0 -0
index 4b91b0f..f782f64 100644

MAINTAINERS Alex Z · line 818

Quoted 4 lines

MAINTAINERS +1 -0

@@ -815,6 +815,15 @@ Alex Z
 	lart		SA1100
 	dnp1110		SA1110
 
+Marek Vasut <[email protected]>

Please keep the list sorted. "V" goes before "Z".

MAINTAINERS Alex Z · line 826

Quoted 7 lines

MAINTAINERS +7 -0

+	balloon3	xscale
+	colibri_pxa270	xscale
+	palmld		xscale
+	palmtc		xscale
+	vpac270		xscale
+	zipitz2		xscale
+

NAK!!

These changes should be squashed into the commits that add the board support. OK, colibri_pxa270, vpac270 and zipitz2 these affect boards already present. But the other ones must be merged into the respective commits.

Best regards,

Wolfgang Denk

Signature · 6 lines

DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Operating-system software is the program that  orchestrates  all  the
basic functions of a computer.
- The Wall Street Journal, Tuesday, September 15, 1987, page 40

Wolfgang Denk

2010-08-10 21:38 UTC #26 lore raw

PATCH 1/9 ARM: Define __raw_readX and __raw_writeX

In reply to Marek Vasut

Dear Marek Vasut,

Quoted 7 lines · In message <[email protected]> you wrote:

These functions are undefined on ARM when using __io. These are the commonly used versions and can be redefined.
Signed-off-by Marek Vasut <[email protected]>
---
 arch/arm/include/asm/io.h |   46 +++++++++++++++++++++++++++++++++++++++-----
 1 files changed, 40 insertions(+), 6 deletions(-)

Why are you submitting this? This patch has been pulled into mainline on Thu Jul 22 already.

If there should be anything wrong with these, please submit an incremental patch.

Best regards,

Wolfgang Denk

Signature · 6 lines

DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
If all the Chinese simultaneously jumped into the Pacific  off  a  10
foot platform erected 10 feet off their coast, it would cause a tidal
wave that would destroy everything in this country west of Nebraska.

Marek Vasut

author

2010-08-10 23:52 UTC #27 lore raw

PATCH 1/9 ARM: Define __raw_readX and __raw_writeX

Dne ?t 10. srpna 2010 23:38:25 Wolfgang Denk napsal(a):

Quoted 3 lines

Dear Marek Vasut,
In message <[email protected]> you

Quoted 6 lines · wrote:

Quoted 6 lines
These functions are undefined on ARM when using __io. These are the commonly used versions and can be redefined.
Signed-off-by Marek Vasut <[email protected]>
---

Quoted 6 lines

Quoted 3 lines
 arch/arm/include/asm/io.h |   46
+++++++++++++++++++++++++++++++++++++++----- 1 files changed, 40 insertions(+), 6 deletions(-)
Why are you submitting this? This patch has been pulled into mainline on Thu Jul 22 already.

Sorry, ignore this please.

Quoted 7 lines

If there should be anything wrong with these, please submit an incremental patch.
Best regards,
Wolfgang Denk