mips: irq: add stackoverflow detection
PATCH v2 1/1 mips: irq: add stackoverflow detection
From: Adam Jiang <[email protected]>
Add stackoverflow detection to mips arch
Signed-off-by Adam Jiang <[email protected]>
--- arch/mips/Kconfig.debug | 9 +++++++++ arch/mips/kernel/irq.c | 21 +++++++++++++++++++++ 2 files changed, 30 insertions(+), 0 deletions(-)
arch/mips/Kconfig.debug +9 -0
@@ -67,6 +67,15 @@ config CMDLINE_OVERRIDE Normally, you will choose 'N' here. +config DEBUG_STACKOVERFLOW + bool "Check for stack overflows" + depends on DEBUG_KERNEL + help + This option will cause messages to be printed if free stack space + drops below a certain limit(2GB on MIPS). The debugging option + provides another way to check stack overflow happened on kernel mode + stack usually caused by nested interruption. + config DEBUG_STACK_USAGE bool "Enable stack utilization instrumentation" depends on DEBUG_KERNEL
arch/mips/kernel/irq.c +21 -0
@@ -151,6 +151,26 @@ void __init init_IRQ(void)#endif } +#ifdef DEBUG_STACKOVERFLOW +static inline void check_stack_overflow (void ) +{ +long sp; + + __asm__ __volatile__("move %0, $sp" :"=r" (sp)); + sp = sp & (THREAD_SIZE -1 ); + +/* check for stack overflow: is there less than 2KB free? */ +if (unlikely (sp < (sizeof (struct thread_info ) +2048 ))) { +printk ("do_IRQ: stack overflow: %ld\n" , + sp -sizeof (struct thread_info )); +dump_stack (); + } +} +#else +static inline void check_stack_overflow (void ) {} +#endif + +/* * do_IRQ handles all normal device IRQ's (the special * SMP cross-CPU interrupts have their own specific
@@ -159,6 +179,7 @@ void __init init_IRQ(void) void __irq_entry do_IRQ(unsigned int irq) {irq_enter (); +check_stack_overflow ();__DO_IRQ_SMTC_HOOK (irq);generic_handle_irq (irq);irq_exit ();
Signature · 1 line
1.7.2.2
Quoted 5 lines · On Fri, Aug 27, 2010 at 06:32:06PM +0900, [email protected] wrote:
arch/mips/Kconfig.debug +0
-0
arch/mips/Kconfig.debug config CMDLINE_OVERRIDE · line 75
Quoted 9 lines
arch/mips/Kconfig.debug +6
-0@@ -67,6 +67,15 @@ config CMDLINE_OVERRIDE Normally, you will choose 'N' here. +config DEBUG_STACKOVERFLOW + bool "Check for stack overflows" + depends on DEBUG_KERNEL + help + This option will cause messages to be printed if free stack space + drops below a certain limit(2GB on MIPS). The debugging option
I better upgrade my meory then. 2GB is a LOTS :)
Quoted 11 lines
arch/mips/Kconfig.debug +3
-0+ provides another way to check stack overflow happened on kernel mode + stack usually caused by nested interruption. + config DEBUG_STACK_USAGE bool "Enable stack utilization instrumentation" depends on DEBUG_KERNELarch/mips/kernel/irq.c +0
-0
arch/mips/kernel/irq.c void __init init_IRQ(void) · line 157
Quoted 7 lines
arch/mips/kernel/irq.c +4
-0@@ -151,6 +151,26 @@ void __init init_IRQ(void)#endif } +#ifdef DEBUG_STACKOVERFLOW +static inline void check_stack_overflow (void ) +{ +long sp;
Addresses in Linux should always be unsigned long.
arch/mips/kernel/irq.c void __init init_IRQ(void) · line 160
Quoted 3 lines
arch/mips/kernel/irq.c +3
-0+ + __asm__ __volatile__("move %0, $sp" :"=r" (sp)); + sp = sp & (THREAD_SIZE -1 );
For THREAD_SIZE - 1 there is the symbol THREAD_MASK.
arch/mips/kernel/irq.c void __init init_IRQ(void) · line 163
Quoted 2 lines
arch/mips/kernel/irq.c +2
-0+/* check for stack overflow: is there less than 2KB free? */ +if (unlikely (sp < (sizeof (struct thread_info ) +2048 ))) {
Looks good otherwise, will queue.
Ralf