Skip to contentSkip to conversation

regulator: set max8998->dev to &pdev->dev.

PATCH Applied Axel Lin 3 participants 3 messages Aug 27, 2010 Voltage and current regulator framework

lore
Share & tools
lore

Axel Lin

author
#0 lore raw

PATCH 1/1 regulator: set max8998->dev to &pdev->dev.

max8998->dev is NULL in current implementation, set it to &pdev->dev.

regulator_register() still return success if max8998->dev is NULL, but rdev->dev.parent will be set to NULL which is incorrect.

Signed-off-by Axel Lin <[email protected]>
---
 drivers/regulator/max8998.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)
drivers/regulator/max8998.c +1 -0
index 8b9bfdf..a1baf1f 100644
@@ -557,6 +557,7 @@ static __devinit int max8998_pmic_probe(struct platform_device *pdev)
 	}
 
 	rdev = max8998->rdev;
+	max8998->dev = &pdev->dev;
 	max8998->iodev = iodev;
 	max8998->num_regulators = pdata->num_regulators;
 	platform_set_drvdata(pdev, max8998);
Signature · 1 line
1.7.2
Applied
#2 lore raw
Quoted 10 lines · Mark Brown
Quoted 6 lines · Axel Lin

max8998->dev is NULL in current implementation, set it to &pdev->dev.

regulator_register() still return success if max8998->dev is NULL, but rdev->dev.parent will be set to NULL which is incorrect.

Signed-off-by Axel Lin <[email protected]>
Acked-by Mark Brown <[email protected]>

--

Applied.

Thanks

Liam

Signature · 3 lines
Freelance Developer, SlimLogic Ltd
ASoC and Voltage Regulator Maintainer.
http://www.slimlogic.co.uk