Skip to contentSkip to conversation

USB: musb: move musb debugfs entry under usb debugfs root dir

PATCH In review [email protected] 4 participants 4 messages Aug 27, 2010 – Aug 28, 2010 3 messages not in the archive

Subsystems (2)
USB MUSB multipoint high speed dual-role controller
lore
Share & tools
lore

[email protected]

author
#0 lore raw

PATCH 1/1 USB: musb: move musb debugfs entry under usb debugfs root dir

From: Ming Lei <[email protected]>

All hcd's debugfs entries are under usb debugfs root dir already, so musb should not be a exception.

Signed-off-by Ming Lei <[email protected]>
---
 drivers/usb/musb/musb_debugfs.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
drivers/usb/musb/musb_debugfs.c +1 -1
index c79a5e3..b19c31c 100644
@@ -257,7 +257,7 @@ int __init musb_init_debugfs(struct musb *musb)
 	struct dentry		*file;
 	int			ret;
 
-	root = debugfs_create_dir("musb", NULL);
+	root = debugfs_create_dir("musb", usb_debug_root);
 	if (IS_ERR(root)) {
 		ret = PTR_ERR(root);
 		goto err0;
Signature · 1 line
1.6.2.5

A message that is not in the archive (sent off-list or not yet received): 1282923939-14872-1-git-send-email-tom.leiming-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org

#2 lore raw
Quoted 16 lines · [email protected] wrote:

From: Ming Lei <[email protected]>

All hcd's debugfs entries are under usb debugfs root dir already, so musb should not be a exception.

Signed-off-by Ming Lei <[email protected]>
---
 drivers/usb/musb/musb_debugfs.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
drivers/usb/musb/musb_debugfs.c +0 -0
index c79a5e3..b19c31c 100644

drivers/usb/musb/musb_debugfs.c int __init musb_init_debugfs(struct musb *musb) · line 263

Quoted 8 lines
drivers/usb/musb/musb_debugfs.c +1 -1
@@ -257,7 +257,7 @@ int __init musb_init_debugfs(struct musb *musb)
 	struct dentry		*file;
 	int			ret;
 
-	root = debugfs_create_dir("musb", NULL);
+	root = debugfs_create_dir("musb", usb_debug_root);
 	if (IS_ERR(root)) {
 		ret = PTR_ERR(root);
 		goto err0;

Hi,

This will not work when you do not have USB Host support enabled in your kernel.

- Anand

--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html

A message that is not in the archive (sent off-list or not yet received): 5A47E75E594F054BAF48C5E4FC4B92AB0328C1CBD0-/tLxBxkBPtCIQmiDNMet8wC/[email protected]

#4 lore raw
Quoted 28 lines · Anand
Quoted 16 lines · [email protected] wrote:

From: Ming Lei <[email protected]>

All hcd's debugfs entries are under usb debugfs root dir already, so musb should not be a exception.

Signed-off-by Ming Lei <[email protected]>
---
 drivers/usb/musb/musb_debugfs.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
drivers/usb/musb/musb_debugfs.c +0 -0
index c79a5e3..b19c31c 100644

drivers/usb/musb/musb_debugfs.c int __init musb_init_debugfs(struct musb *musb) · line 263

Quoted 8 lines
drivers/usb/musb/musb_debugfs.c +1 -1
@@ -257,7 +257,7 @@ int __init musb_init_debugfs(struct musb *musb)
 	struct dentry		*file;
 	int			ret;
 
-	root = debugfs_create_dir("musb", NULL);
+	root = debugfs_create_dir("musb", usb_debug_root);
 	if (IS_ERR(root)) {
 		ret = PTR_ERR(root);
 		goto err0;

Hi,

Quoted 2 lines

This will not work when you do not have USB Host support enabled in your kernel.

Then we should move the creation of usb_debug_root out into somewhere that will work for both types of systems, right? Now where that might be, I can't tell at the moment...

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html

A message that is not in the archive (sent off-list or not yet received): [email protected]

#6 lore raw

2010/8/28 Greg KH <[email protected]>:

Quoted 29 lines · Anand
Quoted 28 lines
Quoted 16 lines · [email protected] wrote:

From: Ming Lei <[email protected]>

All hcd's debugfs entries are under usb debugfs root dir already, so musb should not be a exception.

Signed-off-by Ming Lei <[email protected]>

---
 drivers/usb/musb/musb_debugfs.c |    2 +-

 1 files changed, 1 insertions(+), 1 deletions(-)
drivers/usb/musb/musb_debugfs.c +0 -0
index c79a5e3..b19c31c 100644

drivers/usb/musb/musb_debugfs.c int __init musb_init_debugfs(struct musb *musb) · line 263

Quoted 8 lines
drivers/usb/musb/musb_debugfs.c +1 -1
@@ -257,7 +257,7 @@ int __init musb_init_debugfs(struct musb *musb)
     struct dentry           *file;
     int                     ret;
 
-   root = debugfs_create_dir("musb", NULL);
+   root = debugfs_create_dir("musb", usb_debug_root);
     if (IS_ERR(root)) {
             ret = PTR_ERR(root);
             goto err0;

Hi,

Quoted 6 lines
Quoted 2 lines

This will not work when you do not have USB Host support enabled in your kernel.

Then we should move the creation of usb_debug_root out into somewhere that will work for both types of systems, right?  Now where that might be, I can't tell at the moment...

Seems a little difficult to find a place to create usb_debug_root which may support both usb host and device.

USB gadget framework doesn't depend on usbcore.

So please ignore the patch now, thanks.

Signature · 5 lines
Lei Ming
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html