Skip to contentSkip to conversation

NAND: add support for reading ONFI parameters

PATCH In review Florian Fainelli 2 participants 4 messages Aug 18, 2010 – Aug 30, 2010 Memory technology devices (MTD)

lore
Share & tools
lore
#0 lore raw

v2 cover NAND: add support for reading ONFI parameters

Hi,

This is the second version of the patch series adding support for ONFI parameters to NAND device.

Florian Fainelli (4):
NAND: add NAND_CMD_PARAM (0xec) definition
NAND: denali should also handle NAND_CMD_PARAM
lib: add crc16_le helper
NAND: add support for reading ONFI parameters from NAND device

#1 lore raw
Quoted 10 lines · Florian Fainelli

Hi,

This is the second version of the patch series adding support for ONFI parameters to NAND device.

Florian Fainelli (4):
NAND: add NAND_CMD_PARAM (0xec) definition
NAND: denali should also handle NAND_CMD_PARAM
lib: add crc16_le helper
NAND: add support for reading ONFI parameters from NAND device

Hi,

since I did not review your patches, I am picking them and pushing to l2-mtd-2.6.git / dunno branch. I'll try to encourage dwmw2 to look at them and take them to the mtd tree, so they would have some exposure in the -next tree.

But some "Tested-by" / "Reviewed-by" tags would certainly be useful, anyone?

Also, the last patch did not apply cleanly, could you take a look whether the patch utility got it right?

Applying: mtd: nand: add support for reading ONFI parameters from NAND device
error: patch failed: drivers/mtd/nand/nand_base.c:2943
error: drivers/mtd/nand/nand_base.c: patch does not apply
Patch failed at 0001 mtd: nand: add support for reading ONFI parameters from NAND device When you have resolved this problem run "git am --resolved".
If you would prefer to skip this patch, instead run "git am --skip".
To restore the original branch and stop patching run "git am --abort". [dedekind@brekeke l2-mtd-2.6]$ patch -p1 < .git/rebase-apply/patch patching file drivers/mtd/nand/Kconfig
patching file drivers/mtd/nand/nand_base.c
Hunk #6 succeeded at 2991 (offset 1 line).
Hunk #7 succeeded at 3020 (offset 1 line).
Hunk #8 succeeded at 3045 with fuzz 2 (offset -3 lines).
Hunk #9 succeeded at 3084 (offset -3 lines).
Hunk #10 succeeded at 3107 (offset -3 lines).
Hunk #11 succeeded at 3117 (offset -3 lines).
Hunk #12 succeeded at 3135 (offset -3 lines).
patching file include/linux/mtd/nand.h

My tree is here:
http://git.infradead.org/users/dedekind/l2-mtd-2.6.git

Thanks.

Signature · 2 lines
Best Regards,
Artem Bityutskiy (Битюцкий Артём)
#2 lore raw
Quoted 14 lines · Artem Bityutskiy
Quoted 10 lines · Florian Fainelli

Hi,

This is the second version of the patch series adding support for ONFI parameters to NAND device.

Florian Fainelli (4):
NAND: add NAND_CMD_PARAM (0xec) definition
NAND: denali should also handle NAND_CMD_PARAM
lib: add crc16_le helper
NAND: add support for reading ONFI parameters from NAND device

Hi,

Quoted 7 lines

since I did not review your patches, I am picking them and pushing to l2-mtd-2.6.git / dunno branch. I'll try to encourage dwmw2 to look at them and take them to the mtd tree, so they would have some exposure in the -next tree.

But some "Tested-by" / "Reviewed-by" tags would certainly be useful, anyone?

OK, I've noticed the further discussion. Your patches are not threaded with this e-mail, and this confused me.

So I'm removing your patches from my tree and waiting for newer patch-set.

Signature · 2 lines
Best Regards,
Artem Bityutskiy (Битюцкий Артём)
#3 lore raw

Hello Artem,

Quoted 20 lines · On Monday 30 August 2010 10:36:16 Artem Bityutskiy wrote:
Quoted 19 lines · Artem Bityutskiy
Quoted 10 lines · Florian Fainelli

Hi,

This is the second version of the patch series adding support for ONFI parameters to NAND device.

Florian Fainelli (4):
NAND: add NAND_CMD_PARAM (0xec) definition
NAND: denali should also handle NAND_CMD_PARAM
lib: add crc16_le helper
NAND: add support for reading ONFI parameters from NAND device

Hi,

since I did not review your patches, I am picking them and pushing to l2-mtd-2.6.git / dunno branch. I'll try to encourage dwmw2 to look at them and take them to the mtd tree, so they would have some exposure in the -next tree.

Quoted 8 lines
Quoted 2 lines

But some "Tested-by" / "Reviewed-by" tags would certainly be useful, anyone?

OK, I've noticed the further discussion. Your patches are not threaded with this e-mail, and this confused me.

So I'm removing your patches from my tree and waiting for newer patch-set.

Yes, I will resubmit new patches later today. Thanks! --
Florian