Improve kvm_stat delta display

PATCH New Avi Kivity 1 participant 3 messages Sep 1, 2010 KVM

Share & tools

Avi Kivity

author

2010-09-01 07:05 UTC #0 lore raw

cover Improve kvm_stat delta display

Make the first sleep shorter, so numbers come up quicker, and scale the delta so it is a rate-of-change instead of a meaningless number.

Avi Kivity (2):
kvm_stat: make the initial sleep shorter
kvm_stat: scale delta column to make it a rate

 kvm/kvm_stat |   10 ++++++----
 1 files changed, 6 insertions(+), 4 deletions(-)

Avi Kivity

author

2010-09-01 07:05 UTC #1 lore raw

PATCH 1/2 kvm_stat: make the initial sleep shorter

So we can see results faster

Signed-off-by Avi Kivity <[email protected]>

---
 kvm/kvm_stat |    4 +++-
 1 files changed, 3 insertions(+), 1 deletions(-)

kvm/kvm_stat +3 -1

index e68ca4e..b031d48 100755
@@ -325,9 +325,11 @@ def tui(screen, stats):
             row += 1
         screen.refresh()
 
+    sleeptime = 0.25
     while True:
         refresh()
-        curses.halfdelay(30)
+        curses.halfdelay(int(sleeptime * 10))
+        sleeptime = 3
         try:
             c = screen.getkey()
             if c == 'q':

Signature · 1 line

1.7.1

Avi Kivity

author

2010-09-01 07:05 UTC #2 lore raw

PATCH 2/2 kvm_stat: scale delta column to make it a rate

In reply to Avi Kivity

Scale the delta column by 1/sleeptime, so its units are events per second.

Signed-off-by Avi Kivity <[email protected]>

---
 kvm/kvm_stat |    6 +++---
 1 files changed, 3 insertions(+), 3 deletions(-)

kvm/kvm_stat +3 -3

index b031d48..e32df14 100755
@@ -301,7 +301,7 @@ number_width = 10
 def tui(screen, stats):
     curses.use_default_colors()
     curses.noecho()
-    def refresh():
+    def refresh(sleeptime):
         screen.erase()
         screen.addstr(0, 0, 'kvm statistics')
         row = 2

@@ -321,13 +321,13 @@ def tui(screen, stats):
             screen.addstr(row, col, '%10d' % (values[0],))
             col += number_width
             if values[1] is not None:
-                screen.addstr(row, col, '%8d' % (values[1],))
+                screen.addstr(row, col, '%8d' % (values[1] / sleeptime,))
             row += 1
         screen.refresh()
 
     sleeptime = 0.25
     while True:
-        refresh()
+        refresh(sleeptime)
         curses.halfdelay(int(sleeptime * 10))
         sleeptime = 3
         try:

Signature · 1 line

1.7.1