virtio-9p: Make sure -virtfs option works correctly
PATCH 1/1 virtio-9p: Make sure -virtfs option works correctly
When making copy of arguments we were doing partial copy
Signed-off-by Aneesh Kumar K.V <[email protected]>
--- vl.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-)
vl.c +2 -2
@@ -2332,7 +2332,7 @@ int main(int argc, char **argv, char **envp) len +=strlen (qemu_opt_get (opts,"security_model" )); arg_fsdev =qemu_malloc ((len +1 ) *sizeof (*arg_fsdev)); - snprintf(arg_fsdev, len * sizeof(*arg_fsdev), + snprintf(arg_fsdev, (len + 1) * sizeof(*arg_fsdev), "%s,id=%s,path=%s,security_model=%s", qemu_opt_get(opts, "fstype"), qemu_opt_get(opts, "mount_tag"),
@@ -2343,7 +2343,7 @@ int main(int argc, char **argv, char **envp) len +=2 *strlen (qemu_opt_get (opts,"mount_tag" )); arg_9p =qemu_malloc ((len +1 ) *sizeof (*arg_9p)); -snprintf (arg_9p, len *sizeof (*arg_9p), +snprintf (arg_9p, (len +1 ) *sizeof (*arg_9p),"virtio-9p-pci,fsdev=%s,mount_tag=%s" ,qemu_opt_get (opts,"mount_tag" ),qemu_opt_get (opts,"mount_tag" ));
Signature · 1 line
1.7.0.4
Blue Swirl
AppliedThanks, applied.
Quoted 34 lines · Aneesh Kumar K.V
When making copy of arguments we were doing partial copy
Signed-off-by Aneesh Kumar K.V <[email protected]>---
vl.c | 4 ++--1 files changed, 2 insertions(+), 2 deletions(-)vl.c +2
-3@@ -2332,7 +2332,7 @@ int main(int argc, char **argv, char **envp) len += strlen(qemu_opt_get(opts, "security_model")); arg_fsdev = qemu_malloc((len + 1) * sizeof(*arg_fsdev)); - snprintf(arg_fsdev, len * sizeof(*arg_fsdev), + snprintf(arg_fsdev, (len + 1) * sizeof(*arg_fsdev), "%s,id=%s,path=%s,security_model=%s", qemu_opt_get(opts, "fstype"), qemu_opt_get(opts, "mount_tag"),@@ -2343,7 +2343,7 @@ int main(int argc, char **argv, char **envp) len += 2*strlen(qemu_opt_get(opts, "mount_tag")); arg_9p = qemu_malloc((len + 1) * sizeof(*arg_9p)); - snprintf(arg_9p, len * sizeof(*arg_9p), + snprintf(arg_9p, (len + 1) * sizeof(*arg_9p), "virtio-9p-pci,fsdev=%s,mount_tag=%s", qemu_opt_get(opts, "mount_tag"), qemu_opt_get(opts, "mount_tag")); --1.7.0.4