Skip to contentSkip to conversation

staging: xgifb: Fix compile warning

PATCH In review Javier Martinez Canillas 2 participants 2 messages Sep 4, 2010 – Sep 5, 2010 Staging

lore
Share & tools
lore
#0 lore raw

PATCH 1/4 staging: xgifb: Fix compile warning

Hello, In today linux-next I got a some compile warnings with the staging/xgifb driver. This is the first of a 4 patchset that fix all the issues.

The patches are:

[PATCH 1/4] staging: xgifb: Fix compile warning
[PATCH 2/4] staging: xgifb: Add compilation conditionals
[PATCH 3/4] staging: xgifb: Removes unused variable
[PATCH 4/4] staging: xgifb: Init uninitialized variables and fix some style issues

Thanks a lot.

---
 drivers/staging/xgifb/XGI_main_26.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
drivers/staging/xgifb/XGI_main_26.c +1 -1
index 7cd3e95..3c80191 100644
@@ -3418,7 +3418,7 @@ static int __devinit xgifb_probe(struct pci_dev *pdev,
 		XGIfb_registered = 1;
 
 		printk(KERN_INFO "XGIfb: Installed XGIFB_GET_INFO ioctl (%lx)\n",
-		       XGIFB_GET_INFO);
+		       (unsigned long)XGIFB_GET_INFO);
 
 /*		printk(KERN_INFO "XGIfb: 2D acceleration is %s, scrolling mode %s\n",
 		     XGIfb_accel ? "enabled" : "disabled",
Signature · 1 line
1.7.0.4
#1 lore raw
Quoted 21 lines · Javier Martinez Canillas

Hello, In today linux-next I got a some compile warnings with the staging/xgifb driver. This is the first of a 4 patchset that fix all the issues.

The patches are:

[PATCH 1/4] staging: xgifb: Fix compile warning
[PATCH 2/4] staging: xgifb: Add compilation conditionals
[PATCH 3/4] staging: xgifb: Removes unused variable
[PATCH 4/4] staging: xgifb: Init uninitialized variables and fix some style issues

Thanks a lot.

---
 drivers/staging/xgifb/XGI_main_26.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
drivers/staging/xgifb/XGI_main_26.c +0 -0
index 7cd3e95..3c80191 100644

drivers/staging/xgifb/XGI_main_26.c static int __devinit xgifb_probe(struct pci_dev *pdev, · line 3421

Quoted 5 lines
drivers/staging/xgifb/XGI_main_26.c +1 -1
@@ -3418,7 +3418,7 @@ static int __devinit xgifb_probe(struct pci_dev *pdev,
 		XGIfb_registered = 1;
 
 		printk(KERN_INFO "XGIfb: Installed XGIFB_GET_INFO ioctl (%lx)\n",
-		       XGIFB_GET_INFO);
+		       (unsigned long)XGIFB_GET_INFO);

No, you should use %p instead.

Also, you don't spam the kernel log for assigning an ioctl function pointer, that's just looney...

thanks,

greg k-h