staging: xgifb: Init uninitialized variables and fix some style issues
PATCH 4/4 staging: xgifb: Init uninitialized variables and fix some style issues
Signed-off-by Javier Martinez Canillas <[email protected]>
--- drivers/staging/xgifb/vb_setmode.c | 35 +++++++++++++++++------------------ 1 files changed, 17 insertions(+), 18 deletions(-)
drivers/staging/xgifb/vb_setmode.c +17 -18
@@ -399,21 +399,20 @@ void InitTo330Pointer(unsigned char ChipType, struct vb_device_info *pVBInfo)unsigned char XGISetModeNew (struct xgi_hw_device_info *HwDeviceExtension,unsigned short ModeNo) { -unsigned short ModeIdIndex ; -/* unsigned char *pVBInfo->FBAddr = HwDeviceExtension->pjVideoMemoryAddress ; */ -struct vb_device_info VBINF ; -struct vb_device_info *pVBInfo = &VBINF ; - pVBInfo->ROMAddr = HwDeviceExtension->pjVirtualRomBase ; - pVBInfo->BaseAddr = (unsigned long )HwDeviceExtension->pjIOAddress ; - pVBInfo->IF_DEF_LVDS =0 ; - pVBInfo->IF_DEF_CH7005 =0 ; - pVBInfo->IF_DEF_LCDA =1 ; - pVBInfo->IF_DEF_CH7017 =0 ; - pVBInfo->IF_DEF_CH7007 =0 ;/* [Billy] 2007/05/14 */ - pVBInfo->IF_DEF_VideoCapture =0 ; - pVBInfo->IF_DEF_ScaleLCD =0 ; - pVBInfo->IF_DEF_OEMUtil =0 ; - pVBInfo->IF_DEF_PWD =0 ; +unsigned short ModeIdIndex =0 ; +struct vb_device_info VBINF ; +struct vb_device_info *pVBInfo = &VBINF ; + pVBInfo->ROMAddr = HwDeviceExtension->pjVirtualRomBase; + pVBInfo->BaseAddr = (unsigned long )HwDeviceExtension->pjIOAddress; + pVBInfo->IF_DEF_LVDS =0 ; + pVBInfo->IF_DEF_CH7005 =0 ; + pVBInfo->IF_DEF_LCDA =1 ; + pVBInfo->IF_DEF_CH7017 =0 ; + pVBInfo->IF_DEF_CH7007 =0 ;/* [Billy] 2007/05/14 */ + pVBInfo->IF_DEF_VideoCapture =0 ; + pVBInfo->IF_DEF_ScaleLCD =0 ; + pVBInfo->IF_DEF_OEMUtil =0 ; + pVBInfo->IF_DEF_PWD =0 ;if ( HwDeviceExtension->jChipType >=XG20 )/* kuku 2004/06/25 */
@@ -4444,9 +4443,9 @@ unsigned char XGI_SetCRT2Group301(unsigned short ModeNo,struct xgi_hw_device_info *HwDeviceExtension, struct vb_device_info *pVBInfo) { - unsigned short tempbx , - ModeIdIndex , - RefreshRateTableIndex ; + unsigned short tempbx, + ModeIdIndex =0 , + RefreshRateTableIndex; tempbx=pVBInfo->VBInfo ; pVBInfo->SetFlag |= ProgrammingCRT2 ;
Signature · 1 line
1.7.0.4
Quoted 4 lines · Javier Martinez Canillas
Signed-off-by Javier Martinez Canillas <[email protected]>--- drivers/staging/xgifb/vb_setmode.c | 35 +++++++++++++++++------------------
Sorry, this no longer applies due to some coding style cleanups in this file done by someone else earlier today.
Can you redo this against the next linux-next tree and send me the new version?
thanks,
greg k-h