Skip to contentSkip to conversation

ARM: pxa27x_keypad: added a comment to explain clear_wakeup_event callback

PATCH Applied Mark F. Brown 2 participants 2 messages Sep 5, 2010 – Sep 6, 2010

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ARM: pxa27x_keypad: added a comment to explain clear_wakeup_event callback

---
 arch/arm/plat-pxa/include/plat/pxa27x_keypad.h |    9 +++++++++
 1 files changed, 9 insertions(+), 0 deletions(-)
arch/arm/plat-pxa/include/plat/pxa27x_keypad.h +9 -0
index 73dacda..abcc36e 100644
@@ -25,6 +25,13 @@
  *
  * 4. matrix key and direct key will use the same debounce_interval by
  *    default, which should be sufficient in most cases
+ *
+ * pxa168 keypad platform specific parameter
+ *
+ * NOTE:
+ * clear_wakeup_event callback is a workaround required to clear the
+ * keypad interrupt. The keypad wake must be cleared in addition to
+ * reading the MI/DI bits in the KPC register.
  */
 struct pxa27x_keypad_platform_data {
 
@@ -52,6 +59,8 @@ struct pxa27x_keypad_platform_data {
 
 	/* key debounce interval */
 	unsigned int	debounce_interval;
+
+	/* clear wakeup event requirement for pxa168 */
 	void		(*clear_wakeup_event)(void);
 };
 
Signature · 1 line
1.7.0.4
Applied
#1 lore raw
Quoted 32 lines · Mark F. Brown

---
?arch/arm/plat-pxa/include/plat/pxa27x_keypad.h | ? ?9 +++++++++ ?1 files changed, 9 insertions(+), 0 deletions(-)

arch/arm/plat-pxa/include/plat/pxa27x_keypad.h +0 -0
index 73dacda..abcc36e 100644
@@ -25,6 +25,13 @@

?*
?* 4. matrix key and direct key will use the same debounce_interval by ?* ? ?default, which should be sufficient in most cases
+ *
+ * pxa168 keypad platform specific parameter
+ *
+ * NOTE:
+ * clear_wakeup_event callback is a workaround required to clear the
+ * keypad interrupt. The keypad wake must be cleared in addition to
+ * reading the MI/DI bits in the KPC register.
?*/
?struct pxa27x_keypad_platform_data {

arch/arm/plat-pxa/include/plat/pxa27x_keypad.h +0 -0
@@ -52,6 +59,8 @@ struct pxa27x_keypad_platform_data {
 

? ? ? ?/* key debounce interval */
? ? ? ?unsigned int ? ?debounce_interval;
+
+ ? ? ? /* clear wakeup event requirement for pxa168 */ ? ? ? ?void ? ? ? ? ? ?(*clear_wakeup_event)(void); ?};

Quoted 4 lines

--
1.7.0.4

Merged into below commit, and 'devel' branch pushed.

ARM: pxa27x_keypad: added wakeup event handler for keypad interrupts

Thanks.