Skip to contentSkip to conversation

staging: comedi: check return code of put_user

PATCH In review Kulikov Vasiliy 1 participant 1 message Sep 5, 2010

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 5/14 staging: comedi: check return code of put_user

From: Vasiliy Kulikov <[email protected]>

Function put_user may fail. Check for it.

---
I couldn't compile this driver at all, so it is not tested.

 drivers/staging/comedi/comedi_fops.c |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)
drivers/staging/comedi/comedi_fops.c +2 -1
index 1409131..a3c7183 100644
@@ -537,7 +537,8 @@ static int do_chaninfo_ioctl(struct comedi_device *dev,
 
 			x = (dev->minor << 28) | (it.subdev << 24) | (i << 16) |
 			    (s->range_table_list[i]->length);
-			put_user(x, it.rangelist + i);
+			if (put_user(x, it.rangelist + i))
+				return -EFAULT;
 		}
 #if 0
 		if (copy_to_user(it.rangelist, s->range_type_list,
Signature · 1 line
1.7.0.4