Skip to contentSkip to conversation

: xl: fix out-of-tree libxl builds

PATCH In review Gianni Tedesco 2 participants 2 messages Sep 6, 2010 – Sep 7, 2010

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 : xl: fix out-of-tree libxl builds

Broken since introduction of libxl_uuid.h which defines a core API data-type but it's not installed in include directory.

tools/libxl/Makefile Mon Sep 06 14:01:56 2010 +0100 renamed from tools/libxl/Makefile Mon Sep 06 13:38:24 2010 +0100 +1 -1
diff -r 16bb1ccc6ffa tools/libxl/Makefile
@@ -115,7 +115,7 @@ install: all
    ln -sf libxlutil.so.$(XLUMAJOR).$(XLUMINOR) $(DESTDIR)$(LIBDIR)/libxlutil.so.$(XLUMAJOR)
    ln -sf libxlutil.so.$(XLUMAJOR) $(DESTDIR)$(LIBDIR)/libxlutil.so
    $(INSTALL_DATA) libxlutil.a $(DESTDIR)$(LIBDIR)
-   $(INSTALL_DATA) libxl.h _libxl_types.h $(DESTDIR)$(INCLUDEDIR)
+   $(INSTALL_DATA) libxl.h _libxl_types.h libxl_uuid.h $(DESTDIR)$(INCLUDEDIR)
    $(INSTALL_DATA) bash-completion $(DESTDIR)$(BASH_COMPLETION_DIR)/xl.sh
 
 .PHONY: clean
#1 lore raw

Gianni Tedesco writes ("[PATCH]: xl: fix out-of-tree libxl builds"):

Quoted 9 lines

Broken since introduction of libxl_uuid.h which defines a core API data-type but it's not installed in include directory.

diff -r 16bb1ccc6ffa tools/libxl/Makefile

tools/libxl/Makefile Mon Sep 06 14:01:56 2010 +0100 install: all · line 118

Quoted 5 lines
tools/libxl/Makefile Mon Sep 06 14:01:56 2010 +0100 renamed from tools/libxl/Makefile Mon Sep 06 13:38:24 2010 +0100 +1 -1
@@ -115,7 +115,7 @@ install: all
    ln -sf libxlutil.so.$(XLUMAJOR).$(XLUMINOR) $(DESTDIR)$(LIBDIR)/libxlutil.so.$(XLUMAJOR)
    ln -sf libxlutil.so.$(XLUMAJOR) $(DESTDIR)$(LIBDIR)/libxlutil.so
    $(INSTALL_DATA) libxlutil.a $(DESTDIR)$(LIBDIR)
-   $(INSTALL_DATA) libxl.h _libxl_types.h $(DESTDIR)$(INCLUDEDIR)
+   $(INSTALL_DATA) libxl.h _libxl_types.h libxl_uuid.h $(DESTDIR)$(INCLUDEDIR)

This patch didn't apply automatically because your MUA has converted tabs to spaces (4 spaces!). I'll apply it by hand.

Ian.