Skip to contentSkip to conversation

arch/powerpc: Remove duplicate/redundant Altivec entries

RFC In review Matthew McClintock 3 participants 3 messages Sep 7, 2010 – Oct 7, 2010 PowerPC

lore
Share & tools
lore
#0 lore raw

RFC 1/1 arch/powerpc: Remove duplicate/redundant Altivec entries

In lieu of having multiple similiar lines, we can just have one generic cpu-as line for CONFIG_ALTIVEC

---
Was hoping to get comments about this change and if anyone sees any potential problems?

 arch/powerpc/Makefile |    3 +--
 1 files changed, 1 insertions(+), 2 deletions(-)
arch/powerpc/Makefile +1 -2
index e07d499..4e88b42 100644
@@ -131,8 +131,7 @@ KBUILD_CFLAGS		+= -mno-sched-epilog
 endif
 
 cpu-as-$(CONFIG_4xx)		+= -Wa,-m405
-cpu-as-$(CONFIG_6xx)		+= -Wa,-maltivec
-cpu-as-$(CONFIG_POWER4)		+= -Wa,-maltivec
+cpu-as-$(CONFIG_ALTIVEC)	+= -Wa,-maltivec
 cpu-as-$(CONFIG_E500)		+= -Wa,-me500
 cpu-as-$(CONFIG_E200)		+= -Wa,-me200
 
Signature · 1 line
1.6.6.1
#1 lore raw
Quoted 6 lines · Matthew McClintock

In lieu of having multiple similiar lines, we can just have one generic cpu-as line for CONFIG_ALTIVEC

---
Was hoping to get comments about this change and if anyone sees any potential problems?

I have a memory that we can get some altivec instructions even with CONFIG_ALTIVEC = n, though presumably they never get executed. We would have to check that before applying your patch.

Paul.

#2 lore raw
Quoted 7 lines · Paul Mackerras

On Tue, Sep 07, 2010 at 01:56:55PM -0500, Matthew McClintock wrote:
=20

Quoted 5 lines

In lieu of having multiple similiar lines, we can just have one generic cpu-as line for CONFIG_ALTIVEC
=20
---
Was hoping to get comments about this change and if anyone sees any =

potential

Quoted 5 lines
Quoted 1 line

problems?

=20
I have a memory that we can get some altivec instructions even with CONFIG_ALTIVEC =3D n, though presumably they never get executed. We would have to check that before applying your patch.

How would we check that?

- k=