Why is AHA152X_CS !64BIT?
Hi,
I see that the aha152x driver for pcmcia is marked as unsupported on 64bit. But I also see a patch [1] which removes the restriction based on user's testing in bugzilla [2].
Is there a reason why it would have to be marked as !64BIT? I'm asking because there is an opensuse user with this card who updated to 64-bit distro and lost this driver thereafter.
[1] http://kerneltrap.org/mailarchive/linux-scsi/2010/3/6/6832393
[2] https://bugzilla.kernel.org/show_bug.cgi?id=14333
thanks,
Signature · 2 lines
js suse labs
Quoted 6 lines · Jiri Slaby
Hi,
I see that the aha152x driver for pcmcia is marked as unsupported on 64bit. But I also see a patch [1] which removes the restriction based on user's testing in bugzilla [2].
Quoted 8 lines
Is there a reason why it would have to be marked as !64BIT? I'm asking because there is an opensuse user with this card who updated to 64-bit distro and lost this driver thereafter.
[1] http://kerneltrap.org/mailarchive/linux-scsi/2010/3/6/6832393
[2] https://bugzilla.kernel.org/show_bug.cgi?id=14333thanks,
If memory serves correctly, it might be that you need more then 4 Gbyte of memory installed to exercise the bug, something about IO bouncing addresses > 4G.
But don't believe me, I might be imagining things ;-)
Boaz
Quoted 11 lines · On Monday 30 August 2010 07:13:17 Boaz Harrosh wrote:
Quoted 10 lines · Jiri Slaby
Hi,
I see that the aha152x driver for pcmcia is marked as unsupported on 64bit. But I also see a patch [1] which removes the restriction based on user's testing in bugzilla [2].
Is there a reason why it would have to be marked as !64BIT? I'm asking because there is an opensuse user with this card who updated to 64-bit distro and lost this driver thereafter.
Quoted 8 lines
Quoted 4 lines
[1] http://kerneltrap.org/mailarchive/linux-scsi/2010/3/6/6832393
[2] https://bugzilla.kernel.org/show_bug.cgi?id=14333thanks,
If memory serves correctly, it might be that you need more then 4 Gbyte of memory installed to exercise the bug, something about IO bouncing addresses > 4G.
If the machine is using SWIOTLB, then the bounce buffer would be activated. By default if your machine has more than 4GB compiled under x86_64 the SWIOTLB is turned on - but if you have an Intel/AMD IOMMU it gets turned off. Which is OK as the Intel/AMD IOMMUs would handle the 4GB restricted devices. So as long as the driver has pci_dma_mask_set.
Looking at the git gui blame tool history, the reason that was added was for 'allow drivers to be built non-modular'.
So, does this driver build if you make it non-modular?
Quoted 21 lines · Konrad Rzeszutek Wilk
Quoted 11 lines · On Monday 30 August 2010 07:13:17 Boaz Harrosh wrote:
Quoted 10 lines · Jiri Slaby
Hi,
I see that the aha152x driver for pcmcia is marked as unsupported on 64bit. But I also see a patch [1] which removes the restriction based on user's testing in bugzilla [2].
Is there a reason why it would have to be marked as !64BIT? I'm asking because there is an opensuse user with this card who updated to 64-bit distro and lost this driver thereafter.
Quoted 8 lines
Quoted 4 lines
[1] http://kerneltrap.org/mailarchive/linux-scsi/2010/3/6/6832393
[2] https://bugzilla.kernel.org/show_bug.cgi?id=14333thanks,
If memory serves correctly, it might be that you need more then 4 Gbyte of memory installed to exercise the bug, something about IO bouncing addresses > 4G.
Quoted 8 lines
If the machine is using SWIOTLB, then the bounce buffer would be activated. By default if your machine has more than 4GB compiled under
x86_64the SWIOTLB is turned on - but if you have an Intel/AMD IOMMU it gets turned off. Which is OK as the Intel/AMD IOMMUs would handle the 4GB restricted devices. So as long as the driver haspci_dma_mask_set.Looking at the git gui blame tool history, the reason that was added was for 'allow drivers to be built non-modular'.
023ae619 (Robert P. J. Day 2007-03-26 16:06:45 -0400 14) depends on !64BIT
That commit just removed the "depends on m" part:
- depends on m && !64BIT
+ depends on !64BIT
Quoted 1 line
So, does this driver build if you make it non-modular?
It shouldn't since it still depends on !64BIT.
I expect someone thought or had evidence that the driver was not 64-bit clean.
Is the bitkeeper kernel repo still visible somewhere?
Looks like we would need to look at it for patch history that far back.
Signature · 2 lines
~Randy *** Remember to use Documentation/SubmitChecklist when testing your code ***
Quoted 39 lines · Randy Dunlap
Quoted 21 lines · Konrad Rzeszutek Wilk
Quoted 11 lines · On Monday 30 August 2010 07:13:17 Boaz Harrosh wrote:
Quoted 10 lines · Jiri Slaby
Hi,
I see that the aha152x driver for pcmcia is marked as unsupported on 64bit. But I also see a patch [1] which removes the restriction based on user's testing in bugzilla [2].
Is there a reason why it would have to be marked as !64BIT? I'm asking because there is an opensuse user with this card who updated to 64-bit distro and lost this driver thereafter.
Quoted 8 lines
Quoted 4 lines
[1] http://kerneltrap.org/mailarchive/linux-scsi/2010/3/6/6832393
[2] https://bugzilla.kernel.org/show_bug.cgi?id=14333thanks,
If memory serves correctly, it might be that you need more then 4 Gbyte of memory installed to exercise the bug, something about IO bouncing addresses > 4G.
Quoted 8 lines
If the machine is using SWIOTLB, then the bounce buffer would be activated. By default if your machine has more than 4GB compiled under
x86_64the SWIOTLB is turned on - but if you have an Intel/AMD IOMMU it gets turned off. Which is OK as the Intel/AMD IOMMUs would handle the 4GB restricted devices. So as long as the driver haspci_dma_mask_set.Looking at the git gui blame tool history, the reason that was added was for 'allow drivers to be built non-modular'.
023ae619(Robert P. J. Day 2007-03-26 16:06:45 -0400 14) depends on !64BITThat commit just removed the "depends on m" part:
(quoted diff) +1
-1- depends on m && !64BIT + depends on !64BIT
Quoted 9 lines
Quoted 1 line
So, does this driver build if you make it non-modular?
It shouldn't since it still depends on !64BIT.
I expect someone thought or had evidence that the driver was not 64-bit clean.
Is the bitkeeper kernel repo still visible somewhere?
Looks like we would need to look at it for patch history that far back.
http://linux.bkbits.net:8080/linux-2.6/?PAGE=cset&REV=3fe0bc41KO89ooP68UcrHEMVVAfDnw
but it doesn't quite make sense to me. Sure, no ISA on x86_64, but that does not mean no PCMCIA on x86_64.
Signature · 2 lines
~Randy *** Remember to use Documentation/SubmitChecklist when testing your code ***
Quoted 46 lines · Randy Dunlap
Quoted 45 lines · Randy Dunlap
Quoted 21 lines · Konrad Rzeszutek Wilk
Quoted 11 lines · On Monday 30 August 2010 07:13:17 Boaz Harrosh wrote:
Quoted 10 lines · Jiri Slaby
Hi,
I see that the aha152x driver for pcmcia is marked as unsupported on 64bit. But I also see a patch [1] which removes the restriction based on user's testing in bugzilla [2].
Is there a reason why it would have to be marked as !64BIT? I'm asking because there is an opensuse user with this card who updated to 64-bit distro and lost this driver thereafter.
Quoted 8 lines
Quoted 4 lines
[1] http://kerneltrap.org/mailarchive/linux-scsi/2010/3/6/6832393
[2] https://bugzilla.kernel.org/show_bug.cgi?id=14333thanks,
If memory serves correctly, it might be that you need more then 4 Gbyte of memory installed to exercise the bug, something about IO bouncing addresses > 4G.
Quoted 8 lines
If the machine is using SWIOTLB, then the bounce buffer would be activated. By default if your machine has more than 4GB compiled under
x86_64the SWIOTLB is turned on - but if you have an Intel/AMD IOMMU it gets turned off. Which is OK as the Intel/AMD IOMMUs would handle the 4GB restricted devices. So as long as the driver haspci_dma_mask_set.Looking at the git gui blame tool history, the reason that was added was for 'allow drivers to be built non-modular'.
023ae619(Robert P. J. Day 2007-03-26 16:06:45 -0400 14) depends on !64BITThat commit just removed the "depends on m" part:
(quoted diff) +1
-1- depends on m && !64BIT + depends on !64BITQuoted 3 lines
So, does this driver build if you make it non-modular?
It shouldn't since it still depends on !64BIT.
I expect someone thought or had evidence that the driver was not 64-bit clean.
Quoted 8 lines
Quoted 3 lines
Is the bitkeeper kernel repo still visible somewhere?
Looks like we would need to look at it for patch history that far back.http://linux.bkbits.net:8080/linux-2.6/?PAGE=cset&REV=3fe0bc41KO89ooP68UcrHEMVVAfDnw
but it doesn't quite make sense to me. Sure, no ISA on
x86_64, but that does not mean no PCMCIA onx86_64.
Actually, the patch is this one:
http://permalink.gmane.org/gmane.linux.scsi/5835
The complaint is that the driver spews warnings on a 64 bit compile, so it's likely not 64 bit clean.
James
Quoted 56 lines · James Bottomley
Quoted 46 lines · Randy Dunlap
Quoted 45 lines · Randy Dunlap
Quoted 21 lines · Konrad Rzeszutek Wilk
Quoted 11 lines · On Monday 30 August 2010 07:13:17 Boaz Harrosh wrote:
Quoted 10 lines · Jiri Slaby
Hi,
I see that the aha152x driver for pcmcia is marked as unsupported on 64bit. But I also see a patch [1] which removes the restriction based on user's testing in bugzilla [2].
Is there a reason why it would have to be marked as !64BIT? I'm asking because there is an opensuse user with this card who updated to 64-bit distro and lost this driver thereafter.
Quoted 8 lines
Quoted 4 lines
[1] http://kerneltrap.org/mailarchive/linux-scsi/2010/3/6/6832393
[2] https://bugzilla.kernel.org/show_bug.cgi?id=14333thanks,
If memory serves correctly, it might be that you need more then 4 Gbyte of memory installed to exercise the bug, something about IO bouncing addresses > 4G.
Quoted 8 lines
If the machine is using SWIOTLB, then the bounce buffer would be activated. By default if your machine has more than 4GB compiled under
x86_64the SWIOTLB is turned on - but if you have an Intel/AMD IOMMU it gets turned off. Which is OK as the Intel/AMD IOMMUs would handle the 4GB restricted devices. So as long as the driver haspci_dma_mask_set.Looking at the git gui blame tool history, the reason that was added was for 'allow drivers to be built non-modular'.
023ae619(Robert P. J. Day 2007-03-26 16:06:45 -0400 14) depends on !64BITThat commit just removed the "depends on m" part:
(quoted diff) +1
-1- depends on m && !64BIT + depends on !64BITQuoted 3 lines
So, does this driver build if you make it non-modular?
It shouldn't since it still depends on !64BIT.
I expect someone thought or had evidence that the driver was not 64-bit clean.
Quoted 8 lines
Quoted 3 lines
Is the bitkeeper kernel repo still visible somewhere?
Looks like we would need to look at it for patch history that far back.http://linux.bkbits.net:8080/linux-2.6/?PAGE=cset&REV=3fe0bc41KO89ooP68UcrHEMVVAfDnw
but it doesn't quite make sense to me. Sure, no ISA on
x86_64, but that does not mean no PCMCIA onx86_64.
Quoted 6 lines
Actually, the patch is this one:
http://permalink.gmane.org/gmane.linux.scsi/5835
The complaint is that the driver spews warnings on a 64 bit compile, so it's likely not 64 bit clean.
As I wrote few minutes ago, there is only one which is in print. And I cannot find anybody fixing anything similar since 2.1.
So can we enable it on 64-bit when we have two reports it works on 64-bit? (Is it still maintained? MAINTAINERS says so...)
thanks,
Signature · 2 lines
js suse labs
Hi Jiri,
Quoted 5 lines · Jiri Slaby
As I wrote few minutes ago, there is only one which is in print. And I cannot find anybody fixing anything similar since 2.1.
So can we enable it on 64-bit when we have two reports it works on 64-bit? (Is it still maintained?
MAINTAINERSsays so...)
For the maintainance: My ISA machine is defunct, but I still have a PCMCIA card to test and debug it needed - although no 64bit machine with a PCMCIA slot.
I suppose the hardware is so hardly used nowadays, that there simply hasn't been any need for aha152x specific changes (or debugging) for years. And all the interface updates were done by whoever changed the generic interface and I eventually ceased to follow.
So I guess the maintainance state should be changed to "Odd fixes" at best.
Juergen
Quoted 46 lines · Randy Dunlap
Quoted 45 lines · Randy Dunlap
Quoted 21 lines · Konrad Rzeszutek Wilk
Quoted 11 lines · On Monday 30 August 2010 07:13:17 Boaz Harrosh wrote:
Quoted 10 lines · Jiri Slaby
Hi,
I see that the aha152x driver for pcmcia is marked as unsupported on 64bit. But I also see a patch [1] which removes the restriction based on user's testing in bugzilla [2].
Is there a reason why it would have to be marked as !64BIT? I'm asking because there is an opensuse user with this card who updated to 64-bit distro and lost this driver thereafter.
Quoted 8 lines
Quoted 4 lines
[1] http://kerneltrap.org/mailarchive/linux-scsi/2010/3/6/6832393
[2] https://bugzilla.kernel.org/show_bug.cgi?id=14333thanks,
If memory serves correctly, it might be that you need more then 4 Gbyte of memory installed to exercise the bug, something about IO bouncing addresses > 4G.
Quoted 8 lines
If the machine is using SWIOTLB, then the bounce buffer would be activated. By default if your machine has more than 4GB compiled under
x86_64the SWIOTLB is turned on - but if you have an Intel/AMD IOMMU it gets turned off. Which is OK as the Intel/AMD IOMMUs would handle the 4GB restricted devices. So as long as the driver haspci_dma_mask_set.Looking at the git gui blame tool history, the reason that was added was for 'allow drivers to be built non-modular'.
023ae619(Robert P. J. Day 2007-03-26 16:06:45 -0400 14) depends on !64BITThat commit just removed the "depends on m" part:
(quoted diff) +1
-1- depends on m && !64BIT + depends on !64BITQuoted 3 lines
So, does this driver build if you make it non-modular?
It shouldn't since it still depends on !64BIT.
I expect someone thought or had evidence that the driver was not 64-bit clean.
Quoted 8 lines
Quoted 3 lines
Is the bitkeeper kernel repo still visible somewhere?
Looks like we would need to look at it for patch history that far back.http://linux.bkbits.net:8080/linux-2.6/?PAGE=cset&REV=3fe0bc41KO89ooP68UcrHEMVVAfDnw
but it doesn't quite make sense to me. Sure, no ISA on
x86_64, but that does not mean no PCMCIA onx86_64.
Hmm, the changelog says:
The warning I saw was actually for the PCMCIA aha152x driver.
which I think are compiler warnings. But I see only one emitted by the compiler and it is in a debug print.
thanks,
Signature · 2 lines
js suse labs
Quoted 7 lines
Hmm, the changelog says:
The warning I saw was actually for the PCMCIA aha152x driver.which I think are compiler warnings. But I see only one emitted by the compiler and it is in a debug print.
Don't remember the exact warning, but I was rather trigger happy on getting rid of all these ancient unmaintained drivers on 64bit back then.
In hindsight it was the right thing to do -- their userbase seems to be near zero and there were little to no complains about it ever.
-Andi
Signature · 1 line
[email protected] -- Speaking for myself only.
Quoted 8 lines · Andi Kleen
Quoted 6 lines
Hmm, the changelog says:
The warning I saw was actually for the PCMCIA aha152x driver.which I think are compiler warnings. But I see only one emitted by the compiler and it is in a debug print.
Quoted 7 lines
Don't remember the exact warning, but I was rather trigger happy on getting rid of all these ancient unmaintained drivers on 64bit back then.
In hindsight it was the right thing to do -- their userbase seems to be near zero and there were little to no complains about it ever.
OK ... let's try it. Jiří send a patch ... and if it breaks I'm handing you the pieces ...
James
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Quoted 3 lines
OK ... let's try it. Jiří send a patch ... and if it breaks I'm handing you the pieces ...
You mean reenable it? Why? Do you have any indication the user base of this thing (especially on 64bit) is > 0?
-Andi
Signature · 5 lines
[email protected] -- Speaking for myself only. -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
Quoted 5 lines · Andi Kleen
Quoted 2 lines
OK ... let's try it. Jiří send a patch ... and if it breaks I'm handing you the pieces ...
You mean reenable it? Why? Do you have any indication the user base of this thing (especially on 64bit) is > 0?
Yeah, I know of two people who upgraded to 64-bit recently and had been using that driver before (the one for scanner). They both report it's working if non-64bit condition is removed. So I will post a patch to enable it back again...
regards,
Signature · 6 lines
js suse labs -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html