ARM: pxa168: Added Teton BGA Board Support
Subsystems (3)
cover ARM: pxa168: Added Teton BGA Board Support
1) Support for Teton BGA Board
2) Keypad support for Teton BGA
3) RTC support
Patched on top of Eric Miao's tree commit 5df3afbca20235ff8b3d33bd0d26a0d47b989a30
Mark F. Brown (3):
ARM: pxa168: added support for Teton BGA platform
ARM: pxa168/teton bga: added keypad support
ARM: pxa168/teton bga: add board support for i2c and rtc-ds1337
arch/arm/mach-mmp/Kconfig | 7 ++++ arch/arm/mach-mmp/Makefile | 1 + arch/arm/mach-mmp/teton_bga.c | 81 +++++++++++++++++++++++++++++++++++++++++ 3 files changed, 89 insertions(+), 0 deletions(-) create mode 100644 arch/arm/mach-mmp/teton_bga.c
PATCH 1/3 ARM: pxa168: added support for Teton BGA platform
--- arch/arm/mach-mmp/Kconfig | 7 ++++++ arch/arm/mach-mmp/Makefile | 1 + arch/arm/mach-mmp/teton_bga.c | 47 +++++++++++++++++++++++++++++++++++++++++ 3 files changed, 55 insertions(+), 0 deletions(-) create mode 100644 arch/arm/mach-mmp/teton_bga.c
arch/arm/mach-mmp/Kconfig +7 -0
@@ -57,6 +57,13 @@ config MACH_MARVELL_JASPER PXA910-based development board. Since MMP2 is compatible to ARMv6 architecture. +config MACH_TETON_BGA + bool "Marvell's PXA168 Teton BGA Development Board" + select CPU_PXA168 + help + Say 'Y' here if you want to support the Marvell PXA168-based + Teton BGA Development Board. + endmenu config CPU_PXA168
arch/arm/mach-mmp/Makefile +1 -0
@@ -17,3 +17,4 @@ obj-$(CONFIG_MACH_TAVOREVB) += tavorevb.o obj-$(CONFIG_MACH_TTC_DKB) += ttc_dkb.o obj-$(CONFIG_MACH_FLINT) += flint.o obj-$(CONFIG_MACH_MARVELL_JASPER) += jasper.o +obj-$(CONFIG_MACH_TETON_BGA) += teton_bga.o
arch/arm/mach-mmp/teton_bga.c new file +47 -0
47 lines not on this page · raw message
Signature · 1 line
1.7.0.4
Re: [PATCH 1/3] ARM: pxa168: added support for Teton BGA platform
Quoted 91 lines · Mark F. Brown
Signed-off-by Mark F. Brown <[email protected]>---
?arch/arm/mach-mmp/Kconfig ? ? | ? ?7 ++++++ ?arch/arm/mach-mmp/Makefile ? ?| ? ?1 + ?arch/arm/mach-mmp/teton_bga.c | ? 47 +++++++++++++++++++++++++++++++++++++++++?3 files changed, 55 insertions(+), 0 deletions(-) ?create mode 100644
arch/arm/mach-mmp/teton_bga.carch/arm/mach-mmp/Kconfig +0
-0@@ -57,6 +57,13 @@ config MACH_MARVELL_JASPER? ? ? ? ?PXA910-based development board. Since MMP2 is compatible to ? ? ? ? ?ARMv6 architecture.
arch/arm/mach-mmp/Kconfig +7
-0+config MACH_TETON_BGA + ? ? ? bool "Marvell's PXA168 Teton BGA Development Board" + ? ? ? select CPU_PXA168 + ? ? ? help + ? ? ? ? Say 'Y' here if you want to support the Marvell PXA168-based + ? ? ? ? Teton BGA Development Board. +?endmenu
?config
CPU_PXA168arch/arm/mach-mmp/Makefile +0
-0@@ -17,3 +17,4 @@ obj-$(CONFIG_MACH_TAVOREVB) ? += tavorevb.o?obj-$(CONFIG_MACH_TTC_DKB) ? ? += ttc_dkb.o
?obj-$(CONFIG_MACH_FLINT) ? ? ? += flint.o
?obj-$(CONFIG_MACH_MARVELL_JASPER) += jasper.oarch/arm/mach-mmp/Makefile +1
-0+obj-$(CONFIG_MACH_TETON_BGA) ? += teton_bga.oarch/arm/mach-mmp/teton_bga.c new file +47
-1@@ -0,0 +1,47 @@ +/* +* ?linux/arch/arm/mach-mmp/teton_bga.c +* +* ?Support for the Marvell PXA168 Teton BGA Development Platform. +* +* ?This code is based on aspenite.c +* +* ?This program is free software; you can redistribute it and/or modify +* ?it under the terms of the GNU General Public License version 2 as +* ?publishhed by the Free Software Foundation. +*/ + +#include <linux/init.h> +#include <linux/kernel.h> +#include <linux/platform_device.h> + +#include <asm/mach-types.h> +#include <asm/mach/arch.h> +#include <mach/addr-map.h> +#include <mach/mfp-pxa168.h> +#include <mach/pxa168.h> +#include <mach/gpio.h> + +#include "common.h" + +static unsigned long teton_bga_pin_config[]__initdata = { + ? ? ? /* UART1 */ + ? ? ? GPIO107_UART1_TXD, + ? ? ? GPIO108_UART1_RXD, +}; + +static void __init teton_bga_init (void ) +{ + ? ? ? mfp_config(ARRAY_AND_SIZE(teton_bga_pin_config)); + + ? ? ? /* on-chip devices */ + ? ? ? pxa168_add_uart(1); +} + +MACHINE_START(TETON_BGA, "PXA168-based Teton BGA Development Platform") + ? ? ? .phys_io ? ? ? ?= APB_PHYS_BASE, + ? ? ? .io_pg_offst ? ?= (APB_VIRT_BASE >> 18) & 0xfffc, + ? ? ? .map_io ? ? ? ? = mmp_map_io, + ? ? ? .init_irq ? ? ? = pxa168_init_irq, + ? ? ? .timer ? ? ? ? ?= &pxa168_timer, + ? ? ? .init_machine ? = teton_bga_init, +MACHINE_END --1.7.0.4
Quoted 6 lines
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo at vger.kernel.org
More majordomo info at ?http://vger.kernel.org/majordomo-info.html Please read the FAQ at ?http://www.tux.org/lkml/
Acked
Re: [PATCH 1/3] ARM: pxa168: added support for Teton BGA platform
In reply to Mark F. BrownDne St 8. z??? 2010 04:56:45 Mark F. Brown napsal(a):
---------------------------
Description is missing here
---------------------------
Quoted 42 lines
Signed-off-by Mark F. Brown <[email protected]>--- arch/arm/mach-mmp/Kconfig | 7 ++++++ arch/arm/mach-mmp/Makefile | 1 + arch/arm/mach-mmp/teton_bga.c | 47 +++++++++++++++++++++++++++++++++++++++++ 3 files changed, 55 insertions(+), 0 deletions(-) create mode 100644 arch/arm/mach-mmp/teton_bga.carch/arm/mach-mmp/Kconfig +7
-0@@ -57,6 +57,13 @@ config MACH_MARVELL_JASPER PXA910-based development board. Since MMP2 is compatible to ARMv6 architecture. +config MACH_TETON_BGA + bool "Marvell's PXA168 Teton BGA Development Board" + select CPU_PXA168 + help + Say 'Y' here if you want to support the Marvell PXA168-based + Teton BGA Development Board. + endmenu config CPU_PXA168arch/arm/mach-mmp/Makefile +1
-0@@ -17,3 +17,4 @@ obj-$(CONFIG_MACH_TAVOREVB) += tavorevb.o obj-$(CONFIG_MACH_TTC_DKB) += ttc_dkb.o obj-$(CONFIG_MACH_FLINT) += flint.o obj-$(CONFIG_MACH_MARVELL_JASPER) += jasper.o +obj-$(CONFIG_MACH_TETON_BGA) += teton_bga.oarch/arm/mach-mmp/teton_bga.c new file +0
-0
arch/arm/mach-mmp/teton_bga.c line 4
Quoted 4 lines
arch/arm/mach-mmp/teton_bga.c new file +4
-0@@ -0,0 +1,47 @@ +/* +* linux/arch/arm/mach-mmp/teton_bga.c +* +* Support for the Marvell PXA168 Teton BGA Development Platform.
Authoring information of this file are missing. Also, MAINTAINERS entry is missing.
Quoted 8 lines
arch/arm/mach-mmp/teton_bga.c new file +8
-0+* +* This code is based on aspenite.c +* +* This program is free software; you can redistribute it and/or modify +* it under the terms of the GNU General Public License version 2 as +* publishhed by the Free Software Foundation. +*/ +
arch/arm/mach-mmp/teton_bga.c line 22
Quoted 10 lines
arch/arm/mach-mmp/teton_bga.c new file +10
-0+#include <linux/init.h> +#include <linux/kernel.h> +#include <linux/platform_device.h> + +#include <asm/mach-types.h> +#include <asm/mach/arch.h> +#include <mach/addr-map.h> +#include <mach/mfp-pxa168.h> +#include <mach/pxa168.h> +#include <mach/gpio.h>
use ... #include <linux/gpio.h>
Quoted 5 lines
arch/arm/mach-mmp/teton_bga.c new file +5
-0+ +#include "common.h" + +static unsigned long teton_bga_pin_config[]__initdata = { +/* UART1 */
arch/arm/mach-mmp/teton_bga.c line 37
Quoted 10 lines
arch/arm/mach-mmp/teton_bga.c new file +10
-0+GPIO107_UART1_TXD , + GPIO108_UART1_RXD, +}; + +static void __init teton_bga_init (void ) +{ +mfp_config (ARRAY_AND_SIZE (teton_bga_pin_config)); + +/* on-chip devices */ +pxa168_add_uart (1 );
Don't we have enum for these magic numbers on pxa168 ?
arch/arm/mach-mmp/teton_bga.c line 47
Quoted 10 lines
arch/arm/mach-mmp/teton_bga.c new file +10
-0+} + +MACHINE_START (TETON_BGA ,"PXA168-based Teton BGA Development Platform" ) + .phys_io = APB_PHYS_BASE, + .io_pg_offst = (APB_VIRT_BASE >> 18) & 0xfffc, + .map_io = mmp_map_io, + .init_irq = pxa168_init_irq, + .timer = &pxa168_timer, + .init_machine = teton_bga_init, +MACHINE_END
Cheers
Re: [PATCH 1/3] ARM: pxa168: added support for Teton BGA platform
Quoted 93 lines · Marek Vasut
Dne St 8. z??? 2010 04:56:45 Mark F. Brown napsal(a):
---------------------------
Description is missing here
---------------------------Quoted 42 lines
Signed-off-by Mark F. Brown <[email protected]>---
?arch/arm/mach-mmp/Kconfig ? ? | ? ?7 ++++++ ?arch/arm/mach-mmp/Makefile ? ?| ? ?1 + ?arch/arm/mach-mmp/teton_bga.c | ? 47+++++++++++++++++++++++++++++++++++++++++ 3 files changed, 55 insertions(+), 0 deletions(-)
?create mode 100644arch/arm/mach-mmp/teton_bga.carch/arm/mach-mmp/Kconfig +0
-0@@ -57,6 +57,13 @@ config MACH_MARVELL_JASPER? ? ? ? PXA910-based development board. Since MMP2 is compatible to ? ? ? ? ARMv6 architecture.
arch/arm/mach-mmp/Kconfig +7
-0+config MACH_TETON_BGA + ? ? bool "Marvell's PXA168 Teton BGA Development Board" + ? ? select CPU_PXA168 + ? ? help + ? ? ? Say 'Y' here if you want to support the Marvell PXA168-based + ? ? ? Teton BGA Development Board. +?endmenu
?config
CPU_PXA168arch/arm/mach-mmp/Makefile +0
-0@@ -17,3 +17,4 @@ obj-$(CONFIG_MACH_TAVOREVB) += tavorevb.o?obj-$(CONFIG_MACH_TTC_DKB) ? += ttc_dkb.o
?obj-$(CONFIG_MACH_FLINT) ? ? += flint.o
?obj-$(CONFIG_MACH_MARVELL_JASPER) += jasper.oarch/arm/mach-mmp/Makefile +1
-0+obj-$(CONFIG_MACH_TETON_BGA) += teton_bga.oarch/arm/mach-mmp/teton_bga.c new file +0
-0arch/arm/mach-mmp/teton_bga.c line 4
Quoted 4 lines
arch/arm/mach-mmp/teton_bga.c new file +4
-0@@ -0,0 +1,47 @@ +/* +* ?linux/arch/arm/mach-mmp/teton_bga.c +* +* ?Support for the Marvell PXA168 Teton BGA Development Platform. Authoring information of this file are missing. Also,
MAINTAINERSentry is missing.Quoted 8 lines
arch/arm/mach-mmp/teton_bga.c new file +8
-0+* +* ?This code is based on aspenite.c +* +* ?This program is free software; you can redistribute it and/or modify +* ?it under the terms of the GNU General Public License version 2 as +* ?publishhed by the Free Software Foundation. +*/ +arch/arm/mach-mmp/teton_bga.c line 22
Quoted 10 lines
arch/arm/mach-mmp/teton_bga.c new file +10
-0+#include <linux/init.h> +#include <linux/kernel.h> +#include <linux/platform_device.h> + +#include <asm/mach-types.h> +#include <asm/mach/arch.h> +#include <mach/addr-map.h> +#include <mach/mfp-pxa168.h> +#include <mach/pxa168.h> +#include <mach/gpio.h> use ... #include <
linux/gpio.h>Quoted 5 lines
arch/arm/mach-mmp/teton_bga.c new file +5
-0+ +#include "common.h" + +static unsigned long teton_bga_pin_config[]__initdata = { + ? ? /* UART1 */arch/arm/mach-mmp/teton_bga.c
Quoted 10 lines
arch/arm/mach-mmp/teton_bga.c new file +10
-0+ ? ? GPIO107_UART1_TXD, + ? ? GPIO108_UART1_RXD, +}; + +static void __init teton_bga_init (void ) +{ + ? ? mfp_config(ARRAY_AND_SIZE(teton_bga_pin_config)); + + ? ? /* on-chip devices */ + ? ? pxa168_add_uart(1);Don't we have enum for these magic numbers on pxa168 ?
Quoted 13 lines
arch/arm/mach-mmp/teton_bga.c line 47
Quoted 10 lines
arch/arm/mach-mmp/teton_bga.c new file +10
-0+} + +MACHINE_START(TETON_BGA, "PXA168-based Teton BGA Development Platform") + ? ? .phys_io ? ? ? ?= APB_PHYS_BASE, + ? ? .io_pg_offst ? ?= (APB_VIRT_BASE >> 18) & 0xfffc, + ? ? .map_io ? ? ? ? = mmp_map_io, + ? ? .init_irq ? ? ? = pxa168_init_irq, + ? ? .timer ? ? ? ? ?= &pxa168_timer, + ? ? .init_machine ? = teton_bga_init, +MACHINE_ENDCheers
I am assuming you mean the magic number for .io_pg_offst:
.io_pg_offst ? ?= (APB_VIRT_BASE >> 18) & 0xfffc,
It seems all of the other platforms in arch/arm are configuring it this way. Do you really want me to change this?
Regards,
-- Mark
Re: [PATCH 1/3] ARM: pxa168: added support for Teton BGA platform
Dne ?t 9. z??? 2010 01:42:36 Mark F. Brown napsal(a):
Quoted 109 lines · Marek Vasut
Quoted 95 lines
Dne St 8. z??? 2010 04:56:45 Mark F. Brown napsal(a):
---------------------------
Description is missing here
---------------------------Quoted 42 lines
Signed-off-by Mark F. Brown <[email protected]>--- arch/arm/mach-mmp/Kconfig | 7 ++++++ arch/arm/mach-mmp/Makefile | 1 + arch/arm/mach-mmp/teton_bga.c | 47 +++++++++++++++++++++++++++++++++++++++++ 3 files changed, 55 insertions(+), 0 deletions(-) create mode 100644 arch/arm/mach-mmp/teton_bga.carch/arm/mach-mmp/Kconfig +7
-0@@ -57,6 +57,13 @@ config MACH_MARVELL_JASPER PXA910-based development board. Since MMP2 is compatible to ARMv6 architecture. +config MACH_TETON_BGA + bool "Marvell's PXA168 Teton BGA Development Board" + select CPU_PXA168 + help + Say 'Y' here if you want to support the Marvell PXA168-based + Teton BGA Development Board. + endmenu config CPU_PXA168arch/arm/mach-mmp/Makefile +1
-0@@ -17,3 +17,4 @@ obj-$(CONFIG_MACH_TAVOREVB) += tavorevb.o obj-$(CONFIG_MACH_TTC_DKB) += ttc_dkb.o obj-$(CONFIG_MACH_FLINT) += flint.o obj-$(CONFIG_MACH_MARVELL_JASPER) += jasper.o +obj-$(CONFIG_MACH_TETON_BGA) += teton_bga.o(quoted diff) +0
-0
b/arch/arm/mach-mmp/teton_bga.cnew file mode 100644 index 0000000..014cc37arch/arm/mach-mmp/teton_bga.c line 4
Quoted 4 lines
arch/arm/mach-mmp/teton_bga.c new file +4
-0@@ -0,0 +1,47 @@ +/* +* linux/arch/arm/mach-mmp/teton_bga.c +* +* Support for the Marvell PXA168 Teton BGA Development Platform. Authoring information of this file are missing. Also,
MAINTAINERSentry is missing.Quoted 8 lines
arch/arm/mach-mmp/teton_bga.c new file +4
-0+* +* This code is based on aspenite.c +* +* This program is free software; you can redistribute it and/or modify + * it under the terms of the GNU General Public License version 2 as + * publishhed by the Free Software Foundation.
+ */arch/arm/mach-mmp/teton_bga.c new file +1
-0+arch/arm/mach-mmp/teton_bga.c line 22
Quoted 10 lines
arch/arm/mach-mmp/teton_bga.c new file +10
-0+#include <linux/init.h> +#include <linux/kernel.h> +#include <linux/platform_device.h> + +#include <asm/mach-types.h> +#include <asm/mach/arch.h> +#include <mach/addr-map.h> +#include <mach/mfp-pxa168.h> +#include <mach/pxa168.h> +#include <mach/gpio.h> use ... #include <
linux/gpio.h>Quoted 5 lines
arch/arm/mach-mmp/teton_bga.c new file +5
-0+ +#include "common.h" + +static unsigned long teton_bga_pin_config[]__initdata = { +/* UART1 */ arch/arm/mach-mmp/teton_bga.c line 37
Quoted 10 lines
arch/arm/mach-mmp/teton_bga.c new file +10
-0+GPIO107_UART1_TXD , + GPIO108_UART1_RXD, +}; + +static void __init teton_bga_init (void ) +{ +mfp_config (ARRAY_AND_SIZE (teton_bga_pin_config)); + +/* on-chip devices */ +pxa168_add_uart (1 );Don't we have enum for these magic numbers on pxa168 ?
Quoted 12 lines
arch/arm/mach-mmp/teton_bga.c line 47
Quoted 10 lines
arch/arm/mach-mmp/teton_bga.c new file +10
-0+} + +MACHINE_START (TETON_BGA ,"PXA168-based Teton BGA Development Platform" ) + .phys_io = APB_PHYS_BASE, + .io_pg_offst = (APB_VIRT_BASE >> 18) & 0xfffc, + .map_io = mmp_map_io, + .init_irq = pxa168_init_irq, + .timer = &pxa168_timer, + .init_machine = teton_bga_init, +MACHINE_END Cheers
Quoted 2 lines
I am assuming you mean the magic number for .io_pg_offst:
.io_pg_offst = (APB_VIRT_BASE>> 18) &0xfffc,
Nope, sorry, I meant this:
+ pxa168_add_uart(1);
The (1) seems weird, but whatever. I don't have any pxa168 device.
Quoted 5 lines
It seems all of the other platforms in
arch/armare configuring it this way. Do you really want me to change this?Regards,
-- Mark
Re: [PATCH 1/3] ARM: pxa168: added support for Teton BGA platform
Quoted 110 lines · Marek Vasut
Dne ?t 9. z??? 2010 01:42:36 Mark F. Brown napsal(a):
Quoted 109 lines · Marek Vasut
Quoted 107 lines
Dne St 8. z??? 2010 04:56:45 Mark F. Brown napsal(a):
---------------------------
Description is missing here
---------------------------Quoted 42 lines
Signed-off-by Mark F. Brown <[email protected]>---
?arch/arm/mach-mmp/Kconfig ? ? | ? ?7 ++++++ ?arch/arm/mach-mmp/Makefile ? ?| ? ?1 + ?arch/arm/mach-mmp/teton_bga.c | ? 47+++++++++++++++++++++++++++++++++++++++++ 3 files changed, 55 insertions(+), 0 deletions(-)
?create mode 100644arch/arm/mach-mmp/teton_bga.carch/arm/mach-mmp/Kconfig +0
-0@@ -57,6 +57,13 @@ config MACH_MARVELL_JASPER? ? ? ? PXA910-based development board. Since MMP2 is compatible to ? ? ? ? ARMv6 architecture.
arch/arm/mach-mmp/Kconfig +7
-0+config MACH_TETON_BGA + ? ? bool "Marvell's PXA168 Teton BGA Development Board" + ? ? select CPU_PXA168 + ? ? help + ? ? ? Say 'Y' here if you want to support the Marvell PXA168-based + ? ? ? Teton BGA Development Board. +?endmenu
?config
CPU_PXA168arch/arm/mach-mmp/Makefile +0
-0@@ -17,3 +17,4 @@ obj-$(CONFIG_MACH_TAVOREVB) += tavorevb.o?obj-$(CONFIG_MACH_TTC_DKB) ? += ttc_dkb.o
?obj-$(CONFIG_MACH_FLINT) ? ? += flint.o
?obj-$(CONFIG_MACH_MARVELL_JASPER) += jasper.oarch/arm/mach-mmp/Makefile +1
-0+obj-$(CONFIG_MACH_TETON_BGA) += teton_bga.o(quoted diff) +0
-0
b/arch/arm/mach-mmp/teton_bga.cnew file mode 100644 index 0000000..014cc37arch/arm/mach-mmp/teton_bga.c line 4
Quoted 4 lines
arch/arm/mach-mmp/teton_bga.c new file +4
-0@@ -0,0 +1,47 @@ +/* +* ?linux/arch/arm/mach-mmp/teton_bga.c +* +* ?Support for the Marvell PXA168 Teton BGA Development Platform. Authoring information of this file are missing. Also,
MAINTAINERSentry is missing.Quoted 8 lines
arch/arm/mach-mmp/teton_bga.c new file +4
-0+* +* ?This code is based on aspenite.c +* +* ?This program is free software; you can redistribute it and/or modify + * ?it under the terms of the GNU General Public License version 2 as + * ?publishhed by the Free Software Foundation.
+ */arch/arm/mach-mmp/teton_bga.c new file +1
-0+arch/arm/mach-mmp/teton_bga.c line 22
Quoted 10 lines
arch/arm/mach-mmp/teton_bga.c new file +10
-0+#include <linux/init.h> +#include <linux/kernel.h> +#include <linux/platform_device.h> + +#include <asm/mach-types.h> +#include <asm/mach/arch.h> +#include <mach/addr-map.h> +#include <mach/mfp-pxa168.h> +#include <mach/pxa168.h> +#include <mach/gpio.h> use ... #include <
linux/gpio.h>Quoted 5 lines
arch/arm/mach-mmp/teton_bga.c new file +5
-0+ +#include "common.h" + +static unsigned long teton_bga_pin_config[]__initdata = { + ? ? /* UART1 */arch/arm/mach-mmp/teton_bga.c
Quoted 10 lines
arch/arm/mach-mmp/teton_bga.c new file +10
-0+ ? ? GPIO107_UART1_TXD, + ? ? GPIO108_UART1_RXD, +}; + +static void __init teton_bga_init (void ) +{ + ? ? mfp_config(ARRAY_AND_SIZE(teton_bga_pin_config)); + + ? ? /* on-chip devices */ + ? ? pxa168_add_uart(1);Don't we have enum for these magic numbers on pxa168 ?
arch/arm/mach-mmp/teton_bga.c
Quoted 10 lines
arch/arm/mach-mmp/teton_bga.c new file +10
-0+} + +MACHINE_START(TETON_BGA, "PXA168-based Teton BGA Development Platform") + ? ? .phys_io ? ? ? ?= APB_PHYS_BASE, + ? ? .io_pg_offst ? ?= (APB_VIRT_BASE >> 18) & 0xfffc, + ? ? .map_io ? ? ? ? = mmp_map_io, + ? ? .init_irq ? ? ? = pxa168_init_irq, + ? ? .timer ? ? ? ? ?= &pxa168_timer, + ? ? .init_machine ? = teton_bga_init, +MACHINE_ENDCheers
Quoted 9 lines
Quoted 2 lines
I am assuming you mean the magic number for .io_pg_offst:
?.io_pg_offst ? ?= (APB_VIRT_BASE>> 18) &0xfffc,Nope, sorry, I meant this:
+ ? ?
pxa168_add_uart(1);The (1) seems weird, but whatever. I don't have any pxa168 device.
Actually the parameter means the device ID, so pxa168_add_uart(1) means to add UART1 on pxa168, so it's quite straight-forward.
Re: [PATCH 1/3] ARM: pxa168: added support for Teton BGA platform
Dne ?t 9. z??? 2010 09:39:15 Eric Miao napsal(a):
Quoted 114 lines · Marek Vasut
Quoted 113 lines
Dne ?t 9. z??? 2010 01:42:36 Mark F. Brown napsal(a):
Quoted 111 lines · Marek Vasut
Quoted 95 lines
Dne St 8. z??? 2010 04:56:45 Mark F. Brown napsal(a):
---------------------------
Description is missing here
---------------------------Quoted 42 lines
Signed-off-by Mark F. Brown <[email protected]>--- arch/arm/mach-mmp/Kconfig | 7 ++++++ arch/arm/mach-mmp/Makefile | 1 + arch/arm/mach-mmp/teton_bga.c | 47 +++++++++++++++++++++++++++++++++++++++++ 3 files changed, 55 insertions(+), 0 deletions(-) create mode 100644 arch/arm/mach-mmp/teton_bga.carch/arm/mach-mmp/Kconfig +7
-0@@ -57,6 +57,13 @@ config MACH_MARVELL_JASPER PXA910-based development board. Since MMP2 is compatible to ARMv6 architecture. +config MACH_TETON_BGA + bool "Marvell's PXA168 Teton BGA Development Board" + select CPU_PXA168 + help + Say 'Y' here if you want to support the Marvell PXA168-based + Teton BGA Development Board. + endmenu config CPU_PXA168arch/arm/mach-mmp/Makefile +1
-0@@ -17,3 +17,4 @@ obj-$(CONFIG_MACH_TAVOREVB) += tavorevb.o obj-$(CONFIG_MACH_TTC_DKB) += ttc_dkb.o obj-$(CONFIG_MACH_FLINT) += flint.o obj-$(CONFIG_MACH_MARVELL_JASPER) += jasper.o +obj-$(CONFIG_MACH_TETON_BGA) += teton_bga.o(quoted diff) +0
-0
b/arch/arm/mach-mmp/teton_bga.cnew file mode 100644 index 0000000..014cc37arch/arm/mach-mmp/teton_bga.c line 4
Quoted 4 lines
arch/arm/mach-mmp/teton_bga.c new file +4
-0@@ -0,0 +1,47 @@ +/* +* linux/arch/arm/mach-mmp/teton_bga.c +* +* Support for the Marvell PXA168 Teton BGA Development Platform. Authoring information of this file are missing. Also,
MAINTAINERSentry is missing.Quoted 8 lines
arch/arm/mach-mmp/teton_bga.c new file +4
-0+* +* This code is based on aspenite.c +* +* This program is free software; you can redistribute it and/or modify + * it under the terms of the GNU General Public License version 2 as + * publishhed by the Free Software Foundation.
+ */arch/arm/mach-mmp/teton_bga.c new file +1
-0+arch/arm/mach-mmp/teton_bga.c line 22
Quoted 10 lines
arch/arm/mach-mmp/teton_bga.c new file +10
-0+#include <linux/init.h> +#include <linux/kernel.h> +#include <linux/platform_device.h> + +#include <asm/mach-types.h> +#include <asm/mach/arch.h> +#include <mach/addr-map.h> +#include <mach/mfp-pxa168.h> +#include <mach/pxa168.h> +#include <mach/gpio.h> use ... #include <
linux/gpio.h>Quoted 5 lines
arch/arm/mach-mmp/teton_bga.c new file +5
-0+ +#include "common.h" + +static unsigned long teton_bga_pin_config[]__initdata = { +/* UART1 */ arch/arm/mach-mmp/teton_bga.c line 37
Quoted 10 lines
arch/arm/mach-mmp/teton_bga.c new file +10
-0+GPIO107_UART1_TXD , + GPIO108_UART1_RXD, +}; + +static void __init teton_bga_init (void ) +{ +mfp_config (ARRAY_AND_SIZE (teton_bga_pin_config)); + +/* on-chip devices */ +pxa168_add_uart (1 );Don't we have enum for these magic numbers on pxa168 ?
Quoted 12 lines
arch/arm/mach-mmp/teton_bga.c line 47
Quoted 10 lines
arch/arm/mach-mmp/teton_bga.c new file +3
-0+} + +MACHINE_START(TETON_BGA, "PXA168-based Teton BGA DevelopmentPlatform") + .phys_io =
APB_PHYS_BASE,arch/arm/mach-mmp/teton_bga.c new file +6
-0+ .io_pg_offst = (APB_VIRT_BASE >> 18) & 0xfffc, + .map_io = mmp_map_io, + .init_irq = pxa168_init_irq, + .timer = &pxa168_timer, + .init_machine = teton_bga_init, +MACHINE_END Cheers
I am assuming you mean the magic number for .io_pg_offst:
.io_pg_offst = (APB_VIRT_BASE>> 18) &0xfffc,
Quoted 8 lines
Quoted 5 lines
Nope, sorry, I meant this:
+
pxa168_add_uart(1);The (1) seems weird, but whatever. I don't have any pxa168 device.
Actually the parameter means the device ID, so
pxa168_add_uart(1)means to add UART1 on pxa168, so it's quite straight-forward.
Ah ok, sorry about the confusion.
Can we see new version of this patch with my previous comments addressed ?
Thanks, Cheers
PATCH 2/3 ARM: pxa168/teton bga: added keypad support
In reply to Mark F. Brown--- arch/arm/mach-mmp/teton_bga.c | 24 ++++++++++++++++++++++++ 1 files changed, 24 insertions(+), 0 deletions(-)
arch/arm/mach-mmp/teton_bga.c +24 -0
@@ -20,6 +20,8 @@#include <mach/mfp-pxa168.h> #include <mach/pxa168.h> #include <mach/gpio.h> +#include <linux/input.h> +#include <plat/pxa27x_keypad.h> #include "common.h"
@@ -27,6 +29,27 @@ static unsigned long teton_bga_pin_config[] __initdata = {/* UART1 */ GPIO107_UART1_TXD ,GPIO108_UART1_RXD , + +/* Keypad */ +GPIO109_KP_MKIN1 , +GPIO110_KP_MKIN0 , +GPIO111_KP_MKOUT7 , + GPIO112_KP_MKOUT6, +}; + +static unsigned int teton_bga_matrix_key_map[] = { +KEY (0 ,6 ,KEY_ESC ), +KEY (0 ,7 ,KEY_ENTER ), +KEY (1 ,6 ,KEY_LEFT ), +KEY (1 ,7 ,KEY_RIGHT ), +}; + +static struct pxa27x_keypad_platform_data teton_bga_keypad_info__initdata = { + .matrix_key_rows =2 , + .matrix_key_cols =8 , + .matrix_key_map = teton_bga_matrix_key_map, + .matrix_key_map_size =ARRAY_SIZE (teton_bga_matrix_key_map), + .debounce_interval =30 , };static void __init teton_bga_init (void )
@@ -35,6 +58,7 @@ static void __init teton_bga_init(void)/* on-chip devices */ pxa168_add_uart (1 ); +pxa168_add_keypad (&teton_bga_keypad_info); }MACHINE_START (TETON_BGA ,"PXA168-based Teton BGA Development Platform" )
Signature · 1 line
1.7.0.4
PATCH 3/3 ARM: pxa168/teton bga: add board support for i2c and rtc-ds1337
In reply to Mark F. Brown--- arch/arm/mach-mmp/teton_bga.c | 10 ++++++++++ 1 files changed, 10 insertions(+), 0 deletions(-)
arch/arm/mach-mmp/teton_bga.c +10 -0
@@ -22,6 +22,7 @@#include <mach/gpio.h> #include <linux/input.h> #include <plat/pxa27x_keypad.h> +#include <linux/i2c.h> #include "common.h"
@@ -35,6 +36,10 @@ static unsigned long teton_bga_pin_config[] __initdata = {GPIO110_KP_MKIN0 ,GPIO111_KP_MKOUT7 ,GPIO112_KP_MKOUT6 , + +/* i2c bus */ +GPIO105_CI2C_SDA , + GPIO106_CI2C_SCL, }; static unsigned int teton_bga_matrix_key_map[] = {
@@ -52,6 +57,10 @@ static struct pxa27x_keypad_platform_data teton_bga_keypad_info __initdata = { .debounce_interval = 30, }; +static struct i2c_board_info teton_bga_i2c_info[]__initdata = { + {I2C_BOARD_INFO ("ds1337" ,0x68 ), }, +}; +static void __init teton_bga_init (void ) {mfp_config (ARRAY_AND_SIZE (teton_bga_pin_config));
@@ -59,6 +68,7 @@ static void __init teton_bga_init(void)/* on-chip devices */ pxa168_add_uart (1 );pxa168_add_keypad (&teton_bga_keypad_info); +pxa168_add_twsi (0 ,NULL ,ARRAY_AND_SIZE (teton_bga_i2c_info)); }MACHINE_START (TETON_BGA ,"PXA168-based Teton BGA Development Platform" )
Signature · 1 line
1.7.0.4
Re: [PATCH 3/3] ARM: pxa168/teton bga: add board support for i2c and rtc-ds1337
Quoted 29 lines · Mark F. Brown
Signed-off-by Mark F. Brown <[email protected]>---
?arch/arm/mach-mmp/teton_bga.c | ? 10 ++++++++++ ?1 files changed, 10 insertions(+), 0 deletions(-)arch/arm/mach-mmp/teton_bga.c +0
-0@@ -22,6 +22,7 @@?#include <
mach/gpio.h>
?#include <linux/input.h>
?#include <plat/pxa27x_keypad.h>
+#include <linux/i2c.h>?#include "
common.h"arch/arm/mach-mmp/teton_bga.c +4
-0@@ -35,6 +36,10 @@ static unsigned long teton_bga_pin_config[] __initdata = { ? ? ? ?GPIO110_KP_MKIN0, ? ? ? ?GPIO111_KP_MKOUT7, ? ? ? ?GPIO112_KP_MKOUT6, + + ? ? ? /* i2c bus */ + ? ? ? GPIO105_CI2C_SDA, + ? ? ? GPIO106_CI2C_SCL, ?}; ?static unsigned int teton_bga_matrix_key_map[] = {
arch/arm/mach-mmp/teton_bga.c static struct pxa27x_keypad_platform_data teton_bga_keypad_info __initdata = { · line 63
Quoted 7 lines
arch/arm/mach-mmp/teton_bga.c +4
-0@@ -52,6 +57,10 @@ static struct pxa27x_keypad_platform_data teton_bga_keypad_info __initdata = { ? ? ? ?.debounce_interval ? ? ?= 30, ?}; +static struct i2c_board_info teton_bga_i2c_info[]__initdata = { + ? ? ? { I2C_BOARD_INFO("ds1337", 0x68), }, +}; +
I don't have the schematic of teton. But RTC chips should always has an irq pin. Is it also connected in your platform?
Quoted 20 lines
arch/arm/mach-mmp/teton_bga.c +0
-0?static void __init teton_bga_init(void) ?{ ? ? ? ?mfp_config(ARRAY_AND_SIZE(teton_bga_pin_config));@@ -59,6 +68,7 @@ static void __init teton_bga_init(void)? ? ? ?/* on-chip devices */
? ? ? ?pxa168_add_uart(1);
? ? ? ?pxa168_add_keypad(&teton_bga_keypad_info);
+ ? ? ?pxa168_add_twsi(0, NULL, ARRAY_AND_SIZE(teton_bga_i2c_info)); ?}?MACHINE_START(TETON_BGA, "PXA168-based Teton BGA Development Platform") --
1.7.0.4--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo at vger.kernel.org
More majordomo info at ?http://vger.kernel.org/majordomo-info.html Please read the FAQ at ?http://www.tux.org/lkml/
Re: [PATCH 3/3] ARM: pxa168/teton bga: add board support for i2c and rtc-ds1337
Dne St 8. z??? 2010 07:34:24 Haojian Zhuang napsal(a):
Quoted 1 line
On Wed, Sep 8, 2010 at 10:56 AM, Mark F. Brown <[email protected]>
Quoted 32 lines · wrote:
Quoted 32 lines
Signed-off-by Mark F. Brown <[email protected]>--- arch/arm/mach-mmp/teton_bga.c | 10 ++++++++++ 1 files changed, 10 insertions(+), 0 deletions(-)(quoted diff) +0
-0
b/arch/arm/mach-mmp/teton_bga.cindex bbeda5c..8e5801c 100644arch/arm/mach-mmp/teton_bga.c +5
-0@@ -22,6 +22,7 @@#include <mach/gpio.h> #include <linux/input.h> #include <plat/pxa27x_keypad.h> +#include <linux/i2c.h> #include "common.h" @@ -35,6 +36,10 @@ static unsigned long teton_bga_pin_config[] __initdata = {GPIO110_KP_MKIN0 ,GPIO111_KP_MKOUT7 ,GPIO112_KP_MKOUT6 , + +/* i2c bus */ +GPIO105_CI2C_SDA , +GPIO106_CI2C_SCL , }; static unsigned int teton_bga_matrix_key_map[] = {@@ -52,6 +57,10 @@ static struct pxa27x_keypad_platform_data teton_bga_keypad_info __initdata = { .debounce_interval = 30, };
Quoted 7 lines
arch/arm/mach-mmp/teton_bga.c static struct pxa27x_keypad_platform_data teton_bga_keypad_info __initdata = { · line 63
Quoted 4 lines
arch/arm/mach-mmp/teton_bga.c +4
-0+static struct i2c_board_info teton_bga_i2c_info[]__initdata = { + {I2C_BOARD_INFO ("ds1337" ,0x68 ), }, +}; +I don't have the schematic of teton. But RTC chips should always has an irq pin. Is it also connected in your platform?
I think this one doesn't, but I haven't checked.
Cheers
Quoted 25 lines
Quoted 15 lines
arch/arm/mach-mmp/teton_bga.c +1
-1static void __init teton_bga_init (void ) {mfp_config (ARRAY_AND_SIZE (teton_bga_pin_config));@@ -59,6 +68,7 @@ static void __init teton_bga_init(void)/* on-chip devices */ pxa168_add_uart (1 );pxa168_add_keypad (&teton_bga_keypad_info); +pxa168_add_twsi (0 ,NULL ,ARRAY_AND_SIZE (teton_bga_i2c_info)); }MACHINE_START (TETON_BGA ,"PXA168-based Teton BGA Development Platform" ) --1.7.0.4
Quoted 5 lines
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo at vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel at lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
A message that is not in the archive (sent off-list or not yet received): [email protected]
PATCH 3/3 ARM: pxa168/teton bga: add board support for i2c and rtc-ds1337
Dne St 8. z??? 2010 19:05:02 Mark F. Brown napsal(a):
Quoted 74 lines · Marek Vasut
Quoted 44 lines
Dne St 8. z??? 2010 07:34:24 Haojian Zhuang napsal(a):
Quoted 1 line
On Wed, Sep 8, 2010 at 10:56 AM, Mark F. Brown <[email protected]>
Quoted 32 lines · wrote:
Quoted 32 lines
Signed-off-by Mark F. Brown <[email protected]>--- arch/arm/mach-mmp/teton_bga.c | 10 ++++++++++ 1 files changed, 10 insertions(+), 0 deletions(-)(quoted diff) +0
-0
b/arch/arm/mach-mmp/teton_bga.cindex bbeda5c..8e5801c 100644arch/arm/mach-mmp/teton_bga.c +5
-0@@ -22,6 +22,7 @@#include <mach/gpio.h> #include <linux/input.h> #include <plat/pxa27x_keypad.h> +#include <linux/i2c.h> #include "common.h" @@ -35,6 +36,10 @@ static unsigned long teton_bga_pin_config[]__initdata = {GPIO110_KP_MKIN0 ,GPIO111_KP_MKOUT7 ,GPIO112_KP_MKOUT6 , + +/* i2c bus */ +GPIO105_CI2C_SDA , +GPIO106_CI2C_SCL , }; static unsigned int teton_bga_matrix_key_map[] = {@@ -52,6 +57,10 @@ static struct pxa27x_keypad_platform_data teton_bga_keypad_info __initdata = { .debounce_interval = 30, };Quoted 7 lines
arch/arm/mach-mmp/teton_bga.c static struct pxa27x_keypad_platform_data teton_bga_keypad_info __initdata = { · line 63
Quoted 4 lines
arch/arm/mach-mmp/teton_bga.c +4
-0+static struct i2c_board_info teton_bga_i2c_info[]__initdata = { + {I2C_BOARD_INFO ("ds1337" ,0x68 ), }, +}; +I don't have the schematic of teton. But RTC chips should always has an irq pin. Is it also connected in your platform?
Quoted 28 lines
I think this one doesn't, but I haven't checked.
Cheers
Quoted 24 lines
Quoted 14 lines
arch/arm/mach-mmp/teton_bga.c +1
-0static void __init teton_bga_init (void ) {mfp_config (ARRAY_AND_SIZE (teton_bga_pin_config));@@ -59,6 +68,7 @@ static void __init teton_bga_init(void)/* on-chip devices */ pxa168_add_uart (1 );pxa168_add_keypad (&teton_bga_keypad_info); +pxa168_add_twsi (0 ,NULL ,ARRAY_AND_SIZE (teton_bga_i2c_info)); } MACHINE_START(TETON_BGA, "PXA168-based Teton BGA DevelopmentPlatform") --
1.7.0.4Quoted 5 lines
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo at vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel at lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Quoted 4 lines
It actually does have an alarm pin and it is connected as well. I did not include it, because I have not tested the alarm functionality yet. I was going to add it in a later patch. I did test the hardware clock to system clock syncing.
Fix the CC please. And be careful not to screw this up again next time.
Please add the alarm pin too. Thanks
Cheers
Quoted 3 lines
Regards,
-- Mark