Skip to contentSkip to conversation

Bluetooth: Don't clear the blacklist when closing the HCI device

PATCH In review [email protected] 3 participants 3 messages Sep 9, 2010 – Sep 27, 2010

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Bluetooth: Don't clear the blacklist when closing the HCI device

From: Johan Hedberg <[email protected]>

Clearing the blacklist in hci_dev_do_close() would mean that user space needs to do extra work to re-block devices after a DEVDOWN-DEVUP cycle. This patch removes the clearing of the blacklist in this case and thereby saves user space from the extra work.

---
 net/bluetooth/hci_core.c |    1 -
 1 files changed, 0 insertions(+), 1 deletions(-)
net/bluetooth/hci_core.c +0 -1
index c52f091..bc2a052 100644
@@ -562,7 +562,6 @@ static int hci_dev_do_close(struct hci_dev *hdev)
 	hci_dev_lock_bh(hdev);
 	inquiry_cache_flush(hdev);
 	hci_conn_hash_flush(hdev);
-	hci_blacklist_clear(hdev);
 	hci_dev_unlock_bh(hdev);
 
 	hci_notify(hdev, HCI_DEV_DOWN);
Signature · 1 line
1.7.0.4
Acked-by on v1 1/1
#1 lore raw
Quoted 8 lines · On Thu, Sep 09, 2010 at 09:32:39AM +0200, ext [email protected] wrote:

From: Johan Hedberg <[email protected]>

Clearing the blacklist in hci_dev_do_close() would mean that user space needs to do extra work to re-block devices after a DEVDOWN-DEVUP cycle. This patch removes the clearing of the blacklist in this case and thereby saves user space from the extra work.

Quoted 23 lines
---
 net/bluetooth/hci_core.c |    1 -
 1 files changed, 0 insertions(+), 1 deletions(-)
net/bluetooth/hci_core.c +0 -1
index c52f091..bc2a052 100644
@@ -562,7 +562,6 @@ static int hci_dev_do_close(struct hci_dev *hdev)
 	hci_dev_lock_bh(hdev);
 	inquiry_cache_flush(hdev);
 	hci_conn_hash_flush(hdev);
-	hci_blacklist_clear(hdev);
 	hci_dev_unlock_bh(hdev);
 
 	hci_notify(hdev, HCI_DEV_DOWN);
Signature · 6 lines
1.7.0.4

--
To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
#2 lore raw

Hi Johan,

Quoted 11 lines · Ville Tervo
Quoted 8 lines · On Thu, Sep 09, 2010 at 09:32:39AM +0200, ext [email protected] wrote:

From: Johan Hedberg <[email protected]>

Clearing the blacklist in hci_dev_do_close() would mean that user space needs to do extra work to re-block devices after a DEVDOWN-DEVUP cycle. This patch removes the clearing of the blacklist in this case and thereby saves user space from the extra work.

Patch has been applied to my bluetooth-next-2.6 tree to later merge in wireless-next-2.6

Signature · 2 lines
Gustavo F. Padovan
ProFUSION embedded systems - http://profusion.mobi