Skip to contentSkip to conversation

ACPI: Tie ACPI backlight devices to PCI devices if possible

PATCH In review Matthew Garrett 3 participants 3 messages Sep 9, 2010 – Sep 29, 2010 ACPI

lore
Share & tools
lore

Matthew Garrett

author
#0 lore raw

PATCH 1/1 ACPI: Tie ACPI backlight devices to PCI devices if possible

Dual-GPU machines may provide more than one ACPI backlight interface. Tie the backlight device to the GPU in order to allow userspace to identify the correct interface.

Signed-off-by Matthew Garrett <[email protected]>
---
 drivers/acpi/video.c |   15 ++++++++++++++-
 1 files changed, 14 insertions(+), 1 deletions(-)
drivers/acpi/video.c +14 -1
index fbae6f5..8c45980 100644
@@ -950,6 +950,9 @@ static void acpi_video_device_find_cap(struct acpi_video_device *device)
 
 	if (acpi_video_backlight_support()) {
 		struct backlight_properties props;
+		struct pci_dev *pdev;
+		acpi_handle acpi_parent;
+		struct device *parent = NULL;
 		int result;
 		static int count = 0;
 		char *name;

@@ -962,10 +965,20 @@ static void acpi_video_device_find_cap(struct acpi_video_device *device)
 			return;
 		count++;
 
+		acpi_get_parent(device->dev->handle, &acpi_parent);
+
+		pdev = acpi_get_pci_dev(acpi_parent);
+		if (pdev) {
+			parent = &pdev->dev;
+			pci_dev_put(pdev);
+		}
+
 		memset(&props, 0, sizeof(struct backlight_properties));
 		props.type = BACKLIGHT_FIRMWARE;
 		props.max_brightness = device->brightness->count - 3;
-		device->backlight = backlight_device_register(name, NULL, device,
+		device->backlight = backlight_device_register(name,
+							      parent,
+							      device,
 							      &acpi_backlight_ops,
 							      &props);
 		kfree(name);
Signature · 1 line
1.7.2.1
reviewer
#1 lore raw

-ENOAPPLY

what tree is this patch on top of?

thanks,
Len Brown, Intel Open Source Technology Center

#2 lore raw
Quoted 3 lines · Len Brown

-ENOAPPLY

what tree is this patch on top of?

It requires the backlight rework which still hasn't been merged.

Signature · 1 line
Matthew Garrett | [email protected]