Skip to contentSkip to conversation

ntlmv2 within ntlmssp - enable and sign using crypto apis

PATCH In review [email protected] 2 participants 4 messages Sep 9, 2010 – Sep 13, 2010 2 messages not in the archive

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

cover ntlmv2 within ntlmssp - enable and sign using crypto apis

Three major functionality changes

Make NTLMv2 as a default authentication mechanism within NTLMSSP

Enable cifs/smb signing

Use Crypto sync hash APIs instead of cifs crypto functions to genereate various hashes such as arc4/rc4, md5, and hmac-md5 used during authentication and smb/cifs signature generation

A message that is not in the archive (sent off-list or not yet received): 1284056215-959-1-git-send-email-shirishpargaonkar-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org

#2 lore raw
Quoted 2 lines · On Thu, 9 Sep 2010 13:16:55 -0500 shirishpargaonkar-Re5JQEeQqe8AvxtiuMwx3w@pub…

Three major functionality changes

Maybe this should be 3 separate patchsets then? It would be best if these major functionality changes were bisectable. Also, these patches mix a lot of trivial cleanup code in with the deltas that actually make the major changes. Those should be separated.

IOW, more patches that are smaller and targeted would be ideal.

Quoted 9 lines

Make NTLMv2 as a default authentication mechanism within NTLMSSP

Enable cifs/smb signing

Use Crypto sync hash APIs instead of cifs crypto functions to genereate various hashes such as arc4/rc4, md5, and hmac-md5 used during authentication and smb/cifs signature generation

It seems like this set should be a net reduction in code or at least something closer to 0. This set should not be merged without an accompanying patch to remove the unused crypto code after the conversion to the kernel crypto APIs.

Signature · 1 line
Jeff Layton <[email protected]>

A message that is not in the archive (sent off-list or not yet received): 20100912202701.1cd7d8bf-4QP7MXygkU+dMjc06nkz3ljfA9RmPOcC@public.gmane.org

#4 lore raw
Quoted 23 lines · Jeff Layton
Quoted 2 lines · On Thu,  9 Sep 2010 13:16:55 -0500 shirishpargaonkar-Re5JQEeQqe8AvxtiuMwx3w@pub…

Three major functionality changes

Maybe this should be 3 separate patchsets then? It would be best if these major functionality changes were bisectable. Also, these patches mix a lot of trivial cleanup code in with the deltas that actually make the major changes. Those should be separated.

IOW, more patches that are smaller and targeted would be ideal.

Quoted 9 lines

Make NTLMv2 as a default authentication mechanism within NTLMSSP

Enable cifs/smb signing

Use Crypto sync hash APIs instead of cifs crypto functions to genereate various hashes such as arc4/rc4, md5, and hmac-md5 used during authentication and smb/cifs signature generation

Quoted 4 lines

It seems like this set should be a net reduction in code or at least something closer to 0. This set should not be merged without an accompanying patch to remove the unused crypto code after the conversion to the kernel crypto APIs.

I really do not have time to go through the code to remove the unused cifs crypto code. It is not trivial to remove those functions because they still get used for ntlm authentication.
I am definitely not planning to attempt the code removal till end of the year.

Quoted 8 lines

--
Jeff Layton <[email protected]> --
To unsubscribe from this list: send the line "unsubscribe linux-cifs" in the body of a message to [email protected] More majordomo info at  http://vger.kernel.org/majordomo-info.html

#5 lore raw
In reply to a message not in the archive
Quoted 6 lines · Jeff Layton
Quoted 2 lines · On Thu,  9 Sep 2010 13:16:55 -0500 shirishpargaonkar-Re5JQEeQqe8AvxtiuMwx3w@pub…

Three major functionality changes

Quoted 6 lines

Maybe this should be 3 separate patchsets then? It would be best if these major functionality changes were bisectable. Also, these patches mix a lot of trivial cleanup code in with the deltas that actually make the major changes. Those should be separated.

IOW, more patches that are smaller and targeted would be ideal.

It is probably easier to separate ntlmv2/ntlmssp authentication patch but for signing, we need rc4/arcfour code which does not exist in cifs and so we have to use linux kernel apis and lot of data structures that get introduced in TCP_Server_Info structure. Change from name mac_key to session key would gate some of the changes in auth and signing code. So I would really prefer to keep the patchset intact.

Quoted 23 lines
Quoted 10 lines

Make NTLMv2 as a default authentication mechanism within NTLMSSP

Enable cifs/smb signing

Use Crypto sync hash APIs instead of cifs crypto functions to genereate various hashes such as arc4/rc4, md5, and hmac-md5 used during authentication and smb/cifs signature generation

It seems like this set should be a net reduction in code or at least something closer to 0. This set should not be merged without an accompanying patch to remove the unused crypto code after the conversion to the kernel crypto APIs.

--
Jeff Layton <[email protected]> --
To unsubscribe from this list: send the line "unsubscribe linux-cifs" in the body of a message to [email protected] More majordomo info at  http://vger.kernel.org/majordomo-info.html