Skip to contentSkip to conversation

drm/radeon/kms: don't enable underscan with interlaced modes

PATCH In review Alex Deucher 2 participants 7 messages Sep 10, 2010 – Sep 26, 2010

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 drm/radeon/kms: don't enable underscan with interlaced modes

They aren't compatible.

---
 drivers/gpu/drm/radeon/radeon_display.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)
drivers/gpu/drm/radeon/radeon_display.c +1 -0
index 8c987c9..127a395 100644
@@ -1151,6 +1151,7 @@ bool radeon_crtc_scaling_mode_fixup(struct drm_crtc *crtc,
 
 			/* fix up for overscan on hdmi */
 			if (ASIC_IS_AVIVO(rdev) &&
+			    (!(mode->flags & DRM_MODE_FLAG_INTERLACE)) &&
 			    ((radeon_encoder->underscan_type == UNDERSCAN_ON) ||
 			     ((radeon_encoder->underscan_type == UNDERSCAN_AUTO) &&
 			      drm_detect_hdmi_monitor(radeon_connector->edid) &&
Signature · 1 line
1.7.1.1
#1 lore raw

On 10.09.2010 09:19, wrote Alex Deucher:

Quoted 1 line

They aren't compatible.

Hm, ok. Is this supposed to be quick fix or is there any chance to get proper underscan for interlaced modes?

Secondly, have you had a chance to look at my register dumps? Any clues as to why the Xserver prunes interlaced modes only with KMS?

Thanks
Marius

#2 lore raw

2010/9/10 Marius Gröger <[email protected]>:

Quoted 7 lines

On 10.09.2010 09:19, wrote Alex Deucher:

Quoted 2 lines

They aren't compatible.

Hm, ok. Is this supposed to be quick fix or is there any chance to get proper underscan for interlaced modes?

The scaler doesn't appear to work with interlaced modes as you've noticed; I don't off hand know whether it can be made to or not. Unfortunately, I won't have time to dig into this more for a while.

Quoted 2 lines

Secondly, have you had a chance to look at my register dumps? Any clues as to why the Xserver prunes interlaced modes only with KMS?

If this commit (http://cgit.freedesktop.org/xorg/driver/xf86-video-ati/commit/?id=b90cb61ccb0f4f80e0627141f223354a9371d47d)
doesn't help, then presumably the problem is due to some change in the
xserver.

The only difference in the register dump was that the scaler was enabled for underscan in the kms one.

Alex

Quoted 5 lines

Thanks
Marius

#3 lore raw
Quoted 3 lines · On 10.09.2010 17:20 Alex Deucher wrote:

The scaler doesn't appear to work with interlaced modes as you've noticed; I don't off hand know whether it can be made to or not. Unfortunately, I won't have time to dig into this more for a while.

Is there public documentation available wrt this matter? www.x.org/docs/AMD/ appears to focus on 3D stuff primarily...

Regards,
Marius

#4 lore raw

2010/9/21 Marius Gröger <[email protected]>:

Quoted 9 lines · On 10.09.2010 17:20 Alex Deucher wrote:
Quoted 4 lines

The scaler doesn't appear to work with interlaced modes as you've noticed; I don't off hand know whether it can be made to or not. Unfortunately, I won't have time to dig into this more for a while.

Is there public documentation available wrt this matter? www.x.org/docs/AMD/ appears to focus on 3D stuff primarily...

Not at the moment, however, you could implement underscan using the 3D engine to do the scaling rather than the display scalers. I think you could even do it with randr crtc transforms (which use the 3d engine).

Alex

Quoted 3 lines

Regards,
Marius

#5 lore raw

Am 22.09.2010 06:40, schrieb Alex Deucher:

Quoted 7 lines

2010/9/21 Marius Gröger<[email protected]>:

Quoted 6 lines · On 10.09.2010 17:20 Alex Deucher wrote:
Quoted 4 lines

The scaler doesn't appear to work with interlaced modes as you've noticed; I don't off hand know whether it can be made to or not. Unfortunately, I won't have time to dig into this more for a while.

Quoted 7 lines
Quoted 3 lines

Is there public documentation available wrt this matter? www.x.org/docs/AMD/ appears to focus on 3D stuff primarily...

Not at the moment, however, you could implement underscan using the 3D engine to do the scaling rather than the display scalers. I think you could even do it with randr crtc transforms (which use the 3d engine).

Are you referring to xrandr --transpose? At least for me this seems to be only partially implemented. For example:

xrandr --output HDMI-0 --mode 1920x1080@50i --transform 0.5,0,0,0,0.5,0,0,0,1

This does in fact render the image scaled down by 50%. However,

xrandr --verbose

yields:

HDMI-0 connected 1920x1080+0+0 (0xfd) normal (normal left inverted right x axis y axis) 1600mm x 900mm
...

	Transform:  1.000000 0.000000 0.000000
	            0.000000 1.000000 0.000000
	            0.000000 0.000000 1.000000

Translation doesn't work at all, so it's not a viable workaround.

Sigh. This is all kind of frustrating...

Regards,
Marius

#6 lore raw

2010/9/22 Marius Gröger <[email protected]>:

Quoted 31 lines

Am 22.09.2010 06:40, schrieb Alex Deucher:

Quoted 9 lines

2010/9/21 Marius Gröger<[email protected]>:

Quoted 7 lines · On 10.09.2010 17:20 Alex Deucher wrote:
Quoted 4 lines

The scaler doesn't appear to work with interlaced modes as you've noticed; I don't off hand know whether it can be made to or not. Unfortunately, I won't have time to dig into this more for a while.

Quoted 8 lines
Quoted 4 lines

Is there public documentation available wrt this matter? www.x.org/docs/AMD/
appears to focus on 3D stuff primarily...

Not at the moment, however, you could implement underscan using the 3D engine to do the scaling rather than the display scalers.  I think you could even do it with randr crtc transforms (which use the 3d engine).

Are you referring to xrandr --transpose? At least for me this seems to be only partially implemented. For example:

xrandr --output HDMI-0 --mode 1920x1080@50i --transform 0.5,0,0,0,0.5,0,0,0,1

This does in fact render the image scaled down by 50%. However,

xrandr --verbose

yields:

Quoted 8 lines

HDMI-0 connected 1920x1080+0+0 (0xfd) normal (normal left inverted right x axis y axis) 1600mm x 900mm
...
       Transform:  1.000000 0.000000 0.000000
                   0.000000 1.000000 0.000000
                   0.000000 0.000000 1.000000

Translation doesn't work at all, so it's not a viable workaround.

The transform shader code in the exa composite code probably needs adjusting to deal properly with translation.

Alex

Quoted 6 lines

Sigh. This is all kind of frustrating...

Regards,
Marius