Skip to contentSkip to conversation

: xl: don't leak a lot of memory in forked process in domain_create

PATCH New Gianni Tedesco 1 participant 1 message Sep 10, 2010

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 : xl: don't leak a lot of memory in forked process in domain_create

A goto statement skips over freeing data structures for no good reason. It's not a real issue since the next step is to exit() but this cleans up output of valgrind so that other leaks and errors can be spotted.

tools/libxl/xl_cmdimpl.c +1 -1
diff -r c7c2bc8d6b3a tools/libxl/xl_cmdimpl.c
@@ -1511,7 +1511,7 @@ start:
                 goto error_out;
             }
             ret = domid;
-            goto waitpid_out;
+            goto out;
         }
 
         rc = libxl_ctx_postfork(&ctx);