MAX8998 changes for RTC

PATCH In review Joonyoung Shim 5 participants 5 messages Aug 6, 2010 – Sep 10, 2010

lore

Share & tools

lore

Joonyoung Shim

author

2010-08-06 02:28 UTC #0 lore raw

v3 cover MAX8998 changes for RTC

Hi.

This patchset is to support the RTC provided by the Maxim 8998 chip. For this first, needs i2c interface changes and interrupts support of max8998 mfd driver.

Changes since v1:
- Fix missing braces of 3/3 patch from v1 review.
- The rest is same with v1.

Changes since v2:
- add missing free_irq and rtc_valid_tm on rtc driver of 3/3 patch
- The rest is same with v2.

Joonyoung Shim (3):
mfd: MAX8998: Use struct i2c_client to argument on i2c operation functions
mfd: MAX8998: Add interrupts support
rtc: Add MAX8998 rtc driver

 drivers/mfd/Kconfig                 |    2 +-
 drivers/mfd/Makefile                |    2 +-
 drivers/mfd/max8998-irq.c           |  255 +++++++++++++++++++++++++++++
 drivers/mfd/max8998.c               |   78 +++++++--
 drivers/regulator/max8998.c         |   17 ++-
 drivers/rtc/Kconfig                 |   10 ++
 drivers/rtc/Makefile                |    1 +
 drivers/rtc/rtc-max8998.c           |  300 +++++++++++++++++++++++++++++++++++
 include/linux/mfd/max8998-private.h |  106 +++++++++---
 include/linux/mfd/max8998.h         |   11 +-
 10 files changed, 726 insertions(+), 56 deletions(-)
 create mode 100644 drivers/mfd/max8998-irq.c
 create mode 100644 drivers/rtc/rtc-max8998.c

Joonyoung Shim

2010-08-25 08:55 UTC #1 lore raw

2010/8/6 Joonyoung Shim <[email protected]>:

Quoted 10 lines

Hi.
This patchset is to support the RTC provided by the Maxim 8998 chip. For this first, needs i2c interface changes and interrupts support of max8998 mfd driver.
Changes since v1:
- Fix missing braces of 3/3 patch from v1 review.
- The rest is same with v1.

Quoted 9 lines

Changes since v2:
- add missing free_irq and rtc_valid_tm on rtc driver of 3/3 patch
- The rest is same with v2.
Joonyoung Shim (3):
mfd: MAX8998: Use struct i2c_client to argument on i2c operation functions
mfd: MAX8998: Add interrupts support
rtc: Add MAX8998 rtc driver

Ping. Is there any feedback?

Thanks.

Signature · 1 line

- Joonyoung Shim

Andrew Morton

2010-08-25 19:22 UTC #2 lore raw

Quoted 15 lines · On Wed, 25 Aug 2010 17:55:00 +0900 Joonyoung Shim <[email protected]> wrote:

2010/8/6 Joonyoung Shim <[email protected]>:
Quoted 14 lines
Hi.
This patchset is to support the RTC provided by the Maxim 8998 chip. For this first, needs i2c interface changes and interrupts support of max8998 mfd driver.
Changes since v1:
- Fix missing braces of 3/3 patch from v1 review.
- The rest is same with v1.
Changes since v2:
- add missing free_irq and rtc_valid_tm on rtc driver of 3/3 patch
- The rest is same with v2.

Quoted 7 lines

Quoted 5 lines
Joonyoung Shim (3):
mfd: MAX8998: Use struct i2c_client to argument on i2c operation functions
mfd: MAX8998: Add interrupts support
rtc: Add MAX8998 rtc driver
Ping. Is there any feedback?

They look good to me. Things are pretty delayed at present as I (and presumably others) recover from the -rc merge window..

I merged them. Sam's acks on the MFD bits made life easier.

Samuel Ortiz

2010-09-10 16:39 UTC #3 lore raw

Quoted 24 lines · Andrew Morton

Quoted 21 lines · On Wed, 25 Aug 2010 17:55:00 +0900 Joonyoung Shim <[email protected]> wrote:
2010/8/6 Joonyoung Shim <[email protected]>:
Quoted 19 lines
Hi.
This patchset is to support the RTC provided by the Maxim 8998 chip. For this first, needs i2c interface changes and interrupts support of max8998 mfd driver.
Changes since v1:
- Fix missing braces of 3/3 patch from v1 review.
- The rest is same with v1.
Changes since v2:
- add missing free_irq and rtc_valid_tm on rtc driver of 3/3 patch
- The rest is same with v2.
Joonyoung Shim (3):
mfd: MAX8998: Use struct i2c_client to argument on i2c operation functions
mfd: MAX8998: Add interrupts support
rtc: Add MAX8998 rtc driver

Quoted 6 lines

Quoted 1 line
Ping. Is there any feedback?
They look good to me. Things are pretty delayed at present as I (and presumably others) recover from the -rc merge window..
I merged them. Sam's acks on the MFD bits made life easier.

For some reasons I thought Liam was pushing this patchset through the last merge window.
But now that the max8998 driver is upstreamed, I can carry those patches.

Cheers,
Samuel.

Signature · 2 lines

Intel Open Source Technology Centre
http://oss.intel.com/

Liam Girdwood

2010-09-10 16:45 UTC #4 lore raw

Quoted 25 lines · Samuel Ortiz

Quoted 24 lines · Andrew Morton
Quoted 21 lines · On Wed, 25 Aug 2010 17:55:00 +0900 Joonyoung Shim <[email protected]> wrote:
2010/8/6 Joonyoung Shim <[email protected]>:
Quoted 19 lines
Hi.
This patchset is to support the RTC provided by the Maxim 8998 chip. For this first, needs i2c interface changes and interrupts support of max8998 mfd driver.
Changes since v1:
- Fix missing braces of 3/3 patch from v1 review.
- The rest is same with v1.
Changes since v2:
- add missing free_irq and rtc_valid_tm on rtc driver of 3/3 patch
- The rest is same with v2.
Joonyoung Shim (3):
mfd: MAX8998: Use struct i2c_client to argument on i2c operation functions
mfd: MAX8998: Add interrupts support
rtc: Add MAX8998 rtc driver

Quoted 8 lines

Quoted 6 lines
Quoted 1 line
Ping. Is there any feedback?
They look good to me. Things are pretty delayed at present as I (and presumably others) recover from the -rc merge window..
I merged them. Sam's acks on the MFD bits made life easier.
For some reasons I thought Liam was pushing this patchset through the last merge window.

Oh, that just might be my memory failing me here.... apologies if so.

Quoted 2 lines

But now that the max8998 driver is upstreamed, I can carry those patches.

Thanks

Liam

Signature · 3 lines

Freelance Developer, SlimLogic Ltd
ASoC and Voltage Regulator Maintainer.
http://www.slimlogic.co.uk