Prefer posix_madvise() over madvise()
PATCH 1/1 Prefer posix_madvise() over madvise()
From: Andreas Färber <[email protected]>
vl.c has a Sun-specific hack to supply a prototype for madvise(), but the call site has apparently moved to arch_init.c. The underlying issue is that madvise() is not a POSIX function, therefore Solaris' _POSIX_C_SOURCE suppresses the prototype.
Haiku doesn't implement madvise() at all.
Where functionality equivalent to that of madvise() is provided, use the POSIX function posix_madvise().
http://www.opengroup.org/onlinepubs/9699919799/functions/posix_madvise.html
Remaining madvise() users:exec.c: limited to __linux__ and/or MADV_MERGEABLE (no POSIX equivalent) kvm-all.c: limited to MADV_DONTFORK (no POSIX equivalent),
otherwise runtime error if !kvm_has_sync_mmu()hw/virtio-balloon.c: limited to __linux__
--- arch_init.c | 2 +- vl.c | 3 --- 2 files changed, 1 insertions(+), 4 deletions(-)
arch_init.c +1 -1
@@ -396,7 +396,7 @@ int ram_load(QEMUFile *f, void *opaque, int version_id)#ifndef _WIN32if (ch ==0 && (!kvm_enabled () ||kvm_has_sync_mmu ())) { -madvise (host,TARGET_PAGE_SIZE ,MADV_DONTNEED ); +posix_madvise (host,TARGET_PAGE_SIZE ,POSIX_MADV_DONTNEED ); }#endif }else if (flags &RAM_SAVE_FLAG_PAGE ) {
vl.c +0 -3
@@ -80,9 +80,6 @@#include <net/if.h> #include <syslog.h> #include <stropts.h> -/* See MySQL bug #7156 (http://bugs.mysql.com/bug.php?id=7156) for -discussion about Solaris header problems */ -extern int madvise (caddr_t ,size_t ,int );#endif #endif #endif
Signature · 1 line
1.7.2.2
Quoted 8 lines · Andreas Färber
From: Andreas Färber <[email protected]>
vl.chas a Sun-specific hack to supply a prototype formadvise(), but the call site has apparently moved toarch_init.c. The underlying issue is thatmadvise()is not a POSIX function, therefore Solaris'_POSIX_C_SOURCEsuppresses the prototype.Haiku doesn't implement
madvise()at all.
OpenBSD doesn't implement posix_madvise(). How about adding probing to configure and wrapping the stuff found as qemu_madvise()?
Quoted 49 lines
Where functionality equivalent to that of
madvise()is provided, use the POSIX functionposix_madvise().
http://www.opengroup.org/onlinepubs/9699919799/functions/posix_madvise.htmlRemaining
madvise()users:exec.c: limited to__linux__and/orMADV_MERGEABLE(no POSIX equivalent)kvm-all.c: limited toMADV_DONTFORK(no POSIX equivalent), otherwise runtime error if !kvm_has_sync_mmu()hw/virtio-balloon.c: limited to__linux__Signed-off-by Andreas Färber <[email protected]>Cc Blue Swirl <[email protected]>---
arch_init.c | 2 +-
vl.c | 3 ---2 files changed, 1 insertions(+), 4 deletions(-)arch_init.c +0
-0@@ -396,7 +396,7 @@ int ram_load(QEMUFile *f, void *opaque, int version_id) #ifndef _WIN32if (ch == 0 &&
(!kvm_enabled() ||kvm_has_sync_mmu())) {
- madvise(host,TARGET_PAGE_SIZE,MADV_DONTNEED);
+ posix_madvise(host,TARGET_PAGE_SIZE,POSIX_MADV_DONTNEED); }
#endif
} else if (flags &RAM_SAVE_FLAG_PAGE) {vl.c +0
-4@@ -80,9 +80,6 @@ #include <net/if.h> #include <syslog.h> #include <stropts.h> -/* See MySQL bug #7156 (http://bugs.mysql.com/bug.php?id=7156) for -discussion about Solaris header problems */ -extern int madvise (caddr_t ,size_t ,int ); #endif #endif #endif --1.7.2.2
Am 11.09.2010 um 14:11 schrieb Blue Swirl:
Quoted 9 lines
On Sat, Sep 11, 2010 at 11:51 AM, Andreas Färber <[email protected]
Quoted 8 lines
wrote:
From: Andreas Färber <[email protected]>
vl.chas a Sun-specific hack to supply a prototype formadvise(), but the call site has apparently moved toarch_init.c. The underlying issue is thatmadvise()is not a POSIX function, therefore Solaris'_POSIX_C_SOURCEsuppresses the prototype.
Quoted 4 lines
Quoted 1 line
Haiku doesn't implement
madvise()at all.OpenBSD doesn't implement
posix_madvise(). How about adding probing to configure and wrapping the stuff found asqemu_madvise()?
Done in "Introduce qemu_madvise()". Should've been "[PATCH v2]".
Andreas