platform: x86: throw away custom methods
PATCH 1/1 platform: x86: throw away custom methods
In 2.6.35 the hex_to_bin() was introduced.
Signed-off-by Andy Shevchenko <[email protected]>
Cc Carlos Corbacho <[email protected]>
Cc Matthew Garrett <[email protected]>
--- drivers/platform/x86/wmi.c | 24 ++++++------------------ 1 files changed, 6 insertions(+), 18 deletions(-)
drivers/platform/x86/wmi.c +6 -18
@@ -128,30 +128,18 @@ static struct acpi_driver acpi_wmi_driver = {*/ static int wmi_parse_hexbyte (const u8 *src) { -unsigned int x;/* For correct wrapping */ int h; +int value;/* high part */ - x = src[0 ]; -if (x -'0' <='9' -'0' ) { - h = x -'0' ; - }else if (x -'a' <='f' -'a' ) { - h = x -'a' +10 ; - }else if (x -'A' <='F' -'A' ) { - h = x -'A' +10 ; - }else { + h = value =hex_to_bin (src[0 ]); +if (value <0 )return -1 ; - } - h <<=4 ;/* low part */ - x = src[1 ]; -if (x -'0' <='9' -'0' ) -return h | (x -'0' ); -if (x -'a' <='f' -'a' ) -return h | (x -'a' +10 ); -if (x -'A' <='F' -'A' ) -return h | (x -'A' +10 ); + value =hex_to_bin (src[1 ]); +if (value >=0 ) +return (h <<4 ) | value;return -1 ; }
Signature · 1 line
1.7.2.2
Quoted 3 lines · On Saturday 11 September 2010 14:31:02 Andy Shevchenko wrote:
In 2.6.35 the
hex_to_bin()was introduced.Signed-off-by Andy Shevchenko <[email protected]>
Acked-by Carlos Corbacho <[email protected]>
Quoted 2 lines
Cc Matthew Garrett <[email protected]>
Signature · 3 lines
E-Mail: [email protected] Web: strangeworlds.co.uk GPG Key ID: 0x23EE722D