drivers: s390: remove custom implementation of hex_to_bin()
Subsystems (2)
PATCH 1/1 drivers: s390: remove custom implementation of hex_to_bin()
Signed-off-by Andy Shevchenko <[email protected]>
Cc Martin Schwidefsky <[email protected]>
Cc Heiko Carstens <[email protected]>
--- drivers/s390/cio/blacklist.c | 10 ++++------ 1 files changed, 4 insertions(+), 6 deletions(-)
drivers/s390/cio/blacklist.c +4 -6
@@ -79,17 +79,15 @@ static int pure_hex(char **cp, unsigned int *val, int min_digit, int max_digit, int max_val) { int diff; -unsigned int value; diff =0 ; *val =0 ; -while (isxdigit (**cp) && (diff <= max_digit)) { +while (diff <= max_digit) { +int value =hex_to_bin (**cp); -if (isdigit (**cp)) - value = **cp -'0' ; -else - value =tolower (**cp) -'a' +10 ; +if (value <0 ) +break ; *val = *val *16 + value; (*cp)++; diff++;
Signature · 1 line
1.7.2.2
Heiko Carstens
AppliedQuoted 16 lines · Andy Shevchenko
drivers/s390/cio/blacklist.c +2
-2@@ -79,17 +79,15 @@ static int pure_hex(char **cp, unsigned int *val, int min_digit, int max_digit, int max_val) { int diff; -unsigned int value; diff =0 ; *val =0 ; -while (isxdigit (**cp) && (diff <= max_digit)) { +while (diff <= max_digit) { +int value =hex_to_bin (**cp);
drivers/s390/cio/blacklist.c static int pure_hex(char **cp, unsigned int *val, int min_digit, · line 93
Quoted 10 lines
drivers/s390/cio/blacklist.c +2
-4-if (isdigit (**cp)) - value = **cp -'0' ; -else - value =tolower (**cp) -'a' +10 ; +if (value <0 ) +break ; *val = *val *16 + value; (*cp)++; diff++;
Applied, thanks!