Skip to contentSkip to conversation

staging: solo6010: fix signess bug

PATCH New Vasiliy Kulikov 1 participant 1 message Sep 12, 2010

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 staging: solo6010: fix signess bug

video_nr is unsigned, so check video_nr >= 0 doesn't make sense. The only "negative" value may be -1, so explicitly check for it.

---
Compile tested.

 drivers/staging/solo6x10/solo6010-v4l2-enc.c |    2 +-
 drivers/staging/solo6x10/solo6010-v4l2.c     |    2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)
drivers/staging/solo6x10/solo6010-v4l2-enc.c +1 -1
index f114b4b..bbf3d9c 100644
@@ -1497,7 +1497,7 @@ static struct solo_enc_dev *solo_enc_alloc(struct solo6010_dev *solo_dev, u8 ch)
 		 "%s-enc (%i/%i)", SOLO6010_NAME, solo_dev->vfd->num,
 		 solo_enc->vfd->num);
 
-	if (video_nr >= 0)
+	if (video_nr != -1)
 		video_nr++;
 
 	spin_lock_init(&solo_enc->lock);
drivers/staging/solo6x10/solo6010-v4l2.c +1 -1
index 9537cc6..9731fa0 100644
@@ -825,7 +825,7 @@ int solo_v4l2_init(struct solo6010_dev *solo_dev)
 	snprintf(solo_dev->vfd->name, sizeof(solo_dev->vfd->name), "%s (%i)",
 		 SOLO6010_NAME, solo_dev->vfd->num);
 
-	if (video_nr >= 0)
+	if (video_nr != -1)
 		video_nr++;
 
 	dev_info(&solo_dev->pdev->dev, "Display as /dev/video%d with "
Signature · 1 line
1.7.0.4