writeback: kernel visibility
Subsystems (8)
cover writeback: kernel visibility
Patch #1 sets up some helper functions for account_page_dirty and fixes a bug in ceph
Patch #2 sets up some helper functions for account_page_writeback
Patch #3 adds writeback visibility in /proc/vmstat
To help developers and applications gain visibility into writeback behaviour this patch adds two counters to /proc/vmstat.
# grep nr_dirtied /proc/vmstat nr_dirtied 3747 # grep nr_written /proc/vmstat nr_written 3618
These entries allow user apps to understand writeback behaviour over time and learn how it is impacting their performance. Currently there is no way to inspect dirty and writeback speed over time. It's not possible for nr_dirty/nr_writeback.
These entries are necessary to give visibility into writeback behaviour. We have /proc/diskstats which lets us understand the io in the block layer. We have blktrace for more in depth understanding. We have e2fsprogs and debugsfs to give insight into the file systems behaviour, but we don't offer our users the ability understand what writeback is doing. There is no way to know how active it is over the whole system, if it's falling behind or to quantify it's efforts. With these values exported users can easily see how much data applications are sending through writeback and also at what rates writeback is processing this data. Comparing the rates of change between the two allow developers to see when writeback is not able to keep up with incoming traffic and the rate of dirty memory being sent to the IO back end. This allows folks to understand their io workloads and track kernel issues. Non kernel engineers at Google often use these counters to solve puzzling performance problems.
Patch #4 adds a pernode vmstat file with nr_dirtied and nr_written
Patch #5 add writeback thresholds to /proc/vmstat
Currently these values are in debugfs. But they should be promoted to /proc since they are useful for developers who are writing databases and file servers and are not debugging the kernel.
The output is as below:
# grep threshold /proc/vmstat nr_pages_dirty_threshold 409111 nr_pages_dirty_background_threshold 818223
Michael Rubin (5):
mm: exporting account_page_dirty
mm: account_page_writeback added
writeback: nr_dirtied and nr_written in /proc/vmstat
writeback: Adding /sys/devices/system/node/<node>/vmstat
writeback: Reporting dirty thresholds in /proc/vmstat
drivers/base/node.c | 14 ++++++++++++++ fs/ceph/addr.c | 8 +------- fs/nilfs2/segment.c | 2 +- include/linux/mm.h | 1 + include/linux/mmzone.h | 4 ++++ mm/page-writeback.c | 16 +++++++++++++++- mm/vmstat.c | 7 +++++++ 7 files changed, 43 insertions(+), 9 deletions(-)
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to [email protected]. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"[email protected]"> [email protected] </a>
PATCH 1/5 mm: exporting account_page_dirty
This allows code outside of the mm core to safely manipulate page state and not worry about the other accounting. Not using these routines means that some code will lose track of the accounting and we get bugs. This has happened once already.
Modified cephs to use the interface.
--- fs/ceph/addr.c | 8 +------- mm/page-writeback.c | 1 + 2 files changed, 2 insertions(+), 7 deletions(-)
fs/ceph/addr.c +1 -7
@@ -105,13 +105,7 @@ static int ceph_set_page_dirty(struct page *page)spin_lock_irq (&mapping->tree_lock);if (page->mapping) {/* Race with truncate? */ WARN_ON_ONCE (!PageUptodate (page)); - -if (mapping_cap_account_dirty (mapping)) { -__inc_zone_page_state (page,NR_FILE_DIRTY ); -__inc_bdi_stat (mapping->backing_dev_info, -BDI_RECLAIMABLE ); -task_io_account_write (PAGE_CACHE_SIZE ); - } +account_page_dirtied (page, page->mapping);radix_tree_tag_set (&mapping->page_tree,page_index (page),PAGECACHE_TAG_DIRTY );
mm/page-writeback.c +1 -0
@@ -1131,6 +1131,7 @@ void account_page_dirtied(struct page *page, struct address_space *mapping)task_io_account_write (PAGE_CACHE_SIZE ); } } +EXPORT_SYMBOL (account_page_dirtied);/* * For address_spaces which do not use buffers. Just tag the page as dirty in
Signature · 7 lines
1.7.1 -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to [email protected]. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"[email protected]"> [email protected] </a>
PATCH 2/5 mm: account_page_writeback added
In reply to Michael RubinThis allows code outside of the mm core to safely manipulate page writeback state and not worry about the other accounting. Not using these routines means that some code will lose track of the accounting and we get bugs.
Modified nilfs2 to use interface.
--- fs/nilfs2/segment.c | 2 +- include/linux/mm.h | 1 + mm/page-writeback.c | 13 ++++++++++++- 3 files changed, 14 insertions(+), 2 deletions(-)
fs/nilfs2/segment.c +1 -1
@@ -1599,7 +1599,7 @@ nilfs_copy_replace_page_buffers(struct page *page, struct list_head *out)kunmap_atomic (kaddr,KM_USER0 );if (!TestSetPageWriteback (clone_page)) -inc_zone_page_state (clone_page,NR_WRITEBACK ); +account_page_writeback (clone_page);unlock_page (clone_page);return 0 ;
include/linux/mm.h +1 -0
@@ -856,6 +856,7 @@ int __set_page_dirty_no_writeback(struct page *page);int redirty_page_for_writepage (struct writeback_control *wbc,struct page *page);void account_page_dirtied (struct page *page,struct address_space *mapping); +void account_page_writeback (struct page *page);int set_page_dirty (struct page *page);int set_page_dirty_lock (struct page *page);int clear_page_dirty_for_io (struct page *page);
mm/page-writeback.c +12 -1
@@ -1134,6 +1134,17 @@ void account_page_dirtied(struct page *page, struct address_space *mapping)EXPORT_SYMBOL (account_page_dirtied);/* +* Helper function for set_page_writeback family. +* NOTE: Unlike account_page_dirtied this does not rely on being atomic +* wrt interrupts. +*/ +void account_page_writeback (struct page *page) +{ +inc_zone_page_state (page,NR_WRITEBACK ); +} +EXPORT_SYMBOL (account_page_writeback); + +/* * For address_spaces which do not use buffers. Just tag the page as dirty in * its radix tree. *
@@ -1371,7 +1382,7 @@ int test_set_page_writeback(struct page *page) ret =TestSetPageWriteback (page); }if (!ret) -inc_zone_page_state (page,NR_WRITEBACK ); +account_page_writeback (page);return ret; }
Signature · 7 lines
1.7.1 -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to [email protected]. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"[email protected]"> [email protected] </a>
Re: [PATCH 2/5] mm: account_page_writeback added
Quoted 9 lines · Michael Rubin
This allows code outside of the mm core to safely manipulate page writeback state and not worry about the other accounting. Not using these routines means that some code will lose track of the accounting and we get bugs.
Modified nilfs2 to use interface.
Signed-off-by Michael Rubin <[email protected]>Reviewed-by KOSAKI Motohiro <[email protected]>
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to [email protected]. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"[email protected]"> [email protected] </a>
PATCH 3/5 writeback: nr_dirtied and nr_written in /proc/vmstat
In reply to Michael RubinTo help developers and applications gain visibility into writeback behaviour adding two entries to vm_stat_items and /proc/vmstat. This will allow us to track the "written" and "dirtied" counts.
# grep nr_dirtied /proc/vmstat nr_dirtied 3747 # grep nr_written /proc/vmstat nr_cleaned 3618
--- include/linux/mmzone.h | 2 ++ mm/page-writeback.c | 2 ++ mm/vmstat.c | 3 +++ 3 files changed, 7 insertions(+), 0 deletions(-)
include/linux/mmzone.h +2 -0
@@ -104,6 +104,8 @@ enum zone_stat_item {NR_ISOLATED_ANON ,/* Temporary isolated pages from anon lru */ NR_ISOLATED_FILE ,/* Temporary isolated pages from file lru */ NR_SHMEM ,/* shmem pages (included tmpfs/GEM pages) */ +NR_FILE_DIRTIED ,/* accumulated dirty pages */ +NR_WRITTEN ,/* accumulated written pages */ #ifdef CONFIG_NUMANUMA_HIT ,/* allocated in intended node */ NUMA_MISS, /* allocated in non intended node */
mm/page-writeback.c +2 -0
@@ -1126,6 +1126,7 @@ void account_page_dirtied(struct page *page, struct address_space *mapping) {if (mapping_cap_account_dirty (mapping)) {__inc_zone_page_state (page,NR_FILE_DIRTY ); +__inc_zone_page_state (page,NR_FILE_DIRTIED );__inc_bdi_stat (mapping->backing_dev_info,BDI_RECLAIMABLE );task_dirty_inc (current);task_io_account_write (PAGE_CACHE_SIZE );
@@ -1141,6 +1142,7 @@ EXPORT_SYMBOL(account_page_dirtied);void account_page_writeback (struct page *page) {inc_zone_page_state (page,NR_WRITEBACK ); +inc_zone_page_state (page,NR_WRITTEN ); }EXPORT_SYMBOL (account_page_writeback);
mm/vmstat.c +3 -0
@@ -732,6 +732,9 @@ static const char * const vmstat_text[] = {"nr_isolated_anon" ,"nr_isolated_file" ,"nr_shmem" , +"nr_dirtied" , +"nr_written" , + #ifdef CONFIG_NUMA"numa_hit" , "numa_miss",
Signature · 7 lines
1.7.1 -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to [email protected]. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"[email protected]"> [email protected] </a>
Re: [PATCH 3/5] writeback: nr_dirtied and nr_written in /proc/vmstat
Quoted 8 lines · Michael Rubin
To help developers and applications gain visibility into writeback behaviour adding two entries to
vm_stat_itemsand/proc/vmstat. This will allow us to track the "written" and "dirtied" counts.# grep nr_dirtied /proc/vmstat nr_dirtied 3747 # grep nr_written /proc/vmstat nr_cleaned 3618
s/nr_cleaned/nr_written
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to [email protected]. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"[email protected]"> [email protected] </a>
PATCH 4/5 writeback: Adding /sys/devices/system/node/<node>/vmstat
In reply to Michael RubinFor NUMA node systems it is important to have visibility in memory characteristics. Two of the /proc/vmstat values "nr_cleaned" and "nr_dirtied" are added here.
# cat /sys/devices/system/node/node20/vmstat nr_cleaned 0 nr_dirtied 0
--- drivers/base/node.c | 14 ++++++++++++++ 1 files changed, 14 insertions(+), 0 deletions(-)
drivers/base/node.c +14 -0
@@ -160,6 +160,18 @@ static ssize_t node_read_numastat(struct sys_device * dev, } static SYSDEV_ATTR(numastat, S_IRUGO, node_read_numastat, NULL); +static ssize_t node_read_vmstat (struct sys_device *dev, +struct sysdev_attribute *attr,char *buf) +{ +int nid = dev->id; +return sprintf (buf, +"nr_written %lu\n" +"nr_dirtied %lu\n" , +node_page_state (nid,NR_WRITTEN ), +node_page_state (nid,NR_FILE_DIRTIED )); +} +static SYSDEV_ATTR(vmstat, S_IRUGO, node_read_vmstat, NULL); +static ssize_t node_read_distance (struct sys_device * dev,struct sysdev_attribute *attr,char * buf) {
@@ -243,6 +255,7 @@ int register_node(struct node *node, int num, struct node *parent)sysdev_create_file (&node->sysdev, &attr_meminfo);sysdev_create_file (&node->sysdev, &attr_numastat);sysdev_create_file (&node->sysdev, &attr_distance); +sysdev_create_file (&node->sysdev, &attr_vmstat);scan_unevictable_register_node (node);
@@ -267,6 +280,7 @@ void unregister_node(struct node *node)sysdev_remove_file (&node->sysdev, &attr_meminfo);sysdev_remove_file (&node->sysdev, &attr_numastat);sysdev_remove_file (&node->sysdev, &attr_distance); +sysdev_remove_file (&node->sysdev, &attr_vmstat);scan_unevictable_unregister_node (node);hugetlb_unregister_node (node);/* no-op, if memoryless node */
Signature · 7 lines
1.7.1 -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to [email protected]. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"[email protected]"> [email protected] </a>
Re: [PATCH 4/5] writeback: Adding /sys/devices/system/node/<node>/vmstat
Quoted 2 lines · Michael Rubin
For NUMA node systems it is important to have visibility in memory characteristics. Two of the
/proc/vmstatvalues "nr_cleaned" and
s/nr_cleaned/nr_written/
Quoted 4 lines
"
nr_dirtied" are added here.# cat /sys/devices/system/node/node20/vmstat nr_cleaned 0
ditto
Quoted 3 lines
nr_dirtied0Signed-off-by Michael Rubin <[email protected]>
drivers/base/node.c static ssize_t node_read_numastat(struct sys_device * dev, · line 172
Quoted 10 lines
drivers/base/node.c +10
-0+static ssize_t node_read_vmstat (struct sys_device *dev, +struct sysdev_attribute *attr,char *buf) +{ +int nid = dev->id; +return sprintf (buf, +"nr_written %lu\n" +"nr_dirtied %lu\n" , +node_page_state (nid,NR_WRITTEN ), +node_page_state (nid,NR_FILE_DIRTIED )); +}
Do you have plan to port more vmstat_text[] items? :)
Thanks,
Fengguang
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to [email protected]. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"[email protected]"> [email protected] </a>
Re: [PATCH 4/5] writeback: Adding /sys/devices/system/node/<node>/vmstat
Quoted 1 line · Wu Fengguang
Do you have plan to port more vmstat_text[] items? :)
Yes. I feel bound to do it after all your help. :-)
I may need a few weeks to resolve some other issues but I can get back to this.
mrubin
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to [email protected]. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"[email protected]"> [email protected] </a>
PATCH 5/5 writeback: Reporting dirty thresholds in /proc/vmstat
In reply to Michael RubinThe kernel already exposes the user desired thresholds in /proc/sys/vm with dirty_background_ratio and background_ratio. But the kernel may alter the number requested without giving the user any indication that is the case.
Knowing the actual ratios the kernel is honoring can help app developers understand how their buffered IO will be sent to the disk.
$ grep threshold /proc/vmstat
nr_dirty_threshold 409111
nr_dirty_background_threshold 818223--- include/linux/mmzone.h | 2 ++ mm/vmstat.c | 4 ++++ 2 files changed, 6 insertions(+), 0 deletions(-)
include/linux/mmzone.h +2 -0
@@ -106,6 +106,8 @@ enum zone_stat_item {NR_SHMEM ,/* shmem pages (included tmpfs/GEM pages) */ NR_FILE_DIRTIED ,/* accumulated dirty pages */ NR_WRITTEN ,/* accumulated written pages */ +NR_DIRTY_THRESHOLD ,/* writeback threshold */ +NR_DIRTY_BG_THRESHOLD ,/* bg writeback threshold */ #ifdef CONFIG_NUMANUMA_HIT ,/* allocated in intended node */ NUMA_MISS, /* allocated in non intended node */
mm/vmstat.c +4 -0
@@ -17,6 +17,7 @@#include <linux/vmstat.h> #include <linux/sched.h> #include <linux/math64.h> +#include <linux/writeback.h> #ifdef CONFIG_VM_EVENT_COUNTERS DEFINE_PER_CPU(struct vm_event_state, vm_event_states) = {{0}};
@@ -734,6 +735,8 @@ static const char * const vmstat_text[] = {"nr_shmem" ,"nr_dirtied" ,"nr_written" , +"nr_dirty_threshold" , +"nr_dirty_background_threshold" , #ifdef CONFIG_NUMA "numa_hit",
@@ -917,6 +920,7 @@ static void *vmstat_start(struct seq_file *m, loff_t *pos)return ERR_PTR (-ENOMEM );for (i =0 ; i <NR_VM_ZONE_STAT_ITEMS ; i++) v[i] =global_page_state (i); +global_dirty_limits (v +NR_DIRTY_BG_THRESHOLD , v +NR_DIRTY_THRESHOLD );#ifdef CONFIG_VM_EVENT_COUNTERS e = v +NR_VM_ZONE_STAT_ITEMS ;all_vm_events (e);
Signature · 7 lines
1.7.1 -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to [email protected]. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"[email protected]"> [email protected] </a>
Re: [PATCH 5/5] writeback: Reporting dirty thresholds in /proc/vmstat
Quoted 23 lines · Michael Rubin
The kernel already exposes the user desired thresholds in
/proc/sys/vmwithdirty_background_ratioandbackground_ratio. But the kernel may alter the number requested without giving the user any indication that is the case.Knowing the actual ratios the kernel is honoring can help app developers understand how their buffered IO will be sent to the disk.
$ grep threshold /proc/vmstat nr_dirty_threshold 409111 nr_dirty_background_threshold 818223Signed-off-by Michael Rubin <[email protected]>--- include/linux/mmzone.h | 2 ++ mm/vmstat.c | 4 ++++ 2 files changed, 6 insertions(+), 0 deletions(-)include/linux/mmzone.h +0
-0
include/linux/mmzone.h enum zone_stat_item { · line 109
Quoted 4 lines
include/linux/mmzone.h +1
-0@@ -106,6 +106,8 @@ enum zone_stat_item {NR_SHMEM ,/* shmem pages (included tmpfs/GEM pages) */ NR_FILE_DIRTIED ,/* accumulated dirty pages */ NR_WRITTEN ,/* accumulated written pages */ + NR_DIRTY_THRESHOLD, /* writeback threshold */
s/writeback/dirty throttling/
include/linux/mmzone.h enum zone_stat_item { · line 110
Quoted 1 line
include/linux/mmzone.h +1
-0+ NR_DIRTY_BG_THRESHOLD, /* bg writeback threshold */
I have no idea about this interface change. No ACK or NAK.
But technical wise, the above two enum items should better be removed to avoid possibly eating one more cache line. The two items can be printed by explicit code.
Thanks,
Fengguang
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to [email protected]. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"[email protected]"> [email protected] </a>
Re: [PATCH 5/5] writeback: Reporting dirty thresholds in /proc/vmstat
Quoted 3 lines · Wu Fengguang
But technical wise, the above two enum items should better be removed to avoid possibly eating one more cache line. The two items can be printed by explicit code.
Done. Patch coming.
mrubin
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to [email protected]. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"[email protected]"> [email protected] </a>