mmc: Add architecture dependency for Marvell SoC controller
PATCH 1/1 mmc: Add architecture dependency for Marvell SoC controller
Since the driver is for controllers integrated into Marvells SoCs only offer MMC_SDHCI_MV if we're building for one.
--- drivers/mmc/host/Kconfig | 1 + 1 files changed, 1 insertions(+), 0 deletions(-)
drivers/mmc/host/Kconfig +1 -0
@@ -133,6 +133,7 @@ config MMC_SDHCI_CNS3XXX config MMC_SDHCI_MV tristate "SDHCI support on Marvell's SoC" depends on MMC_SDHCI + depends on (PLAT_PXA || PLAT_ORION) select MMC_SDHCI_IO_ACCESSORS help This selects the Secure Digital Host Controller Interface in
Signature · 1 line
1.7.1
drivers/mmc/host/Kconfig config MMC_SDHCI_CNS3XXX · line 139
Quoted 12 lines · Mark Brown
drivers/mmc/host/Kconfig +1
-0@@ -133,6 +133,7 @@ config MMC_SDHCI_CNS3XXX config MMC_SDHCI_MV tristate "SDHCI support on Marvell's SoC" depends on MMC_SDHCI + depends on (PLAT_PXA || PLAT_ORION) select MMC_SDHCI_IO_ACCESSORS help This selects the Secure Digital Host Controller Interface in
I think we normally try to do the the other way round: in order to increase build coverage, try to enable all drivers on as many platforms as possible, just don't have them in the defconfig.
Do you get build errors on other platforms? If yes, there is probably a bug in the driver that should be fixed instead.
Arnd
Quoted 3 lines · Arnd Bergmann
I think we normally try to do the the other way round: in order to increase build coverage, try to enable all drivers on as many platforms as possible, just don't have them in the defconfig.
This is not the general pattern for on-CPU devices on the embedded SoCs, for those we normally only offer the config option when building for a system which could physically have the device. Looking at the existing MMC host drivers you'll see this pattern is already heavily used there - all the existing embedded controllers have similar dependencies.
Quoted 2 lines
Do you get build errors on other platforms? If yes, there is probably a bug in the driver that should be fixed instead.
No, I didn't even try to build it - I saw that I was being offered a device for a Marvell CPU when building for a non-Marvell CPU.
Hi,
Quoted 22 lines · Mark Brown
Since the driver is for controllers integrated into Marvells SoCs only offer
MMC_SDHCI_MVif we're building for one.Signed-off-by Mark Brown <[email protected]>--- drivers/mmc/host/Kconfig | 1 + 1 files changed, 1 insertions(+), 0 deletions(-)drivers/mmc/host/Kconfig +1
-0@@ -133,6 +133,7 @@ config MMC_SDHCI_CNS3XXX config MMC_SDHCI_MV tristate "SDHCI support on Marvell's SoC" depends on MMC_SDHCI + depends on (PLAT_PXA || PLAT_ORION) select MMC_SDHCI_IO_ACCESSORS help This selects the Secure Digital Host Controller Interface inSignature · 1 line
1.7.1
This is fine with me. Saeed, please can you ACK the choice of platforms if you agree?
Thanks,
Signature · 2 lines
Chris Ball <[email protected]> <http://printf.net/> One Laptop Per Child
Quoted 2 lines · Chris Ball
This is fine with me. Saeed, please can you ACK the choice of platforms if you agree?
If the list of platforms is wrong we should probably also improve the help text :)
Quoted 11 lines
-----Original Message-----
From: Mark Brown [mailto:[email protected]]
Sent: Wednesday, September 15, 2010 11:40 AM
To: Chris Ball
Cc: Saeed Bishara; Andrew Morton; [email protected]; [email protected]
Subject: Re: [PATCH] mmc: Add architecture dependency for Marvell SoC controller
Quoted 7 lines
Quoted 2 lines · Chris Ball
This is fine with me. Saeed, please can you ACK the choice of platforms if you agree?
If the list of platforms is wrong we should probably also improve the help text :)
I think the PLAT_PXA it too general, maybe you better specify the exact ARCH (ARCH_MMP). saeed
Quoted 1 line
Quoted 2 lines · Saeed Bishara
I think the
PLAT_PXAit too general, maybe you better specify the exact ARCH (ARCH_MMP).
Which CPUs does the driver actually support? The Kconfig and commit log just say "Marvell" so I went for the conservative option and included all Marvell CPUs I was aware of.
Quoted 5 lines
Which CPUs does the driver actually support? The
Kconfigand commit log
just say "Marvell" so I went for the conservative option and included all Marvell CPUs I was aware of.
The Marvell Dove SoC includes this device, this SoC defined by ARCH_DOVE I guess it found also only on mmp (defined by ARCH_MMP), Haojian, can you confirm? saeed
Quoted 8 lines · Saeed Bishara
Quoted 5 lines
Which CPUs does the driver actually support? The
Kconfigand commit log
just say "Marvell" so I went for the conservative option and included all Marvell CPUs I was aware of.The Marvell Dove SoC includes this device, this SoC defined by
ARCH_DOVEI guess it found also only on mmp (defined byARCH_MMP), Haojian, can you confirm? saeed
As I know, MG1 is also using this IP. Although MG1 isn't supported in mainline, it's planned to be added into ARCH_PXA or one new ARCH. So PLAT_PXA is preferred.
Best Regards
Haojian
Quoted 19 lines
-----Original Message-----
From: Haojian Zhuang [mailto:[email protected]]
Sent: Wednesday, September 15, 2010 1:21 PM
To: Saeed Bishara
Cc: Mark Brown; Chris Ball; Andrew Morton; [email protected]; [email protected]
Subject: Re: [PATCH] mmc: Add architecture dependency for Marvell SoC controllerQuoted 6 lines · Saeed Bishara
Quoted 5 lines
Which CPUs does the driver actually support? The
Kconfigand commit log
just say "Marvell" so I went for the conservative option and included all Marvell CPUs I was aware of.The Marvell Dove SoC includes this device, this SoC defined
Quoted 8 lines
by
ARCH_DOVEQuoted 1 line
I guess it found also only on mmp (defined by
ARCH_MMP),Haojian, can you confirm?
Quoted 1 line
saeed
As I know, MG1 is also using this IP. Although MG1 isn't supported in mainline, it's planned to be added into
ARCH_PXAor one new ARCH. SoPLAT_PXAis preferred.
I think (ARCH_DOVE || ARCH_MMP) is prefered, when MG1 gets added to mainline, then we will add that new ARCH.
saeed
Quoted 22 lines · Saeed Bishara
Quoted 22 lines
-----Original Message-----
From: Haojian Zhuang [mailto:[email protected]]
Sent: Wednesday, September 15, 2010 1:21 PM
To: Saeed Bishara
Cc: Mark Brown; Chris Ball; Andrew Morton; [email protected]; [email protected]
Subject: Re: [PATCH] mmc: Add architecture dependency for Marvell SoC controllerQuoted 6 lines · Saeed Bishara
Quoted 5 lines
Which CPUs does the driver actually support? The
Kconfigand commit log
just say "Marvell" so I went for the conservative option and included all Marvell CPUs I was aware of.The Marvell Dove SoC includes this device, this SoC defined
by
ARCH_DOVEQuoted 1 line
I guess it found also only on mmp (defined by
ARCH_MMP),Haojian, can you confirm?
Quoted 8 lines
Quoted 5 lines
Quoted 1 line
saeed
As I know, MG1 is also using this IP. Although MG1 isn't supported in mainline, it's planned to be added into
ARCH_PXAor one new ARCH. SoPLAT_PXAis preferred.I think (
ARCH_DOVE||ARCH_MMP) is prefered, when MG1 gets added to mainline, then we will add that new ARCH.saeed
OK.
Quoted 2 lines · Saeed Bishara
I think (
ARCH_DOVE||ARCH_MMP) is prefered, when MG1 gets added to mainline, then we will add that new ARCH.
Thanks, pushed to mmc-next as below.
From: Mark Brown <[email protected]>
Date: Wed, 15 Sep 2010 16:45:41 -0400
Subject: [PATCH] mmc: Add architecture dependency for Marvell SoC controller
Since the driver is for controllers integrated into Marvell SoCs only offer MMC_SDHCI_MV if we're building for one.
--- drivers/mmc/host/Kconfig | 5 +++-- 1 files changed, 3 insertions(+), 2 deletions(-)
drivers/mmc/host/Kconfig +3 -2
@@ -133,10 +133,11 @@ config MMC_SDHCI_CNS3XXX config MMC_SDHCI_MV tristate "SDHCI support on Marvell's SoC" depends on MMC_SDHCI + depends on (ARCH_DOVE || ARCH_MMP) select MMC_SDHCI_IO_ACCESSORS help - This selects the Secure Digital Host Controller Interface in - Marvell's SoC controllers. + This selects SDHCI support for controllers found in the Dove + and MMP SoCs from Marvell. If you have a controller with this interface, say Y or M here.
Signature · 5 lines
1.7.2.2 -- Chris Ball <[email protected]> <http://printf.net/> One Laptop Per Child