Skip to contentSkip to conversation

mmc: add boundary check for mmc operation

PATCH Superseded Lei Wen 5 participants 20 messages Sep 13, 2010 – Oct 12, 2010 MMC, SD and SDIO

lore
Share & tools
lore

Lei Wen

author
#0 lore raw

PATCH 1/2 mmc: add boundary check for mmc operation

---
 drivers/mmc/mmc.c |   10 ++++++++++
 1 files changed, 10 insertions(+), 0 deletions(-)
drivers/mmc/mmc.c +10 -0
index cf4ea16..42638f6 100644
@@ -92,6 +92,11 @@ mmc_bwrite(int dev_num, ulong start, lbaint_t blkcnt, const void*src)
 
 	blklen = mmc->write_bl_len;
 
+	if ((start + blkcnt) > mmc->block_dev.lba) {
+		puts("operation exceed mmc boundary..\n"
+		     "This devices only have 0x%x blocks\n", mmc->block_dev.lba);
+		return 0;
+	}
 	err = mmc_set_blocklen(mmc, mmc->write_bl_len);
 
 	if (err) {
@@ -219,6 +224,11 @@ static ulong mmc_bread(int dev_num, ulong start, lbaint_t blkcnt, void *dst)
 	if (!mmc)
 		return 0;
 
+	if ((start + blkcnt) > mmc->block_dev.lba) {
+		puts("operation exceed mmc boundary..\n"
+		     "This devices only have 0x%x blocks\n", mmc->block_dev.lba);
+		return 0;
+	}
 	/* We always do full block reads from the card */
 	err = mmc_set_blocklen(mmc, mmc->read_bl_len);
 
Signature · 1 line
1.7.0.4
author
#1 lore raw

PATCH 2/2 mmc: print out avaible partition table

---
 common/cmd_mmc.c |   20 ++++++++++++++++++++
 disk/part.c      |    3 +++
 2 files changed, 23 insertions(+), 0 deletions(-)
common/cmd_mmc.c +20 -0
index c0b30d8..437dd88 100644
@@ -154,6 +154,25 @@ int do_mmcops(cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[])
 			mmc_init(mmc);
 
 			return 0;
+		} else if (strncmp(argv[1], "part", 4) == 0) {
+			int dev = simple_strtoul(argv[2], NULL, 10);
+			block_dev_desc_t *mmc_dev;
+			struct mmc *mmc = find_mmc_device(dev);
+
+			if (!mmc) {
+				puts("no mmc devices available\n");
+				return 1;
+			}
+			mmc_init(mmc);
+			mmc_dev = mmc_get_dev(dev);
+			if (mmc_dev != NULL &&
+			    mmc_dev->type != DEV_TYPE_UNKNOWN) {
+				print_part(mmc_dev);
+				return 0;
+			}
+
+			puts("get mmc type error!\n");
+			return 1;
 		}
 
 	case 0:
@@ -230,5 +249,6 @@ U_BOOT_CMD(
 	"read <device num> addr blk# cnt\n"
 	"mmc write <device num> addr blk# cnt\n"
 	"mmc rescan <device num>\n"
+	"mmc part <device num>- lists avaiable partition on mmc\n"
 	"mmc list - lists available devices");
 #endif
disk/part.c +3 -0
index 3ba88c7..1806fe6 100644
@@ -364,6 +364,9 @@ static void print_part_header (const char *type, block_dev_desc_t * dev_desc)
 	case IF_TYPE_DOC:
 		puts ("DOC");
 		break;
+	case IF_TYPE_MMC:
+		puts ("MMC");
+		break;
 	default:
 		puts ("UNKNOWN");
 		break;
Signature · 1 line
1.7.0.4
#2 lore raw

PATCH 1/2 mmc: add boundary check for mmc operation

In reply to Lei Wen

Dear Lei Wen,

when posting new versions of patches, please always

1) make sure the messages are properly threaded, i. e. make sure to provide proper references to the previous postings;
"git send-email" asks for the message ID.
2) show in the Subject that tthios is a new version of the patch (for example by using "[PATCH 1/2 v2]", and add (in the comment section, i. e. below the "---" line, a description of what was changed respective to the previous version(s).

Thanks.

Quoted 10 lines · In message <[email protected]> you wrote:
---
 drivers/mmc/mmc.c |   10 ++++++++++
 1 files changed, 10 insertions(+), 0 deletions(-)
drivers/mmc/mmc.c +0 -0
index cf4ea16..42638f6 100644

drivers/mmc/mmc.c mmc_bwrite(int dev_num, ulong start, lbaint_t blkcnt, const void*src) · line 97

Quoted 6 lines
drivers/mmc/mmc.c +3 -0
@@ -92,6 +92,11 @@ mmc_bwrite(int dev_num, ulong start, lbaint_t blkcnt, const void*src)
 
 	blklen = mmc->write_bl_len;
 
+	if ((start + blkcnt) > mmc->block_dev.lba) {
+		puts("operation exceed mmc boundary..\n"
+		     "This devices only have 0x%x blocks\n", mmc->block_dev.lba);

puts() does not perform output formatting. You want printf() here (and below).

Also, try to use a shorter message, for example:

	printf("MMC: block number 0x%x = %d exceeds max (0x%x = %d)", ...);

Best regards,

Wolfgang Denk

Signature · 5 lines
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
"Beauty is transitory." "Beauty survives."
	-- Spock and Kirk, "That Which Survives", stardate unknown
author
#3 lore raw

PATCH v2 1/2 mmc: add boundary check for mmc operation

In reply to Lei Wen

Change log:
change the puts to printf to better formating.

---
 drivers/mmc/mmc.c |   10 ++++++++++
 1 files changed, 10 insertions(+), 0 deletions(-)
drivers/mmc/mmc.c +10 -0
index cf4ea16..42638f6 100644
@@ -92,6 +92,11 @@ mmc_bwrite(int dev_num, ulong start, lbaint_t blkcnt, const void*src)
 
 	blklen = mmc->write_bl_len;
 
+	if ((start + blkcnt) > mmc->block_dev.lba) {
+		printf("MMC: block number 0x%x exceeds max(0x%x)",
+			start + blkcnt, mmc->block_dev.lba);
+		return 0;
+	}
 	err = mmc_set_blocklen(mmc, mmc->write_bl_len);
 
 	if (err) {
@@ -219,6 +224,11 @@ static ulong mmc_bread(int dev_num, ulong start, lbaint_t blkcnt, void *dst)
 	if (!mmc)
 		return 0;
 
+	if ((start + blkcnt) > mmc->block_dev.lba) {
+		printf("MMC: block number 0x%x exceeds max(0x%x)",
+			start + blkcnt, mmc->block_dev.lba);
+		return 0;
+	}
 	/* We always do full block reads from the card */
 	err = mmc_set_blocklen(mmc, mmc->read_bl_len);
 
Signature · 1 line
1.7.0.4
#4 lore raw

PATCH v2 1/2 mmc: add boundary check for mmc operation

Hello.

Quoted 2 lines · Lei Wen

Change log:
change the puts to printf to better formating.

This change log should have followed the "---" tear-line.

Quoted 2 lines

---

WBR, Sergei

#5 lore raw

PATCH v2 1/2 mmc: add boundary check for mmc operation

Fix in V3..

Thanks,
Lei

Quoted 14 lines · Sergei Shtylyov

Hello.

Quoted 2 lines · Lei Wen

Change log:
change the puts to printf to better formating.

? This change log should have followed the "---" tear-line.

Quoted 2 lines

---

WBR, Sergei

author
#6 lore raw

PATCH v2 2/2 mmc: print out avaible partition table

In reply to Lei Wen
---
 common/cmd_mmc.c |   20 ++++++++++++++++++++
 disk/part.c      |    3 +++
 2 files changed, 23 insertions(+), 0 deletions(-)
common/cmd_mmc.c +20 -0
index c0b30d8..437dd88 100644
@@ -154,6 +154,25 @@ int do_mmcops(cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[])
 			mmc_init(mmc);
 
 			return 0;
+		} else if (strncmp(argv[1], "part", 4) == 0) {
+			int dev = simple_strtoul(argv[2], NULL, 10);
+			block_dev_desc_t *mmc_dev;
+			struct mmc *mmc = find_mmc_device(dev);
+
+			if (!mmc) {
+				puts("no mmc devices available\n");
+				return 1;
+			}
+			mmc_init(mmc);
+			mmc_dev = mmc_get_dev(dev);
+			if (mmc_dev != NULL &&
+			    mmc_dev->type != DEV_TYPE_UNKNOWN) {
+				print_part(mmc_dev);
+				return 0;
+			}
+
+			puts("get mmc type error!\n");
+			return 1;
 		}
 
 	case 0:
@@ -230,5 +249,6 @@ U_BOOT_CMD(
 	"read <device num> addr blk# cnt\n"
 	"mmc write <device num> addr blk# cnt\n"
 	"mmc rescan <device num>\n"
+	"mmc part <device num>- lists avaiable partition on mmc\n"
 	"mmc list - lists available devices");
 #endif
disk/part.c +3 -0
index 3ba88c7..1806fe6 100644
@@ -364,6 +364,9 @@ static void print_part_header (const char *type, block_dev_desc_t * dev_desc)
 	case IF_TYPE_DOC:
 		puts ("DOC");
 		break;
+	case IF_TYPE_MMC:
+		puts ("MMC");
+		break;
 	default:
 		puts ("UNKNOWN");
 		break;
Signature · 1 line
1.7.0.4
#7 lore raw

PATCH v2 2/2 mmc: print out avaible partition table

Hello.

Quoted 1 line · Lei Wen

[...]

Quoted 4 lines
common/cmd_mmc.c +0 -0
index c0b30d8..437dd88 100644

[...]

common/cmd_mmc.c U_BOOT_CMD( · line 252

Quoted 5 lines
common/cmd_mmc.c +1 -0
@@ -230,5 +249,6 @@ U_BOOT_CMD(
 	"read <device num> addr blk# cnt\n"
 	"mmc write <device num> addr blk# cnt\n"
 	"mmc rescan <device num>\n"
+	"mmc part <device num>- lists avaiable partition on mmc\n"

Space is surely needed after <device num>.

WBR, Sergei

#8 lore raw

PATCH v2 2/2 mmc: print out avaible partition table

Fixed in V3.

Thanks,
Lei

Quoted 25 lines · Sergei Shtylyov

Hello.

Quoted 1 line · Lei Wen

[...]

Quoted 4 lines
common/cmd_mmc.c +0 -0
index c0b30d8..437dd88 100644

[...]

Quoted 6 lines
common/cmd_mmc.c +0 -0
@@ -230,5 +249,6 @@ U_BOOT_CMD(

? ? ? ?"read <device num> addr blk# cnt\n"
? ? ? ?"mmc write <device num> addr blk# cnt\n"
? ? ? ?"mmc rescan <device num>\n"
+ ? ? ? "mmc part <device num>- lists avaiable partition on mmc\n"

? Space is surely needed after <device num>.

WBR, Sergei

author
#9 lore raw

PATCH v3 1/2 mmc: add boundary check for mmc operation

In reply to Sergei Shtylyov

---
V2:
Change log:
change the puts to printf to better formating.

 drivers/mmc/mmc.c |   10 ++++++++++
 1 files changed, 10 insertions(+), 0 deletions(-)
drivers/mmc/mmc.c +10 -0
index cf4ea16..23928c1 100644
@@ -92,6 +92,11 @@ mmc_bwrite(int dev_num, ulong start, lbaint_t blkcnt, const void*src)
 
 	blklen = mmc->write_bl_len;
 
+	if ((start + blkcnt) > mmc->block_dev.lba) {
+		printf("MMC: block number 0x%x exceeds max(0x%x)",
+			start + blkcnt, mmc->block_dev.lba);
+		return 0;
+	}
 	err = mmc_set_blocklen(mmc, mmc->write_bl_len);
 
 	if (err) {
@@ -219,6 +224,11 @@ static ulong mmc_bread(int dev_num, ulong start, lbaint_t blkcnt, void *dst)
 	if (!mmc)
 		return 0;
 
+	if ((start + blkcnt) > mmc->block_dev.lba) {
+		printf("MMC: block number 0x%x exceeds max(0x%x)",
+			start + blkcnt, mmc->block_dev.lba);
+		return 0;
+	}
 	/* We always do full block reads from the card */
 	err = mmc_set_blocklen(mmc, mmc->read_bl_len);
 
Signature · 1 line
1.7.0.4
#10 lore raw

PATCH v3 1/2 mmc: add boundary check for mmc operation

Hi,

Is it ok now for merging....?

Thanks,
Lei

Quoted 42 lines · Lei Wen

---
V2:
Change log:
change the puts to printf to better formating.

?drivers/mmc/mmc.c | ? 10 ++++++++++
?1 files changed, 10 insertions(+), 0 deletions(-)

drivers/mmc/mmc.c +10 -0
index cf4ea16..23928c1 100644
@@ -92,6 +92,11 @@ mmc_bwrite(int dev_num, ulong start, lbaint_t blkcnt, const void*src)
 
 ? ? ? ?blklen = mmc->write_bl_len;
 
+ ? ? ? if ((start + blkcnt) > mmc->block_dev.lba) {
+ ? ? ? ? ? ? ? printf("MMC: block number 0x%x exceeds max(0x%x)",
+ ? ? ? ? ? ? ? ? ? ? ? start + blkcnt, mmc->block_dev.lba);
+ ? ? ? ? ? ? ? return 0;
+ ? ? ? }
 ? ? ? ?err = mmc_set_blocklen(mmc, mmc->write_bl_len);
 
 ? ? ? ?if (err) {
@@ -219,6 +224,11 @@ static ulong mmc_bread(int dev_num, ulong start, lbaint_t blkcnt, void *dst)
 ? ? ? ?if (!mmc)
 ? ? ? ? ? ? ? ?return 0;
 
+ ? ? ? if ((start + blkcnt) > mmc->block_dev.lba) {
+ ? ? ? ? ? ? ? printf("MMC: block number 0x%x exceeds max(0x%x)",
+ ? ? ? ? ? ? ? ? ? ? ? start + blkcnt, mmc->block_dev.lba);
+ ? ? ? ? ? ? ? return 0;
+ ? ? ? }

? ? ? ?/* We always do full block reads from the card */ ? ? ? ?err = mmc_set_blocklen(mmc, mmc->read_bl_len);

--
1.7.0.4

#11 lore raw

PATCH v3 1/2 mmc: add boundary check for mmc operation

Continue ping...

Best regards,
Lei

Quoted 51 lines · Lei Wen

Hi,

Is it ok now for merging....?

Thanks,
Lei

Quoted 42 lines · Lei Wen

---
V2:
Change log:
change the puts to printf to better formating.

?drivers/mmc/mmc.c | ? 10 ++++++++++
?1 files changed, 10 insertions(+), 0 deletions(-)

drivers/mmc/mmc.c +10 -0
index cf4ea16..23928c1 100644
@@ -92,6 +92,11 @@ mmc_bwrite(int dev_num, ulong start, lbaint_t blkcnt, const void*src)
 
 ? ? ? ?blklen = mmc->write_bl_len;
 
+ ? ? ? if ((start + blkcnt) > mmc->block_dev.lba) {
+ ? ? ? ? ? ? ? printf("MMC: block number 0x%x exceeds max(0x%x)",
+ ? ? ? ? ? ? ? ? ? ? ? start + blkcnt, mmc->block_dev.lba);
+ ? ? ? ? ? ? ? return 0;
+ ? ? ? }
 ? ? ? ?err = mmc_set_blocklen(mmc, mmc->write_bl_len);
 
 ? ? ? ?if (err) {
@@ -219,6 +224,11 @@ static ulong mmc_bread(int dev_num, ulong start, lbaint_t blkcnt, void *dst)
 ? ? ? ?if (!mmc)
 ? ? ? ? ? ? ? ?return 0;
 
+ ? ? ? if ((start + blkcnt) > mmc->block_dev.lba) {
+ ? ? ? ? ? ? ? printf("MMC: block number 0x%x exceeds max(0x%x)",
+ ? ? ? ? ? ? ? ? ? ? ? start + blkcnt, mmc->block_dev.lba);
+ ? ? ? ? ? ? ? return 0;
+ ? ? ? }

? ? ? ?/* We always do full block reads from the card */ ? ? ? ?err = mmc_set_blocklen(mmc, mmc->read_bl_len);

--
1.7.0.4

#12 lore raw

PATCH v3 1/2 mmc: add boundary check for mmc operation

In reply to Lei Wen

Dear Lei Wen,

Quoted 9 lines · In message <[email protected]> you wrote:

---
V2:
Change log:
change the puts to printf to better formating.

 drivers/mmc/mmc.c |   10 ++++++++++
 1 files changed, 10 insertions(+), 0 deletions(-)

Applied, thanks.

Best regards,

Wolfgang Denk

Signature · 4 lines
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Intel's new motto: United we stand. Divided we fall!
#13 lore raw

PATCH v3 1/2 mmc: add boundary check for mmc operation

Quoted 22 lines

-----Original Message-----
From: u-boot-bounces at lists.denx.de [mailto:u-boot-bounces at lists.denx.de] On Behalf Of Wolfgang Denk
Sent: Sunday, September 19, 2010 3:17 AM
To: Lei Wen
Cc: u-boot at lists.denx.de; sshtylyov at mvista.com
Subject: Re: [U-Boot] [PATCH 1/2 V3] mmc: add boundary check for mmc operation

Dear Lei Wen,

In message <[email protected]> you

Quoted 7 lines · wrote:

---
V2:
Change log:
change the puts to printf to better formating.

Quoted 4 lines
Quoted 2 lines
 drivers/mmc/mmc.c |   10 ++++++++++
 1 files changed, 10 insertions(+), 0 deletions(-)

Applied, thanks.

[Ghorai] I was using the latest mmc/sd core for OMAP 4 and getting the following error. OMAP4430 SDP # mmc rescan 1
MMC: block number 0x1 exceeds max(0x0)OMAP4430 SDP #

Please let me know what I am missing.

Quoted 14 lines

Best regards,

Wolfgang Denk

--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de Intel's new motto: United we stand. Divided we fall!
_______________________________________________
U-Boot mailing list
U-Boot at lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

#14 lore raw

PATCH v3 1/2 mmc: add boundary check for mmc operation

Hi Ghorai,

Quoted 7 lines

[Ghorai] I was using the latest mmc/sd core for OMAP 4 and getting the following error. OMAP4430 SDP # mmc rescan 1
MMC: block number 0x1 exceeds max(0x0)OMAP4430 SDP #

Please let me know what I am missing.

I also test the latest code, and don't find the issue you report... What would happen when you type "mmcinfo 1"? Seems your mmc card is not init properly.

Best regards,
Lei

#15 lore raw

PATCH v3 1/2 mmc: add boundary check for mmc operation

Quoted 10 lines

-----Original Message-----
From: Lei Wen [mailto:adrian.wenl at gmail.com]
Sent: Monday, September 20, 2010 6:29 PM
To: Ghorai, Sukumar
Cc: Wolfgang Denk; Lei Wen; u-boot at lists.denx.de; sshtylyov at mvista.com
Subject: Re: [U-Boot] [PATCH 1/2 V3] mmc: add boundary check for mmc operation

Quoted 9 lines

Hi Ghorai,

Quoted 2 lines

[Ghorai] I was using the latest mmc/sd core for OMAP 4 and getting the

following error.

Quoted 4 lines

OMAP4430 SDP # mmc rescan 1
MMC: block number 0x1 exceeds max(0x0)OMAP4430 SDP #

Please let me know what I am missing.

[Ghorai] Thanks.
I found the problem. It's a eMMC size calculation is wrong and here is the fix I am sending as a patch too in my next email.

From: Sukumar Ghorai <[email protected]>
Date: Mon, 20 Sep 2010 18:29:29 +0530
Subject: [PATCH 1/3] fix for eMMC capacity calculation

capacity of the eMMC device available in ext-CSD register only

---
drivers/mmc/mmc.c | 11 +++++++++++

 1 files changed, 11 insertions(+), 0 deletions(-)
drivers/mmc/mmc.c +11 -0
index 80cd9bf..c543d83 100644
@@ -627,6 +627,7 @@ int mmc_startup(struct mmc *mmc)
 	uint mult, freq;
 	u64 cmult, csize;
 	struct mmc_cmd cmd;
+	char ext_csd[512];
 
 	/* Put the Card in Identify Mode */
 	cmd.cmdidx = MMC_CMD_ALL_SEND_CID;
@@ -742,6 +743,16 @@ int mmc_startup(struct mmc *mmc)
 	if (err)
 		return err;
 
+	if (!IS_SD(mmc) && (mmc->version >= MMC_VERSION_4)) {
+		/* check  ext_csd version and capacity */
+		err = mmc_send_ext_csd(mmc, ext_csd);
+		if (!err & (ext_csd[192] >= 2)) {
+			mmc->capacity = ext_csd[212] << 0 | ext_csd[213] << 8 |
+					ext_csd[214] << 16 | ext_csd[215] << 24;
+			mmc->capacity *= 512;
+		}
+	}
+
 	if (IS_SD(mmc))
 		err = sd_change_freq(mmc);
 	else
Signature · 1 line
1.7.0.4
Quoted 8 lines
Quoted 1 line

I also test the latest code, and don't find the issue you report... What would happen when you type "mmcinfo 1"? Seems your mmc card is not init properly.

Best regards,
Lei

#16 lore raw

PATCH v3 1/2 mmc: add boundary check for mmc operation

Dear Andy,

In message <[email protected]> Sukumar Ghorai wrote:
...

Quoted 7 lines

I found the problem. It's a eMMC size calculation is wrong and here is the fix I am sending as a patch too in my next email.

From: Sukumar Ghorai <[email protected]>
Date: Mon, 20 Sep 2010 18:29:29 +0530
Subject: [PATCH 1/3] fix for eMMC capacity calculation

Quoted 6 lines

capacity of the eMMC device available in ext-CSD register only

---
drivers/mmc/mmc.c | 11 +++++++++++

 1 files changed, 11 insertions(+), 0 deletions(-)

Is this patch on your queue?

Best regards,

Wolfgang Denk

Signature · 5 lines
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
"Here's a fish hangs in the net like a poor man's right in  the  law.
'Twill hardly come out."     - Shakespeare, Pericles, Act II, Scene 1
#17 lore raw

PATCH v3 1/2 mmc: add boundary check for mmc operation

Quoted 23 lines

-----Original Message-----
From: Wolfgang Denk [mailto:wd at denx.de]
Sent: Wednesday, October 13, 2010 12:51 AM
To: Andy Fleming; Ghorai, Sukumar
Cc: Lei Wen; Lei Wen; u-boot at lists.denx.de; sshtylyov at mvista.com
Subject: Re: [U-Boot] [PATCH 1/2 V3] mmc: add boundary check for mmc operation

Dear Andy,

In message <[email protected]> Sukumar Ghorai wrote:
...

Quoted 1 line

I found the problem. It's a eMMC size calculation is wrong and here is

the

Quoted 6 lines

fix I am sending as a patch too in my next email.

From: Sukumar Ghorai <[email protected]>
Date: Mon, 20 Sep 2010 18:29:29 +0530
Subject: [PATCH 1/3] fix for eMMC capacity calculation

Quoted 8 lines
Quoted 6 lines

capacity of the eMMC device available in ext-CSD register only

---
drivers/mmc/mmc.c | 11 +++++++++++

 1 files changed, 11 insertions(+), 0 deletions(-)

Is this patch on your queue?

[Ghorai]
This has been submitted by Steve Sakoman sometime back.
http://www.mail-archive.com/u-boot at lists.denx.de/msg38692.html

Quoted 11 lines

Best regards,

Wolfgang Denk

--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de "Here's a fish hangs in the net like a poor man's right in the law.
'Twill hardly come out." - Shakespeare, Pericles, Act II, Scene 1

author
#18 lore raw

PATCH v3 2/2 mmc: print out avaible partition table

In reply to Sergei Shtylyov

---
V3: add additional space after <device num>

 common/cmd_mmc.c |   20 ++++++++++++++++++++
 disk/part.c      |    3 +++
 2 files changed, 23 insertions(+), 0 deletions(-)
common/cmd_mmc.c +20 -0
index c0b30d8..45924e3 100644
@@ -154,6 +154,25 @@ int do_mmcops(cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[])
 			mmc_init(mmc);
 
 			return 0;
+		} else if (strncmp(argv[1], "part", 4) == 0) {
+			int dev = simple_strtoul(argv[2], NULL, 10);
+			block_dev_desc_t *mmc_dev;
+			struct mmc *mmc = find_mmc_device(dev);
+
+			if (!mmc) {
+				puts("no mmc devices available\n");
+				return 1;
+			}
+			mmc_init(mmc);
+			mmc_dev = mmc_get_dev(dev);
+			if (mmc_dev != NULL &&
+			    mmc_dev->type != DEV_TYPE_UNKNOWN) {
+				print_part(mmc_dev);
+				return 0;
+			}
+
+			puts("get mmc type error!\n");
+			return 1;
 		}
 
 	case 0:
@@ -230,5 +249,6 @@ U_BOOT_CMD(
 	"read <device num> addr blk# cnt\n"
 	"mmc write <device num> addr blk# cnt\n"
 	"mmc rescan <device num>\n"
+	"mmc part <device num> - lists available partition on mmc\n"
 	"mmc list - lists available devices");
 #endif
disk/part.c +3 -0
index 3ba88c7..1806fe6 100644
@@ -364,6 +364,9 @@ static void print_part_header (const char *type, block_dev_desc_t * dev_desc)
 	case IF_TYPE_DOC:
 		puts ("DOC");
 		break;
+	case IF_TYPE_MMC:
+		puts ("MMC");
+		break;
 	default:
 		puts ("UNKNOWN");
 		break;
Signature · 1 line
1.7.0.4
#19 lore raw

PATCH v3 2/2 mmc: print out avaible partition table

Dear Lei Wen,

Quoted 7 lines · In message <[email protected]> you wrote:

---
V3: add additional space after <device num>

 common/cmd_mmc.c |   20 ++++++++++++++++++++
 disk/part.c      |    3 +++
 2 files changed, 23 insertions(+), 0 deletions(-)

Applied, thanks.

Best regards,

Wolfgang Denk

Signature · 6 lines
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Ninety-Ninety Rule of Project Schedules:
        The first ninety percent of the task takes ninety percent of
the time, and the last ten percent takes the other ninety percent.