change default_llseek action
Subsystems (138)
Arnd Bergmann
maintainercover change default_llseek action
The llseek file operations traditionally behaves differently from all other file operations, the default being a generic implementation of the call instead of a stub returning an error.
This changes *all* instances of struct file_operations in the kernel to have a .llseek operation and then changes the default to no_llseek, which returns -ESPIPE, which is what we had decided some time ago in a discussion with Christoph Hellwig.
Where possible, the change is done automatically using a semantic patch with coccinelle, the few cases where an automatic conversion is not possible have separate patches.
Finally, the default_llseek operation gets changed to no longer require the big kernel lock. Since only a few users are left using it, it can easily be shown that none of them actually expects the big kernel lock here.
I would like to get this into -next now, but will regenerate the automatic mass-conversion part when this gets ready for inclusion in 2.6.37, to accomodate any drivers that got added without a .llseek method.
Stephen, please add git+ssh://master.kernel.org/pub/scm/linux/kernel/git/arnd/bkl.git llseek
Arnd Bergmann (15):
drm: use noop_llseek
net/wireless: use generic_file_llseek in debugfs
lkdtm: use generic_file_llseek in debugfs arm/omap: use generic_file_llseek in iommu_debug
spufs: use llseek in all file operations
ibmasmfs: use generic_file_llseek
raw: use explicit llseek file operations irda/irnet: use noop_llseek viotape: use noop_llseek lirc: make chardev nonseekable mac80211: disallow seeks in minstrel debug code libfs: use generic_file_llseek for simple_attr llseek: automatically add .llseek fop vfs: don't use BKL in default_llseek vfs: make no_llseek the default
Documentation/DocBook/drm.tmpl | 1 + arch/arm/kernel/etm.c | 1 + arch/arm/mach-msm/last_radio_log.c | 3 +- arch/arm/mach-msm/smd_debug.c | 1 + arch/arm/plat-mxc/audmux-v2.c | 1 + arch/arm/plat-omap/iommu-debug.c | 2 + arch/avr32/boards/mimc200/fram.c | 1 + arch/blackfin/kernel/kgdb_test.c | 1 + arch/blackfin/mach-bf561/coreb.c | 1 + arch/cris/arch-v10/drivers/ds1302.c | 1 + arch/cris/arch-v10/drivers/gpio.c | 1 + arch/cris/arch-v10/drivers/i2c.c | 1 + arch/cris/arch-v10/drivers/pcf8563.c | 1 + arch/cris/arch-v10/drivers/sync_serial.c | 3 +- arch/cris/arch-v32/drivers/cryptocop.c | 3 +- arch/cris/arch-v32/drivers/i2c.c | 1 + arch/cris/arch-v32/drivers/mach-a3/gpio.c | 1 + arch/cris/arch-v32/drivers/mach-fs/gpio.c | 1 + arch/cris/arch-v32/drivers/pcf8563.c | 1 + arch/cris/arch-v32/drivers/sync_serial.c | 3 +- arch/cris/kernel/profile.c | 1 + arch/ia64/kernel/salinfo.c | 2 + arch/ia64/sn/kernel/sn2/sn_hwperf.c | 1 + arch/m68k/bvme6000/rtc.c | 1 + arch/m68k/mvme16x/rtc.c | 1 + arch/mips/kernel/rtlx.c | 3 +- arch/mips/kernel/vpe.c | 3 +- arch/mips/sibyte/common/sb_tbprof.c | 1 + arch/powerpc/kernel/lparcfg.c | 1 + arch/powerpc/kernel/rtas_flash.c | 3 ++ arch/powerpc/kernel/rtasd.c | 1 + arch/powerpc/platforms/cell/spufs/file.c | 18 ++++++++++++ arch/powerpc/platforms/iseries/mf.c | 1 + arch/powerpc/platforms/pseries/reconfig.c | 3 +- arch/powerpc/platforms/pseries/scanlog.c | 1 + arch/s390/crypto/prng.c | 1 + arch/s390/hypfs/hypfs_diag.c | 1 + arch/s390/hypfs/hypfs_vm.c | 1 + arch/s390/hypfs/inode.c | 1 + arch/s390/kernel/debug.c | 1 + arch/sh/boards/mach-landisk/gio.c | 1 + arch/sparc/kernel/apc.c | 1 + arch/sparc/kernel/mdesc.c | 1 + arch/tile/kernel/hardwall.c | 1 + arch/um/drivers/harddog_kern.c | 1 + arch/um/drivers/mconsole_kern.c | 1 + arch/um/drivers/mmapper_kern.c | 1 + arch/um/drivers/random.c | 1 + arch/x86/kernel/apm_32.c | 1 + arch/x86/kernel/cpu/mcheck/mce-severity.c | 1 + arch/x86/kernel/cpu/mcheck/mce.c | 1 + arch/x86/kernel/kdebugfs.c | 1 + arch/x86/kernel/microcode_core.c | 1 + arch/x86/kernel/tlb_uv.c | 1 + arch/x86/xen/debugfs.c | 1 + block/bsg.c | 1 + drivers/acpi/ec_sys.c | 1 + drivers/acpi/event.c | 1 + drivers/block/DAC960.c | 3 +- drivers/block/aoe/aoechr.c | 1 + drivers/block/paride/pg.c | 1 + drivers/block/paride/pt.c | 1 + drivers/block/pktcdvd.c | 1 + drivers/bluetooth/btmrvl_debugfs.c | 10 ++++++ drivers/bluetooth/hci_vhci.c | 1 + drivers/char/apm-emulation.c | 1 + drivers/char/bfin-otp.c | 1 + drivers/char/briq_panel.c | 1 + drivers/char/bsr.c | 1 + drivers/char/cs5535_gpio.c | 3 +- drivers/char/ds1302.c | 1 + drivers/char/ds1620.c | 1 + drivers/char/dsp56k.c | 1 + drivers/char/dtlk.c | 1 + drivers/char/genrtc.c | 1 + drivers/char/hw_random/core.c | 1 + drivers/char/ip2/ip2main.c | 1 + drivers/char/ipmi/ipmi_devintf.c | 1 + drivers/char/ipmi/ipmi_watchdog.c | 1 + drivers/char/istallion.c | 1 + drivers/char/lp.c | 1 + drivers/char/mem.c | 3 ++ drivers/char/misc.c | 1 + drivers/char/mmtimer.c | 1 + drivers/char/mspec.c | 9 ++++-- drivers/char/mwave/mwavedd.c | 3 +- drivers/char/nwbutton.c | 1 + drivers/char/pc8736x_gpio.c | 1 + drivers/char/pcmcia/cm4000_cs.c | 1 + drivers/char/pcmcia/cm4040_cs.c | 1 + drivers/char/random.c | 2 + drivers/char/raw.c | 2 + drivers/char/rio/rio_linux.c | 1 + drivers/char/scx200_gpio.c | 1 + drivers/char/snsc.c | 1 + drivers/char/stallion.c | 1 + drivers/char/sx.c | 1 + drivers/char/sysrq.c | 1 + drivers/char/tb0219.c | 1 + drivers/char/tlclk.c | 1 + drivers/char/toshiba.c | 1 + drivers/char/uv_mmtimer.c | 1 + drivers/char/viotape.c | 1 + drivers/char/virtio_console.c | 3 ++ drivers/char/xilinx_hwicap/xilinx_hwicap.c | 1 + drivers/dma/coh901318.c | 1 + drivers/firewire/nosy.c | 1 + drivers/gpu/drm/drm_drv.c | 3 +- drivers/gpu/drm/i810/i810_dma.c | 1 + drivers/gpu/drm/i810/i810_drv.c | 1 + drivers/gpu/drm/i830/i830_dma.c | 1 + drivers/gpu/drm/i830/i830_drv.c | 1 + drivers/gpu/drm/i915/i915_debugfs.c | 1 + drivers/gpu/drm/i915/i915_drv.c | 1 + drivers/gpu/drm/mga/mga_drv.c | 1 + drivers/gpu/drm/nouveau/nouveau_drv.c | 1 + drivers/gpu/drm/r128/r128_drv.c | 1 + drivers/gpu/drm/radeon/radeon_drv.c | 1 + drivers/gpu/drm/savage/savage_drv.c | 1 + drivers/gpu/drm/sis/sis_drv.c | 1 + drivers/gpu/drm/tdfx/tdfx_drv.c | 1 + drivers/gpu/drm/via/via_drv.c | 1 + drivers/gpu/drm/vmwgfx/vmwgfx_drv.c | 1 + drivers/gpu/vga/vgaarb.c | 1 + drivers/hid/hid-debug.c | 1 + drivers/hid/hid-roccat.c | 1 + drivers/hid/hidraw.c | 1 + drivers/hid/usbhid/hiddev.c | 1 + drivers/hwmon/asus_atk0110.c | 1 + drivers/ide/ide-tape.c | 1 + drivers/idle/i7300_idle.c | 1 + drivers/infiniband/hw/cxgb4/device.c | 1 + drivers/infiniband/hw/ipath/ipath_diag.c | 4 ++- drivers/infiniband/hw/ipath/ipath_file_ops.c | 3 +- drivers/infiniband/hw/ipath/ipath_fs.c | 3 ++ drivers/infiniband/hw/qib/qib_diag.c | 4 ++- drivers/infiniband/hw/qib/qib_file_ops.c | 3 +- drivers/infiniband/hw/qib/qib_fs.c | 1 + drivers/input/evdev.c | 3 +- drivers/input/input.c | 1 + drivers/input/joydev.c | 1 + drivers/input/misc/uinput.c | 1 + drivers/input/mousedev.c | 1 + drivers/input/serio/serio_raw.c | 1 + drivers/isdn/mISDN/timerdev.c | 1 + drivers/lguest/lguest_user.c | 1 + drivers/macintosh/ans-lcd.c | 1 + drivers/macintosh/via-pmu.c | 1 + drivers/md/dm-ioctl.c | 1 + drivers/media/IR/imon.c | 6 ++- drivers/media/IR/ir-lirc-codec.c | 1 + drivers/media/IR/lirc_dev.c | 3 ++ drivers/media/dvb/bt8xx/dst_ca.c | 3 +- drivers/media/dvb/dvb-core/dmxdev.c | 2 + drivers/media/dvb/dvb-core/dvb_ca_en50221.c | 1 + drivers/media/dvb/dvb-core/dvb_frontend.c | 3 +- drivers/media/dvb/dvb-core/dvb_net.c | 1 + drivers/media/dvb/dvb-core/dvbdev.c | 1 + drivers/media/dvb/firewire/firedtv-ci.c | 1 + drivers/media/dvb/ttpci/av7110.c | 1 + drivers/media/dvb/ttpci/av7110_av.c | 2 + drivers/media/dvb/ttpci/av7110_ca.c | 1 + drivers/media/dvb/ttpci/av7110_ir.c | 1 + drivers/mfd/ab3100-core.c | 1 + drivers/misc/hpilo.c | 1 + drivers/misc/ibmasm/ibmasmfs.c | 4 ++ drivers/misc/iwmc3200top/debugfs.c | 3 ++ drivers/misc/lkdtm.c | 9 ++++++ drivers/misc/phantom.c | 1 + drivers/misc/sgi-gru/grufile.c | 1 + drivers/mmc/core/debugfs.c | 1 + drivers/mtd/ubi/cdev.c | 1 + drivers/net/caif/caif_spi.c | 6 ++- drivers/net/cxgb4/cxgb4_main.c | 1 + drivers/net/ppp_generic.c | 3 +- drivers/net/wimax/i2400m/debugfs.c | 2 + drivers/net/wireless/airo.c | 24 ++++++++++----- drivers/net/wireless/ath/ath5k/debug.c | 7 ++++ drivers/net/wireless/ath/ath9k/debug.c | 33 ++++++++++++++------- drivers/net/wireless/ath/ath9k/htc_drv_main.c | 9 ++++-- drivers/net/wireless/b43/debugfs.c | 1 + drivers/net/wireless/b43legacy/debugfs.c | 1 + drivers/net/wireless/iwlwifi/iwl-3945-rs.c | 1 + drivers/net/wireless/iwlwifi/iwl-agn-rs.c | 3 ++ drivers/net/wireless/iwlwifi/iwl-debugfs.c | 3 ++ drivers/net/wireless/iwmc3200wifi/debugfs.c | 4 ++ drivers/net/wireless/iwmc3200wifi/sdio.c | 1 + drivers/net/wireless/libertas/debugfs.c | 2 + drivers/net/wireless/ray_cs.c | 2 + drivers/net/wireless/rt2x00/rt2x00debug.c | 5 +++ drivers/net/wireless/wl12xx/wl1251_debugfs.c | 4 ++ drivers/net/wireless/wl12xx/wl1271_debugfs.c | 6 +++- drivers/oprofile/oprofile_files.c | 8 ++++- drivers/oprofile/oprofilefs.c | 3 ++ drivers/pci/pcie/aer/aer_inject.c | 1 + drivers/platform/x86/sony-laptop.c | 1 + drivers/rtc/rtc-m41t80.c | 1 + drivers/s390/block/dasd_eer.c | 1 + drivers/s390/char/fs3270.c | 1 + drivers/s390/char/monreader.c | 1 + drivers/s390/char/monwriter.c | 1 + drivers/s390/char/tape_char.c | 1 + drivers/s390/char/vmcp.c | 1 + drivers/s390/char/vmlogrdr.c | 1 + drivers/s390/char/vmwatchdog.c | 1 + drivers/s390/char/zcore.c | 2 + drivers/s390/cio/chsc_sch.c | 1 + drivers/s390/cio/css.c | 1 + drivers/s390/crypto/zcrypt_api.c | 3 +- drivers/s390/scsi/zfcp_cfdc.c | 3 +- drivers/sbus/char/display7seg.c | 1 + drivers/sbus/char/envctrl.c | 1 + drivers/scsi/3w-9xxx.c | 3 +- drivers/scsi/3w-sas.c | 3 +- drivers/scsi/3w-xxxx.c | 3 +- drivers/scsi/aacraid/linit.c | 1 + drivers/scsi/ch.c | 1 + drivers/scsi/dpt_i2o.c | 1 + drivers/scsi/gdth.c | 1 + drivers/scsi/megaraid.c | 1 + drivers/scsi/megaraid/megaraid_mm.c | 1 + drivers/scsi/megaraid/megaraid_sas.c | 1 + drivers/scsi/mpt2sas/mpt2sas_ctl.c | 1 + drivers/scsi/osd/osd_uld.c | 1 + drivers/scsi/pmcraid.c | 1 + drivers/scsi/qla2xxx/qla_os.c | 1 + drivers/scsi/scsi_tgt_if.c | 1 + drivers/scsi/sg.c | 1 + drivers/serial/mfd.c | 2 + drivers/spi/dw_spi.c | 1 + drivers/spi/spidev.c | 1 + drivers/staging/batman-adv/bat_debugfs.c | 1 + drivers/staging/batman-adv/icmp_socket.c | 1 + drivers/staging/comedi/comedi_fops.c | 1 + drivers/staging/crystalhd/crystalhd_lnx.c | 1 + drivers/staging/dream/camera/msm_camera.c | 3 ++ drivers/staging/dream/pmem.c | 2 + drivers/staging/dream/qdsp5/adsp_driver.c | 1 + drivers/staging/dream/qdsp5/audio_aac.c | 1 + drivers/staging/dream/qdsp5/audio_amrnb.c | 1 + drivers/staging/dream/qdsp5/audio_evrc.c | 1 + drivers/staging/dream/qdsp5/audio_in.c | 2 + drivers/staging/dream/qdsp5/audio_mp3.c | 1 + drivers/staging/dream/qdsp5/audio_out.c | 2 + drivers/staging/dream/qdsp5/audio_qcelp.c | 1 + drivers/staging/dream/qdsp5/evlog.h | 1 + drivers/staging/dream/qdsp5/snd.c | 1 + drivers/staging/frontier/alphatrack.c | 1 + drivers/staging/frontier/tranzport.c | 1 + drivers/staging/iio/industrialio-core.c | 1 + drivers/staging/iio/industrialio-ring.c | 1 + drivers/staging/lirc/lirc_imon.c | 3 +- drivers/staging/lirc/lirc_it87.c | 1 + drivers/staging/lirc/lirc_sasem.c | 1 + drivers/staging/lirc/lirc_serial.c | 1 + drivers/staging/lirc/lirc_sir.c | 1 + drivers/staging/memrar/memrar_handler.c | 1 + drivers/staging/panel/panel.c | 1 + drivers/staging/tidspbridge/rmgr/drv_interface.c | 1 + drivers/telephony/ixj.c | 3 +- drivers/telephony/phonedev.c | 1 + drivers/uio/uio.c | 1 + drivers/usb/class/cdc-wdm.c | 3 +- drivers/usb/class/usblp.c | 1 + drivers/usb/class/usbtmc.c | 1 + drivers/usb/core/file.c | 1 + drivers/usb/gadget/f_hid.c | 1 + drivers/usb/gadget/printer.c | 3 +- drivers/usb/host/ehci-dbg.c | 4 ++ drivers/usb/host/ohci-dbg.c | 3 ++ drivers/usb/image/mdc800.c | 1 + drivers/usb/misc/adutux.c | 1 + drivers/usb/misc/idmouse.c | 1 + drivers/usb/misc/iowarrior.c | 1 + drivers/usb/misc/ldusb.c | 1 + drivers/usb/misc/rio500.c | 1 + drivers/usb/misc/usblcd.c | 1 + drivers/usb/usb-skeleton.c | 1 + drivers/vhost/net.c | 1 + drivers/video/fbmem.c | 1 + drivers/video/mbx/mbxdebugfs.c | 6 ++++ drivers/watchdog/ar7_wdt.c | 1 + drivers/watchdog/cpwd.c | 1 + drivers/watchdog/ep93xx_wdt.c | 1 + drivers/watchdog/omap_wdt.c | 1 + drivers/xen/evtchn.c | 1 + drivers/xen/xenfs/super.c | 1 + drivers/xen/xenfs/xenbus.c | 1 + fs/afs/mntpt.c | 1 + fs/autofs4/dev-ioctl.c | 1 + fs/binfmt_misc.c | 3 ++ fs/btrfs/super.c | 1 + fs/cachefiles/daemon.c | 1 + fs/char_dev.c | 1 + fs/coda/pioctl.c | 1 + fs/coda/psdev.c | 1 + fs/debugfs/file.c | 3 ++ fs/dlm/debug_fs.c | 3 +- fs/dlm/plock.c | 3 +- fs/dlm/user.c | 3 ++ fs/ecryptfs/file.c | 1 + fs/ecryptfs/miscdev.c | 1 + fs/eventfd.c | 1 + fs/eventpoll.c | 3 +- fs/fifo.c | 1 + fs/fuse/control.c | 4 ++ fs/fuse/cuse.c | 1 + fs/gfs2/file.c | 2 + fs/hppfs/hppfs.c | 1 + fs/hugetlbfs/inode.c | 1 + fs/logfs/dir.c | 1 + fs/nfsd/nfsctl.c | 1 + fs/no-block.c | 1 + fs/notify/fanotify/fanotify_user.c | 1 + fs/notify/inotify/inotify_user.c | 1 + fs/ntfs/file.c | 3 +- fs/ocfs2/dlmfs/dlmfs.c | 1 + fs/ocfs2/stack_user.c | 1 + fs/proc/base.c | 8 +++++ fs/proc/proc_sysctl.c | 1 + fs/proc/root.c | 1 + fs/proc/task_mmu.c | 1 + fs/read_write.c | 5 +-- fs/romfs/super.c | 1 + fs/signalfd.c | 1 + fs/squashfs/dir.c | 3 +- fs/timerfd.c | 1 + fs/ubifs/debug.c | 1 + include/linux/fs.h | 1 + ipc/mqueue.c | 1 + ipc/shm.c | 2 + kernel/configs.c | 1 + kernel/gcov/fs.c | 1 + kernel/kprobes.c | 1 + kernel/pm_qos_params.c | 1 + kernel/profile.c | 1 + kernel/trace/blktrace.c | 2 + kernel/trace/ftrace.c | 2 + kernel/trace/ring_buffer.c | 1 + kernel/trace/trace_events.c | 6 ++++ kernel/trace/trace_stack.c | 1 + lib/dma-debug.c | 1 + net/atm/proc.c | 1 + net/dccp/probe.c | 1 + net/ipv4/tcp_probe.c | 1 + net/irda/irnet/irnet_ppp.h | 3 +- net/mac80211/debugfs.c | 21 ++++++++++---- net/mac80211/debugfs_key.c | 2 + net/mac80211/debugfs_netdev.c | 1 + net/mac80211/debugfs_sta.c | 2 + net/mac80211/rate.c | 1 + net/mac80211/rc80211_minstrel_debugfs.c | 1 + net/mac80211/rc80211_minstrel_ht_debugfs.c | 3 +- net/mac80211/rc80211_pid_debugfs.c | 1 + net/netfilter/xt_recent.c | 1 + net/nonet.c | 1 + net/rfkill/core.c | 1 + net/sctp/probe.c | 1 + net/socket.c | 1 + net/sunrpc/cache.c | 2 + net/wireless/debugfs.c | 2 + samples/kfifo/bytestream-example.c | 1 + samples/kfifo/inttype-example.c | 1 + samples/kfifo/record-example.c | 1 + samples/tracepoints/tracepoint-sample.c | 1 + security/apparmor/apparmorfs.c | 9 ++++-- security/inode.c | 1 + security/smack/smackfs.c | 5 +++ sound/core/seq/oss/seq_oss.c | 1 + sound/core/sound.c | 3 +- sound/oss/msnd_pinnacle.c | 1 + sound/oss/sh_dac_audio.c | 1 + sound/soc/soc-core.c | 1 + sound/soc/soc-dapm.c | 1 + sound/sound_core.c | 1 + virt/kvm/kvm_main.c | 3 ++ 376 files changed, 628 insertions(+), 79 deletions(-)
Cc: Al Viro <viro-RmSDqhL/[email protected]>
Cc: Christoph Hellwig <[email protected]>
Cc: David Airlie <[email protected]>
Cc: [email protected]
Cc: Jeremy Kerr <[email protected]>
Cc: "John W. Linville" <[email protected]>
Cc: Julia Lawall <[email protected]>
Cc: Linus Torvalds <torvalds-de/[email protected]>
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]
Cc: Samuel Ortiz <[email protected]>
Cc: Stephen Rothwell <[email protected]>
Cc: Tony Lindgren <[email protected]> --
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
Arnd Bergmann
maintainerPATCH 1/15 drm: use noop_llseek
The drm device drivers currently allow seeking on the character device but never care about the actual file position.
When we change the default llseek operation to be no_llseek, calling llseek on a drm device would return an error condition, which is an API change.
Explicitly setting noop_llseek lets us keep the current API.
--- Documentation/DocBook/drm.tmpl | 1 + drivers/gpu/drm/i810/i810_drv.c | 1 + drivers/gpu/drm/i830/i830_drv.c | 1 + drivers/gpu/drm/i915/i915_drv.c | 1 + drivers/gpu/drm/mga/mga_drv.c | 1 + drivers/gpu/drm/nouveau/nouveau_drv.c | 1 + drivers/gpu/drm/r128/r128_drv.c | 1 + drivers/gpu/drm/radeon/radeon_drv.c | 1 + drivers/gpu/drm/savage/savage_drv.c | 1 + drivers/gpu/drm/sis/sis_drv.c | 1 + drivers/gpu/drm/tdfx/tdfx_drv.c | 1 + drivers/gpu/drm/via/via_drv.c | 1 + drivers/gpu/drm/vmwgfx/vmwgfx_drv.c | 1 + 13 files changed, 13 insertions(+), 0 deletions(-)
Documentation/DocBook/drm.tmpl +1 -0
@@ -136,6 +136,7 @@ #ifdef CONFIG_COMPAT .compat_ioctl = i915_compat_ioctl, #endif + .llseek = noop_llseek, }, .pci_driver = { .name = DRIVER_NAME,
drivers/gpu/drm/i810/i810_drv.c +1 -0
@@ -63,6 +63,7 @@ static struct drm_driver driver = { .mmap = drm_mmap, .poll = drm_poll, .fasync = drm_fasync, + .llseek = noop_llseek, }, .pci_driver = {
drivers/gpu/drm/i830/i830_drv.c +1 -0
@@ -74,6 +74,7 @@ static struct drm_driver driver = { .mmap = drm_mmap, .poll = drm_poll, .fasync = drm_fasync, + .llseek = noop_llseek, }, .pci_driver = {
drivers/gpu/drm/i915/i915_drv.c +1 -0
@@ -548,6 +548,7 @@ static struct drm_driver driver = {#ifdef CONFIG_COMPAT .compat_ioctl = i915_compat_ioctl, #endif + .llseek = noop_llseek, }, .pci_driver = {
drivers/gpu/drm/mga/mga_drv.c +1 -0
@@ -75,6 +75,7 @@ static struct drm_driver driver = { #ifdef CONFIG_COMPAT .compat_ioctl = mga_compat_ioctl, #endif + .llseek = noop_llseek, }, .pci_driver = { .name = DRIVER_NAME,
drivers/gpu/drm/nouveau/nouveau_drv.c +1 -0
@@ -393,6 +393,7 @@ static struct drm_driver driver = { #if defined(CONFIG_COMPAT) .compat_ioctl = nouveau_compat_ioctl, #endif + .llseek = noop_llseek, }, .pci_driver = { .name = DRIVER_NAME,
drivers/gpu/drm/r128/r128_drv.c +1 -0
@@ -71,6 +71,7 @@ static struct drm_driver driver = { #ifdef CONFIG_COMPAT .compat_ioctl = r128_compat_ioctl, #endif + .llseek = noop_llseek, }, .pci_driver = { .name = DRIVER_NAME,
drivers/gpu/drm/radeon/radeon_drv.c +1 -0
@@ -219,6 +219,7 @@ static struct drm_driver driver_old = {#ifdef CONFIG_COMPAT .compat_ioctl = radeon_compat_ioctl, #endif + .llseek = noop_llseek, }, .pci_driver = {
drivers/gpu/drm/savage/savage_drv.c +1 -0
@@ -54,6 +54,7 @@ static struct drm_driver driver = { .mmap = drm_mmap, .poll = drm_poll, .fasync = drm_fasync, + .llseek = noop_llseek, }, .pci_driver = {
drivers/gpu/drm/sis/sis_drv.c +1 -0
@@ -83,6 +83,7 @@ static struct drm_driver driver = { .mmap = drm_mmap, .poll = drm_poll, .fasync = drm_fasync, + .llseek = noop_llseek, }, .pci_driver = { .name = DRIVER_NAME,
drivers/gpu/drm/tdfx/tdfx_drv.c +1 -0
@@ -52,6 +52,7 @@ static struct drm_driver driver = { .mmap = drm_mmap, .poll = drm_poll, .fasync = drm_fasync, + .llseek = noop_llseek, }, .pci_driver = { .name = DRIVER_NAME,
drivers/gpu/drm/via/via_drv.c +1 -0
@@ -62,6 +62,7 @@ static struct drm_driver driver = { .mmap = drm_mmap, .poll = drm_poll, .fasync = drm_fasync, + .llseek = noop_llseek, }, .pci_driver = { .name = DRIVER_NAME,
drivers/gpu/drm/vmwgfx/vmwgfx_drv.c +1 -0
@@ -745,6 +745,7 @@ static struct drm_driver driver = { #if defined(CONFIG_COMPAT) .compat_ioctl = drm_compat_ioctl, #endif + .llseek = noop_llseek, }, .pci_driver = { .name = VMWGFX_DRIVER_NAME,
Signature · 1 line
1.7.1
Arnd Bergmann
maintainerPATCH 2/15 net/wireless: use generic_file_llseek in debugfs
In reply to Arnd BergmannThe default llseek operation is changing from default_llseek to no_llseek, so all code relying on the current behaviour needs to make that explicit.
The wireless driver infrastructure and some of the drivers make use of generated debugfs files, so they cannot be converted by our script that automatically determines the right operation.
All these files use debugfs and they typically rely on simple_read_from_buffer, so the best llseek operation here is generic_file_llseek.
--- drivers/misc/iwmc3200top/debugfs.c | 3 +++ drivers/net/wireless/b43/debugfs.c | 1 + drivers/net/wireless/b43legacy/debugfs.c | 1 + drivers/net/wireless/iwlwifi/iwl-debugfs.c | 3 +++ drivers/net/wireless/libertas/debugfs.c | 1 + drivers/net/wireless/rt2x00/rt2x00debug.c | 1 + drivers/net/wireless/wl12xx/wl1251_debugfs.c | 2 ++ drivers/net/wireless/wl12xx/wl1271_debugfs.c | 2 ++ net/mac80211/debugfs.c | 2 ++ net/mac80211/debugfs_key.c | 2 ++ net/mac80211/debugfs_netdev.c | 1 + net/mac80211/debugfs_sta.c | 2 ++ net/wireless/debugfs.c | 1 + 13 files changed, 22 insertions(+), 0 deletions(-)
drivers/misc/iwmc3200top/debugfs.c +3 -0
@@ -71,6 +71,7 @@ ssize_t iwmct_dbgfs_##name##_write(struct file *file, \ static const struct file_operations iwmct_dbgfs_##name##_ops = { \ .read = iwmct_dbgfs_##name##_read, \ .open = iwmct_dbgfs_open_file_generic, \ + .llseek = generic_file_llseek, \ };#define DEBUGFS_WRITE_FILE_OPS (name) \
@@ -78,6 +79,7 @@ ssize_t iwmct_dbgfs_##name##_write(struct file *file, \ static const struct file_operations iwmct_dbgfs_##name##_ops = { \ .write = iwmct_dbgfs_##name##_write, \ .open = iwmct_dbgfs_open_file_generic, \ + .llseek = generic_file_llseek, \ };#define DEBUGFS_READ_WRITE_FILE_OPS (name) \
@@ -87,6 +89,7 @@ ssize_t iwmct_dbgfs_##name##_write(struct file *file, \ .write = iwmct_dbgfs_##name##_write, \ .read = iwmct_dbgfs_##name##_read, \ .open = iwmct_dbgfs_open_file_generic, \ + .llseek = generic_file_llseek, \ };
drivers/net/wireless/b43/debugfs.c +1 -0
@@ -627,6 +627,7 @@ out_unlock: .open = b43_debugfs_open, \ .read = b43_debugfs_read, \ .write = b43_debugfs_write, \ + .llseek = generic_file_llseek, \ }, \ .file_struct_offset = offsetof(struct b43_dfsentry, \ file_##name), \
drivers/net/wireless/b43legacy/debugfs.c +1 -0
@@ -334,6 +334,7 @@ out_unlock: .open = b43legacy_debugfs_open, \ .read = b43legacy_debugfs_read, \ .write = b43legacy_debugfs_write, \ + .llseek = generic_file_llseek, \ }, \ .file_struct_offset = offsetof(struct b43legacy_dfsentry, \ file_##name), \
drivers/net/wireless/iwlwifi/iwl-debugfs.c +3 -0
@@ -87,6 +87,7 @@ static int iwl_dbgfs_open_file_generic(struct inode *inode, struct file *file) static const struct file_operations iwl_dbgfs_##name##_ops = { \ .read = iwl_dbgfs_##name##_read, \ .open = iwl_dbgfs_open_file_generic, \ + .llseek = generic_file_llseek, \ };#define DEBUGFS_WRITE_FILE_OPS (name) \
@@ -94,6 +95,7 @@ static const struct file_operations iwl_dbgfs_##name##_ops = { \ static const struct file_operations iwl_dbgfs_##name##_ops = { \ .write = iwl_dbgfs_##name##_write, \ .open = iwl_dbgfs_open_file_generic, \ + .llseek = generic_file_llseek, \ };
@@ -104,6 +106,7 @@ static const struct file_operations iwl_dbgfs_##name##_ops = { \ .write = iwl_dbgfs_##name##_write, \ .read = iwl_dbgfs_##name##_read, \ .open = iwl_dbgfs_open_file_generic, \ + .llseek = generic_file_llseek, \ }; static ssize_t iwl_dbgfs_tx_statistics_read(struct file *file,
drivers/net/wireless/libertas/debugfs.c +1 -0
@@ -696,6 +696,7 @@ out_unlock: .open = open_file_generic, \ .read = (fread), \ .write = (fwrite), \ + .llseek = generic_file_llseek, \ }struct lbs_debugfs_files {
drivers/net/wireless/rt2x00/rt2x00debug.c +1 -0
@@ -509,6 +509,7 @@ static const struct file_operations rt2x00debug_fop_##__name = {\ .write = rt2x00debug_write_##__name, \ .open = rt2x00debug_file_open, \ .release = rt2x00debug_file_release, \ + .llseek = generic_file_llseek, \ };RT2X00DEBUGFS_OPS (csr,"0x%.8x\n" , u32);
drivers/net/wireless/wl12xx/wl1251_debugfs.c +2 -0
@@ -50,6 +50,7 @@ static ssize_t name## _read(struct file *file, char __user *userbuf, \ static const struct file_operations name## _ops = { \ .read = name## _read, \ .open = wl1251_open_file_generic, \ + .llseek = generic_file_llseek, \ };#define DEBUGFS_ADD (name, parent) \
@@ -86,6 +87,7 @@ static ssize_t sub## _ ##name## _read(struct file *file, \ static const struct file_operations sub## _ ##name## _ops = { \ .read = sub## _ ##name## _read, \ .open = wl1251_open_file_generic, \ + .llseek = generic_file_llseek, \ };#define DEBUGFS_FWSTATS_ADD (sub, name) \
drivers/net/wireless/wl12xx/wl1271_debugfs.c +2 -0
@@ -51,6 +51,7 @@ static ssize_t name## _read(struct file *file, char __user *userbuf, \ static const struct file_operations name## _ops = { \ .read = name## _read, \ .open = wl1271_open_file_generic, \ + .llseek = generic_file_llseek, \ };#define DEBUGFS_ADD (name, parent) \
@@ -87,6 +88,7 @@ static ssize_t sub## _ ##name## _read(struct file *file, \ static const struct file_operations sub## _ ##name## _ops = { \ .read = sub## _ ##name## _read, \ .open = wl1271_open_file_generic, \ + .llseek = generic_file_llseek, \ };#define DEBUGFS_FWSTATS_ADD (sub, name) \
net/mac80211/debugfs.c +2 -0
@@ -36,6 +36,7 @@ static ssize_t name## _read(struct file *file, char __user *userbuf, \ static const struct file_operations name## _ops = { \ .read = name## _read, \ .open = mac80211_open_file_generic, \ + .llseek = generic_file_llseek, \ };#define DEBUGFS_ADD (name) \
@@ -346,6 +347,7 @@ static ssize_t stats_ ##name## _read(struct file *file, \ static const struct file_operations stats_ ##name## _ops = { \ .read = stats_ ##name## _read, \ .open = mac80211_open_file_generic, \ + .llseek = generic_file_llseek, \ };#define DEBUGFS_STATS_ADD (name, field) \
net/mac80211/debugfs_key.c +2 -0
@@ -32,6 +32,7 @@ static ssize_t key_##name##_read(struct file *file, \ static const struct file_operations key_ ##name## _ops = { \ .read = key_##name##_read, \ .open = mac80211_open_file_generic, \ + .llseek = generic_file_llseek, \ }#define KEY_FILE (name, format) \
@@ -46,6 +47,7 @@ static const struct file_operations key_ ##name## _ops = { \ static const struct file_operations key_ ##name## _ops = { \ .read = key_conf_##name##_read, \ .open = mac80211_open_file_generic, \ + .llseek = generic_file_llseek, \ }#define KEY_CONF_FILE (name, format) \
net/mac80211/debugfs_netdev.c +1 -0
@@ -121,6 +121,7 @@ static const struct file_operations name##_ops = { \ .read = ieee80211_if_read_##name, \ .write = (_write), \ .open = mac80211_open_file_generic, \ + .llseek = generic_file_llseek, \ }#define __IEEE80211_IF_FILE_W (name) \
net/mac80211/debugfs_sta.c +2 -0
@@ -36,6 +36,7 @@ static ssize_t sta_ ##name## _read(struct file *file, \ static const struct file_operations sta_ ##name## _ops = { \ .read = sta_##name##_read, \ .open = mac80211_open_file_generic, \ + .llseek = generic_file_llseek, \ }#define STA_OPS_RW (name) \
@@ -43,6 +44,7 @@ static const struct file_operations sta_ ##name## _ops = { \ .read = sta_##name##_read, \ .write = sta_##name##_write, \ .open = mac80211_open_file_generic, \ + .llseek = generic_file_llseek, \ }#define STA_FILE (name, field, format) \
net/wireless/debugfs.c +1 -0
@@ -34,6 +34,7 @@ static ssize_t name## _read(struct file *file, char __user *userbuf, \ static const struct file_operations name## _ops = { \ .read = name## _read, \ .open = cfg80211_open_file_generic, \ + .llseek = generic_file_llseek, \ }; DEBUGFS_READONLY_FILE(rts_threshold, 20, "%d",
Signature · 1 line
1.7.1
Christian Lamparter
maintainerPATCH 1/1 carl9170: use generic_file_llseek in debugfs
Quoted 7 lines · On Tuesday 14 September 2010 22:22:30 Arnd Bergmann wrote:
The default llseek operation is changing from
default_llseektono_llseek, so all code relying on the current behaviour needs to make that explicit.All these files use debugfs and they typically rely on
simple_read_from_buffer, so the best llseek operation here isgeneric_file_llseek.
---
drivers/net/wireless/ath/carl9170/debug.c +1 -0
@@ -181,6 +181,7 @@ static const struct carl9170_debugfs_fops carl_debugfs_##name ##_ops = {\ .open = carl9170_debugfs_open, \ .read = carl9170_debugfs_read, \ .write = carl9170_debugfs_write, \ + .llseek = generic_file_llseek, \ .owner =THIS_MODULE \ }, \ }
Arnd Bergmann
maintainerPATCH 3/15 lkdtm: use generic_file_llseek in debugfs
In reply to Arnd BergmannWhen the default llseek behavior gets changed to not allowing seek, all file operations that rely on the current behaviour need to use an explicit .llseek operation.
The files that lkdtm uses in debugfs are regular files and they get read using simple_read_from_buffer, so generic_file_llseek is the right operation.
--- drivers/misc/lkdtm.c | 9 +++++++++ 1 files changed, 9 insertions(+), 0 deletions(-)
drivers/misc/lkdtm.c +9 -0
@@ -575,30 +575,39 @@ struct crash_entry {static const struct crash_entry crash_entries[] = { {"DIRECT" , {.read = lkdtm_debugfs_read, + .llseek = generic_file_llseek, .open = lkdtm_debugfs_open, .write = direct_entry} }, {"INT_HARDWARE_ENTRY" , {.read = lkdtm_debugfs_read, + .llseek = generic_file_llseek, .open = lkdtm_debugfs_open, .write = int_hardware_entry} }, {"INT_HW_IRQ_EN" , {.read = lkdtm_debugfs_read, + .llseek = generic_file_llseek, .open = lkdtm_debugfs_open, .write = int_hw_irq_en} }, {"INT_TASKLET_ENTRY" , {.read = lkdtm_debugfs_read, + .llseek = generic_file_llseek, .open = lkdtm_debugfs_open, .write = int_tasklet_entry} }, {"FS_DEVRW" , {.read = lkdtm_debugfs_read, + .llseek = generic_file_llseek, .open = lkdtm_debugfs_open, .write = fs_devrw_entry} }, {"MEM_SWAPOUT" , {.read = lkdtm_debugfs_read, + .llseek = generic_file_llseek, .open = lkdtm_debugfs_open, .write = mem_swapout_entry} }, {"TIMERADD" , {.read = lkdtm_debugfs_read, + .llseek = generic_file_llseek, .open = lkdtm_debugfs_open, .write = timeradd_entry} }, {"SCSI_DISPATCH_CMD" , {.read = lkdtm_debugfs_read, + .llseek = generic_file_llseek, .open = lkdtm_debugfs_open, .write = scsi_dispatch_cmd_entry} }, {"IDE_CORE_CP" , {.read = lkdtm_debugfs_read, + .llseek = generic_file_llseek, .open = lkdtm_debugfs_open, .write = ide_core_cp_entry} }, };
Signature · 1 line
1.7.1
Arnd Bergmann
maintainerPATCH 4/15 arm/omap: use generic_file_llseek in iommu_debug
In reply to Arnd BergmannIn future kernels, debugfs files need to specify the llseek operation explicitly to allow seeking. This sets the llseek operation in the omap iommu debugfs files to generic_file_llseek, which is appropriate for files using simple_read_from_buffer.
--- arch/arm/plat-omap/iommu-debug.c | 2 ++ 1 files changed, 2 insertions(+), 0 deletions(-)
arch/arm/plat-omap/iommu-debug.c +2 -0
@@ -328,12 +328,14 @@ static int debug_open_generic(struct inode *inode, struct file *file) .open = debug_open_generic, \ .read = debug_read_##name, \ .write = debug_write_##name, \ + .llseek = generic_file_llseek, \ };#define DEBUG_FOPS_RO (name) \ static const struct file_operations debug_##name##_fops = { \ .open = debug_open_generic, \ .read = debug_read_##name, \ + .llseek = generic_file_llseek, \ };DEBUG_FOPS_RO (ver);
Signature · 1 line
1.7.1
Arnd Bergmann
maintainerPATCH 5/15 spufs: use llseek in all file operations
In reply to Arnd BergmannThe default for llseek is changing, so we need
explicit operations everywhere.
--- arch/powerpc/platforms/cell/spufs/file.c | 18 ++++++++++++++++++ 1 files changed, 18 insertions(+), 0 deletions(-)
arch/powerpc/platforms/cell/spufs/file.c +18 -0
@@ -154,6 +154,7 @@ static const struct file_operations __fops = { \ .release = spufs_attr_release, \ .read = spufs_attr_read, \ .write = spufs_attr_write, \ + .llseek = generic_file_llseek, \ };
@@ -521,6 +522,7 @@ static const struct file_operations spufs_cntl_fops = { .release = spufs_cntl_release, .read = simple_attr_read, .write = simple_attr_write, + .llseek = generic_file_llseek, .mmap = spufs_cntl_mmap, };
@@ -714,6 +716,7 @@ static ssize_t spufs_mbox_read(struct file *file, char __user *buf,static const struct file_operations spufs_mbox_fops = { .open = spufs_pipe_open, .read = spufs_mbox_read, + .llseek = no_llseek, }; static ssize_t spufs_mbox_stat_read(struct file *file, char __user *buf,
@@ -743,6 +746,7 @@ static ssize_t spufs_mbox_stat_read(struct file *file, char __user *buf,static const struct file_operations spufs_mbox_stat_fops = { .open = spufs_pipe_open, .read = spufs_mbox_stat_read, + .llseek = no_llseek, };/* low-level ibox access function */
@@ -863,6 +867,7 @@ static const struct file_operations spufs_ibox_fops = { .read = spufs_ibox_read, .poll = spufs_ibox_poll, .fasync = spufs_ibox_fasync, + .llseek = no_llseek, }; static ssize_t spufs_ibox_stat_read(struct file *file, char __user *buf,
@@ -890,6 +895,7 @@ static ssize_t spufs_ibox_stat_read(struct file *file, char __user *buf,static const struct file_operations spufs_ibox_stat_fops = { .open = spufs_pipe_open, .read = spufs_ibox_stat_read, + .llseek = no_llseek, };/* low-level mailbox write */
@@ -1011,6 +1017,7 @@ static const struct file_operations spufs_wbox_fops = { .write = spufs_wbox_write, .poll = spufs_wbox_poll, .fasync = spufs_wbox_fasync, + .llseek = no_llseek, }; static ssize_t spufs_wbox_stat_read(struct file *file, char __user *buf,
@@ -1038,6 +1045,7 @@ static ssize_t spufs_wbox_stat_read(struct file *file, char __user *buf,static const struct file_operations spufs_wbox_stat_fops = { .open = spufs_pipe_open, .read = spufs_wbox_stat_read, + .llseek = no_llseek, };static int spufs_signal1_open (struct inode *inode,struct file *file)
@@ -1166,6 +1174,7 @@ static const struct file_operations spufs_signal1_fops = { .read = spufs_signal1_read, .write = spufs_signal1_write, .mmap = spufs_signal1_mmap, + .llseek = no_llseek, };static const struct file_operations spufs_signal1_nosched_fops = {
@@ -1173,6 +1182,7 @@ static const struct file_operations spufs_signal1_nosched_fops = { .release = spufs_signal1_release, .write = spufs_signal1_write, .mmap = spufs_signal1_mmap, + .llseek = no_llseek, };static int spufs_signal2_open (struct inode *inode,struct file *file)
@@ -1305,6 +1315,7 @@ static const struct file_operations spufs_signal2_fops = { .read = spufs_signal2_read, .write = spufs_signal2_write, .mmap = spufs_signal2_mmap, + .llseek = no_llseek, };static const struct file_operations spufs_signal2_nosched_fops = {
@@ -1312,6 +1323,7 @@ static const struct file_operations spufs_signal2_nosched_fops = { .release = spufs_signal2_release, .write = spufs_signal2_write, .mmap = spufs_signal2_mmap, + .llseek = no_llseek, };/*
@@ -1451,6 +1463,7 @@ static const struct file_operations spufs_mss_fops = { .open = spufs_mss_open, .release = spufs_mss_release, .mmap = spufs_mss_mmap, + .llseek = no_llseek, }; static int
@@ -1508,6 +1521,7 @@ static const struct file_operations spufs_psmap_fops = { .open = spufs_psmap_open, .release = spufs_psmap_release, .mmap = spufs_psmap_mmap, + .llseek = no_llseek, };
@@ -1871,6 +1885,7 @@ static const struct file_operations spufs_mfc_fops = { .fsync = spufs_mfc_fsync, .fasync = spufs_mfc_fasync, .mmap = spufs_mfc_mmap, + .llseek = no_llseek, };static int spufs_npc_set (void *data,u64 val)
@@ -2246,6 +2261,7 @@ static ssize_t spufs_dma_info_read(struct file *file, char __user *buf,static const struct file_operations spufs_dma_info_fops = { .open = spufs_info_open, .read = spufs_dma_info_read, + .llseek = no_llseek, }; static ssize_t __spufs_proxydma_info_read(struct spu_context *ctx,
@@ -2299,6 +2315,7 @@ static ssize_t spufs_proxydma_info_read(struct file *file, char __user *buf,static const struct file_operations spufs_proxydma_info_fops = { .open = spufs_info_open, .read = spufs_proxydma_info_read, + .llseek = no_llseek, };static int spufs_show_tid (struct seq_file *s,void *private)
@@ -2585,6 +2602,7 @@ static const struct file_operations spufs_switch_log_fops = { .read = spufs_switch_log_read, .poll = spufs_switch_log_poll, .release = spufs_switch_log_release, + .llseek = no_llseek, };/**
Signature · 1 line
1.7.1
Arnd Bergmann
maintainerPATCH 6/15 ibmasmfs: use generic_file_llseek
In reply to Arnd BergmannThe default for llseek will change to no_llseek, so ibmasmfs needs to add explicit .llseek assignments. Since we're dealing with regular files from a VFS perspective, use generic_file_llseek.
--- drivers/misc/ibmasm/ibmasmfs.c | 4 ++++ 1 files changed, 4 insertions(+), 0 deletions(-)
drivers/misc/ibmasm/ibmasmfs.c +4 -0
@@ -584,6 +584,7 @@ static const struct file_operations command_fops = { .release = command_file_close, .read = command_file_read, .write = command_file_write, + .llseek = generic_file_llseek, };static const struct file_operations event_fops = {
@@ -591,6 +592,7 @@ static const struct file_operations event_fops = { .release = event_file_close, .read = event_file_read, .write = event_file_write, + .llseek = generic_file_llseek, };static const struct file_operations r_heartbeat_fops = {
@@ -598,6 +600,7 @@ static const struct file_operations r_heartbeat_fops = { .release = r_heartbeat_file_close, .read = r_heartbeat_file_read, .write = r_heartbeat_file_write, + .llseek = generic_file_llseek, };static const struct file_operations remote_settings_fops = {
@@ -605,6 +608,7 @@ static const struct file_operations remote_settings_fops = { .release = remote_settings_file_close, .read = remote_settings_file_read, .write = remote_settings_file_write, + .llseek = generic_file_llseek, };
Signature · 1 line
1.7.1
Arnd Bergmann
maintainerPATCH 7/15 raw: use explicit llseek file operations
In reply to Arnd BergmannThe raw_fops may need to seek, so there should be an explicit reference to default_llseek. raw_ctl_fops does not contain a read or write method, so we use noop_llseek to ignore seeking requests without an error.
--- drivers/char/raw.c | 2 ++ 1 files changed, 2 insertions(+), 0 deletions(-)
drivers/char/raw.c +2 -0
@@ -258,6 +258,7 @@ static const struct file_operations raw_fops = { .open = raw_open, .release = raw_release, .unlocked_ioctl = raw_ioctl, + .llseek = default_llseek, .owner = THIS_MODULE, };
@@ -265,6 +266,7 @@ static const struct file_operations raw_ctl_fops = { .unlocked_ioctl = raw_ctl_ioctl, .open = raw_open, .owner = THIS_MODULE, + .llseek = noop_llseek, };static struct cdev raw_cdev;
Signature · 1 line
1.7.1
Arnd Bergmann
maintainerPATCH 8/15 irda/irnet: use noop_llseek
In reply to Arnd BergmannThere may be applications trying to seek on the irnet character device, so we should use noop_llseek to avoid returning an error when the default llseek changes to no_llseek.
--- net/irda/irnet/irnet_ppp.h | 3 ++- 1 files changed, 2 insertions(+), 1 deletions(-)
net/irda/irnet/irnet_ppp.h +2 -1
@@ -103,7 +103,8 @@ static const struct file_operations irnet_device_fops = .poll = dev_irnet_poll, .unlocked_ioctl = dev_irnet_ioctl, .open = dev_irnet_open, - .release = dev_irnet_close + .release = dev_irnet_close, + .llseek = noop_llseek,/* Also : llseek, readdir, mmap, flush, fsync, fasync, lock, readv, writev */ };
Signature · 1 line
1.7.1
Re: [PATCH 08/15] irda/irnet: use noop_llseek
From: Arnd Bergmann <[email protected]>
Date: Tue, 14 Sep 2010 22:22:36 +0200
Quoted 6 lines
There may be applications trying to seek on the irnet character device, so we should use
noop_llseekto avoid returning an error when the default llseek changes tono_llseek.Signed-off-by Arnd Bergmann <[email protected]>
Applied.
Arnd Bergmann
maintainerPATCH 9/15 viotape: use noop_llseek
In reply to Arnd BergmannSome applications try to seek on tape devices and fail if they return an error. Since we want to change the default llseek action to no_llseek, viotape needs to be changed to use noop_llseek explicitly.
--- drivers/char/viotape.c | 1 + 1 files changed, 1 insertions(+), 0 deletions(-)
drivers/char/viotape.c +1 -0
@@ -804,6 +804,7 @@ const struct file_operations viotap_fops = { .unlocked_ioctl = viotap_unlocked_ioctl, .open = viotap_open, .release = viotap_release, + .llseek = noop_llseek, };/* Handle interrupt events for tape */
Signature · 1 line
1.7.1
Arnd Bergmann
maintainerPATCH 10/15 lirc: make chardev nonseekable
In reply to Arnd BergmannThere does not seem to be a need for lirc to
allow seeking on the file descriptor, so let's
just disallow this before users start relying
on it.
--- drivers/media/IR/ir-lirc-codec.c | 1 + drivers/media/IR/lirc_dev.c | 2 ++ drivers/staging/lirc/lirc_serial.c | 1 + drivers/staging/lirc/lirc_sir.c | 1 + 4 files changed, 5 insertions(+), 0 deletions(-)
drivers/media/IR/ir-lirc-codec.c +1 -0
@@ -235,6 +235,7 @@ static struct file_operations lirc_fops = { .poll = lirc_dev_fop_poll, .open = lirc_dev_fop_open, .release = lirc_dev_fop_close, + .llseek = no_llseek, };static int ir_lirc_register (struct input_dev *input_dev)
drivers/media/IR/lirc_dev.c +2 -0
@@ -460,6 +460,8 @@ error:mutex_unlock (&lirc_dev_lock); +nonseekable_open (inode, file); +return retval; }EXPORT_SYMBOL (lirc_dev_fop_open);
drivers/staging/lirc/lirc_serial.c +1 -0
@@ -1058,6 +1058,7 @@ static const struct file_operations lirc_fops = { .poll = lirc_dev_fop_poll, .open = lirc_dev_fop_open, .release = lirc_dev_fop_close, + .llseek = no_llseek, };static struct lirc_driver driver = {
drivers/staging/lirc/lirc_sir.c +1 -0
@@ -459,6 +459,7 @@ static const struct file_operations lirc_fops = { .unlocked_ioctl = lirc_ioctl, .open = lirc_dev_fop_open, .release = lirc_dev_fop_close, + .llseek = no_llseek, };static int set_use_inc (void *data)
Signature · 1 line
1.7.1
Arnd Bergmann
maintainerPATCH 11/15 mac80211: disallow seeks in minstrel debug code
In reply to Arnd BergmannNo need for seek here, so let's just use nonseekable_open.
--- net/mac80211/rc80211_minstrel_ht_debugfs.c | 3 ++- 1 files changed, 2 insertions(+), 1 deletions(-)
net/mac80211/rc80211_minstrel_ht_debugfs.c +2 -1
@@ -90,7 +90,7 @@ minstrel_ht_stats_open(struct inode *inode, struct file *file) MINSTREL_TRUNC(mi->avg_ampdu_len * 10) % 10); ms->len = p - ms->buf; -return 0 ; +return nonseekable_open (inode, file); }static const struct file_operations minstrel_ht_stat_fops = {
@@ -98,6 +98,7 @@ static const struct file_operations minstrel_ht_stat_fops = { .open = minstrel_ht_stats_open, .read = minstrel_stats_read, .release = minstrel_stats_release, + .llseek = no_llseek, };void
Signature · 1 line
1.7.1
Arnd Bergmann
maintainerPATCH 12/15 libfs: use generic_file_llseek for simple_attr
In reply to Arnd BergmannSimple attribute files need to be seekable to
allow resetting the file for another read.
--- include/linux/fs.h | 1 + 1 files changed, 1 insertions(+), 0 deletions(-)
include/linux/fs.h +1 -0
@@ -2450,6 +2450,7 @@ static const struct file_operations __fops = { \ .release = simple_attr_release, \ .read = simple_attr_read, \ .write = simple_attr_write, \ + .llseek = generic_file_llseek, \ }; static inline void __attribute__((format(printf, 1, 2)))
Signature · 1 line
1.7.1
Arnd Bergmann
maintainerPATCH 13/15 llseek: automatically add .llseek fop
In reply to Arnd BergmannAll file_operations should get a .llseek operation so we can make nonseekable_open the default for future file operations without a .llseek pointer.
The three cases that we can automatically detect are no_llseek, seq_lseek and default_llseek. For cases where we can we can automatically prove that the file offset is always ignored, we use noop_llseek, which maintains the current behavior of not returning an error from a seek.
New drivers should normally not use noop_llseek but instead use no_llseek and call nonseekable_open at open time. Existing drivers can be converted to do the same when the maintainer knows for certain that no user code relies on calling seek on the device file.
The generated code is often incorrectly indented and right now contains comments that clarify for each added line why a specific variant was chosen. In the version that gets submitted upstream, the comments will be gone and I will manually fix the indentation, because there does not seem to be a way to do that using coccinelle.
Some amount of new code is currently sitting in linux-next that should get the same modifications, which I will do at the end of the merge window.
Many thanks to Julia Lawall for helping me learn to write a semantic patch that does all this.
===== begin semantic patch =====
// This adds an llseek= method to all file operations, // as a preparation for making no_llseek the default. //
// The rules are
// - use no_llseek explicitly if we do nonseekable_open // - use seq_lseek for sequential files
// - use default_llseek if we know we access f_pos // - use noop_llseek if we know we don't access f_pos,
// but we still want to allow users to call lseek
//
@ open1 exists @
identifier nested_open;
@@nested_open(...)
{
<+...nonseekable_open(...)
...+>
}
@ open exists@
identifier open_f;
identifier i, f;
identifier open1.nested_open;
@@
int open_f(struct inode *i, struct file *f) {
<+...
(nonseekable_open(...)
|nested_open(...)
)
...+>
}
@ read disable optional_qualifier exists @ identifier read_f;
identifier f, p, s, off;
type ssize_t, size_t, loff_t;
expression E;
identifier func;
@@ssize_t read_f(struct file *f, char *p, size_t s, loff_t *off) {
<+...
(
*off = E
|
*off += E
|
func(..., off, ...)
|
E = *off
)
...+>
}
@ read_no_fpos disable optional_qualifier exists @ identifier read_f;
identifier f, p, s, off;
type ssize_t, size_t, loff_t;
@@ssize_t read_f(struct file *f, char *p, size_t s, loff_t *off) {
... when != off
}
@ write @
identifier write_f;
identifier f, p, s, off;
type ssize_t, size_t, loff_t;
expression E;
identifier func;
@@ssize_t write_f(struct file *f, const char *p, size_t s, loff_t *off) {
<+...
(
*off = E
|
*off += E
|
func(..., off, ...)
|
E = *off
)
...+>
}
@ write_no_fpos @
identifier write_f;
identifier f, p, s, off;
type ssize_t, size_t, loff_t;
@@ssize_t write_f(struct file *f, const char *p, size_t s, loff_t *off) {
... when != off
}
@ fops0 @
identifier fops;
@@
struct file_operations fops = {
...
};
@ has_llseek depends on fops0 @
identifier fops0.fops;
identifier llseek_f;
@@
struct file_operations fops = {
...
.llseek = llseek_f,
...
};
@ has_read depends on fops0 @
identifier fops0.fops;
identifier read_f;
@@
struct file_operations fops = {
...
.read = read_f,
...
};
@ has_write depends on fops0 @
identifier fops0.fops;
identifier write_f;
@@
struct file_operations fops = {
...
.write = write_f,
...
};
@ has_open depends on fops0 @
identifier fops0.fops;
identifier open_f;
@@
struct file_operations fops = {
...
.open = open_f,
...
};
// use no_llseek if we call nonseekable_open //////////////////////////////////////////// @ nonseekable1 depends on !has_llseek && has_open @ identifier fops0.fops;
identifier nso ~= "nonseekable_open";
@@
struct file_operations fops = {
... .open = nso, ...
+.llseek = no_llseek, /* nonseekable */
};
@ nonseekable2 depends on !has_llseek @ identifier fops0.fops;
identifier open.open_f;
@@
struct file_operations fops = {
... .open = open_f, ...
+.llseek = no_llseek, /* open uses nonseekable */ };
// use seq_lseek for sequential files ///////////////////////////////////// @ seq depends on !has_llseek @ identifier fops0.fops;
identifier sr ~= "seq_read";
@@
struct file_operations fops = {
... .read = sr, ...
+.llseek = seq_lseek, /* we have seq_read */ };
// use default_llseek if there is a readdir ///////////////////////////////////////////
@ fops1 depends on !has_llseek && !nonseekable1 && !nonseekable2 && !seq @ identifier fops0.fops;
identifier readdir_e;
@@
// any other fop is used that changes pos
struct file_operations fops = {
... .readdir = readdir_e, ...
+.llseek = default_llseek, /* readdir is present */
};
// use default_llseek if at least one of read/write touches f_pos /////////////////////////////////////////////////////////////////
@ fops2 depends on !fops1 && !has_llseek && !nonseekable1 && !nonseekable2 && !seq @ identifier fops0.fops;
identifier read.read_f;
@@
// read fops use offset
struct file_operations fops = {
... .read = read_f, ...
+.llseek = default_llseek, /* read accesses f_pos */
};
@ fops3 depends on !fops1 && !fops2 && !has_llseek && !nonseekable1 && !nonseekable2 && !seq @ identifier fops0.fops;
identifier write.write_f;
@@
// write fops use offset
struct file_operations fops = {
... .write = write_f, ...
+ .llseek = default_llseek, /* write accesses f_pos */
};
// Use noop_llseek if neither read nor write accesses f_pos ///////////////////////////////////////////////////////////
@ fops4 depends on !fops1 && !fops2 && !fops3 && !has_llseek && !nonseekable1 && !nonseekable2 && !seq @ identifier fops0.fops;
identifier read_no_fpos.read_f;
identifier write_no_fpos.write_f;
@@
// write fops use offset
struct file_operations fops = {
...
.write = write_f,
.read = read_f,
...
+.llseek = noop_llseek, /* read and write both use no f_pos */
};
@ depends on has_write && !has_read && !fops1 && !fops2 && !has_llseek && !nonseekable1 && !nonseekable2 && !seq @ identifier fops0.fops;
identifier write_no_fpos.write_f;
@@
struct file_operations fops = {
... .write = write_f, ...
+.llseek = noop_llseek, /* write uses no f_pos */
};
@ depends on has_read && !has_write && !fops1 && !fops2 && !has_llseek && !nonseekable1 && !nonseekable2 && !seq @ identifier fops0.fops;
identifier read_no_fpos.read_f;
@@
struct file_operations fops = {
... .read = read_f, ...
+.llseek = noop_llseek, /* read uses no f_pos */
};
@ depends on !has_read && !has_write && !fops1 && !fops2 && !has_llseek && !nonseekable1 && !nonseekable2 && !seq @ identifier fops0.fops;
@@
struct file_operations fops = {
...
+.llseek = noop_llseek, /* no read or write fn */
};
===== End semantic patch =====
--- arch/arm/kernel/etm.c | 1 + arch/arm/mach-msm/last_radio_log.c | 3 +- arch/arm/mach-msm/smd_debug.c | 1 + arch/arm/plat-mxc/audmux-v2.c | 1 + arch/avr32/boards/mimc200/fram.c | 1 + arch/blackfin/kernel/kgdb_test.c | 1 + arch/blackfin/mach-bf561/coreb.c | 1 + arch/cris/arch-v10/drivers/ds1302.c | 1 + arch/cris/arch-v10/drivers/gpio.c | 1 + arch/cris/arch-v10/drivers/i2c.c | 1 + arch/cris/arch-v10/drivers/pcf8563.c | 1 + arch/cris/arch-v10/drivers/sync_serial.c | 3 +- arch/cris/arch-v32/drivers/cryptocop.c | 3 +- arch/cris/arch-v32/drivers/i2c.c | 1 + arch/cris/arch-v32/drivers/mach-a3/gpio.c | 1 + arch/cris/arch-v32/drivers/mach-fs/gpio.c | 1 + arch/cris/arch-v32/drivers/pcf8563.c | 1 + arch/cris/arch-v32/drivers/sync_serial.c | 3 +- arch/cris/kernel/profile.c | 1 + arch/ia64/kernel/salinfo.c | 2 + arch/ia64/sn/kernel/sn2/sn_hwperf.c | 1 + arch/m68k/bvme6000/rtc.c | 1 + arch/m68k/mvme16x/rtc.c | 1 + arch/mips/kernel/rtlx.c | 3 +- arch/mips/kernel/vpe.c | 3 +- arch/mips/sibyte/common/sb_tbprof.c | 1 + arch/powerpc/kernel/lparcfg.c | 1 + arch/powerpc/kernel/rtas_flash.c | 3 ++ arch/powerpc/kernel/rtasd.c | 1 + arch/powerpc/platforms/iseries/mf.c | 1 + arch/powerpc/platforms/pseries/reconfig.c | 3 +- arch/powerpc/platforms/pseries/scanlog.c | 1 + arch/s390/crypto/prng.c | 1 + arch/s390/hypfs/hypfs_diag.c | 1 + arch/s390/hypfs/hypfs_vm.c | 1 + arch/s390/hypfs/inode.c | 1 + arch/s390/kernel/debug.c | 1 + arch/sh/boards/mach-landisk/gio.c | 1 + arch/sparc/kernel/apc.c | 1 + arch/sparc/kernel/mdesc.c | 1 + arch/tile/kernel/hardwall.c | 1 + arch/um/drivers/harddog_kern.c | 1 + arch/um/drivers/mconsole_kern.c | 1 + arch/um/drivers/mmapper_kern.c | 1 + arch/um/drivers/random.c | 1 + arch/x86/kernel/apm_32.c | 1 + arch/x86/kernel/cpu/mcheck/mce-severity.c | 1 + arch/x86/kernel/cpu/mcheck/mce.c | 1 + arch/x86/kernel/kdebugfs.c | 1 + arch/x86/kernel/microcode_core.c | 1 + arch/x86/kernel/tlb_uv.c | 1 + arch/x86/xen/debugfs.c | 1 + block/bsg.c | 1 + drivers/acpi/ec_sys.c | 1 + drivers/acpi/event.c | 1 + drivers/block/DAC960.c | 3 +- drivers/block/aoe/aoechr.c | 1 + drivers/block/paride/pg.c | 1 + drivers/block/paride/pt.c | 1 + drivers/block/pktcdvd.c | 1 + drivers/bluetooth/btmrvl_debugfs.c | 10 ++++++ drivers/bluetooth/hci_vhci.c | 1 + drivers/char/apm-emulation.c | 1 + drivers/char/bfin-otp.c | 1 + drivers/char/briq_panel.c | 1 + drivers/char/bsr.c | 1 + drivers/char/cs5535_gpio.c | 3 +- drivers/char/ds1302.c | 1 + drivers/char/ds1620.c | 1 + drivers/char/dsp56k.c | 1 + drivers/char/dtlk.c | 1 + drivers/char/genrtc.c | 1 + drivers/char/hw_random/core.c | 1 + drivers/char/ip2/ip2main.c | 1 + drivers/char/ipmi/ipmi_devintf.c | 1 + drivers/char/ipmi/ipmi_watchdog.c | 1 + drivers/char/istallion.c | 1 + drivers/char/lp.c | 1 + drivers/char/mem.c | 3 ++ drivers/char/misc.c | 1 + drivers/char/mmtimer.c | 1 + drivers/char/mspec.c | 9 ++++-- drivers/char/mwave/mwavedd.c | 3 +- drivers/char/nwbutton.c | 1 + drivers/char/pc8736x_gpio.c | 1 + drivers/char/pcmcia/cm4000_cs.c | 1 + drivers/char/pcmcia/cm4040_cs.c | 1 + drivers/char/random.c | 2 + drivers/char/rio/rio_linux.c | 1 + drivers/char/scx200_gpio.c | 1 + drivers/char/snsc.c | 1 + drivers/char/stallion.c | 1 + drivers/char/sx.c | 1 + drivers/char/sysrq.c | 1 + drivers/char/tb0219.c | 1 + drivers/char/tlclk.c | 1 + drivers/char/toshiba.c | 1 + drivers/char/uv_mmtimer.c | 1 + drivers/char/virtio_console.c | 3 ++ drivers/char/xilinx_hwicap/xilinx_hwicap.c | 1 + drivers/dma/coh901318.c | 1 + drivers/firewire/nosy.c | 1 + drivers/gpu/drm/drm_drv.c | 3 +- drivers/gpu/drm/i810/i810_dma.c | 1 + drivers/gpu/drm/i830/i830_dma.c | 1 + drivers/gpu/drm/i915/i915_debugfs.c | 1 + drivers/gpu/vga/vgaarb.c | 1 + drivers/hid/hid-debug.c | 1 + drivers/hid/hid-roccat.c | 1 + drivers/hid/hidraw.c | 1 + drivers/hid/usbhid/hiddev.c | 1 + drivers/hwmon/asus_atk0110.c | 1 + drivers/ide/ide-tape.c | 1 + drivers/idle/i7300_idle.c | 1 + drivers/infiniband/hw/cxgb4/device.c | 1 + drivers/infiniband/hw/ipath/ipath_diag.c | 4 ++- drivers/infiniband/hw/ipath/ipath_file_ops.c | 3 +- drivers/infiniband/hw/ipath/ipath_fs.c | 3 ++ drivers/infiniband/hw/qib/qib_diag.c | 4 ++- drivers/infiniband/hw/qib/qib_file_ops.c | 3 +- drivers/infiniband/hw/qib/qib_fs.c | 1 + drivers/input/evdev.c | 3 +- drivers/input/input.c | 1 + drivers/input/joydev.c | 1 + drivers/input/misc/uinput.c | 1 + drivers/input/mousedev.c | 1 + drivers/input/serio/serio_raw.c | 1 + drivers/isdn/mISDN/timerdev.c | 1 + drivers/lguest/lguest_user.c | 1 + drivers/macintosh/ans-lcd.c | 1 + drivers/macintosh/via-pmu.c | 1 + drivers/md/dm-ioctl.c | 1 + drivers/media/IR/imon.c | 6 ++- drivers/media/IR/lirc_dev.c | 1 + drivers/media/dvb/bt8xx/dst_ca.c | 3 +- drivers/media/dvb/dvb-core/dmxdev.c | 2 + drivers/media/dvb/dvb-core/dvb_ca_en50221.c | 1 + drivers/media/dvb/dvb-core/dvb_frontend.c | 3 +- drivers/media/dvb/dvb-core/dvb_net.c | 1 + drivers/media/dvb/dvb-core/dvbdev.c | 1 + drivers/media/dvb/firewire/firedtv-ci.c | 1 + drivers/media/dvb/ttpci/av7110.c | 1 + drivers/media/dvb/ttpci/av7110_av.c | 2 + drivers/media/dvb/ttpci/av7110_ca.c | 1 + drivers/media/dvb/ttpci/av7110_ir.c | 1 + drivers/mfd/ab3100-core.c | 1 + drivers/misc/hpilo.c | 1 + drivers/misc/phantom.c | 1 + drivers/misc/sgi-gru/grufile.c | 1 + drivers/mmc/core/debugfs.c | 1 + drivers/mtd/ubi/cdev.c | 1 + drivers/net/caif/caif_spi.c | 6 ++- drivers/net/cxgb4/cxgb4_main.c | 1 + drivers/net/ppp_generic.c | 3 +- drivers/net/wimax/i2400m/debugfs.c | 2 + drivers/net/wireless/airo.c | 24 ++++++++++----- drivers/net/wireless/ath/ath5k/debug.c | 7 ++++ drivers/net/wireless/ath/ath9k/debug.c | 33 ++++++++++++++------- drivers/net/wireless/ath/ath9k/htc_drv_main.c | 9 ++++-- drivers/net/wireless/iwlwifi/iwl-3945-rs.c | 1 + drivers/net/wireless/iwlwifi/iwl-agn-rs.c | 3 ++ drivers/net/wireless/iwmc3200wifi/debugfs.c | 4 ++ drivers/net/wireless/iwmc3200wifi/sdio.c | 1 + drivers/net/wireless/libertas/debugfs.c | 1 + drivers/net/wireless/ray_cs.c | 2 + drivers/net/wireless/rt2x00/rt2x00debug.c | 4 ++ drivers/net/wireless/wl12xx/wl1251_debugfs.c | 2 + drivers/net/wireless/wl12xx/wl1271_debugfs.c | 4 ++- drivers/oprofile/oprofile_files.c | 8 ++++- drivers/oprofile/oprofilefs.c | 3 ++ drivers/pci/pcie/aer/aer_inject.c | 1 + drivers/platform/x86/sony-laptop.c | 1 + drivers/rtc/rtc-m41t80.c | 1 + drivers/s390/block/dasd_eer.c | 1 + drivers/s390/char/fs3270.c | 1 + drivers/s390/char/monreader.c | 1 + drivers/s390/char/monwriter.c | 1 + drivers/s390/char/tape_char.c | 1 + drivers/s390/char/vmcp.c | 1 + drivers/s390/char/vmlogrdr.c | 1 + drivers/s390/char/vmwatchdog.c | 1 + drivers/s390/char/zcore.c | 2 + drivers/s390/cio/chsc_sch.c | 1 + drivers/s390/cio/css.c | 1 + drivers/s390/crypto/zcrypt_api.c | 3 +- drivers/s390/scsi/zfcp_cfdc.c | 3 +- drivers/sbus/char/display7seg.c | 1 + drivers/sbus/char/envctrl.c | 1 + drivers/scsi/3w-9xxx.c | 3 +- drivers/scsi/3w-sas.c | 3 +- drivers/scsi/3w-xxxx.c | 3 +- drivers/scsi/aacraid/linit.c | 1 + drivers/scsi/ch.c | 1 + drivers/scsi/dpt_i2o.c | 1 + drivers/scsi/gdth.c | 1 + drivers/scsi/megaraid.c | 1 + drivers/scsi/megaraid/megaraid_mm.c | 1 + drivers/scsi/megaraid/megaraid_sas.c | 1 + drivers/scsi/mpt2sas/mpt2sas_ctl.c | 1 + drivers/scsi/osd/osd_uld.c | 1 + drivers/scsi/pmcraid.c | 1 + drivers/scsi/qla2xxx/qla_os.c | 1 + drivers/scsi/scsi_tgt_if.c | 1 + drivers/scsi/sg.c | 1 + drivers/serial/mfd.c | 2 + drivers/spi/dw_spi.c | 1 + drivers/spi/spidev.c | 1 + drivers/staging/batman-adv/bat_debugfs.c | 1 + drivers/staging/batman-adv/icmp_socket.c | 1 + drivers/staging/comedi/comedi_fops.c | 1 + drivers/staging/crystalhd/crystalhd_lnx.c | 1 + drivers/staging/dream/camera/msm_camera.c | 3 ++ drivers/staging/dream/pmem.c | 2 + drivers/staging/dream/qdsp5/adsp_driver.c | 1 + drivers/staging/dream/qdsp5/audio_aac.c | 1 + drivers/staging/dream/qdsp5/audio_amrnb.c | 1 + drivers/staging/dream/qdsp5/audio_evrc.c | 1 + drivers/staging/dream/qdsp5/audio_in.c | 2 + drivers/staging/dream/qdsp5/audio_mp3.c | 1 + drivers/staging/dream/qdsp5/audio_out.c | 2 + drivers/staging/dream/qdsp5/audio_qcelp.c | 1 + drivers/staging/dream/qdsp5/evlog.h | 1 + drivers/staging/dream/qdsp5/snd.c | 1 + drivers/staging/frontier/alphatrack.c | 1 + drivers/staging/frontier/tranzport.c | 1 + drivers/staging/iio/industrialio-core.c | 1 + drivers/staging/iio/industrialio-ring.c | 1 + drivers/staging/lirc/lirc_imon.c | 3 +- drivers/staging/lirc/lirc_it87.c | 1 + drivers/staging/lirc/lirc_sasem.c | 1 + drivers/staging/memrar/memrar_handler.c | 1 + drivers/staging/panel/panel.c | 1 + drivers/staging/tidspbridge/rmgr/drv_interface.c | 1 + drivers/telephony/ixj.c | 3 +- drivers/telephony/phonedev.c | 1 + drivers/uio/uio.c | 1 + drivers/usb/class/cdc-wdm.c | 3 +- drivers/usb/class/usblp.c | 1 + drivers/usb/class/usbtmc.c | 1 + drivers/usb/core/file.c | 1 + drivers/usb/gadget/f_hid.c | 1 + drivers/usb/gadget/printer.c | 3 +- drivers/usb/host/ehci-dbg.c | 4 ++ drivers/usb/host/ohci-dbg.c | 3 ++ drivers/usb/image/mdc800.c | 1 + drivers/usb/misc/adutux.c | 1 + drivers/usb/misc/idmouse.c | 1 + drivers/usb/misc/iowarrior.c | 1 + drivers/usb/misc/ldusb.c | 1 + drivers/usb/misc/rio500.c | 1 + drivers/usb/misc/usblcd.c | 1 + drivers/usb/usb-skeleton.c | 1 + drivers/vhost/net.c | 1 + drivers/video/fbmem.c | 1 + drivers/video/mbx/mbxdebugfs.c | 6 ++++ drivers/watchdog/ar7_wdt.c | 1 + drivers/watchdog/cpwd.c | 1 + drivers/watchdog/ep93xx_wdt.c | 1 + drivers/watchdog/omap_wdt.c | 1 + drivers/xen/evtchn.c | 1 + drivers/xen/xenfs/super.c | 1 + drivers/xen/xenfs/xenbus.c | 1 + fs/afs/mntpt.c | 1 + fs/autofs4/dev-ioctl.c | 1 + fs/binfmt_misc.c | 3 ++ fs/btrfs/super.c | 1 + fs/cachefiles/daemon.c | 1 + fs/char_dev.c | 1 + fs/coda/pioctl.c | 1 + fs/coda/psdev.c | 1 + fs/debugfs/file.c | 3 ++ fs/dlm/debug_fs.c | 3 +- fs/dlm/plock.c | 3 +- fs/dlm/user.c | 3 ++ fs/ecryptfs/file.c | 1 + fs/ecryptfs/miscdev.c | 1 + fs/eventfd.c | 1 + fs/eventpoll.c | 3 +- fs/fifo.c | 1 + fs/fuse/control.c | 4 ++ fs/fuse/cuse.c | 1 + fs/gfs2/file.c | 2 + fs/hppfs/hppfs.c | 1 + fs/hugetlbfs/inode.c | 1 + fs/logfs/dir.c | 1 + fs/nfsd/nfsctl.c | 1 + fs/no-block.c | 1 + fs/notify/fanotify/fanotify_user.c | 1 + fs/notify/inotify/inotify_user.c | 1 + fs/ntfs/file.c | 3 +- fs/ocfs2/dlmfs/dlmfs.c | 1 + fs/ocfs2/stack_user.c | 1 + fs/proc/base.c | 8 +++++ fs/proc/proc_sysctl.c | 1 + fs/proc/root.c | 1 + fs/proc/task_mmu.c | 1 + fs/romfs/super.c | 1 + fs/signalfd.c | 1 + fs/squashfs/dir.c | 3 +- fs/timerfd.c | 1 + fs/ubifs/debug.c | 1 + ipc/mqueue.c | 1 + ipc/shm.c | 2 + kernel/configs.c | 1 + kernel/gcov/fs.c | 1 + kernel/kprobes.c | 1 + kernel/pm_qos_params.c | 1 + kernel/profile.c | 1 + kernel/trace/blktrace.c | 2 + kernel/trace/ftrace.c | 2 + kernel/trace/ring_buffer.c | 1 + kernel/trace/trace_events.c | 6 ++++ kernel/trace/trace_stack.c | 1 + lib/dma-debug.c | 1 + net/atm/proc.c | 1 + net/dccp/probe.c | 1 + net/ipv4/tcp_probe.c | 1 + net/mac80211/debugfs.c | 19 ++++++++---- net/mac80211/rate.c | 1 + net/mac80211/rc80211_minstrel_debugfs.c | 1 + net/mac80211/rc80211_pid_debugfs.c | 1 + net/netfilter/xt_recent.c | 1 + net/nonet.c | 1 + net/rfkill/core.c | 1 + net/sctp/probe.c | 1 + net/socket.c | 1 + net/sunrpc/cache.c | 2 + net/wireless/debugfs.c | 1 + samples/kfifo/bytestream-example.c | 1 + samples/kfifo/inttype-example.c | 1 + samples/kfifo/record-example.c | 1 + samples/tracepoints/tracepoint-sample.c | 1 + security/apparmor/apparmorfs.c | 9 ++++-- security/inode.c | 1 + security/smack/smackfs.c | 5 +++ sound/core/seq/oss/seq_oss.c | 1 + sound/core/sound.c | 3 +- sound/oss/msnd_pinnacle.c | 1 + sound/oss/sh_dac_audio.c | 1 + sound/soc/soc-core.c | 1 + sound/soc/soc-dapm.c | 1 + sound/sound_core.c | 1 + virt/kvm/kvm_main.c | 3 ++ 343 files changed, 545 insertions(+), 74 deletions(-)
arch/arm/kernel/etm.c +1 -0
@@ -314,6 +314,7 @@ static const struct file_operations etb_fops = { .read = etb_read, .open = etb_open, .release = etb_release, + .llseek = no_llseek,/* open uses nonseekable */ };static struct miscdevice etb_miscdev = {
arch/arm/mach-msm/last_radio_log.c +2 -1
@@ -48,7 +48,8 @@ static ssize_t last_radio_log_read(struct file *file, char __user *buf, }static struct file_operations last_radio_log_fops = { - .read = last_radio_log_read + .read = last_radio_log_read, + .llseek = default_llseek,/* read accesses f_pos */ };void msm_init_last_radio_log (struct module *owner)
arch/arm/mach-msm/smd_debug.c +1 -0
@@ -212,6 +212,7 @@ static int debug_open(struct inode *inode, struct file *file)static const struct file_operations debug_ops = { .read = debug_read, .open = debug_open, + .llseek = default_llseek,/* read accesses f_pos */ }; static void debug_create(const char *name, mode_t mode,
arch/arm/plat-mxc/audmux-v2.c +1 -0
@@ -137,6 +137,7 @@ static ssize_t audmux_read_file(struct file *file, char __user *user_buf,static const struct file_operations audmux_debugfs_fops = { .open = audmux_open_file, .read = audmux_read_file, + .llseek = default_llseek,/* read accesses f_pos */ };static void audmux_debugfs_init (void )
arch/avr32/boards/mimc200/fram.c +1 -0
@@ -41,6 +41,7 @@ static int fram_mmap(struct file *filp, struct vm_area_struct *vma)static const struct file_operations fram_fops = { .owner =THIS_MODULE , .mmap = fram_mmap, + .llseek = noop_llseek,/* no read or write fn */ };#define FRAM_MINOR 0
arch/blackfin/kernel/kgdb_test.c +1 -0
@@ -88,6 +88,7 @@ static const struct file_operations kgdb_test_proc_fops = { .owner = THIS_MODULE, .read = kgdb_test_proc_read, .write = kgdb_test_proc_write, + .llseek = noop_llseek,/* read and write both use no f_pos */ };static int __init kgdbtest_init (void )
arch/blackfin/mach-bf561/coreb.c +1 -0
@@ -51,6 +51,7 @@ coreb_ioctl(struct file *file, unsigned int cmd, unsigned long arg)static const struct file_operations coreb_fops = { .owner =THIS_MODULE , .unlocked_ioctl = coreb_ioctl, + .llseek = noop_llseek,/* no read or write fn */ };static struct miscdevice coreb_dev = {
arch/cris/arch-v10/drivers/ds1302.c +1 -0
@@ -387,6 +387,7 @@ print_rtc_status(void)static const struct file_operations rtc_fops = { .owner =THIS_MODULE , .unlocked_ioctl = rtc_unlocked_ioctl, + .llseek = noop_llseek,/* no read or write fn */ };/* Probe for the chip by writing something to its RAM and try reading it back. */
arch/cris/arch-v10/drivers/gpio.c +1 -0
@@ -745,6 +745,7 @@ static const struct file_operations gpio_fops = { .write = gpio_write, .open = gpio_open, .release = gpio_release, + .llseek = noop_llseek,/* write uses no f_pos */ }; static void ioif_watcher(const unsigned int gpio_in_available,
arch/cris/arch-v10/drivers/i2c.c +1 -0
@@ -617,6 +617,7 @@ static const struct file_operations i2c_fops = { .unlocked_ioctl = i2c_ioctl, .open = i2c_open, .release = i2c_release, + .llseek = noop_llseek,/* no read or write fn */ };int __init
arch/cris/arch-v10/drivers/pcf8563.c +1 -0
@@ -64,6 +64,7 @@ static int voltage_low;static const struct file_operations pcf8563_fops = { .owner =THIS_MODULE , .unlocked_ioctl = pcf8563_unlocked_ioctl, + .llseek = noop_llseek,/* no read or write fn */ };unsigned char
arch/cris/arch-v10/drivers/sync_serial.c +2 -1
@@ -250,7 +250,8 @@ static const struct file_operations sync_serial_fops = { .poll = sync_serial_poll, .unlocked_ioctl = sync_serial_ioctl, .open = sync_serial_open, - .release = sync_serial_release + .release = sync_serial_release, + .llseek = noop_llseek,/* read and write both use no f_pos */ };static int __init etrax_sync_serial_init (void )
arch/cris/arch-v32/drivers/cryptocop.c +2 -1
@@ -281,7 +281,8 @@ const struct file_operations cryptocop_fops = { .owner = THIS_MODULE, .open = cryptocop_open, .release = cryptocop_release, - .unlocked_ioctl = cryptocop_ioctl + .unlocked_ioctl = cryptocop_ioctl, + .llseek = noop_llseek,/* no read or write fn */ };
arch/cris/arch-v32/drivers/i2c.c +1 -0
@@ -698,6 +698,7 @@ static const struct file_operations i2c_fops = { .unlocked_ioctl = i2c_ioctl, .open = i2c_open, .release = i2c_release, + .llseek = noop_llseek,/* no read or write fn */ };static int __init i2c_init (void )
arch/cris/arch-v32/drivers/mach-a3/gpio.c +1 -0
@@ -893,6 +893,7 @@ static const struct file_operations gpio_fops = { .write = gpio_write, .open = gpio_open, .release = gpio_release, + .llseek = noop_llseek,/* write uses no f_pos */ };#ifdef CONFIG_ETRAX_VIRTUAL_GPIO
arch/cris/arch-v32/drivers/mach-fs/gpio.c +1 -0
@@ -870,6 +870,7 @@ static const struct file_operations gpio_fops = { .write = gpio_write, .open = gpio_open, .release = gpio_release, + .llseek = noop_llseek,/* write uses no f_pos */ };#ifdef CONFIG_ETRAX_VIRTUAL_GPIO
arch/cris/arch-v32/drivers/pcf8563.c +1 -0
@@ -60,6 +60,7 @@ static int voltage_low;static const struct file_operations pcf8563_fops = { .owner =THIS_MODULE , .unlocked_ioctl = pcf8563_unlocked_ioctl, + .llseek = noop_llseek,/* no read or write fn */ };unsigned char
arch/cris/arch-v32/drivers/sync_serial.c +2 -1
@@ -247,7 +247,8 @@ static const struct file_operations sync_serial_fops = { .poll = sync_serial_poll, .unlocked_ioctl = sync_serial_ioctl, .open = sync_serial_open, - .release = sync_serial_release + .release = sync_serial_release, + .llseek = noop_llseek,/* read and write both use no f_pos */ };static int __init etrax_sync_serial_init (void )
arch/cris/kernel/profile.c +1 -0
@@ -59,6 +59,7 @@ write_cris_profile(struct file *file, const char __user *buf,static const struct file_operations cris_proc_profile_operations = { .read = read_cris_profile, .write = write_cris_profile, + .llseek = default_llseek,/* read accesses f_pos */ };static int __init init_cris_profile (void )
arch/ia64/kernel/salinfo.c +2 -0
@@ -354,6 +354,7 @@ retry:static const struct file_operations salinfo_event_fops = { .open = salinfo_event_open, .read = salinfo_event_read, + .llseek = noop_llseek,/* read uses no f_pos */ }; static int
@@ -571,6 +572,7 @@ static const struct file_operations salinfo_data_fops = { .release = salinfo_log_release, .read = salinfo_log_read, .write = salinfo_log_write, + .llseek = default_llseek,/* read accesses f_pos */ }; static int __cpuinit
arch/ia64/sn/kernel/sn2/sn_hwperf.c +1 -0
@@ -860,6 +860,7 @@ error:static const struct file_operations sn_hwperf_fops = { .unlocked_ioctl = sn_hwperf_ioctl, + .llseek = noop_llseek,/* no read or write fn */ };static struct miscdevice sn_hwperf_dev = {
arch/m68k/bvme6000/rtc.c +1 -0
@@ -155,6 +155,7 @@ static const struct file_operations rtc_fops = { .unlocked_ioctl = rtc_ioctl, .open = rtc_open, .release = rtc_release, + .llseek = noop_llseek,/* no read or write fn */ };static struct miscdevice rtc_dev = {
arch/m68k/mvme16x/rtc.c +1 -0
@@ -144,6 +144,7 @@ static const struct file_operations rtc_fops = { .unlocked_ioctl = rtc_ioctl, .open = rtc_open, .release = rtc_release, + .llseek = noop_llseek,/* no read or write fn */ }; static struct miscdevice rtc_dev=
arch/mips/kernel/rtlx.c +2 -1
@@ -468,7 +468,8 @@ static const struct file_operations rtlx_fops = { .release = file_release, .write = file_write, .read = file_read, - .poll = file_poll + .poll = file_poll, + .llseek = noop_llseek,/* read and write both use no f_pos */ };static struct irqaction rtlx_irq = {
arch/mips/kernel/vpe.c +2 -1
@@ -1192,7 +1192,8 @@ static const struct file_operations vpe_fops = { .owner = THIS_MODULE, .open = vpe_open, .release = vpe_release, - .write = vpe_write + .write = vpe_write, + .llseek = noop_llseek,/* write uses no f_pos */ };/* module wrapper entry points */
arch/mips/sibyte/common/sb_tbprof.c +1 -0
@@ -545,6 +545,7 @@ static const struct file_operations sbprof_tb_fops = { .unlocked_ioctl = sbprof_tb_ioctl, .compat_ioctl = sbprof_tb_ioctl, .mmap = NULL, + .llseek = default_llseek,/* read accesses f_pos */ };static struct class *tb_class;
arch/powerpc/kernel/lparcfg.c +1 -0
@@ -780,6 +780,7 @@ static const struct file_operations lparcfg_fops = { .write = lparcfg_write, .open = lparcfg_open, .release = single_release, + .llseek = seq_lseek,/* we have seq_read */ };static int __init lparcfg_init (void )
arch/powerpc/kernel/rtas_flash.c +3 -0
@@ -716,6 +716,7 @@ static const struct file_operations rtas_flash_operations = { .write = rtas_flash_write, .open = rtas_excl_open, .release = rtas_flash_release, + .llseek = default_llseek,/* read accesses f_pos */ };static const struct file_operations manage_flash_operations = {
@@ -724,6 +725,7 @@ static const struct file_operations manage_flash_operations = { .write = manage_flash_write, .open = rtas_excl_open, .release = rtas_excl_release, + .llseek = default_llseek,/* read accesses f_pos */ };static const struct file_operations validate_flash_operations = {
@@ -732,6 +734,7 @@ static const struct file_operations validate_flash_operations = { .write = validate_flash_write, .open = rtas_excl_open, .release = validate_flash_release, + .llseek = default_llseek,/* read accesses f_pos */ };static int __init rtas_flash_init (void )
arch/powerpc/kernel/rtasd.c +1 -0
@@ -354,6 +354,7 @@ static const struct file_operations proc_rtas_log_operations = { .poll = rtas_log_poll, .open = rtas_log_open, .release = rtas_log_release, + .llseek = noop_llseek,/* read uses no f_pos */ };static int enable_surveillance (int timeout)
arch/powerpc/platforms/iseries/mf.c +1 -0
@@ -1249,6 +1249,7 @@ out:static const struct file_operations proc_vmlinux_operations = { .write = proc_mf_change_vmlinux, + .llseek = default_llseek,/* write accesses f_pos */ };static int __init mf_proc_init (void )
arch/powerpc/platforms/pseries/reconfig.c +2 -1
@@ -539,7 +539,8 @@ out: }static const struct file_operations ofdt_fops = { - .write = ofdt_write + .write = ofdt_write, + .llseek = noop_llseek,/* write uses no f_pos */ };/* create /proc/powerpc/ofdt write-only by root */
arch/powerpc/platforms/pseries/scanlog.c +1 -0
@@ -170,6 +170,7 @@ const struct file_operations scanlog_fops = { .write = scanlog_write, .open = scanlog_open, .release = scanlog_release, + .llseek = noop_llseek,/* read and write both use no f_pos */ };static int __init scanlog_init (void )
arch/s390/crypto/prng.c +1 -0
@@ -152,6 +152,7 @@ static const struct file_operations prng_fops = { .open = &prng_open, .release = NULL, .read = &prng_read, + .llseek = noop_llseek,/* no read or write fn */ };static struct miscdevice prng_dev = {
arch/s390/hypfs/hypfs_diag.c +1 -0
@@ -618,6 +618,7 @@ static const struct file_operations dbfs_d204_ops = { .open = dbfs_d204_open, .read = dbfs_d204_read, .release = dbfs_d204_release, + .llseek = no_llseek,/* open uses nonseekable */ };static int hypfs_dbfs_init (void )
arch/s390/hypfs/hypfs_vm.c +1 -0
@@ -275,6 +275,7 @@ static const struct file_operations dbfs_d2fc_ops = { .open = dbfs_d2fc_open, .read = dbfs_d2fc_read, .release = dbfs_d2fc_release, + .llseek = no_llseek,/* open uses nonseekable */ };int hypfs_vm_init (void )
arch/s390/hypfs/inode.c +1 -0
@@ -449,6 +449,7 @@ static const struct file_operations hypfs_file_ops = { .write = do_sync_write, .aio_read = hypfs_aio_read, .aio_write = hypfs_aio_write, + .llseek = no_llseek,/* open uses nonseekable */ };static struct file_system_type hypfs_type = {
arch/s390/kernel/debug.c +1 -0
@@ -174,6 +174,7 @@ static const struct file_operations debug_file_ops = { .write = debug_input, .open = debug_open, .release = debug_close, + .llseek = no_llseek,/* open uses nonseekable */ };static struct dentry *debug_debugfs_root_entry;
arch/sh/boards/mach-landisk/gio.c +1 -0
@@ -128,6 +128,7 @@ static const struct file_operations gio_fops = { .open = gio_open, /* open */ .release = gio_close, /* release */ .unlocked_ioctl = gio_ioctl, + .llseek = noop_llseek,/* no read or write fn */ };static int __init gio_init (void )
arch/sparc/kernel/apc.c +1 -0
@@ -132,6 +132,7 @@ static const struct file_operations apc_fops = { .unlocked_ioctl = apc_ioctl, .open = apc_open, .release = apc_release, + .llseek = noop_llseek,/* no read or write fn */ };static struct miscdevice apc_miscdev = {APC_MINOR ,APC_DEVNAME , &apc_fops };
arch/sparc/kernel/mdesc.c +1 -0
@@ -890,6 +890,7 @@ static ssize_t mdesc_read(struct file *file, char __user *buf,static const struct file_operations mdesc_fops = { .read = mdesc_read, .owner =THIS_MODULE , + .llseek = noop_llseek,/* read uses no f_pos */ };static struct miscdevice mdesc_misc = {
arch/tile/kernel/hardwall.c +1 -0
@@ -774,6 +774,7 @@ static const struct file_operations dev_hardwall_fops = {#endif .flush = hardwall_flush, .release = hardwall_release, + .llseek = noop_llseek,/* no read or write fn */ };static struct cdev hardwall_dev;
arch/um/drivers/harddog_kern.c +1 -0
@@ -166,6 +166,7 @@ static const struct file_operations harddog_fops = { .unlocked_ioctl = harddog_ioctl, .open = harddog_open, .release = harddog_release, + .llseek = no_llseek,/* open uses nonseekable */ };static struct miscdevice harddog_miscdev = {
arch/um/drivers/mconsole_kern.c +1 -0
@@ -843,6 +843,7 @@ static ssize_t mconsole_proc_write(struct file *file,static const struct file_operations mconsole_proc_fops = { .owner =THIS_MODULE , .write = mconsole_proc_write, + .llseek = noop_llseek,/* write uses no f_pos */ };static int create_proc_mconsole (void )
arch/um/drivers/mmapper_kern.c +1 -0
@@ -93,6 +93,7 @@ static const struct file_operations mmapper_fops = { .mmap = mmapper_mmap, .open = mmapper_open, .release = mmapper_release, + .llseek = default_llseek,/* read accesses f_pos */ };/*
arch/um/drivers/random.c +1 -0
@@ -100,6 +100,7 @@ static const struct file_operations rng_chrdev_ops = { .owner = THIS_MODULE, .open = rng_dev_open, .read = rng_dev_read, + .llseek = noop_llseek,/* read uses no f_pos */ };/* rng_init shouldn't be called more than once at boot time */
arch/x86/kernel/apm_32.c +1 -0
@@ -1926,6 +1926,7 @@ static const struct file_operations apm_bios_fops = { .unlocked_ioctl = do_ioctl, .open = do_open, .release = do_release, + .llseek = noop_llseek,/* read uses no f_pos */ };static struct miscdevice apm_device = {
arch/x86/kernel/cpu/mcheck/mce-severity.c +1 -0
@@ -192,6 +192,7 @@ static const struct file_operations severities_coverage_fops = { .release = seq_release, .read = seq_read, .write = severities_coverage_write, + .llseek = seq_lseek,/* we have seq_read */ };static int __init severities_debugfs_init (void )
arch/x86/kernel/cpu/mcheck/mce.c +1 -0
@@ -1665,6 +1665,7 @@ struct file_operations mce_chrdev_ops = { .read = mce_read, .poll = mce_poll, .unlocked_ioctl = mce_ioctl, + .llseek = no_llseek,/* open uses nonseekable */ };EXPORT_SYMBOL_GPL (mce_chrdev_ops);
arch/x86/kernel/kdebugfs.c +1 -0
@@ -78,6 +78,7 @@ static int setup_data_open(struct inode *inode, struct file *file)static const struct file_operations fops_setup_data = { .read = setup_data_read, .open = setup_data_open, + .llseek = default_llseek,/* read accesses f_pos */ }; static int __init
arch/x86/kernel/microcode_core.c +1 -0
@@ -232,6 +232,7 @@ static const struct file_operations microcode_fops = { .owner = THIS_MODULE, .write = microcode_write, .open = microcode_open, + .llseek = no_llseek,/* open uses nonseekable */ };static struct miscdevice microcode_dev = {
arch/x86/kernel/tlb_uv.c +1 -0
@@ -1285,6 +1285,7 @@ static const struct file_operations tunables_fops = { .open = tunables_open, .read = tunables_read, .write = tunables_write, + .llseek = default_llseek,/* read accesses f_pos */ };static int __init uv_ptc_init (void )
arch/x86/xen/debugfs.c +1 -0
@@ -106,6 +106,7 @@ static const struct file_operations u32_array_fops = { .open = u32_array_open, .release= xen_array_release, .read = u32_array_read, + .llseek = no_llseek,/* open uses nonseekable */ }; struct dentry *xen_debugfs_create_u32_array(const char *name, mode_t mode,
block/bsg.c +1 -0
@@ -968,6 +968,7 @@ static const struct file_operations bsg_fops = { .release = bsg_release, .unlocked_ioctl = bsg_ioctl, .owner = THIS_MODULE, + .llseek = default_llseek,/* read accesses f_pos */ };void bsg_unregister_queue (struct request_queue *q)
drivers/acpi/ec_sys.c +1 -0
@@ -101,6 +101,7 @@ static struct file_operations acpi_ec_io_ops = { .open = acpi_ec_open_io, .read = acpi_ec_read_io, .write = acpi_ec_write_io, + .llseek = default_llseek,/* read accesses f_pos */ };int acpi_ec_add_debugfs (struct acpi_ec *ec,unsigned int ec_device_count)
drivers/acpi/event.c +1 -0
@@ -110,6 +110,7 @@ static const struct file_operations acpi_system_event_ops = { .read = acpi_system_read_event, .release = acpi_system_close_event, .poll = acpi_system_poll_event, + .llseek = default_llseek,/* read accesses f_pos */ };#endif /* CONFIG_ACPI_PROC_EVENT */
drivers/block/DAC960.c +2 -1
@@ -7062,7 +7062,8 @@ static long DAC960_gam_ioctl(struct file *file, unsigned int Request,static const struct file_operations DAC960_gam_fops = { .owner =THIS_MODULE , - .unlocked_ioctl = DAC960_gam_ioctl + .unlocked_ioctl = DAC960_gam_ioctl, + .llseek = noop_llseek,/* no read or write fn */ };static struct miscdevice DAC960_gam_dev = {
drivers/block/aoe/aoechr.c +1 -0
@@ -265,6 +265,7 @@ static const struct file_operations aoe_fops = { .open = aoechr_open, .release = aoechr_rel, .owner = THIS_MODULE, + .llseek = noop_llseek,/* read and write both use no f_pos */ };static char *aoe_devnode (struct device *dev,mode_t *mode)
drivers/block/paride/pg.c +1 -0
@@ -234,6 +234,7 @@ static const struct file_operations pg_fops = { .write = pg_write, .open = pg_open, .release = pg_release, + .llseek = noop_llseek,/* read and write both use no f_pos */ };static void pg_init_units (void )
drivers/block/paride/pt.c +1 -0
@@ -239,6 +239,7 @@ static const struct file_operations pt_fops = { .unlocked_ioctl = pt_ioctl, .open = pt_open, .release = pt_release, + .llseek = noop_llseek,/* read and write both use no f_pos */ };/* sysfs class support */
drivers/block/pktcdvd.c +1 -0
@@ -3046,6 +3046,7 @@ static const struct file_operations pkt_ctl_fops = { .compat_ioctl = pkt_ctl_compat_ioctl, #endif .owner = THIS_MODULE, + .llseek = no_llseek,/* nonseekable */ }; static struct miscdevice pkt_misc = {
drivers/bluetooth/btmrvl_debugfs.c +10 -0
@@ -92,6 +92,7 @@ static const struct file_operations btmrvl_hscfgcmd_fops = { .read = btmrvl_hscfgcmd_read, .write = btmrvl_hscfgcmd_write, .open = btmrvl_open_generic, + .llseek = default_llseek,/* read accesses f_pos */ }; static ssize_t btmrvl_psmode_write(struct file *file, const char __user *ubuf,
@@ -130,6 +131,7 @@ static const struct file_operations btmrvl_psmode_fops = { .read = btmrvl_psmode_read, .write = btmrvl_psmode_write, .open = btmrvl_open_generic, + .llseek = default_llseek,/* read accesses f_pos */ }; static ssize_t btmrvl_pscmd_write(struct file *file, const char __user *ubuf,
@@ -173,6 +175,7 @@ static const struct file_operations btmrvl_pscmd_fops = { .read = btmrvl_pscmd_read, .write = btmrvl_pscmd_write, .open = btmrvl_open_generic, + .llseek = default_llseek,/* read accesses f_pos */ }; static ssize_t btmrvl_gpiogap_write(struct file *file, const char __user *ubuf,
@@ -211,6 +214,7 @@ static const struct file_operations btmrvl_gpiogap_fops = { .read = btmrvl_gpiogap_read, .write = btmrvl_gpiogap_write, .open = btmrvl_open_generic, + .llseek = default_llseek,/* read accesses f_pos */ }; static ssize_t btmrvl_hscmd_write(struct file *file, const char __user *ubuf,
@@ -252,6 +256,7 @@ static const struct file_operations btmrvl_hscmd_fops = { .read = btmrvl_hscmd_read, .write = btmrvl_hscmd_write, .open = btmrvl_open_generic, + .llseek = default_llseek,/* read accesses f_pos */ }; static ssize_t btmrvl_hsmode_write(struct file *file, const char __user *ubuf,
@@ -289,6 +294,7 @@ static const struct file_operations btmrvl_hsmode_fops = { .read = btmrvl_hsmode_read, .write = btmrvl_hsmode_write, .open = btmrvl_open_generic, + .llseek = default_llseek,/* read accesses f_pos */ }; static ssize_t btmrvl_curpsmode_read(struct file *file, char __user *userbuf,
@@ -306,6 +312,7 @@ static ssize_t btmrvl_curpsmode_read(struct file *file, char __user *userbuf,static const struct file_operations btmrvl_curpsmode_fops = { .read = btmrvl_curpsmode_read, .open = btmrvl_open_generic, + .llseek = default_llseek,/* read accesses f_pos */ }; static ssize_t btmrvl_psstate_read(struct file *file, char __user * userbuf,
@@ -323,6 +330,7 @@ static ssize_t btmrvl_psstate_read(struct file *file, char __user * userbuf,static const struct file_operations btmrvl_psstate_fops = { .read = btmrvl_psstate_read, .open = btmrvl_open_generic, + .llseek = default_llseek,/* read accesses f_pos */ }; static ssize_t btmrvl_hsstate_read(struct file *file, char __user *userbuf,
@@ -340,6 +348,7 @@ static ssize_t btmrvl_hsstate_read(struct file *file, char __user *userbuf,static const struct file_operations btmrvl_hsstate_fops = { .read = btmrvl_hsstate_read, .open = btmrvl_open_generic, + .llseek = default_llseek,/* read accesses f_pos */ }; static ssize_t btmrvl_txdnldready_read(struct file *file, char __user *userbuf,
@@ -358,6 +367,7 @@ static ssize_t btmrvl_txdnldready_read(struct file *file, char __user *userbuf,static const struct file_operations btmrvl_txdnldready_fops = { .read = btmrvl_txdnldready_read, .open = btmrvl_open_generic, + .llseek = default_llseek,/* read accesses f_pos */ };void btmrvl_debugfs_init (struct hci_dev *hdev)
drivers/bluetooth/hci_vhci.c +1 -0
@@ -282,6 +282,7 @@ static const struct file_operations vhci_fops = { .poll = vhci_poll, .open = vhci_open, .release = vhci_release, + .llseek = no_llseek,/* open uses nonseekable */ };static struct miscdevice vhci_miscdev= {
drivers/char/apm-emulation.c +1 -0
@@ -402,6 +402,7 @@ static const struct file_operations apm_bios_fops = { .unlocked_ioctl = apm_ioctl, .open = apm_open, .release = apm_release, + .llseek = noop_llseek,/* read uses no f_pos */ };static struct miscdevice apm_device = {
drivers/char/bfin-otp.c +1 -0
@@ -222,6 +222,7 @@ static const struct file_operations bfin_otp_fops = { .unlocked_ioctl = bfin_otp_ioctl, .read = bfin_otp_read, .write = bfin_otp_write, + .llseek = default_llseek,/* read accesses f_pos */ };static struct miscdevice bfin_otp_misc_device = {
drivers/char/briq_panel.c +1 -0
@@ -186,6 +186,7 @@ static const struct file_operations briq_panel_fops = { .write = briq_panel_write, .open = briq_panel_open, .release = briq_panel_release, + .llseek = noop_llseek,/* read and write both use no f_pos */ };static struct miscdevice briq_panel_miscdev = {
drivers/char/bsr.c +1 -0
@@ -155,6 +155,7 @@ static const struct file_operations bsr_fops = { .owner = THIS_MODULE, .mmap = bsr_mmap, .open = bsr_open, + .llseek = noop_llseek,/* no read or write fn */ };static void bsr_cleanup_devs (void )
drivers/char/cs5535_gpio.c +2 -1
@@ -169,7 +169,8 @@ static const struct file_operations cs5535_gpio_fops = { .owner = THIS_MODULE, .write = cs5535_gpio_write, .read = cs5535_gpio_read, - .open = cs5535_gpio_open + .open = cs5535_gpio_open, + .llseek = no_llseek,/* open uses nonseekable */ };static int __init cs5535_gpio_init (void )
drivers/char/ds1302.c +1 -0
@@ -288,6 +288,7 @@ get_rtc_status(char *buf)static const struct file_operations rtc_fops = { .owner =THIS_MODULE , .unlocked_ioctl = rtc_ioctl, + .llseek = noop_llseek,/* no read or write fn */ };/* Probe for the chip by writing something to its RAM and try reading it back. */
drivers/char/ds1620.c +1 -0
@@ -357,6 +357,7 @@ static const struct file_operations ds1620_fops = { .open = ds1620_open, .read = ds1620_read, .unlocked_ioctl = ds1620_unlocked_ioctl, + .llseek = no_llseek,/* open uses nonseekable */ };static struct miscdevice ds1620_miscdev = {
drivers/char/dsp56k.c +1 -0
@@ -482,6 +482,7 @@ static const struct file_operations dsp56k_fops = { .unlocked_ioctl = dsp56k_ioctl, .open = dsp56k_open, .release = dsp56k_release, + .llseek = noop_llseek,/* read and write both use no f_pos */ };
drivers/char/dtlk.c +1 -0
@@ -105,6 +105,7 @@ static const struct file_operations dtlk_fops = .unlocked_ioctl = dtlk_ioctl, .open = dtlk_open, .release = dtlk_release, + .llseek = no_llseek,/* open uses nonseekable */ };/* local prototypes */
drivers/char/genrtc.c +1 -0
@@ -497,6 +497,7 @@ static const struct file_operations gen_rtc_fops = { .unlocked_ioctl = gen_rtc_unlocked_ioctl, .open = gen_rtc_open, .release = gen_rtc_release, + .llseek = noop_llseek,/* read uses no f_pos */ }; static struct miscdevice rtc_gen_dev =
drivers/char/hw_random/core.c +1 -0
@@ -170,6 +170,7 @@ static const struct file_operations rng_chrdev_ops = { .owner = THIS_MODULE, .open = rng_dev_open, .read = rng_dev_read, + .llseek = noop_llseek,/* read uses no f_pos */ };static struct miscdevice rng_miscdev = {
drivers/char/ip2/ip2main.c +1 -0
@@ -236,6 +236,7 @@ static const struct file_operations ip2_ipl = { .write = ip2_ipl_write, .unlocked_ioctl = ip2_ipl_ioctl, .open = ip2_ipl_open, + .llseek = noop_llseek,/* read and write both use no f_pos */ };static unsigned long irq_counter;
drivers/char/ipmi/ipmi_devintf.c +1 -0
@@ -850,6 +850,7 @@ static const struct file_operations ipmi_fops = { .release = ipmi_release, .fasync = ipmi_fasync, .poll = ipmi_poll, + .llseek = noop_llseek,/* no read or write fn */ };#define DEVICE_NAME "ipmidev"
drivers/char/ipmi/ipmi_watchdog.c +1 -0
@@ -909,6 +909,7 @@ static const struct file_operations ipmi_wdog_fops = { .open = ipmi_open, .release = ipmi_close, .fasync = ipmi_fasync, + .llseek = no_llseek,/* open uses nonseekable */ };static struct miscdevice ipmi_wdog_miscdev = {
drivers/char/istallion.c +1 -0
@@ -704,6 +704,7 @@ static const struct file_operations stli_fsiomem = { .read = stli_memread, .write = stli_memwrite, .unlocked_ioctl = stli_memioctl, + .llseek = default_llseek,/* read accesses f_pos */ };/*****************************************************************************/
drivers/char/lp.c +1 -0
@@ -748,6 +748,7 @@ static const struct file_operations lp_fops = {#ifdef CONFIG_PARPORT_1284 .read = lp_read, #endif + .llseek = noop_llseek,/* read and write both use no f_pos */ };/* --- support for console on the line printer ----------------- */
drivers/char/mem.c +3 -0
@@ -804,6 +804,7 @@ static const struct file_operations full_fops = {static const struct file_operations oldmem_fops = { .read = read_oldmem, .open = open_oldmem, + .llseek = default_llseek,/* read accesses f_pos */ };#endif
@@ -830,6 +831,7 @@ static ssize_t kmsg_write(struct file *file, const char __user *buf,static const struct file_operations kmsg_fops = { .write = kmsg_write, + .llseek = noop_llseek,/* write uses no f_pos */ }; static const struct memdev {
@@ -881,6 +883,7 @@ static int memory_open(struct inode *inode, struct file *filp)static const struct file_operations memory_fops = { .open = memory_open, + .llseek = noop_llseek,/* no read or write fn */ };static char *mem_devnode (struct device *dev,mode_t *mode)
drivers/char/misc.c +1 -0
@@ -162,6 +162,7 @@ static struct class *misc_class;static const struct file_operations misc_fops = { .owner =THIS_MODULE , .open = misc_open, + .llseek = noop_llseek,/* no read or write fn */ };/**
drivers/char/mmtimer.c +1 -0
@@ -72,6 +72,7 @@ static const struct file_operations mmtimer_fops = { .owner = THIS_MODULE, .mmap = mmtimer_mmap, .unlocked_ioctl = mmtimer_ioctl, + .llseek = noop_llseek,/* no read or write fn */ };/*
drivers/char/mspec.c +6 -3
@@ -316,7 +316,8 @@ uncached_mmap(struct file *file, struct vm_area_struct *vma)static const struct file_operations fetchop_fops = { .owner =THIS_MODULE , - .mmap = fetchop_mmap + .mmap = fetchop_mmap, + .llseek = noop_llseek,/* no read or write fn */ };static struct miscdevice fetchop_miscdev = {
@@ -327,7 +328,8 @@ static struct miscdevice fetchop_miscdev = {static const struct file_operations cached_fops = { .owner =THIS_MODULE , - .mmap = cached_mmap + .mmap = cached_mmap, + .llseek = noop_llseek,/* no read or write fn */ };static struct miscdevice cached_miscdev = {
@@ -338,7 +340,8 @@ static struct miscdevice cached_miscdev = {static const struct file_operations uncached_fops = { .owner =THIS_MODULE , - .mmap = uncached_mmap + .mmap = uncached_mmap, + .llseek = noop_llseek,/* no read or write fn */ };static struct miscdevice uncached_miscdev = {
drivers/char/mwave/mwavedd.c +2 -1
@@ -479,7 +479,8 @@ static const struct file_operations mwave_fops = { .write = mwave_write, .unlocked_ioctl = mwave_ioctl, .open = mwave_open, - .release = mwave_close + .release = mwave_close, + .llseek = default_llseek,/* read accesses f_pos */ };
drivers/char/nwbutton.c +1 -0
@@ -182,6 +182,7 @@ static int button_read (struct file *filp, char __user *buffer,static const struct file_operations button_fops = { .owner =THIS_MODULE , .read = button_read, + .llseek = noop_llseek,/* read uses no f_pos */ };/*
drivers/char/pc8736x_gpio.c +1 -0
@@ -234,6 +234,7 @@ static const struct file_operations pc8736x_gpio_fileops = { .open = pc8736x_gpio_open, .write = nsc_gpio_write, .read = nsc_gpio_read, + .llseek = no_llseek,/* open uses nonseekable */ };static void __init pc8736x_init_shadow (void )
drivers/char/pcmcia/cm4000_cs.c +1 -0
@@ -1880,6 +1880,7 @@ static const struct file_operations cm4000_fops = { .unlocked_ioctl = cmm_ioctl, .open = cmm_open, .release= cmm_close, + .llseek = no_llseek,/* open uses nonseekable */ };static struct pcmcia_device_id cm4000_ids[] = {
drivers/char/pcmcia/cm4040_cs.c +1 -0
@@ -650,6 +650,7 @@ static const struct file_operations reader_fops = { .open = cm4040_open, .release = cm4040_close, .poll = cm4040_poll, + .llseek = no_llseek,/* open uses nonseekable */ };static struct pcmcia_device_id cm4040_ids[] = {
drivers/char/random.c +2 -0
@@ -1165,6 +1165,7 @@ const struct file_operations random_fops = { .poll = random_poll, .unlocked_ioctl = random_ioctl, .fasync = random_fasync, + .llseek = noop_llseek,/* read and write both use no f_pos */ };const struct file_operations urandom_fops = {
@@ -1172,6 +1173,7 @@ const struct file_operations urandom_fops = { .write = random_write, .unlocked_ioctl = random_ioctl, .fasync = random_fasync, + .llseek = noop_llseek,/* read and write both use no f_pos */ };/***************************************************************
drivers/char/rio/rio_linux.c +1 -0
@@ -241,6 +241,7 @@ static struct real_driver rio_real_driver = {static const struct file_operations rio_fw_fops = { .owner =THIS_MODULE , .unlocked_ioctl = rio_fw_ioctl, + .llseek = noop_llseek,/* no read or write fn */ };static struct miscdevice rio_fw_device = {
drivers/char/scx200_gpio.c +1 -0
@@ -67,6 +67,7 @@ static const struct file_operations scx200_gpio_fileops = { .read = nsc_gpio_read, .open = scx200_gpio_open, .release = scx200_gpio_release, + .llseek = no_llseek,/* open uses nonseekable */ };static struct cdev scx200_gpio_cdev;/* use 1 cdev for all pins */
drivers/char/snsc.c +1 -0
@@ -357,6 +357,7 @@ static const struct file_operations scdrv_fops = { .poll = scdrv_poll, .open = scdrv_open, .release = scdrv_release, + .llseek = noop_llseek,/* read and write both use no f_pos */ };static struct class *snsc_class;
drivers/char/stallion.c +1 -0
@@ -608,6 +608,7 @@ static unsigned int sc26198_baudtable[] = {static const struct file_operations stl_fsiomem = { .owner =THIS_MODULE , .unlocked_ioctl = stl_memioctl, + .llseek = noop_llseek,/* no read or write fn */ };static struct class *stallion_class;
drivers/char/sx.c +1 -0
@@ -397,6 +397,7 @@ static struct real_driver sx_real_driver = {static const struct file_operations sx_fw_fops = { .owner =THIS_MODULE , .unlocked_ioctl = sx_fw_ioctl, + .llseek = noop_llseek,/* no read or write fn */ };static struct miscdevice sx_fw_device = {
drivers/char/sysrq.c +1 -0
@@ -772,6 +772,7 @@ static ssize_t write_sysrq_trigger(struct file *file, const char __user *buf,static const struct file_operations proc_sysrq_trigger_operations = { .write = write_sysrq_trigger, + .llseek = noop_llseek,/* write uses no f_pos */ };static void sysrq_init_procfs (void )
drivers/char/tb0219.c +1 -0
@@ -261,6 +261,7 @@ static const struct file_operations tb0219_fops = { .write = tanbac_tb0219_write, .open = tanbac_tb0219_open, .release = tanbac_tb0219_release, + .llseek = no_llseek,/* open uses nonseekable */ };static void tb0219_restart (char *command)
drivers/char/tlclk.c +1 -0
@@ -268,6 +268,7 @@ static const struct file_operations tlclk_fops = { .open = tlclk_open, .release = tlclk_release, + .llseek = noop_llseek,/* read uses no f_pos */ };static struct miscdevice tlclk_miscdev = {
drivers/char/toshiba.c +1 -0
@@ -95,6 +95,7 @@ static long tosh_ioctl(struct file *, unsigned int,static const struct file_operations tosh_fops = { .owner =THIS_MODULE , .unlocked_ioctl = tosh_ioctl, + .llseek = noop_llseek,/* no read or write fn */ };static struct miscdevice tosh_device = {
drivers/char/uv_mmtimer.c +1 -0
@@ -52,6 +52,7 @@ static const struct file_operations uv_mmtimer_fops = { .owner = THIS_MODULE, .mmap = uv_mmtimer_mmap, .unlocked_ioctl = uv_mmtimer_ioctl, + .llseek = noop_llseek,/* no read or write fn */ };/**
drivers/char/virtio_console.c +3 -0
@@ -728,6 +728,7 @@ static const struct file_operations port_fops = { .write = port_fops_write, .poll = port_fops_poll, .release = port_fops_release, + .llseek = noop_llseek,/* read and write both use no f_pos */ };/*
@@ -949,6 +950,7 @@ static const struct file_operations port_debugfs_ops = { .owner = THIS_MODULE, .open = debugfs_open, .read = debugfs_read, + .llseek = default_llseek,/* read accesses f_pos */ };static void set_console_size (struct port *port,u16 rows,u16 cols)
@@ -1477,6 +1479,7 @@ fail:static const struct file_operations portdev_fops = { .owner =THIS_MODULE , + .llseek = noop_llseek,/* no read or write fn */ };/*
drivers/char/xilinx_hwicap/xilinx_hwicap.c +1 -0
@@ -567,6 +567,7 @@ static const struct file_operations hwicap_fops = { .read = hwicap_read, .open = hwicap_open, .release = hwicap_release, + .llseek = noop_llseek,/* read and write both use no f_pos */ }; static int __devinit hwicap_setup(struct device *dev, int id,
drivers/dma/coh901318.c +1 -0
@@ -157,6 +157,7 @@ static const struct file_operations coh901318_debugfs_status_operations = { .owner = THIS_MODULE, .open = coh901318_debugfs_open, .read = coh901318_debugfs_read, + .llseek = default_llseek,/* read accesses f_pos */ };
drivers/firewire/nosy.c +1 -0
@@ -405,6 +405,7 @@ static const struct file_operations nosy_ops = { .poll = nosy_poll, .open = nosy_open, .release = nosy_release, + .llseek = noop_llseek,/* read uses no f_pos */ };#define PHY_PACKET_SIZE 12/* 1 payload, 1 inverse, 1 ack = 3 quadlets */
drivers/gpu/drm/drm_drv.c +2 -1
@@ -284,7 +284,8 @@ EXPORT_SYMBOL(drm_exit);/** File operations structure */ static const struct file_operations drm_stub_fops = { .owner =THIS_MODULE , - .open = drm_stub_open + .open = drm_stub_open, + .llseek = noop_llseek,/* no read or write fn */ };static int __init drm_core_init (void )
drivers/gpu/drm/i810/i810_dma.c +1 -0
@@ -119,6 +119,7 @@ static const struct file_operations i810_buffer_fops = { .unlocked_ioctl = drm_ioctl, .mmap = i810_mmap_buffers, .fasync = drm_fasync, + .llseek = noop_llseek,/* no read or write fn */ };static int i810_map_buffer (struct drm_buf *buf,struct drm_file *file_priv)
drivers/gpu/drm/i830/i830_dma.c +1 -0
@@ -121,6 +121,7 @@ static const struct file_operations i830_buffer_fops = { .unlocked_ioctl = drm_ioctl, .mmap = i830_mmap_buffers, .fasync = drm_fasync, + .llseek = noop_llseek,/* no read or write fn */ };static int i830_map_buffer (struct drm_buf *buf,struct drm_file *file_priv)
drivers/gpu/drm/i915/i915_debugfs.c +1 -0
@@ -733,6 +733,7 @@ static const struct file_operations i915_wedged_fops = { .open = i915_wedged_open, .read = i915_wedged_read, .write = i915_wedged_write, + .llseek = default_llseek,/* read accesses f_pos */ };/* As the drm_debugfs_init() routines are called before dev->dev_private is
drivers/gpu/vga/vgaarb.c +1 -0
@@ -1211,6 +1211,7 @@ static const struct file_operations vga_arb_device_fops = { .poll = vga_arb_fpoll, .open = vga_arb_open, .release = vga_arb_release, + .llseek = noop_llseek,/* read and write both use no f_pos */ };static struct miscdevice vga_arb_device = {
drivers/hid/hid-debug.c +1 -0
@@ -1051,6 +1051,7 @@ static const struct file_operations hid_debug_events_fops = { .read = hid_debug_events_read, .poll = hid_debug_events_poll, .release = hid_debug_events_release, + .llseek = noop_llseek,/* read uses no f_pos */ };
drivers/hid/hid-roccat.c +1 -0
@@ -384,6 +384,7 @@ static const struct file_operations roccat_ops = { .poll = roccat_poll, .open = roccat_open, .release = roccat_release, + .llseek = noop_llseek,/* read uses no f_pos */ };static int __init roccat_init (void )
drivers/hid/hidraw.c +1 -0
@@ -329,6 +329,7 @@ static const struct file_operations hidraw_ops = { .open = hidraw_open, .release = hidraw_release, .unlocked_ioctl = hidraw_ioctl, + .llseek = noop_llseek,/* read and write both use no f_pos */ };void hidraw_report_event (struct hid_device *hid,u8 *data,int len)
drivers/hid/usbhid/hiddev.c +1 -0
@@ -847,6 +847,7 @@ static const struct file_operations hiddev_fops = {#ifdef CONFIG_COMPAT .compat_ioctl = hiddev_compat_ioctl, #endif + .llseek = noop_llseek,/* read and write both use no f_pos */ };static char *hiddev_devnode (struct device *dev,mode_t *mode)
drivers/hwmon/asus_atk0110.c +1 -0
@@ -762,6 +762,7 @@ static const struct file_operations atk_debugfs_ggrp_fops = { .read = atk_debugfs_ggrp_read, .open = atk_debugfs_ggrp_open, .release = atk_debugfs_ggrp_release, + .llseek = no_llseek,/* open uses nonseekable */ };static void atk_debugfs_init (struct atk_data *data)
drivers/ide/ide-tape.c +1 -0
@@ -1903,6 +1903,7 @@ static const struct file_operations idetape_fops = { .unlocked_ioctl = idetape_chrdev_ioctl, .open = idetape_chrdev_open, .release = idetape_chrdev_release, + .llseek = noop_llseek,/* read and write both use no f_pos */ };static int idetape_open (struct block_device *bdev,fmode_t mode)
drivers/idle/i7300_idle.c +1 -0
@@ -536,6 +536,7 @@ static ssize_t stats_read_ul(struct file *fp, char __user *ubuf, size_t count,static const struct file_operations idle_fops = { .open = stats_open_generic, .read = stats_read_ul, + .llseek = default_llseek,/* read accesses f_pos */ };struct debugfs_file_info {
drivers/infiniband/hw/cxgb4/device.c +1 -0
@@ -186,6 +186,7 @@ static const struct file_operations qp_debugfs_fops = { .open = qp_open, .release = qp_release, .read = qp_read, + .llseek = default_llseek,/* read accesses f_pos */ };static int setup_debugfs (struct c4iw_dev *devp)
drivers/infiniband/hw/ipath/ipath_diag.c +3 -1
@@ -65,7 +65,8 @@ static const struct file_operations diag_file_ops = { .write = ipath_diag_write, .read = ipath_diag_read, .open = ipath_diag_open, - .release = ipath_diag_release + .release = ipath_diag_release, + .llseek = default_llseek,/* read accesses f_pos */ }; static ssize_t ipath_diagpkt_write(struct file *fp,
@@ -75,6 +76,7 @@ static ssize_t ipath_diagpkt_write(struct file *fp,static const struct file_operations diagpkt_file_ops = { .owner =THIS_MODULE , .write = ipath_diagpkt_write, + .llseek = noop_llseek,/* write uses no f_pos */ };static atomic_t diagpkt_count =ATOMIC_INIT (0 );
drivers/infiniband/hw/ipath/ipath_file_ops.c +2 -1
@@ -63,7 +63,8 @@ static const struct file_operations ipath_file_ops = { .open = ipath_open, .release = ipath_close, .poll = ipath_poll, - .mmap = ipath_mmap + .mmap = ipath_mmap, + .llseek = noop_llseek,/* write uses no f_pos */ };/*
drivers/infiniband/hw/ipath/ipath_fs.c +3 -0
@@ -103,6 +103,7 @@ static ssize_t atomic_stats_read(struct file *file, char __user *buf,static const struct file_operations atomic_stats_ops = { .read = atomic_stats_read, + .llseek = default_llseek,/* read accesses f_pos */ }; static ssize_t atomic_counters_read(struct file *file, char __user *buf,
@@ -120,6 +121,7 @@ static ssize_t atomic_counters_read(struct file *file, char __user *buf,static const struct file_operations atomic_counters_ops = { .read = atomic_counters_read, + .llseek = default_llseek,/* read accesses f_pos */ }; static ssize_t flash_read(struct file *file, char __user *buf,
@@ -224,6 +226,7 @@ bail:static const struct file_operations flash_ops = { .read = flash_read, .write = flash_write, + .llseek = default_llseek,/* read accesses f_pos */ }; static int create_device_files(struct super_block *sb,
drivers/infiniband/hw/qib/qib_diag.c +3 -1
@@ -136,7 +136,8 @@ static const struct file_operations diag_file_ops = { .write = qib_diag_write, .read = qib_diag_read, .open = qib_diag_open, - .release = qib_diag_release + .release = qib_diag_release, + .llseek = default_llseek,/* read accesses f_pos */ };static atomic_t diagpkt_count =ATOMIC_INIT (0 );
@@ -149,6 +150,7 @@ static ssize_t qib_diagpkt_write(struct file *fp, const char __user *data,static const struct file_operations diagpkt_file_ops = { .owner =THIS_MODULE , .write = qib_diagpkt_write, + .llseek = noop_llseek,/* write uses no f_pos */ };int qib_diag_add (struct qib_devdata *dd)
drivers/infiniband/hw/qib/qib_file_ops.c +2 -1
@@ -63,7 +63,8 @@ static const struct file_operations qib_file_ops = { .open = qib_open, .release = qib_close, .poll = qib_poll, - .mmap = qib_mmapf + .mmap = qib_mmapf, + .llseek = noop_llseek,/* write uses no f_pos */ };/*
drivers/infiniband/hw/qib/qib_fs.c +1 -0
@@ -367,6 +367,7 @@ bail:static const struct file_operations flash_ops = { .read = flash_read, .write = flash_write, + .llseek = default_llseek,/* read accesses f_pos */ };static int add_cntr_files (struct super_block *sb,struct qib_devdata *dd)
drivers/input/evdev.c +2 -1
@@ -761,7 +761,8 @@ static const struct file_operations evdev_fops = { .compat_ioctl = evdev_ioctl_compat, #endif .fasync = evdev_fasync, - .flush = evdev_flush + .flush = evdev_flush, + .llseek = no_llseek,/* open uses nonseekable */ };static int evdev_install_chrdev (struct evdev *evdev)
drivers/input/input.c +1 -0
@@ -2040,6 +2040,7 @@ out:static const struct file_operations input_fops = { .owner =THIS_MODULE , .open = input_open_file, + .llseek = noop_llseek,/* no read or write fn */ };static int __init input_init (void )
drivers/input/joydev.c +1 -0
@@ -736,6 +736,7 @@ static const struct file_operations joydev_fops = { .compat_ioctl = joydev_compat_ioctl, #endif .fasync = joydev_fasync, + .llseek = no_llseek,/* open uses nonseekable */ };static int joydev_install_chrdev (struct joydev *joydev)
drivers/input/misc/uinput.c +1 -0
@@ -804,6 +804,7 @@ static const struct file_operations uinput_fops = { #ifdef CONFIG_COMPAT .compat_ioctl = uinput_compat_ioctl, #endif + .llseek = no_llseek,/* open uses nonseekable */ }; static struct miscdevice uinput_misc = {
drivers/input/mousedev.c +1 -0
@@ -792,6 +792,7 @@ static const struct file_operations mousedev_fops = { .open = mousedev_open, .release = mousedev_release, .fasync = mousedev_fasync, + .llseek = noop_llseek,/* read and write both use no f_pos */ };static int mousedev_install_chrdev (struct mousedev *mousedev)
drivers/input/serio/serio_raw.c +1 -0
@@ -243,6 +243,7 @@ static const struct file_operations serio_raw_fops = { .write = serio_raw_write, .poll = serio_raw_poll, .fasync = serio_raw_fasync, + .llseek = noop_llseek,/* read and write both use no f_pos */ };
drivers/isdn/mISDN/timerdev.c +1 -0
@@ -267,6 +267,7 @@ static const struct file_operations mISDN_fops = { .unlocked_ioctl = mISDN_ioctl, .open = mISDN_open, .release = mISDN_close, + .llseek = no_llseek,/* open uses nonseekable */ };static struct miscdevice mISDNtimer = {
drivers/lguest/lguest_user.c +1 -0
@@ -514,6 +514,7 @@ static const struct file_operations lguest_fops = { .release = close, .write = write, .read = read, + .llseek = default_llseek,/* read accesses f_pos */ };/*
drivers/macintosh/ans-lcd.c +1 -0
@@ -137,6 +137,7 @@ const struct file_operations anslcd_fops = { .write = anslcd_write, .unlocked_ioctl = anslcd_ioctl, .open = anslcd_open, + .llseek = default_llseek,/* write accesses f_pos */ };static struct miscdevice anslcd_dev = {
drivers/macintosh/via-pmu.c +1 -0
@@ -2398,6 +2398,7 @@ static const struct file_operations pmu_device_fops = {#endif .open = pmu_open, .release = pmu_release, + .llseek = noop_llseek,/* read and write both use no f_pos */ };static struct miscdevice pmu_device = {
drivers/md/dm-ioctl.c +1 -0
@@ -1596,6 +1596,7 @@ static const struct file_operations _ctl_fops = { .unlocked_ioctl = dm_ctl_ioctl, .compat_ioctl = dm_compat_ctl_ioctl, .owner = THIS_MODULE, + .llseek = noop_llseek,/* no read or write fn */ };static struct miscdevice _dm_misc = {
drivers/media/IR/imon.c +4 -2
@@ -151,7 +151,8 @@ static const struct file_operations vfd_fops = { .owner = THIS_MODULE, .open = &display_open, .write = &vfd_write, - .release = &display_close + .release = &display_close, + .llseek = noop_llseek,/* no read or write fn */ };/* lcd character device file operations */
@@ -159,7 +160,8 @@ static const struct file_operations lcd_fops = { .owner = THIS_MODULE, .open = &display_open, .write = &lcd_write, - .release = &display_close + .release = &display_close, + .llseek = noop_llseek,/* no read or write fn */ };enum {
drivers/media/IR/lirc_dev.c +1 -0
@@ -163,6 +163,7 @@ static struct file_operations fops = { .unlocked_ioctl = lirc_dev_fop_ioctl, .open = lirc_dev_fop_open, .release = lirc_dev_fop_close, + .llseek = noop_llseek,/* read and write both use no f_pos */ };static int lirc_cdev_add (struct irctl *ir)
drivers/media/dvb/bt8xx/dst_ca.c +2 -1
@@ -694,7 +694,8 @@ static const struct file_operations dst_ca_fops = { .open = dst_ca_open, .release = dst_ca_release, .read = dst_ca_read, - .write = dst_ca_write + .write = dst_ca_write, + .llseek = noop_llseek,/* read and write both use no f_pos */ };static struct dvb_device dvbdev_ca = {
drivers/media/dvb/dvb-core/dmxdev.c +2 -0
@@ -1150,6 +1150,7 @@ static const struct file_operations dvb_demux_fops = { .open = dvb_demux_open, .release = dvb_demux_release, .poll = dvb_demux_poll, + .llseek = default_llseek,/* read accesses f_pos */ };static struct dvb_device dvbdev_demux = {
@@ -1225,6 +1226,7 @@ static const struct file_operations dvb_dvr_fops = { .open = dvb_dvr_open, .release = dvb_dvr_release, .poll = dvb_dvr_poll, + .llseek = default_llseek,/* read accesses f_pos */ };static struct dvb_device dvbdev_dvr = {
drivers/media/dvb/dvb-core/dvb_ca_en50221.c +1 -0
@@ -1628,6 +1628,7 @@ static const struct file_operations dvb_ca_fops = { .open = dvb_ca_en50221_io_open, .release = dvb_ca_en50221_io_release, .poll = dvb_ca_en50221_io_poll, + .llseek = noop_llseek,/* read and write both use no f_pos */ };static struct dvb_device dvbdev_ca = {
drivers/media/dvb/dvb-core/dvb_frontend.c +2 -1
@@ -2034,7 +2034,8 @@ static const struct file_operations dvb_frontend_fops = { .unlocked_ioctl = dvb_generic_ioctl, .poll = dvb_frontend_poll, .open = dvb_frontend_open, - .release = dvb_frontend_release + .release = dvb_frontend_release, + .llseek = noop_llseek,/* no read or write fn */ }; int dvb_register_frontend(struct dvb_adapter* dvb,
drivers/media/dvb/dvb-core/dvb_net.c +1 -0
@@ -1475,6 +1475,7 @@ static const struct file_operations dvb_net_fops = { .unlocked_ioctl = dvb_net_ioctl, .open = dvb_generic_open, .release = dvb_net_close, + .llseek = noop_llseek,/* no read or write fn */ };static struct dvb_device dvbdev_net = {
drivers/media/dvb/dvb-core/dvbdev.c +1 -0
@@ -105,6 +105,7 @@ static const struct file_operations dvb_device_fops = { .owner = THIS_MODULE, .open = dvb_device_open, + .llseek = noop_llseek,/* no read or write fn */ };static struct cdev dvb_device_cdev;
drivers/media/dvb/firewire/firedtv-ci.c +1 -0
@@ -220,6 +220,7 @@ static const struct file_operations fdtv_ca_fops = { .open = dvb_generic_open, .release = dvb_generic_release, .poll = fdtv_ca_io_poll, + .llseek = noop_llseek,/* no read or write fn */ };static struct dvb_device fdtv_ca = {
drivers/media/dvb/ttpci/av7110.c +1 -0
@@ -730,6 +730,7 @@ static const struct file_operations dvb_osd_fops = { .unlocked_ioctl = dvb_generic_ioctl, .open = dvb_generic_open, .release = dvb_generic_release, + .llseek = noop_llseek,/* no read or write fn */ };static struct dvb_device dvbdev_osd = {
drivers/media/dvb/ttpci/av7110_av.c +2 -0
@@ -1521,6 +1521,7 @@ static const struct file_operations dvb_video_fops = { .open = dvb_video_open, .release = dvb_video_release, .poll = dvb_video_poll, + .llseek = noop_llseek,/* write uses no f_pos */ };static struct dvb_device dvbdev_video = {
@@ -1539,6 +1540,7 @@ static const struct file_operations dvb_audio_fops = { .open = dvb_audio_open, .release = dvb_audio_release, .poll = dvb_audio_poll, + .llseek = noop_llseek,/* write uses no f_pos */ };static struct dvb_device dvbdev_audio = {
drivers/media/dvb/ttpci/av7110_ca.c +1 -0
@@ -353,6 +353,7 @@ static const struct file_operations dvb_ca_fops = { .open = dvb_ca_open, .release = dvb_generic_release, .poll = dvb_ca_poll, + .llseek = default_llseek,/* read accesses f_pos */ };static struct dvb_device dvbdev_ca = {
drivers/media/dvb/ttpci/av7110_ir.c +1 -0
@@ -312,6 +312,7 @@ static ssize_t av7110_ir_proc_write(struct file *file, const char __user *bufferstatic const struct file_operations av7110_ir_proc_fops = { .owner =THIS_MODULE , .write = av7110_ir_proc_write, + .llseek = noop_llseek,/* write uses no f_pos */ };/* interrupt handler */
drivers/mfd/ab3100-core.c +1 -0
@@ -583,6 +583,7 @@ static ssize_t ab3100_get_set_reg(struct file *file,static const struct file_operations ab3100_get_set_reg_fops = { .open = ab3100_get_set_reg_open_file, .write = ab3100_get_set_reg, + .llseek = noop_llseek,/* write uses no f_pos */ };static struct dentry *ab3100_dir;
drivers/misc/hpilo.c +1 -0
@@ -640,6 +640,7 @@ static const struct file_operations ilo_fops = { .poll = ilo_poll, .open = ilo_open, .release = ilo_close, + .llseek = noop_llseek,/* read and write both use no f_pos */ };static irqreturn_t ilo_isr (int irq,void *data)
drivers/misc/phantom.c +1 -0
@@ -279,6 +279,7 @@ static const struct file_operations phantom_file_ops = { .unlocked_ioctl = phantom_ioctl, .compat_ioctl = phantom_compat_ioctl, .poll = phantom_poll, + .llseek = no_llseek,/* open uses nonseekable */ };static irqreturn_t phantom_isr (int irq,void *data)
drivers/misc/sgi-gru/grufile.c +1 -0
@@ -587,6 +587,7 @@ static const struct file_operations gru_fops = { .owner = THIS_MODULE, .unlocked_ioctl = gru_file_unlocked_ioctl, .mmap = gru_file_mmap, + .llseek = noop_llseek,/* no read or write fn */ };static struct miscdevice gru_miscdev = {
drivers/mmc/core/debugfs.c +1 -0
@@ -245,6 +245,7 @@ static const struct file_operations mmc_dbg_ext_csd_fops = { .open = mmc_ext_csd_open, .read = mmc_ext_csd_read, .release = mmc_ext_csd_release, + .llseek = default_llseek,/* read accesses f_pos */ };void mmc_add_card_debugfs (struct mmc_card *card)
drivers/mtd/ubi/cdev.c +1 -0
@@ -1100,4 +1100,5 @@ const struct file_operations ubi_ctrl_cdev_operations = { .owner = THIS_MODULE, .unlocked_ioctl = ctrl_cdev_ioctl, .compat_ioctl = ctrl_cdev_compat_ioctl, + .llseek = noop_llseek,/* no read or write fn */ };
drivers/net/caif/caif_spi.c +4 -2
@@ -240,13 +240,15 @@ static ssize_t dbgfs_frame(struct file *file, char __user *user_buf,static const struct file_operations dbgfs_state_fops = { .open = dbgfs_open, .read = dbgfs_state, - .owner =THIS_MODULE + .owner =THIS_MODULE , + .llseek = default_llseek,/* read accesses f_pos */ };static const struct file_operations dbgfs_frame_fops = { .open = dbgfs_open, .read = dbgfs_frame, - .owner =THIS_MODULE + .owner =THIS_MODULE , + .llseek = default_llseek,/* read accesses f_pos */ };static inline void dev_debugfs_add (struct cfspi *cfspi)
drivers/net/cxgb4/cxgb4_main.c +1 -0
@@ -2026,6 +2026,7 @@ static const struct file_operations mem_debugfs_fops = { .owner = THIS_MODULE, .open = mem_open, .read = mem_read, + .llseek = default_llseek,/* read accesses f_pos */ }; static void __devinit add_debugfs_mem(struct adapter *adap, const char *name,
drivers/net/ppp_generic.c +2 -1
@@ -856,7 +856,8 @@ static const struct file_operations ppp_device_fops = { .poll = ppp_poll, .unlocked_ioctl = ppp_ioctl, .open = ppp_open, - .release = ppp_release + .release = ppp_release, + .llseek = noop_llseek,/* read and write both use no f_pos */ };static __net_init int ppp_init_net (struct net *net)
drivers/net/wimax/i2400m/debugfs.c +2 -0
@@ -119,6 +119,7 @@ const struct file_operations i2400m_rx_stats_fops = { .open = i2400m_stats_open, .read = i2400m_rx_stats_read, .write = i2400m_rx_stats_write, + .llseek = default_llseek,/* read accesses f_pos */ };
@@ -171,6 +172,7 @@ const struct file_operations i2400m_tx_stats_fops = { .open = i2400m_stats_open, .read = i2400m_tx_stats_read, .write = i2400m_tx_stats_write, + .llseek = default_llseek,/* read accesses f_pos */ };
drivers/net/wireless/airo.c +16 -8
@@ -4430,21 +4430,24 @@ static const struct file_operations proc_statsdelta_ops = { .owner = THIS_MODULE, .read = proc_read, .open = proc_statsdelta_open, - .release = proc_close + .release = proc_close, + .llseek = default_llseek,/* read accesses f_pos */ };static const struct file_operations proc_stats_ops = { .owner =THIS_MODULE , .read = proc_read, .open = proc_stats_open, - .release = proc_close + .release = proc_close, + .llseek = default_llseek,/* read accesses f_pos */ };static const struct file_operations proc_status_ops = { .owner =THIS_MODULE , .read = proc_read, .open = proc_status_open, - .release = proc_close + .release = proc_close, + .llseek = default_llseek,/* read accesses f_pos */ };static const struct file_operations proc_SSID_ops = {
@@ -4452,7 +4455,8 @@ static const struct file_operations proc_SSID_ops = { .read = proc_read, .write = proc_write, .open = proc_SSID_open, - .release = proc_close + .release = proc_close, + .llseek = default_llseek,/* read accesses f_pos */ };static const struct file_operations proc_BSSList_ops = {
@@ -4460,7 +4464,8 @@ static const struct file_operations proc_BSSList_ops = { .read = proc_read, .write = proc_write, .open = proc_BSSList_open, - .release = proc_close + .release = proc_close, + .llseek = default_llseek,/* read accesses f_pos */ };static const struct file_operations proc_APList_ops = {
@@ -4468,7 +4473,8 @@ static const struct file_operations proc_APList_ops = { .read = proc_read, .write = proc_write, .open = proc_APList_open, - .release = proc_close + .release = proc_close, + .llseek = default_llseek,/* read accesses f_pos */ };static const struct file_operations proc_config_ops = {
@@ -4476,7 +4482,8 @@ static const struct file_operations proc_config_ops = { .read = proc_read, .write = proc_write, .open = proc_config_open, - .release = proc_close + .release = proc_close, + .llseek = default_llseek,/* read accesses f_pos */ };static const struct file_operations proc_wepkey_ops = {
@@ -4484,7 +4491,8 @@ static const struct file_operations proc_wepkey_ops = { .read = proc_read, .write = proc_write, .open = proc_wepkey_open, - .release = proc_close + .release = proc_close, + .llseek = default_llseek,/* read accesses f_pos */ };static struct proc_dir_entry *airo_entry;
drivers/net/wireless/ath/ath5k/debug.c +7 -0
@@ -271,6 +271,7 @@ static const struct file_operations fops_beacon = { .write = write_file_beacon, .open = ath5k_debugfs_open, .owner = THIS_MODULE, + .llseek = default_llseek,/* read accesses f_pos */ };
@@ -290,6 +291,7 @@ static const struct file_operations fops_reset = { .write = write_file_reset, .open = ath5k_debugfs_open, .owner = THIS_MODULE, + .llseek = noop_llseek,/* write uses no f_pos */ };
@@ -369,6 +371,7 @@ static const struct file_operations fops_debug = { .write = write_file_debug, .open = ath5k_debugfs_open, .owner = THIS_MODULE, + .llseek = default_llseek,/* read accesses f_pos */ };
@@ -480,6 +483,7 @@ static const struct file_operations fops_antenna = { .write = write_file_antenna, .open = ath5k_debugfs_open, .owner = THIS_MODULE, + .llseek = default_llseek,/* read accesses f_pos */ };
@@ -591,6 +595,7 @@ static const struct file_operations fops_frameerrors = { .write = write_file_frameerrors, .open = ath5k_debugfs_open, .owner = THIS_MODULE, + .llseek = default_llseek,/* read accesses f_pos */ };
@@ -748,6 +753,7 @@ static const struct file_operations fops_ani = { .write = write_file_ani, .open = ath5k_debugfs_open, .owner = THIS_MODULE, + .llseek = default_llseek,/* read accesses f_pos */ };
@@ -811,6 +817,7 @@ static const struct file_operations fops_queue = { .write = write_file_queue, .open = ath5k_debugfs_open, .owner = THIS_MODULE, + .llseek = default_llseek,/* read accesses f_pos */ };
drivers/net/wireless/ath/ath9k/debug.c +22 -11
@@ -71,7 +71,8 @@ static const struct file_operations fops_debug = { .read = read_file_debug, .write = write_file_debug, .open = ath9k_debugfs_open, - .owner =THIS_MODULE + .owner = THIS_MODULE, + .llseek = default_llseek,/* read accesses f_pos */ };#endif
@@ -116,7 +117,8 @@ static const struct file_operations fops_tx_chainmask = { .read = read_file_tx_chainmask, .write = write_file_tx_chainmask, .open = ath9k_debugfs_open, - .owner = THIS_MODULE + .owner = THIS_MODULE, + .llseek = default_llseek,/* read accesses f_pos */ };
@@ -158,7 +160,8 @@ static const struct file_operations fops_rx_chainmask = { .read = read_file_rx_chainmask, .write = write_file_rx_chainmask, .open = ath9k_debugfs_open, - .owner = THIS_MODULE + .owner = THIS_MODULE, + .llseek = default_llseek,/* read accesses f_pos */ };
@@ -259,7 +262,8 @@ static ssize_t read_file_dma(struct file *file, char __user *user_buf,static const struct file_operations fops_dma = { .read = read_file_dma, .open = ath9k_debugfs_open, - .owner =THIS_MODULE + .owner =THIS_MODULE , + .llseek = default_llseek,/* read accesses f_pos */ };
@@ -375,7 +379,8 @@ static ssize_t read_file_interrupt(struct file *file, char __user *user_buf,static const struct file_operations fops_interrupt = { .read = read_file_interrupt, .open = ath9k_debugfs_open, - .owner =THIS_MODULE + .owner =THIS_MODULE , + .llseek = default_llseek,/* read accesses f_pos */ };void ath_debug_stat_rc (struct ath_softc *sc,int final_rate)
@@ -464,7 +469,8 @@ static ssize_t read_file_rcstat(struct file *file, char __user *user_buf,static const struct file_operations fops_rcstat = { .read = read_file_rcstat, .open = ath9k_debugfs_open, - .owner =THIS_MODULE + .owner =THIS_MODULE , + .llseek = default_llseek,/* read accesses f_pos */ };static const char *ath_wiphy_state_str (enum ath_wiphy_state state)
@@ -623,7 +629,8 @@ static const struct file_operations fops_wiphy = { .read = read_file_wiphy, .write = write_file_wiphy, .open = ath9k_debugfs_open, - .owner = THIS_MODULE + .owner = THIS_MODULE, + .llseek = default_llseek,/* read accesses f_pos */ };#define PR (str, elem) \
@@ -702,7 +709,8 @@ void ath_debug_stat_tx(struct ath_softc *sc, struct ath_txq *txq,static const struct file_operations fops_xmit = { .read = read_file_xmit, .open = ath9k_debugfs_open, - .owner =THIS_MODULE + .owner =THIS_MODULE , + .llseek = default_llseek,/* read accesses f_pos */ }; static ssize_t read_file_recv(struct file *file, char __user *user_buf,
@@ -814,7 +822,8 @@ void ath_debug_stat_rx(struct ath_softc *sc, struct ath_rx_status *rs)static const struct file_operations fops_recv = { .read = read_file_recv, .open = ath9k_debugfs_open, - .owner =THIS_MODULE + .owner =THIS_MODULE , + .llseek = default_llseek,/* read accesses f_pos */ }; static ssize_t read_file_regidx(struct file *file, char __user *user_buf,
@@ -852,7 +861,8 @@ static const struct file_operations fops_regidx = { .read = read_file_regidx, .write = write_file_regidx, .open = ath9k_debugfs_open, - .owner = THIS_MODULE + .owner = THIS_MODULE, + .llseek = default_llseek,/* read accesses f_pos */ }; static ssize_t read_file_regval(struct file *file, char __user *user_buf,
@@ -894,7 +904,8 @@ static const struct file_operations fops_regval = { .read = read_file_regval, .write = write_file_regval, .open = ath9k_debugfs_open, - .owner = THIS_MODULE + .owner = THIS_MODULE, + .llseek = default_llseek,/* read accesses f_pos */ };int ath9k_init_debug (struct ath_hw *ah)
drivers/net/wireless/ath/ath9k/htc_drv_main.c +6 -3
@@ -536,7 +536,8 @@ static ssize_t read_file_tgt_stats(struct file *file, char __user *user_buf,static const struct file_operations fops_tgt_stats = { .read = read_file_tgt_stats, .open = ath9k_debugfs_open, - .owner =THIS_MODULE + .owner =THIS_MODULE , + .llseek = default_llseek,/* read accesses f_pos */ }; static ssize_t read_file_xmit(struct file *file, char __user *user_buf,
@@ -584,7 +585,8 @@ static ssize_t read_file_xmit(struct file *file, char __user *user_buf,static const struct file_operations fops_xmit = { .read = read_file_xmit, .open = ath9k_debugfs_open, - .owner =THIS_MODULE + .owner =THIS_MODULE , + .llseek = default_llseek,/* read accesses f_pos */ }; static ssize_t read_file_recv(struct file *file, char __user *user_buf,
@@ -613,7 +615,8 @@ static ssize_t read_file_recv(struct file *file, char __user *user_buf,static const struct file_operations fops_recv = { .read = read_file_recv, .open = ath9k_debugfs_open, - .owner =THIS_MODULE + .owner =THIS_MODULE , + .llseek = default_llseek,/* read accesses f_pos */ };int ath9k_htc_init_debug (struct ath_hw *ah)
drivers/net/wireless/iwlwifi/iwl-3945-rs.c +1 -0
@@ -873,6 +873,7 @@ static ssize_t iwl3945_sta_dbgfs_stats_table_read(struct file *file,static const struct file_operations rs_sta_dbgfs_stats_table_ops = { .read = iwl3945_sta_dbgfs_stats_table_read, .open = iwl3945_open_file_generic, + .llseek = default_llseek,/* read accesses f_pos */ }; static void iwl3945_add_debugfs(void *priv, void *priv_sta,
drivers/net/wireless/iwlwifi/iwl-agn-rs.c +3 -0
@@ -2873,6 +2873,7 @@ static const struct file_operations rs_sta_dbgfs_scale_table_ops = { .write = rs_sta_dbgfs_scale_table_write, .read = rs_sta_dbgfs_scale_table_read, .open = open_file_generic, + .llseek = default_llseek,/* read accesses f_pos */ };static ssize_t rs_sta_dbgfs_stats_table_read (struct file *file,char __user *user_buf,size_t count,loff_t *ppos)
@@ -2915,6 +2916,7 @@ static ssize_t rs_sta_dbgfs_stats_table_read(struct file *file,static const struct file_operations rs_sta_dbgfs_stats_table_ops = { .read = rs_sta_dbgfs_stats_table_read, .open = open_file_generic, + .llseek = default_llseek,/* read accesses f_pos */ }; static ssize_t rs_sta_dbgfs_rate_scale_data_read(struct file *file,
@@ -2946,6 +2948,7 @@ static ssize_t rs_sta_dbgfs_rate_scale_data_read(struct file *file,static const struct file_operations rs_sta_dbgfs_rate_scale_data_ops = { .read = rs_sta_dbgfs_rate_scale_data_read, .open = open_file_generic, + .llseek = default_llseek,/* read accesses f_pos */ }; static void rs_add_debugfs(void *priv, void *priv_sta,
drivers/net/wireless/iwmc3200wifi/debugfs.c +4 -0
@@ -402,24 +402,28 @@ static const struct file_operations iwm_debugfs_txq_fops = { .owner = THIS_MODULE, .open = iwm_generic_open, .read = iwm_debugfs_txq_read, + .llseek = default_llseek,/* read accesses f_pos */ };static const struct file_operations iwm_debugfs_tx_credit_fops = { .owner =THIS_MODULE , .open = iwm_generic_open, .read = iwm_debugfs_tx_credit_read, + .llseek = default_llseek,/* read accesses f_pos */ };static const struct file_operations iwm_debugfs_rx_ticket_fops = { .owner =THIS_MODULE , .open = iwm_generic_open, .read = iwm_debugfs_rx_ticket_read, + .llseek = default_llseek,/* read accesses f_pos */ };static const struct file_operations iwm_debugfs_fw_err_fops = { .owner =THIS_MODULE , .open = iwm_generic_open, .read = iwm_debugfs_fw_err_read, + .llseek = default_llseek,/* read accesses f_pos */ };void iwm_debugfs_init (struct iwm_priv *iwm)
drivers/net/wireless/iwmc3200wifi/sdio.c +1 -0
@@ -364,6 +364,7 @@ static const struct file_operations iwm_debugfs_sdio_fops = { .owner = THIS_MODULE, .open = iwm_debugfs_sdio_open, .read = iwm_debugfs_sdio_read, + .llseek = default_llseek,/* read accesses f_pos */ };static void if_sdio_debugfs_init (struct iwm_priv *iwm,struct dentry *parent_dir)
drivers/net/wireless/libertas/debugfs.c +1 -0
@@ -962,6 +962,7 @@ static const struct file_operations lbs_debug_fops = { .open = open_file_generic, .write = lbs_debugfs_write, .read = lbs_debugfs_read, + .llseek = default_llseek,/* read accesses f_pos */ };/**
drivers/net/wireless/ray_cs.c +2 -0
@@ -2802,6 +2802,7 @@ static ssize_t ray_cs_essid_proc_write(struct file *file,static const struct file_operations ray_cs_essid_proc_fops = { .owner =THIS_MODULE , .write = ray_cs_essid_proc_write, + .llseek = noop_llseek,/* write uses no f_pos */ }; static ssize_t int_proc_write(struct file *file, const char __user *buffer,
@@ -2835,6 +2836,7 @@ static ssize_t int_proc_write(struct file *file, const char __user *buffer,static const struct file_operations int_proc_fops = { .owner =THIS_MODULE , .write = int_proc_write, + .llseek = noop_llseek,/* write uses no f_pos */ };#endif
drivers/net/wireless/rt2x00/rt2x00debug.c +4 -0
@@ -315,6 +315,7 @@ static const struct file_operations rt2x00debug_fop_queue_dump = { .poll = rt2x00debug_poll_queue_dump, .open = rt2x00debug_open_queue_dump, .release = rt2x00debug_release_queue_dump, + .llseek = default_llseek,/* read accesses f_pos */ }; static ssize_t rt2x00debug_read_queue_stats(struct file *file,
@@ -371,6 +372,7 @@ static const struct file_operations rt2x00debug_fop_queue_stats = { .read = rt2x00debug_read_queue_stats, .open = rt2x00debug_file_open, .release = rt2x00debug_file_release, + .llseek = default_llseek,/* read accesses f_pos */ };#ifdef CONFIG_RT2X00_LIB_CRYPTO
@@ -423,6 +425,7 @@ static const struct file_operations rt2x00debug_fop_crypto_stats = { .read = rt2x00debug_read_crypto_stats, .open = rt2x00debug_file_open, .release = rt2x00debug_file_release, + .llseek = default_llseek,/* read accesses f_pos */ };#endif
@@ -543,6 +546,7 @@ static const struct file_operations rt2x00debug_fop_dev_flags = { .read = rt2x00debug_read_dev_flags, .open = rt2x00debug_file_open, .release = rt2x00debug_file_release, + .llseek = default_llseek,/* read accesses f_pos */ }; static struct dentry *rt2x00debug_create_file_driver(const char *name,
drivers/net/wireless/wl12xx/wl1251_debugfs.c +2 -0
@@ -238,6 +238,7 @@ static ssize_t tx_queue_len_read(struct file *file, char __user *userbuf,static const struct file_operations tx_queue_len_ops = { .read = tx_queue_len_read, .open = wl1251_open_file_generic, + .llseek = default_llseek,/* read accesses f_pos */ }; static ssize_t tx_queue_status_read(struct file *file, char __user *userbuf,
@@ -259,6 +260,7 @@ static ssize_t tx_queue_status_read(struct file *file, char __user *userbuf,static const struct file_operations tx_queue_status_ops = { .read = tx_queue_status_read, .open = wl1251_open_file_generic, + .llseek = default_llseek,/* read accesses f_pos */ };static void wl1251_debugfs_delete_files (struct wl1251 *wl)
drivers/net/wireless/wl12xx/wl1271_debugfs.c +3 -1
@@ -239,6 +239,7 @@ static ssize_t tx_queue_len_read(struct file *file, char __user *userbuf,static const struct file_operations tx_queue_len_ops = { .read = tx_queue_len_read, .open = wl1271_open_file_generic, + .llseek = default_llseek,/* read accesses f_pos */ }; static ssize_t gpio_power_read(struct file *file, char __user *user_buf,
@@ -293,7 +294,8 @@ out:static const struct file_operations gpio_power_ops = { .read = gpio_power_read, .write = gpio_power_write, - .open = wl1271_open_file_generic + .open = wl1271_open_file_generic, + .llseek = default_llseek,/* read accesses f_pos */ };static void wl1271_debugfs_delete_files (struct wl1271 *wl)
drivers/oprofile/oprofile_files.c +7 -1
@@ -59,6 +59,7 @@ static ssize_t timeout_write(struct file *file, char const __user *buf,static const struct file_operations timeout_fops = { .read = timeout_read, .write = timeout_write, + .llseek = default_llseek,/* read accesses f_pos */ };#endif
@@ -93,7 +94,8 @@ static ssize_t depth_write(struct file *file, char const __user *buf, size_t coustatic const struct file_operations depth_fops = { .read = depth_read, - .write = depth_write + .write = depth_write, + .llseek = default_llseek,/* read accesses f_pos */ };
@@ -105,6 +107,7 @@ static ssize_t pointer_size_read(struct file *file, char __user *buf, size_t coustatic const struct file_operations pointer_size_fops = { .read = pointer_size_read, + .llseek = default_llseek,/* read accesses f_pos */ };
@@ -116,6 +119,7 @@ static ssize_t cpu_type_read(struct file *file, char __user *buf, size_t count,static const struct file_operations cpu_type_fops = { .read = cpu_type_read, + .llseek = default_llseek,/* read accesses f_pos */ };
@@ -151,6 +155,7 @@ static ssize_t enable_write(struct file *file, char const __user *buf, size_t costatic const struct file_operations enable_fops = { .read = enable_read, .write = enable_write, + .llseek = default_llseek,/* read accesses f_pos */ };
@@ -163,6 +168,7 @@ static ssize_t dump_write(struct file *file, char const __user *buf, size_t counstatic const struct file_operations dump_fops = { .write = dump_write, + .llseek = noop_llseek,/* write uses no f_pos */ };void oprofile_create_files (struct super_block *sb,struct dentry *root)
drivers/oprofile/oprofilefs.c +3 -0
@@ -117,12 +117,14 @@ static const struct file_operations ulong_fops = { .read = ulong_read_file, .write = ulong_write_file, .open = default_open, + .llseek = default_llseek,/* read accesses f_pos */ };static const struct file_operations ulong_ro_fops = { .read = ulong_read_file, .open = default_open, + .llseek = default_llseek,/* read accesses f_pos */ };
@@ -183,6 +185,7 @@ static ssize_t atomic_read_file(struct file *file, char __user *buf, size_t counstatic const struct file_operations atomic_ro_fops = { .read = atomic_read_file, .open = default_open, + .llseek = default_llseek,/* read accesses f_pos */ };
drivers/pci/pcie/aer/aer_inject.c +1 -0
@@ -472,6 +472,7 @@ static ssize_t aer_inject_write(struct file *filp, const char __user *ubuf,static const struct file_operations aer_inject_fops = { .write = aer_inject_write, .owner =THIS_MODULE , + .llseek = noop_llseek,/* write uses no f_pos */ };static struct miscdevice aer_inject_device = {
drivers/platform/x86/sony-laptop.c +1 -0
@@ -2360,6 +2360,7 @@ static const struct file_operations sonypi_misc_fops = { .release = sonypi_misc_release, .fasync = sonypi_misc_fasync, .unlocked_ioctl = sonypi_misc_ioctl, + .llseek = noop_llseek,/* read uses no f_pos */ };static struct miscdevice sonypi_misc_device = {
drivers/rtc/rtc-m41t80.c +1 -0
@@ -748,6 +748,7 @@ static const struct file_operations wdt_fops = { .write = wdt_write, .open = wdt_open, .release = wdt_release, + .llseek = no_llseek,/* open uses nonseekable */ };static struct miscdevice wdt_dev = {
drivers/s390/block/dasd_eer.c +1 -0
@@ -670,6 +670,7 @@ static const struct file_operations dasd_eer_fops = { .read = &dasd_eer_read, .poll = &dasd_eer_poll, .owner = THIS_MODULE, + .llseek = noop_llseek,/* no read or write fn */ };static struct miscdevice *dasd_eer_dev =NULL ;
drivers/s390/char/fs3270.c +1 -0
@@ -520,6 +520,7 @@ static const struct file_operations fs3270_fops = { .compat_ioctl = fs3270_ioctl, /* ioctl */ .open = fs3270_open, /* open */ .release = fs3270_close, /* release */ + .llseek = no_llseek,/* open uses nonseekable */ };/*
drivers/s390/char/monreader.c +1 -0
@@ -447,6 +447,7 @@ static const struct file_operations mon_fops = { .release = &mon_close, .read = &mon_read, .poll = &mon_poll, + .llseek = noop_llseek,/* no read or write fn */ };static struct miscdevice mon_dev = {
drivers/s390/char/monwriter.c +1 -0
@@ -274,6 +274,7 @@ static const struct file_operations monwrite_fops = { .open = &monwrite_open, .release = &monwrite_close, .write = &monwrite_write, + .llseek = noop_llseek,/* no read or write fn */ };static struct miscdevice mon_dev = {
drivers/s390/char/tape_char.c +1 -0
@@ -53,6 +53,7 @@ static const struct file_operations tape_fops =#endif .open = tapechar_open, .release = tapechar_release, + .llseek = no_llseek,/* open uses nonseekable */ };static int tapechar_major =TAPECHAR_MAJOR ;
drivers/s390/char/vmcp.c +1 -0
@@ -177,6 +177,7 @@ static const struct file_operations vmcp_fops = { .write = vmcp_write, .unlocked_ioctl = vmcp_ioctl, .compat_ioctl = vmcp_ioctl, + .llseek = no_llseek,/* open uses nonseekable */ };static struct miscdevice vmcp_dev = {
drivers/s390/char/vmlogrdr.c +1 -0
@@ -97,6 +97,7 @@ static const struct file_operations vmlogrdr_fops = { .open = vmlogrdr_open, .release = vmlogrdr_release, .read = vmlogrdr_read, + .llseek = no_llseek,/* open uses nonseekable */ };
drivers/s390/char/vmwatchdog.c +1 -0
@@ -297,6 +297,7 @@ static const struct file_operations vmwdt_fops = { .unlocked_ioctl = &vmwdt_ioctl, .write = &vmwdt_write, .owner = THIS_MODULE, + .llseek = noop_llseek,/* no read or write fn */ };static struct miscdevice vmwdt_dev = {
drivers/s390/char/zcore.c +2 -0
@@ -459,6 +459,7 @@ static const struct file_operations zcore_memmap_fops = { .read = zcore_memmap_read, .open = zcore_memmap_open, .release = zcore_memmap_release, + .llseek = no_llseek,/* open uses nonseekable */ }; static ssize_t zcore_reipl_write(struct file *filp, const char __user *buf,
@@ -486,6 +487,7 @@ static const struct file_operations zcore_reipl_fops = { .write = zcore_reipl_write, .open = zcore_reipl_open, .release = zcore_reipl_release, + .llseek = no_llseek,/* open uses nonseekable */ };#ifdef CONFIG_32BIT
drivers/s390/cio/chsc_sch.c +1 -0
@@ -806,6 +806,7 @@ static const struct file_operations chsc_fops = { .open = nonseekable_open, .unlocked_ioctl = chsc_ioctl, .compat_ioctl = chsc_ioctl, + .llseek = no_llseek,/* nonseekable */ };static struct miscdevice chsc_misc_device = {
drivers/s390/cio/css.c +1 -0
@@ -1067,6 +1067,7 @@ static ssize_t cio_settle_write(struct file *file, const char __user *buf,static const struct file_operations cio_settle_proc_fops = { .open = nonseekable_open, .write = cio_settle_write, + .llseek = no_llseek,/* nonseekable */ };static int __init cio_settle_init (void )
drivers/s390/crypto/zcrypt_api.c +2 -1
@@ -897,7 +897,8 @@ static const struct file_operations zcrypt_fops = { .compat_ioctl = zcrypt_compat_ioctl, #endif .open = zcrypt_open, - .release = zcrypt_release + .release = zcrypt_release, + .llseek = no_llseek,/* open uses nonseekable */ };/*
drivers/s390/scsi/zfcp_cfdc.c +2 -1
@@ -251,8 +251,9 @@ static const struct file_operations zfcp_cfdc_fops = { .open = nonseekable_open, .unlocked_ioctl = zfcp_cfdc_dev_ioctl, #ifdef CONFIG_COMPAT - .compat_ioctl = zfcp_cfdc_dev_ioctl + .compat_ioctl = zfcp_cfdc_dev_ioctl, #endif + .llseek = no_llseek,/* nonseekable */ };struct miscdevice zfcp_cfdc_misc = {
drivers/sbus/char/display7seg.c +1 -0
@@ -162,6 +162,7 @@ static const struct file_operations d7s_fops = { .compat_ioctl = d7s_ioctl, .open = d7s_open, .release = d7s_release, + .llseek = noop_llseek,/* no read or write fn */ };static struct miscdevice d7s_miscdev = {
drivers/sbus/char/envctrl.c +1 -0
@@ -720,6 +720,7 @@ static const struct file_operations envctrl_fops = {#endif .open = envctrl_open, .release = envctrl_release, + .llseek = noop_llseek,/* read uses no f_pos */ };static struct miscdevice envctrl_dev = {
drivers/scsi/3w-9xxx.c +2 -1
@@ -222,7 +222,8 @@ static const struct file_operations twa_fops = { .owner = THIS_MODULE, .unlocked_ioctl = twa_chrdev_ioctl, .open = twa_chrdev_open, - .release = NULL + .release = NULL, + .llseek = noop_llseek,/* no read or write fn */ };/* This function will complete an aen request from the isr */
drivers/scsi/3w-sas.c +2 -1
@@ -890,7 +890,8 @@ static const struct file_operations twl_fops = { .owner = THIS_MODULE, .unlocked_ioctl = twl_chrdev_ioctl, .open = twl_chrdev_open, - .release = NULL + .release = NULL, + .llseek = noop_llseek,/* no read or write fn */ };/* This function passes sense data from firmware to scsi layer */
drivers/scsi/3w-xxxx.c +2 -1
@@ -1059,7 +1059,8 @@ static const struct file_operations tw_fops = { .owner = THIS_MODULE, .unlocked_ioctl = tw_chrdev_ioctl, .open = tw_chrdev_open, - .release = NULL + .release = NULL, + .llseek = noop_llseek,/* no read or write fn */ };/* This function will free up device extension resources */
drivers/scsi/aacraid/linit.c +1 -0
@@ -1039,6 +1039,7 @@ static const struct file_operations aac_cfg_fops = { .compat_ioctl = aac_compat_cfg_ioctl, #endif .open = aac_cfg_open, + .llseek = noop_llseek,/* no read or write fn */ }; static struct scsi_host_template aac_driver_template = {
drivers/scsi/ch.c +1 -0
@@ -981,6 +981,7 @@ static const struct file_operations changer_fops = {#ifdef CONFIG_COMPAT .compat_ioctl = ch_ioctl_compat, #endif + .llseek = noop_llseek,/* no read or write fn */ };static int __init init_ch_module (void )
drivers/scsi/dpt_i2o.c +1 -0
@@ -126,6 +126,7 @@ static const struct file_operations adpt_fops = {#ifdef CONFIG_COMPAT .compat_ioctl = compat_adpt_ioctl, #endif + .llseek = noop_llseek,/* no read or write fn */ };/* Structures and definitions for synchronous message posting.
drivers/scsi/gdth.c +1 -0
@@ -372,6 +372,7 @@ static const struct file_operations gdth_fops = { .unlocked_ioctl = gdth_unlocked_ioctl, .open = gdth_open, .release = gdth_close, + .llseek = noop_llseek,/* no read or write fn */ };#include "gdth_proc.h"
drivers/scsi/megaraid.c +1 -0
@@ -101,6 +101,7 @@ static const struct file_operations megadev_fops = { .owner = THIS_MODULE, .unlocked_ioctl = megadev_unlocked_ioctl, .open = megadev_open, + .llseek = noop_llseek,/* no read or write fn */ };/*
drivers/scsi/megaraid/megaraid_mm.c +1 -0
@@ -75,6 +75,7 @@ static const struct file_operations lsi_fops = { .compat_ioctl = mraid_mm_compat_ioctl, #endif .owner = THIS_MODULE, + .llseek = noop_llseek,/* no read or write fn */ }; static struct miscdevice megaraid_mm_dev = {
drivers/scsi/megaraid/megaraid_sas.c +1 -0
@@ -3957,6 +3957,7 @@ static const struct file_operations megasas_mgmt_fops = {#ifdef CONFIG_COMPAT .compat_ioctl = megasas_mgmt_compat_ioctl, #endif + .llseek = noop_llseek,/* no read or write fn */ };/*
drivers/scsi/mpt2sas/mpt2sas_ctl.c +1 -0
@@ -2952,6 +2952,7 @@ static const struct file_operations ctl_fops = { #ifdef CONFIG_COMPAT .compat_ioctl = _ctl_ioctl_compat, #endif + .llseek = noop_llseek,/* no read or write fn */ }; static struct miscdevice ctl_dev = {
drivers/scsi/osd/osd_uld.c +1 -0
@@ -182,6 +182,7 @@ static const struct file_operations osd_fops = { .open = osd_uld_open, .release = osd_uld_release, .unlocked_ioctl = osd_uld_ioctl, + .llseek = noop_llseek,/* no read or write fn */ };struct osd_dev *osduld_path_lookup (const char *name)
drivers/scsi/pmcraid.c +1 -0
@@ -4165,6 +4165,7 @@ static const struct file_operations pmcraid_fops = {#ifdef CONFIG_COMPAT .compat_ioctl = pmcraid_chr_ioctl, #endif + .llseek = noop_llseek,/* no read or write fn */ };
drivers/scsi/qla2xxx/qla_os.c +1 -0
@@ -3926,6 +3926,7 @@ static struct pci_driver qla2xxx_pci_driver = {static struct file_operations apidev_fops = { .owner =THIS_MODULE , + .llseek = noop_llseek,/* no read or write fn */ };/**
drivers/scsi/scsi_tgt_if.c +1 -0
@@ -333,6 +333,7 @@ static const struct file_operations tgt_fops = { .poll = tgt_poll, .write = tgt_write, .mmap = tgt_mmap, + .llseek = noop_llseek,/* write uses no f_pos */ };static struct miscdevice tgt_miscdev = {
drivers/scsi/sg.c +1 -0
@@ -1351,6 +1351,7 @@ static const struct file_operations sg_fops = { .mmap = sg_mmap, .release = sg_release, .fasync = sg_fasync, + .llseek = no_llseek,/* open uses nonseekable */ };static struct class *sg_sysfs_class;
drivers/serial/mfd.c +2 -0
@@ -227,12 +227,14 @@ static const struct file_operations port_regs_ops = { .owner = THIS_MODULE, .open = hsu_show_regs_open, .read = port_show_regs, + .llseek = default_llseek,/* read accesses f_pos */ };static const struct file_operations dma_regs_ops = { .owner =THIS_MODULE , .open = hsu_show_regs_open, .read = dma_show_regs, + .llseek = default_llseek,/* read accesses f_pos */ };static int hsu_debugfs_init (struct hsu_port *hsu)
drivers/spi/dw_spi.c +1 -0
@@ -131,6 +131,7 @@ static const struct file_operations mrst_spi_regs_ops = { .owner = THIS_MODULE, .open = spi_show_regs_open, .read = spi_show_regs, + .llseek = default_llseek,/* read accesses f_pos */ };static int mrst_spi_debugfs_init (struct dw_spi *dws)
drivers/spi/spidev.c +1 -0
@@ -545,6 +545,7 @@ static const struct file_operations spidev_fops = { .unlocked_ioctl = spidev_ioctl, .open = spidev_open, .release = spidev_release, + .llseek = no_llseek,/* open uses nonseekable */ };/*-------------------------------------------------------------------------*/
drivers/staging/batman-adv/bat_debugfs.c +1 -0
@@ -174,6 +174,7 @@ static const struct file_operations log_fops = { .release = log_release, .read = log_read, .poll = log_poll, + .llseek = noop_llseek,/* read uses no f_pos */ };static int debug_log_setup (struct bat_priv *bat_priv)
drivers/staging/batman-adv/icmp_socket.c +1 -0
@@ -265,6 +265,7 @@ static const struct file_operations fops = { .read = bat_socket_read, .write = bat_socket_write, .poll = bat_socket_poll, + .llseek = noop_llseek,/* read and write both use no f_pos */ };int bat_socket_setup (struct bat_priv *bat_priv)
drivers/staging/comedi/comedi_fops.c +1 -0
@@ -1922,6 +1922,7 @@ const struct file_operations comedi_fops = { .mmap = comedi_mmap, .poll = comedi_poll, .fasync = comedi_fasync, + .llseek = noop_llseek,/* read and write both use no f_pos */ };struct class *comedi_class;
drivers/staging/crystalhd/crystalhd_lnx.c +1 -0
@@ -351,6 +351,7 @@ static const struct file_operations chd_dec_fops = { .unlocked_ioctl = chd_dec_ioctl, .open = chd_dec_open, .release = chd_dec_close, + .llseek = noop_llseek,/* no read or write fn */ };static int __devinit chd_dec_init_chdev (struct crystalhd_adp *adp)
drivers/staging/dream/camera/msm_camera.c +3 -0
@@ -1941,6 +1941,7 @@ static const struct file_operations msm_fops_config = { .open = msm_open, .unlocked_ioctl = msm_ioctl_config, .release = msm_release_config, + .llseek = no_llseek,/* open uses nonseekable */ };static const struct file_operations msm_fops_control = {
@@ -1948,6 +1949,7 @@ static const struct file_operations msm_fops_control = { .open = msm_open_control, .unlocked_ioctl = msm_ioctl_control, .release = msm_release_control, + .llseek = no_llseek,/* open uses nonseekable */ };static const struct file_operations msm_fops_frame = {
@@ -1956,6 +1958,7 @@ static const struct file_operations msm_fops_frame = { .unlocked_ioctl = msm_ioctl_frame, .release = msm_release_frame, .poll = msm_poll_frame, + .llseek = no_llseek,/* open uses nonseekable */ }; static int msm_setup_cdev(struct msm_device *msm,
drivers/staging/dream/pmem.c +2 -0
@@ -180,6 +180,7 @@ const struct file_operations pmem_fops = { .mmap = pmem_mmap, .open = pmem_open, .unlocked_ioctl = pmem_ioctl, + .llseek = noop_llseek,/* no read or write fn */ };static int get_id (struct file *file)
@@ -1204,6 +1205,7 @@ static ssize_t debug_read(struct file *file, char __user *buf, size_t count,static struct file_operations debug_fops = { .read = debug_read, .open = debug_open, + .llseek = default_llseek,/* read accesses f_pos */ };#endif
drivers/staging/dream/qdsp5/adsp_driver.c +1 -0
@@ -582,6 +582,7 @@ static struct file_operations adsp_fops = { .open = adsp_open, .unlocked_ioctl = adsp_ioctl, .release = adsp_release, + .llseek = no_llseek,/* open uses nonseekable */ }; static void adsp_create(struct adsp_device *adev, const char *name,
drivers/staging/dream/qdsp5/audio_aac.c +1 -0
@@ -1030,6 +1030,7 @@ static struct file_operations audio_aac_fops = { .read = audio_read, .write = audio_write, .unlocked_ioctl = audio_ioctl, + .llseek = noop_llseek,/* read and write both use no f_pos */ };struct miscdevice audio_aac_misc = {
drivers/staging/dream/qdsp5/audio_amrnb.c +1 -0
@@ -841,6 +841,7 @@ static struct file_operations audio_amrnb_fops = { .read = audamrnb_read, .write = audamrnb_write, .unlocked_ioctl = audamrnb_ioctl, + .llseek = noop_llseek,/* read and write both use no f_pos */ };struct miscdevice audio_amrnb_misc = {
drivers/staging/dream/qdsp5/audio_evrc.c +1 -0
@@ -813,6 +813,7 @@ static struct file_operations audio_evrc_fops = { .read = audevrc_read, .write = audevrc_write, .unlocked_ioctl = audevrc_ioctl, + .llseek = noop_llseek,/* read and write both use no f_pos */ };struct miscdevice audio_evrc_misc = {
drivers/staging/dream/qdsp5/audio_in.c +2 -0
@@ -921,12 +921,14 @@ static struct file_operations audio_fops = { .read = audio_in_read, .write = audio_in_write, .unlocked_ioctl = audio_in_ioctl, + .llseek = noop_llseek,/* read and write both use no f_pos */ };static struct file_operations audpre_fops = { .owner =THIS_MODULE , .open = audpre_open, .unlocked_ioctl = audpre_ioctl, + .llseek = noop_llseek,/* no read or write fn */ };struct miscdevice audio_in_misc = {
drivers/staging/dream/qdsp5/audio_mp3.c +1 -0
@@ -948,6 +948,7 @@ static struct file_operations audio_mp3_fops = { .read = audio_read, .write = audio_write, .unlocked_ioctl = audio_ioctl, + .llseek = noop_llseek,/* read and write both use no f_pos */ };struct miscdevice audio_mp3_misc = {
drivers/staging/dream/qdsp5/audio_out.c +2 -0
@@ -807,12 +807,14 @@ static struct file_operations audio_fops = { .read = audio_read, .write = audio_write, .unlocked_ioctl = audio_ioctl, + .llseek = noop_llseek,/* read and write both use no f_pos */ };static struct file_operations audpp_fops = { .owner =THIS_MODULE , .open = audpp_open, .unlocked_ioctl = audpp_ioctl, + .llseek = noop_llseek,/* no read or write fn */ };struct miscdevice audio_misc = {
drivers/staging/dream/qdsp5/audio_qcelp.c +1 -0
@@ -824,6 +824,7 @@ static struct file_operations audio_qcelp_fops = { .read = audqcelp_read, .write = audqcelp_write, .unlocked_ioctl = audqcelp_ioctl, + .llseek = noop_llseek,/* read and write both use no f_pos */ };struct miscdevice audio_qcelp_misc = {
drivers/staging/dream/qdsp5/evlog.h +1 -0
@@ -123,6 +123,7 @@ static int ev_log_open(struct inode *inode, struct file *file)static const struct file_operations ev_log_ops = { .read = ev_log_read, .open = ev_log_open, + .llseek = default_llseek,/* read accesses f_pos */ };static int ev_log_init (struct ev_log *log)
drivers/staging/dream/qdsp5/snd.c +1 -0
@@ -247,6 +247,7 @@ static struct file_operations snd_fops = { .open = snd_open, .release = snd_release, .unlocked_ioctl = snd_ioctl, + .llseek = noop_llseek,/* no read or write fn */ };struct miscdevice snd_misc = {
drivers/staging/frontier/alphatrack.c +1 -0
@@ -641,6 +641,7 @@ static const struct file_operations usb_alphatrack_fops = { .open = usb_alphatrack_open, .release = usb_alphatrack_release, .poll = usb_alphatrack_poll, + .llseek = no_llseek,/* open uses nonseekable */ };/*
drivers/staging/frontier/tranzport.c +1 -0
@@ -767,6 +767,7 @@ static const struct file_operations usb_tranzport_fops = { .open = usb_tranzport_open, .release = usb_tranzport_release, .poll = usb_tranzport_poll, + .llseek = no_llseek,/* open uses nonseekable */ };/*
drivers/staging/iio/industrialio-core.c +1 -0
@@ -349,6 +349,7 @@ static const struct file_operations iio_event_chrdev_fileops = { .release = iio_event_chrdev_release, .open = iio_event_chrdev_open, .owner = THIS_MODULE, + .llseek = noop_llseek,/* read uses no f_pos */ };static void iio_event_dev_release (struct device *dev)
drivers/staging/iio/industrialio-ring.c +1 -0
@@ -133,6 +133,7 @@ static const struct file_operations iio_ring_fileops = { .release = iio_ring_release, .open = iio_ring_open, .owner = THIS_MODULE, + .llseek = noop_llseek,/* read uses no f_pos */ };/**
drivers/staging/lirc/lirc_imon.c +2 -1
@@ -115,7 +115,8 @@ static const struct file_operations display_fops = { .owner = THIS_MODULE, .open = &display_open, .write = &vfd_write, - .release = &display_close + .release = &display_close, + .llseek = noop_llseek,/* no read or write fn */ };/*
drivers/staging/lirc/lirc_it87.c +1 -0
@@ -342,6 +342,7 @@ static const struct file_operations lirc_fops = { .unlocked_ioctl = lirc_ioctl, .open = lirc_open, .release = lirc_close, + .llseek = noop_llseek,/* read and write both use no f_pos */ };static int set_use_inc (void *data)
drivers/staging/lirc/lirc_sasem.c +1 -0
@@ -125,6 +125,7 @@ static const struct file_operations vfd_fops = { .write = &vfd_write, .unlocked_ioctl = &vfd_ioctl, .release = &vfd_close, + .llseek = noop_llseek,/* no read or write fn */ };/* USB Device ID for Sasem USB Control Board */
drivers/staging/memrar/memrar_handler.c +1 -0
@@ -890,6 +890,7 @@ static const struct file_operations memrar_fops = { .mmap = memrar_mmap, .open = memrar_open, .release = memrar_release, + .llseek = no_llseek,/* open uses nonseekable */ };static struct miscdevice memrar_miscdev = {
drivers/staging/panel/panel.c +1 -0
@@ -1631,6 +1631,7 @@ static const struct file_operations keypad_fops = { .read = keypad_read, /* read */ .open = keypad_open, /* open */ .release = keypad_release, /* close */ + .llseek = default_llseek,/* read accesses f_pos */ };static struct miscdevice keypad_dev = {
drivers/staging/tidspbridge/rmgr/drv_interface.c +1 -0
@@ -144,6 +144,7 @@ static const struct file_operations bridge_fops = { .release = bridge_release, .unlocked_ioctl = bridge_ioctl, .mmap = bridge_mmap, + .llseek = noop_llseek,/* no read or write fn */ };#ifdef CONFIG_PM
drivers/telephony/ixj.c +2 -1
@@ -6676,7 +6676,8 @@ static const struct file_operations ixj_fops = .poll = ixj_poll, .unlocked_ioctl = ixj_ioctl, .release = ixj_release, - .fasync = ixj_fasync + .fasync = ixj_fasync, + .llseek = default_llseek,/* read accesses f_pos */ };static int ixj_linetest (IXJ *j)
drivers/telephony/phonedev.c +1 -0
@@ -130,6 +130,7 @@ static const struct file_operations phone_fops = { .owner = THIS_MODULE, .open = phone_open, + .llseek = noop_llseek,/* no read or write fn */ };/*
drivers/uio/uio.c +1 -0
@@ -740,6 +740,7 @@ static const struct file_operations uio_fops = { .mmap = uio_mmap, .poll = uio_poll, .fasync = uio_fasync, + .llseek = noop_llseek,/* read and write both use no f_pos */ };static int uio_major_init (void )
drivers/usb/class/cdc-wdm.c +2 -1
@@ -584,7 +584,8 @@ static const struct file_operations wdm_fops = { .open = wdm_open, .flush = wdm_flush, .release = wdm_release, - .poll = wdm_poll + .poll = wdm_poll, + .llseek = noop_llseek,/* read and write both use no f_pos */ };static struct usb_class_driver wdm_class = {
drivers/usb/class/usblp.c +1 -0
@@ -1043,6 +1043,7 @@ static const struct file_operations usblp_fops = { .compat_ioctl = usblp_ioctl, .open = usblp_open, .release = usblp_release, + .llseek = noop_llseek,/* read and write both use no f_pos */ };static char *usblp_devnode (struct device *dev,mode_t *mode)
drivers/usb/class/usbtmc.c +1 -0
@@ -987,6 +987,7 @@ static const struct file_operations fops = { .open = usbtmc_open, .release = usbtmc_release, .unlocked_ioctl = usbtmc_ioctl, + .llseek = default_llseek,/* read accesses f_pos */ };static struct usb_class_driver usbtmc_class = {
drivers/usb/core/file.c +1 -0
@@ -59,6 +59,7 @@ static int usb_open(struct inode * inode, struct file * file)static const struct file_operations usb_fops = { .owner =THIS_MODULE , .open = usb_open, + .llseek = noop_llseek,/* no read or write fn */ }; static struct usb_class {
drivers/usb/gadget/f_hid.c +1 -0
@@ -451,6 +451,7 @@ const struct file_operations f_hidg_fops = { .write = f_hidg_write, .read = f_hidg_read, .poll = f_hidg_poll, + .llseek = noop_llseek,/* read and write both use no f_pos */ };static int __init hidg_bind (struct usb_configuration *c,struct usb_function *f)
drivers/usb/gadget/printer.c +2 -1
@@ -884,7 +884,8 @@ static const struct file_operations printer_io_operations = { .fsync = printer_fsync, .poll = printer_poll, .unlocked_ioctl = printer_ioctl, - .release = printer_close + .release = printer_close, + .llseek = noop_llseek,/* read and write both use no f_pos */ };/*-------------------------------------------------------------------------*/
drivers/usb/host/ehci-dbg.c +4 -0
@@ -369,18 +369,21 @@ static const struct file_operations debug_async_fops = { .open = debug_async_open, .read = debug_output, .release = debug_close, + .llseek = default_llseek,/* read accesses f_pos */ };static const struct file_operations debug_periodic_fops = { .owner =THIS_MODULE , .open = debug_periodic_open, .read = debug_output, .release = debug_close, + .llseek = default_llseek,/* read accesses f_pos */ };static const struct file_operations debug_registers_fops = { .owner =THIS_MODULE , .open = debug_registers_open, .read = debug_output, .release = debug_close, + .llseek = default_llseek,/* read accesses f_pos */ };static const struct file_operations debug_lpm_fops = { .owner =THIS_MODULE ,
@@ -388,6 +391,7 @@ static const struct file_operations debug_lpm_fops = { .read = debug_lpm_read, .write = debug_lpm_write, .release = debug_lpm_close, + .llseek = noop_llseek,/* read and write both use no f_pos */ };static struct dentry *ehci_debug_root;
drivers/usb/host/ohci-dbg.c +3 -0
@@ -413,18 +413,21 @@ static const struct file_operations debug_async_fops = { .open = debug_async_open, .read = debug_output, .release = debug_close, + .llseek = default_llseek,/* read accesses f_pos */ };static const struct file_operations debug_periodic_fops = { .owner =THIS_MODULE , .open = debug_periodic_open, .read = debug_output, .release = debug_close, + .llseek = default_llseek,/* read accesses f_pos */ };static const struct file_operations debug_registers_fops = { .owner =THIS_MODULE , .open = debug_registers_open, .read = debug_output, .release = debug_close, + .llseek = default_llseek,/* read accesses f_pos */ };static struct dentry *ohci_debug_root;
drivers/usb/image/mdc800.c +1 -0
@@ -963,6 +963,7 @@ static const struct file_operations mdc800_device_ops = .write = mdc800_device_write, .open = mdc800_device_open, .release = mdc800_device_release, + .llseek = noop_llseek,/* read and write both use no f_pos */ };
drivers/usb/misc/adutux.c +1 -0
@@ -679,6 +679,7 @@ static const struct file_operations adu_fops = { .write = adu_write, .open = adu_open, .release = adu_release, + .llseek = noop_llseek,/* read and write both use no f_pos */ };/*
drivers/usb/misc/idmouse.c +1 -0
@@ -105,6 +105,7 @@ static const struct file_operations idmouse_fops = { .read = idmouse_read, .open = idmouse_open, .release = idmouse_release, + .llseek = default_llseek,/* read accesses f_pos */ };/* class driver information */
drivers/usb/misc/iowarrior.c +1 -0
@@ -730,6 +730,7 @@ static const struct file_operations iowarrior_fops = { .open = iowarrior_open, .release = iowarrior_release, .poll = iowarrior_poll, + .llseek = noop_llseek,/* read and write both use no f_pos */ };static char *iowarrior_devnode (struct device *dev,mode_t *mode)
drivers/usb/misc/ldusb.c +1 -0
@@ -613,6 +613,7 @@ static const struct file_operations ld_usb_fops = { .open = ld_usb_open, .release = ld_usb_release, .poll = ld_usb_poll, + .llseek = no_llseek,/* open uses nonseekable */ };/*
drivers/usb/misc/rio500.c +1 -0
@@ -439,6 +439,7 @@ static const struct file_operations usb_rio_fops = { .unlocked_ioctl = ioctl_rio, .open = open_rio, .release = close_rio, + .llseek = noop_llseek,/* read and write both use no f_pos */ };static struct usb_class_driver usb_rio_class = {
drivers/usb/misc/usblcd.c +1 -0
@@ -282,6 +282,7 @@ static const struct file_operations lcd_fops = { .open = lcd_open, .unlocked_ioctl = lcd_ioctl, .release = lcd_release, + .llseek = noop_llseek,/* read and write both use no f_pos */ };/*
drivers/usb/usb-skeleton.c +1 -0
@@ -507,6 +507,7 @@ static const struct file_operations skel_fops = { .open = skel_open, .release = skel_release, .flush = skel_flush, + .llseek = noop_llseek,/* read and write both use no f_pos */ };/*
drivers/vhost/net.c +1 -0
@@ -869,6 +869,7 @@ static const struct file_operations vhost_net_fops = { .compat_ioctl = vhost_net_compat_ioctl, #endif .open = vhost_net_open, + .llseek = noop_llseek,/* no read or write fn */ }; static struct miscdevice vhost_net_misc = {
drivers/video/fbmem.c +1 -0
@@ -1439,6 +1439,7 @@ static const struct file_operations fb_fops = {#ifdef CONFIG_FB_DEFERRED_IO .fsync = fb_deferred_io_fsync, #endif + .llseek = default_llseek,/* read accesses f_pos */ };struct class *fb_class;
drivers/video/mbx/mbxdebugfs.c +6 -0
@@ -175,36 +175,42 @@ static const struct file_operations sysconf_fops = { .read = sysconf_read_file, .write = write_file_dummy, .open = open_file_generic, + .llseek = default_llseek,/* read accesses f_pos */ };static const struct file_operations clock_fops = { .read = clock_read_file, .write = write_file_dummy, .open = open_file_generic, + .llseek = default_llseek,/* read accesses f_pos */ };static const struct file_operations display_fops = { .read = display_read_file, .write = write_file_dummy, .open = open_file_generic, + .llseek = default_llseek,/* read accesses f_pos */ };static const struct file_operations gsctl_fops = { .read = gsctl_read_file, .write = write_file_dummy, .open = open_file_generic, + .llseek = default_llseek,/* read accesses f_pos */ };static const struct file_operations sdram_fops = { .read = sdram_read_file, .write = write_file_dummy, .open = open_file_generic, + .llseek = default_llseek,/* read accesses f_pos */ };static const struct file_operations misc_fops = { .read = misc_read_file, .write = write_file_dummy, .open = open_file_generic, + .llseek = default_llseek,/* read accesses f_pos */ };static void __devinit mbxfb_debugfs_init (struct fb_info *fbi)
drivers/watchdog/ar7_wdt.c +1 -0
@@ -267,6 +267,7 @@ static const struct file_operations ar7_wdt_fops = { .unlocked_ioctl = ar7_wdt_ioctl, .open = ar7_wdt_open, .release = ar7_wdt_release, + .llseek = no_llseek,/* open uses nonseekable */ };static struct miscdevice ar7_wdt_miscdev = {
drivers/watchdog/cpwd.c +1 -0
@@ -524,6 +524,7 @@ static const struct file_operations cpwd_fops = { .write = cpwd_write, .read = cpwd_read, .release = cpwd_release, + .llseek = no_llseek,/* open uses nonseekable */ }; static int __devinit cpwd_probe(struct platform_device *op,
drivers/watchdog/ep93xx_wdt.c +1 -0
@@ -188,6 +188,7 @@ static const struct file_operations ep93xx_wdt_fops = { .unlocked_ioctl = ep93xx_wdt_ioctl, .open = ep93xx_wdt_open, .release = ep93xx_wdt_release, + .llseek = no_llseek,/* open uses nonseekable */ };static struct miscdevice ep93xx_wdt_miscdev = {
drivers/watchdog/omap_wdt.c +1 -0
@@ -258,6 +258,7 @@ static const struct file_operations omap_wdt_fops = { .unlocked_ioctl = omap_wdt_ioctl, .open = omap_wdt_open, .release = omap_wdt_release, + .llseek = no_llseek,/* open uses nonseekable */ };static int __devinit omap_wdt_probe (struct platform_device *pdev)
drivers/xen/evtchn.c +1 -0
@@ -467,6 +467,7 @@ static const struct file_operations evtchn_fops = { .fasync = evtchn_fasync, .open = evtchn_open, .release = evtchn_release, + .llseek = noop_llseek,/* read and write both use no f_pos */ };static struct miscdevice evtchn_miscdev = {
drivers/xen/xenfs/super.c +1 -0
@@ -35,6 +35,7 @@ static ssize_t capabilities_read(struct file *file, char __user *buf,static const struct file_operations capabilities_file_ops = { .read = capabilities_read, + .llseek = default_llseek,/* read accesses f_pos */ };static int xenfs_fill_super (struct super_block *sb,void *data,int silent)
drivers/xen/xenfs/xenbus.c +1 -0
@@ -594,4 +594,5 @@ const struct file_operations xenbus_file_ops = { .open = xenbus_file_open, .release = xenbus_file_release, .poll = xenbus_file_poll, + .llseek = no_llseek,/* open uses nonseekable */ };
fs/afs/mntpt.c +1 -0
@@ -29,6 +29,7 @@ static void afs_mntpt_expiry_timed_out(struct work_struct *work);const struct file_operations afs_mntpt_file_operations = { .open = afs_mntpt_open, + .llseek = noop_llseek,/* no read or write fn */ };const struct inode_operations afs_mntpt_inode_operations = {
fs/autofs4/dev-ioctl.c +1 -0
@@ -724,6 +724,7 @@ static const struct file_operations _dev_ioctl_fops = { .unlocked_ioctl = autofs_dev_ioctl, .compat_ioctl = autofs_dev_ioctl_compat, .owner = THIS_MODULE, + .llseek = noop_llseek,/* no read or write fn */ };static struct miscdevice _autofs_dev_ioctl_misc = {
fs/binfmt_misc.c +3 -0
@@ -576,6 +576,7 @@ static ssize_t bm_entry_write(struct file *file, const char __user *buffer,static const struct file_operations bm_entry_operations = { .read = bm_entry_read, .write = bm_entry_write, + .llseek = default_llseek,/* read accesses f_pos */ };/* /register */
@@ -643,6 +644,7 @@ out:static const struct file_operations bm_register_operations = { .write = bm_register_write, + .llseek = noop_llseek,/* write uses no f_pos */ };/* /status */
@@ -680,6 +682,7 @@ static ssize_t bm_status_write(struct file * file, const char __user * buffer,static const struct file_operations bm_status_operations = { .read = bm_status_read, .write = bm_status_write, + .llseek = default_llseek,/* read accesses f_pos */ };/* Superblock handling */
fs/btrfs/super.c +1 -0
@@ -815,6 +815,7 @@ static const struct file_operations btrfs_ctl_fops = { .unlocked_ioctl = btrfs_control_ioctl, .compat_ioctl = btrfs_control_ioctl, .owner = THIS_MODULE, + .llseek = noop_llseek,/* no read or write fn */ };static struct miscdevice btrfs_misc = {
fs/cachefiles/daemon.c +1 -0
@@ -55,6 +55,7 @@ const struct file_operations cachefiles_daemon_fops = { .read = cachefiles_daemon_read, .write = cachefiles_daemon_write, .poll = cachefiles_daemon_poll, + .llseek = noop_llseek,/* read and write both use no f_pos */ };struct cachefiles_daemon_cmd {
fs/char_dev.c +1 -0
@@ -454,6 +454,7 @@ static void cdev_purge(struct cdev *cdev)*/ const struct file_operations def_chr_fops = { .open = chrdev_open, + .llseek = noop_llseek,/* no read or write fn */ };static struct kobject *exact_match (dev_t dev,int *part,void *data)
fs/coda/pioctl.c +1 -0
@@ -39,6 +39,7 @@ const struct inode_operations coda_ioctl_inode_operations = {const struct file_operations coda_ioctl_operations = { .owner =THIS_MODULE , .unlocked_ioctl = coda_pioctl, + .llseek = noop_llseek,/* no read or write fn */ };/* the coda pioctl inode ops */
fs/coda/psdev.c +1 -0
@@ -346,6 +346,7 @@ static const struct file_operations coda_psdev_fops = { .unlocked_ioctl = coda_psdev_ioctl, .open = coda_psdev_open, .release = coda_psdev_release, + .llseek = noop_llseek,/* read and write both use no f_pos */ };static int init_coda_psdev (void )
fs/debugfs/file.c +3 -0
@@ -43,6 +43,7 @@ const struct file_operations debugfs_file_operations = { .read = default_read_file, .write = default_write_file, .open = default_open, + .llseek = noop_llseek,/* read and write both use no f_pos */ };static void *debugfs_follow_link (struct dentry *dentry,struct nameidata *nd)
@@ -454,6 +455,7 @@ static const struct file_operations fops_bool = { .read = read_file_bool, .write = write_file_bool, .open = default_open, + .llseek = default_llseek,/* read accesses f_pos */ };/**
@@ -498,6 +500,7 @@ static ssize_t read_file_blob(struct file *file, char __user *user_buf,static const struct file_operations fops_blob = { .read = read_file_blob, .open = default_open, + .llseek = default_llseek,/* read accesses f_pos */ };/**
fs/dlm/debug_fs.c +2 -1
@@ -643,7 +643,8 @@ static ssize_t waiters_read(struct file *file, char __user *userbuf,static const struct file_operations waiters_fops = { .owner =THIS_MODULE , .open = waiters_open, - .read = waiters_read + .read = waiters_read, + .llseek = default_llseek,/* read accesses f_pos */ };void dlm_delete_debug_file (struct dlm_ls *ls)
fs/dlm/plock.c +2 -1
@@ -412,7 +412,8 @@ static const struct file_operations dev_fops = { .read = dev_read, .write = dev_write, .poll = dev_poll, - .owner = THIS_MODULE + .owner = THIS_MODULE, + .llseek = noop_llseek,/* read and write both use no f_pos */ };static struct miscdevice plock_dev_misc = {
fs/dlm/user.c +3 -0
@@ -1009,6 +1009,7 @@ static const struct file_operations device_fops = { .write = device_write, .poll = device_poll, .owner = THIS_MODULE, + .llseek = noop_llseek,/* read and write both use no f_pos */ };static const struct file_operations ctl_device_fops = {
@@ -1017,6 +1018,7 @@ static const struct file_operations ctl_device_fops = { .read = device_read, .write = device_write, .owner = THIS_MODULE, + .llseek = noop_llseek,/* read and write both use no f_pos */ };static struct miscdevice ctl_device = {
@@ -1029,6 +1031,7 @@ static const struct file_operations monitor_device_fops = { .open = monitor_device_open, .release = monitor_device_close, .owner = THIS_MODULE, + .llseek = noop_llseek,/* no read or write fn */ };static struct miscdevice monitor_device = {
fs/ecryptfs/file.c +1 -0
@@ -332,6 +332,7 @@ const struct file_operations ecryptfs_dir_fops = { .fsync = ecryptfs_fsync, .fasync = ecryptfs_fasync, .splice_read = generic_file_splice_read, + .llseek = default_llseek,/* readdir is present */ };const struct file_operations ecryptfs_main_fops = {
fs/ecryptfs/miscdev.c +1 -0
@@ -482,6 +482,7 @@ static const struct file_operations ecryptfs_miscdev_fops = { .read = ecryptfs_miscdev_read, .write = ecryptfs_miscdev_write, .release = ecryptfs_miscdev_release, + .llseek = noop_llseek,/* read and write both use no f_pos */ };static struct miscdevice ecryptfs_miscdev = {
fs/eventfd.c +1 -0
@@ -293,6 +293,7 @@ static const struct file_operations eventfd_fops = { .poll = eventfd_poll, .read = eventfd_read, .write = eventfd_write, + .llseek = noop_llseek,/* read and write both use no f_pos */ };/**
fs/eventpoll.c +2 -1
@@ -674,7 +674,8 @@ static unsigned int ep_eventpoll_poll(struct file *file, poll_table *wait)/* File callbacks that implement the eventpoll file behaviour */ static const struct file_operations eventpoll_fops = { .release = ep_eventpoll_release, - .poll = ep_eventpoll_poll + .poll = ep_eventpoll_poll, + .llseek = noop_llseek,/* no read or write fn */ };/* Fast test to see if the file is an evenpoll file */
fs/fifo.c +1 -0
@@ -151,4 +151,5 @@ err_nocleanup:*/ const struct file_operations def_fifo_fops = { .open = fifo_open,/* will set read_ or write_pipefifo_fops */ + .llseek = noop_llseek,/* no read or write fn */ };
fs/fuse/control.c +4 -0
@@ -179,23 +179,27 @@ static ssize_t fuse_conn_congestion_threshold_write(struct file *file,static const struct file_operations fuse_ctl_abort_ops = { .open = nonseekable_open, .write = fuse_conn_abort_write, + .llseek = no_llseek,/* nonseekable */ };static const struct file_operations fuse_ctl_waiting_ops = { .open = nonseekable_open, .read = fuse_conn_waiting_read, + .llseek = no_llseek,/* nonseekable */ };static const struct file_operations fuse_conn_max_background_ops = { .open = nonseekable_open, .read = fuse_conn_max_background_read, .write = fuse_conn_max_background_write, + .llseek = no_llseek,/* nonseekable */ };static const struct file_operations fuse_conn_congestion_threshold_ops = { .open = nonseekable_open, .read = fuse_conn_congestion_threshold_read, .write = fuse_conn_congestion_threshold_write, + .llseek = no_llseek,/* nonseekable */ }; static struct dentry *fuse_ctl_add_dentry(struct dentry *parent,
fs/fuse/cuse.c +1 -0
@@ -182,6 +182,7 @@ static const struct file_operations cuse_frontend_fops = { .unlocked_ioctl = cuse_file_ioctl, .compat_ioctl = cuse_file_compat_ioctl, .poll = fuse_file_poll, + .llseek = noop_llseek,/* read and write both use no f_pos */ };
fs/gfs2/file.c +2 -0
@@ -771,6 +771,7 @@ const struct file_operations gfs2_dir_fops = { .fsync = gfs2_fsync, .lock = gfs2_lock, .flock = gfs2_flock, + .llseek = default_llseek,/* readdir is present */ };#endif /* CONFIG_GFS2_FS_LOCKING_DLM */
@@ -797,5 +798,6 @@ const struct file_operations gfs2_dir_fops_nolock = { .open = gfs2_open, .release = gfs2_close, .fsync = gfs2_fsync, + .llseek = default_llseek,/* readdir is present */ };
fs/hppfs/hppfs.c +1 -0
@@ -598,6 +598,7 @@ static const struct file_operations hppfs_dir_fops = { .readdir = hppfs_readdir, .open = hppfs_dir_open, .fsync = hppfs_fsync, + .llseek = default_llseek,/* readdir is present */ };static int hppfs_statfs (struct dentry *dentry,struct kstatfs *sf)
fs/hugetlbfs/inode.c +1 -0
@@ -674,6 +674,7 @@ const struct file_operations hugetlbfs_file_operations = { .mmap = hugetlbfs_file_mmap, .fsync = noop_fsync, .get_unmapped_area = hugetlb_get_unmapped_area, + .llseek = default_llseek,/* read accesses f_pos */ };static const struct inode_operations hugetlbfs_dir_inode_operations = {
fs/logfs/dir.c +1 -0
@@ -827,4 +827,5 @@ const struct file_operations logfs_dir_fops = { .unlocked_ioctl = logfs_ioctl, .readdir = logfs_readdir, .read = generic_read_dir, + .llseek = default_llseek,/* readdir is present */ };
fs/nfsd/nfsctl.c +1 -0
@@ -137,6 +137,7 @@ static const struct file_operations transaction_ops = { .write = nfsctl_transaction_write, .read = nfsctl_transaction_read, .release = simple_transaction_release, + .llseek = default_llseek,/* read accesses f_pos */ };static int exports_open (struct inode *inode,struct file *file)
fs/no-block.c +1 -0
@@ -19,4 +19,5 @@ static int no_blkdev_open(struct inode * inode, struct file * filp)const struct file_operations def_blk_fops = { .open = no_blkdev_open, + .llseek = noop_llseek,/* no read or write fn */ };
fs/notify/fanotify/fanotify_user.c +1 -0
@@ -433,6 +433,7 @@ static const struct file_operations fanotify_fops = { .release = fanotify_release, .unlocked_ioctl = fanotify_ioctl, .compat_ioctl = fanotify_ioctl, + .llseek = noop_llseek,/* read and write both use no f_pos */ };static void fanotify_free_mark (struct fsnotify_mark *fsn_mark)
fs/notify/inotify/inotify_user.c +1 -0
@@ -344,6 +344,7 @@ static const struct file_operations inotify_fops = { .release = inotify_release, .unlocked_ioctl = inotify_ioctl, .compat_ioctl = inotify_ioctl, + .llseek = noop_llseek,/* read uses no f_pos */ };
fs/ntfs/file.c +2 -1
@@ -2223,6 +2223,7 @@ const struct inode_operations ntfs_file_inode_ops = {#endif /* NTFS_RW */ }; -const struct file_operations ntfs_empty_file_ops = {}; +const struct file_operations ntfs_empty_file_ops = {.llseek = noop_llseek,/* no read or write fn */ +};const struct inode_operations ntfs_empty_inode_ops = {};
fs/ocfs2/dlmfs/dlmfs.c +1 -0
@@ -612,6 +612,7 @@ static const struct file_operations dlmfs_file_operations = { .poll = dlmfs_file_poll, .read = dlmfs_file_read, .write = dlmfs_file_write, + .llseek = default_llseek,/* read accesses f_pos */ };static const struct inode_operations dlmfs_dir_inode_operations = {
fs/ocfs2/stack_user.c +1 -0
@@ -628,6 +628,7 @@ static const struct file_operations ocfs2_control_fops = { .read = ocfs2_control_read, .write = ocfs2_control_write, .owner = THIS_MODULE, + .llseek = default_llseek,/* read accesses f_pos */ };static struct miscdevice ocfs2_control_device = {
fs/proc/base.c +8 -0
@@ -1151,6 +1151,7 @@ static ssize_t oom_score_adj_write(struct file *file, const char __user *buf,static const struct file_operations proc_oom_score_adj_operations = { .read = oom_score_adj_read, .write = oom_score_adj_write, + .llseek = default_llseek,/* read accesses f_pos */ };#ifdef CONFIG_AUDITSYSCALL
@@ -2039,11 +2040,13 @@ static ssize_t proc_fdinfo_read(struct file *file, char __user *buf,static const struct file_operations proc_fdinfo_file_operations = { .open = nonseekable_open, .read = proc_fdinfo_read, + .llseek = no_llseek,/* nonseekable */ };static const struct file_operations proc_fd_operations = { .read = generic_read_dir, .readdir = proc_readfd, + .llseek = default_llseek,/* readdir is present */ };/*
@@ -2112,6 +2115,7 @@ static int proc_readfdinfo(struct file *filp, void *dirent, filldir_t filldir)static const struct file_operations proc_fdinfo_operations = { .read = generic_read_dir, .readdir = proc_readfdinfo, + .llseek = default_llseek,/* readdir is present */ };/*
@@ -2343,6 +2347,7 @@ static int proc_attr_dir_readdir(struct file * filp,static const struct file_operations proc_attr_dir_operations = { .read = generic_read_dir, .readdir = proc_attr_dir_readdir, + .llseek = default_llseek,/* readdir is present */ }; static struct dentry *proc_attr_dir_lookup(struct inode *dir,
@@ -2751,6 +2756,7 @@ static int proc_tgid_base_readdir(struct file * filp,static const struct file_operations proc_tgid_base_operations = { .read = generic_read_dir, .readdir = proc_tgid_base_readdir, + .llseek = default_llseek,/* readdir is present */ };static struct dentry *proc_tgid_base_lookup (struct inode *dir,struct dentry *dentry,struct nameidata *nd){
@@ -3088,6 +3094,7 @@ static struct dentry *proc_tid_base_lookup(struct inode *dir, struct dentry *denstatic const struct file_operations proc_tid_base_operations = { .read = generic_read_dir, .readdir = proc_tid_base_readdir, + .llseek = default_llseek,/* readdir is present */ };static const struct inode_operations proc_tid_base_inode_operations = {
@@ -3324,4 +3331,5 @@ static const struct inode_operations proc_task_inode_operations = {static const struct file_operations proc_task_operations = { .read = generic_read_dir, .readdir = proc_task_readdir, + .llseek = default_llseek,/* readdir is present */ };
fs/proc/proc_sysctl.c +1 -0
@@ -364,6 +364,7 @@ static int proc_sys_getattr(struct vfsmount *mnt, struct dentry *dentry, structstatic const struct file_operations proc_sys_file_operations = { .read = proc_sys_read, .write = proc_sys_write, + .llseek = default_llseek,/* read accesses f_pos */ };static const struct file_operations proc_sys_dir_file_operations = {
fs/proc/root.c +1 -0
@@ -179,6 +179,7 @@ static int proc_root_readdir(struct file * filp,static const struct file_operations proc_root_operations = { .read = generic_read_dir, .readdir = proc_root_readdir, + .llseek = default_llseek,/* readdir is present */ };/*
fs/proc/task_mmu.c +1 -0
@@ -538,6 +538,7 @@ static ssize_t clear_refs_write(struct file *file, const char __user *buf,const struct file_operations proc_clear_refs_operations = { .write = clear_refs_write, + .llseek = noop_llseek,/* write uses no f_pos */ };struct pagemapread {
fs/romfs/super.c +1 -0
@@ -282,6 +282,7 @@ error:static const struct file_operations romfs_dir_operations = { .read = generic_read_dir, .readdir = romfs_readdir, + .llseek = default_llseek,/* readdir is present */ };static const struct inode_operations romfs_dir_inode_operations = {
fs/signalfd.c +1 -0
@@ -206,6 +206,7 @@ static const struct file_operations signalfd_fops = { .release = signalfd_release, .poll = signalfd_poll, .read = signalfd_read, + .llseek = noop_llseek,/* read uses no f_pos */ }; SYSCALL_DEFINE4(signalfd4, int, ufd, sigset_t __user *, user_mask,
fs/squashfs/dir.c +2 -1
@@ -230,5 +230,6 @@ failed_read:const struct file_operations squashfs_dir_ops = { .read = generic_read_dir, - .readdir = squashfs_readdir + .readdir = squashfs_readdir, + .llseek = default_llseek,/* readdir is present */ };
fs/timerfd.c +1 -0
@@ -144,6 +144,7 @@ static const struct file_operations timerfd_fops = { .release = timerfd_release, .poll = timerfd_poll, .read = timerfd_read, + .llseek = noop_llseek,/* read uses no f_pos */ };static struct file *timerfd_fget (int fd)
fs/ubifs/debug.c +1 -0
@@ -2625,6 +2625,7 @@ static const struct file_operations dfs_fops = { .open = open_debugfs_file, .write = write_debugfs_file, .owner = THIS_MODULE, + .llseek = default_llseek,/* write accesses f_pos */ };/**
ipc/mqueue.c +1 -0
@@ -1219,6 +1219,7 @@ static const struct file_operations mqueue_file_operations = { .flush = mqueue_flush_file, .poll = mqueue_poll_file, .read = mqueue_read_file, + .llseek = default_llseek,/* read accesses f_pos */ };static const struct super_operations mqueue_super_ops = {
ipc/shm.c +2 -0
@@ -298,6 +298,7 @@ static const struct file_operations shm_file_operations = { #ifndef CONFIG_MMU .get_unmapped_area = shm_get_unmapped_area, #endif + .llseek = noop_llseek,/* no read or write fn */ }; static const struct file_operations shm_file_operations_huge = {
@@ -305,6 +306,7 @@ static const struct file_operations shm_file_operations_huge = { .fsync = shm_fsync, .release = shm_release, .get_unmapped_area = shm_get_unmapped_area, + .llseek = noop_llseek,/* no read or write fn */ };int is_file_shm_hugepages (struct file *file)
kernel/configs.c +1 -0
@@ -66,6 +66,7 @@ ikconfig_read_current(struct file *file, char __user *buf,static const struct file_operations ikconfig_file_ops = { .owner =THIS_MODULE , .read = ikconfig_read_current, + .llseek = default_llseek,/* read accesses f_pos */ };static int __init ikconfig_init (void )
kernel/gcov/fs.c +1 -0
@@ -511,6 +511,7 @@ static ssize_t reset_read(struct file *file, char __user *addr, size_t len,static const struct file_operations gcov_reset_fops = { .write = reset_write, .read = reset_read, + .llseek = noop_llseek,/* read and write both use no f_pos */ };/*
kernel/kprobes.c +1 -0
@@ -1992,6 +1992,7 @@ static ssize_t write_enabled_file_bool(struct file *file,static const struct file_operations fops_kp = { .read = read_enabled_file_bool, .write = write_enabled_file_bool, + .llseek = default_llseek,/* read accesses f_pos */ };static int __kprobes debugfs_kprobe_init (void )
kernel/pm_qos_params.c +1 -0
@@ -110,6 +110,7 @@ static const struct file_operations pm_qos_power_fops = { .write = pm_qos_power_write, .open = pm_qos_power_open, .release = pm_qos_power_release, + .llseek = noop_llseek,/* write uses no f_pos */ };
Lines of this file are not shown. View the raw message.
net/mac80211/rc80211_minstrel_debugfs.c +1 -0
Lines of this file are not shown. View the raw message.
samples/tracepoints/tracepoint-sample.c +1 -0
Lines of this file are not shown. View the raw message.
The rest of this diff is not shown. View the raw message.
Signature · 1 line
1.7.1
Part of the diff is not shown here. View the raw message.
Arnd Bergmann
maintainerPATCH 14/15 vfs: don't use BKL in default_llseek
In reply to Arnd BergmannThere are currently 191 users of default_llseek. Nine of these are in device drivers that use the big kernel lock. None of these ever touch file->f_pos outside of llseek or file_pos_write.
Consequently, we never rely on the BKL in the default_llseek function and can replace that with i_mutex, which is also used in generic_file_llseek.
--- fs/read_write.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-)
fs/read_write.c +2 -2
@@ -124,7 +124,7 @@ loff_t default_llseek(struct file *file, loff_t offset, int origin) {loff_t retval; -lock_kernel (); +mutex_lock (&file->f_dentry->d_inode->i_mutex);switch (origin) {case SEEK_END : offset +=i_size_read (file->f_path.dentry->d_inode);
@@ -145,7 +145,7 @@ loff_t default_llseek(struct file *file, loff_t offset, int origin) retval = offset; } out: -unlock_kernel (); +mutex_unlock (&file->f_dentry->d_inode->i_mutex);return retval; }EXPORT_SYMBOL (default_llseek);
Signature · 1 line
1.7.1
Arnd Bergmann
maintainerPATCH 15/15 vfs: make no_llseek the default
In reply to Arnd BergmannAll file operations now have an explicit .llseek operation pointer, so we can change the default action for future code.
This makes changes the default from default_llseek to no_llseek, which always returns -ESPIPE if a user tries to seek on a file without a .llseek operation.
The name of the default_llseek function remains unchanged, if anyone thinks we should change it, please speak up.
--- fs/read_write.c | 1 - 1 files changed, 0 insertions(+), 1 deletions(-)
fs/read_write.c +0 -1
@@ -156,7 +156,6 @@ loff_t vfs_llseek(struct file *file, loff_t offset, int origin) fn = no_llseek;if (file->f_mode &FMODE_LSEEK ) { - fn = default_llseek;if (file->f_op && file->f_op->llseek) fn = file->f_op->llseek; }
Signature · 1 line
1.7.1
Hi Arnd,
Quoted 3 lines · On Tue, 14 Sep 2010 22:22:28 +0200 Arnd Bergmann <[email protected]> wrote:
Stephen, please add git+ssh://master.kernel.org/pub/scm/linux/kernel/git/arnd/bkl.git llseek
Added from today.
Thanks for adding your subsystem tree as a participant of linux-next. As you may know, this is not a judgment of your code. The purpose of linux-next is for integration testing and to lower the impact of conflicts between subsystems in the next merge window.
You will need to ensure that the patches/commits in your tree/series have been:
* submitted under GPL v2 (or later) and include the Contributor's Signed-off-by,
* posted to the relevant mailing list,
* reviewed by you (or another maintainer of your subsystem tree),
* successfully unit tested, and
* destined for the current or next Linux merge window.
Basically, this should be just what you would send to Linus (or ask him to fetch). It is allowed to be rebased if you deem it necessary.
Signature · 15 lines
Cheers, Stephen Rothwell [email protected] Legal Stuff: By participating in linux-next, your subsystem tree contributions are public and will be included in the linux-next trees. You may be sent e-mail messages indicating errors or other issues when the patches/commits from your subsystem tree are merged and tested in linux-next. These messages may also be cross-posted to the linux-next mailing list, the linux-kernel mailing list, etc. The linux-next tree project and IBM (my employer) make no warranties regarding the linux-next project, the testing procedures, the results, the e-mails, etc. If you don't agree to these ground rules, let me know and I'll remove your tree from participation in linux-next.
Quoted 14 lines · Stephen Rothwell
Hi Arnd,
Quoted 3 lines · On Tue, 14 Sep 2010 22:22:28 +0200 Arnd Bergmann <[email protected]> wrote:
Stephen, please add git+ssh://master.kernel.org/pub/scm/linux/kernel/git/arnd/bkl.git llseek
Added from today.
Thanks for adding your subsystem tree as a participant of linux-next. As you may know, this is not a judgment of your code. The purpose of linux-next is for integration testing and to lower the impact of conflicts between subsystems in the next merge window.
Quoted 4 lines
You will need to ensure that the patches/commits in your tree/series have been:
* submitted under GPL v2 (or later) and include the Contributor's Signed-off-by,
I should note this should say the code should be GPL-compatible, it doesn't need to be GPLv2 (or later). Furthermore the contributors of the subsystem respect the individual licenses of the files through the Developers Certificate of Origin, which tells the developers what the meaning of Signed-off-by means.
Luis
Quoted 5 lines · Arnd Bergmann
This changes *all* instances of struct
file_operationsin the kernel to have a .llseek operation and then changes the default tono_llseek, which returns-ESPIPE, which is what we had decided some time ago in a discussion with Christoph Hellwig.
I don't suppose there's any clean way to throw a build error or a printk_on_once() or something if we encounter an unconverted 'struct file_operations', is there? I have this creeping fear that this patch will go upstream during the merge window - as will 12 new staging/ drivers from authors who didn't get the memo yet.
Other than the "missed converting a new usage" issue, it looks OK to me.
Arnd Bergmann
maintainerQuoted 9 lines · On Wednesday 15 September 2010, [email protected] wrote:
Show Details
Quoted 5 lines · Arnd Bergmann
This changes all instances of struct
file_operationsin the kernel to have a .llseek operation and then changes the default tono_llseek, which returns-ESPIPE, which is what we had decided some time ago in a discussion with Christoph Hellwig.
Quoted 7 lines
I don't suppose there's any clean way to throw a build error or a
printk_on_once()or something if we encounter an unconverted 'structfile_operations', is there? I have this creeping fear that this patch will go upstream during the merge window - as will 12 new staging/ drivers from authors who didn't get the memo yet.Other than the "missed converting a new usage" issue, it looks OK to me.
One advantage of the scripted approach is that I can run the script repeatedly, and send a patch after -rc1 fixing up all the new file operations.
Moreover, any new drivers are by definition not regressions and staging drivers are expected to have issues. IIRC the most common llseek operation is 'noop_llseek', which usually means it should have been 'no_llseek' to start with, but since this has been in a released kernel, some random user application might expect a seek on that file to succeed without error.
Arnd