writeback: nr_dirtied and nr_written in /proc/vmstat
Subsystems (6)
PATCH 3/5 writeback: nr_dirtied and nr_written in /proc/vmstat
To help developers and applications gain visibility into writeback behaviour adding two entries to vm_stat_items and /proc/vmstat. This will allow us to track the "written" and "dirtied" counts.
# grep nr_dirtied /proc/vmstat nr_dirtied 3747 # grep nr_written /proc/vmstat nr_written 3618
Signed-off-by Michael Rubin <[email protected]>
--- include/linux/mmzone.h | 2 ++ mm/page-writeback.c | 2 ++ mm/vmstat.c | 3 +++ 3 files changed, 7 insertions(+), 0 deletions(-)
include/linux/mmzone.h +2 -0
@@ -104,6 +104,8 @@ enum zone_stat_item {NR_ISOLATED_ANON ,/* Temporary isolated pages from anon lru */ NR_ISOLATED_FILE ,/* Temporary isolated pages from file lru */ NR_SHMEM ,/* shmem pages (included tmpfs/GEM pages) */ +NR_DIRTIED ,/* page dirtyings since bootup */ +NR_WRITTEN ,/* page writings since bootup */ #ifdef CONFIG_NUMANUMA_HIT ,/* allocated in intended node */ NUMA_MISS, /* allocated in non intended node */
mm/page-writeback.c +2 -0
@@ -1126,6 +1126,7 @@ void account_page_dirtied(struct page *page, struct address_space *mapping) {if (mapping_cap_account_dirty (mapping)) {__inc_zone_page_state (page,NR_FILE_DIRTY ); +__inc_zone_page_state (page,NR_DIRTIED );__inc_bdi_stat (mapping->backing_dev_info,BDI_RECLAIMABLE );task_dirty_inc (current);task_io_account_write (PAGE_CACHE_SIZE );
@@ -1141,6 +1142,7 @@ EXPORT_SYMBOL(account_page_dirtied);void account_page_writeback (struct page *page) {inc_zone_page_state (page,NR_WRITEBACK ); +inc_zone_page_state (page,NR_WRITTEN ); }EXPORT_SYMBOL (account_page_writeback);
mm/vmstat.c +3 -0
@@ -732,6 +732,9 @@ static const char * const vmstat_text[] = {"nr_isolated_anon" ,"nr_isolated_file" ,"nr_shmem" , +"nr_dirtied" , +"nr_written" , + #ifdef CONFIG_NUMA"numa_hit" , "numa_miss",
Signature · 7 lines
1.7.1 -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to [email protected]. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"[email protected]"> [email protected] </a>
PATCH 4/5 writeback: Adding /sys/devices/system/node/<node>/vmstat
For NUMA node systems it is important to have visibility in memory characteristics. Two of the /proc/vmstat values "nr_written" and "nr_dirtied" are added here.
# cat /sys/devices/system/node/node20/vmstat nr_written 0 nr_dirtied 0
Signed-off-by Michael Rubin <[email protected]>
--- drivers/base/node.c | 14 ++++++++++++++ 1 files changed, 14 insertions(+), 0 deletions(-)
drivers/base/node.c +14 -0
@@ -160,6 +160,18 @@ static ssize_t node_read_numastat(struct sys_device * dev, } static SYSDEV_ATTR(numastat, S_IRUGO, node_read_numastat, NULL); +static ssize_t node_read_vmstat (struct sys_device *dev, +struct sysdev_attribute *attr,char *buf) +{ +int nid = dev->id; +return sprintf (buf, +"nr_written %lu\n" +"nr_dirtied %lu\n" , +node_page_state (nid,NR_WRITTEN ), +node_page_state (nid,NR_DIRTIED )); +} +static SYSDEV_ATTR(vmstat, S_IRUGO, node_read_vmstat, NULL); +static ssize_t node_read_distance (struct sys_device * dev,struct sysdev_attribute *attr,char * buf) {
@@ -243,6 +255,7 @@ int register_node(struct node *node, int num, struct node *parent)sysdev_create_file (&node->sysdev, &attr_meminfo);sysdev_create_file (&node->sysdev, &attr_numastat);sysdev_create_file (&node->sysdev, &attr_distance); +sysdev_create_file (&node->sysdev, &attr_vmstat);scan_unevictable_register_node (node);
@@ -267,6 +280,7 @@ void unregister_node(struct node *node)sysdev_remove_file (&node->sysdev, &attr_meminfo);sysdev_remove_file (&node->sysdev, &attr_numastat);sysdev_remove_file (&node->sysdev, &attr_distance); +sysdev_remove_file (&node->sysdev, &attr_vmstat);scan_unevictable_unregister_node (node);hugetlb_unregister_node (node);/* no-op, if memoryless node */
Signature · 7 lines
1.7.1 -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to [email protected]. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"[email protected]"> [email protected] </a>