ida: document IDA_BITMAP_LONGS calculation
Subsystems (2)
PATCH RESEND 1/2 ida: document IDA_BITMAP_LONGS calculation
IDA_BITMAP_LONGS value is calculated take into account struct ida_bitmap not to waste memory space. Comment it.
--- include/linux/idr.h | 5 ++++- 1 files changed, 4 insertions(+), 1 deletions(-)
include/linux/idr.h +4 -1
@@ -117,10 +117,13 @@ void idr_init(struct idr *idp);/* * IDA - IDR based id allocator, use when translation from id to * pointer isn't necessary. +* +* IDA_BITMAP_LONGS is calculated to be one less to accommodate +* ida_bitmap->nr_busy so that the whole struct fits in 128 bytes. */ #define IDA_CHUNK_SIZE 128/* 128 bytes per chunk */ #define IDA_BITMAP_LONGS (128 / sizeof(long) - 1) -#define IDA_BITMAP_BITS (IDA_BITMAP_LONGS * sizeof(long) * 8) +#define IDA_BITMAP_BITS (IDA_BITMAP_LONGS * sizeof(long) * 8)struct ida_bitmap {long nr_busy;
Signature · 1 line
1.7.2.2
PATCH RESEND 2/2 ext2: trivial: fix a typo on comment in ext2/inode.c
'excpet' should be 'except'.
'ext3_get_branch' should be 'ext2_get_branch'.
--- fs/ext2/inode.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-)
fs/ext2/inode.c +2 -2
@@ -458,7 +458,7 @@ failed_out:* the same format as ext2_get_branch() would do. We are calling it after * we had read the existing part of chain and partial points to the last * triple of that (one with zero ->key). Upon the exit we have the same -* picture as after the successful ext2_get_block(), excpet that in one +* picture as after the successful ext2_get_block(), except that in one * place chain is disconnected - *branch->p is still zero (we did not * set the last link), but branch->key contains the number that should * be placed into *branch->p to fill that gap.
@@ -662,7 +662,7 @@ static int ext2_get_blocks(struct inode *inode,mutex_lock (&ei->truncate_mutex);/* * If the indirect block is missing while we are reading -* the chain(ext3_get_branch() returns -EAGAIN err), or +* the chain(ext2_get_branch() returns -EAGAIN err), or * if the chain has been changed after we grab the semaphore, * (either because another process truncated this branch, or * another get_block allocated this branch) re-grab the chain to see if
Signature · 1 line
1.7.2.2
Quoted 14 lines · On Wed, 15 Sep 2010 21:46:01 +0900 Namhyung Kim wrote:
IDA_BITMAP_LONGSvalue is calculated take into account structida_bitmapnot to waste memory space. Comment it.Signed-off-by Namhyung Kim <[email protected]>Acked-by Tejun Heo <[email protected]>--- include/linux/idr.h | 5 ++++- 1 files changed, 4 insertions(+), 1 deletions(-)include/linux/idr.h +0
-0
include/linux/idr.h void idr_init(struct idr *idp); · line 125
Quoted 9 lines
include/linux/idr.h +3
-0@@ -117,10 +117,13 @@ void idr_init(struct idr *idp);/* * IDA - IDR based id allocator, use when translation from id to * pointer isn't necessary. +* +* IDA_BITMAP_LONGS is calculated to be one less to accommodate +* ida_bitmap->nr_busy so that the whole struct fits in 128 bytes. */ #define IDA_CHUNK_SIZE 128/* 128 bytes per chunk */ #define IDA_BITMAP_LONGS (128 / sizeof(long) - 1)
Might as well do:
#define IDA_BITMAP_LONGS (IDA_CHUNK_SIZE / sizeof(long) - 1)
instead of repeating the 128.
include/linux/idr.h void idr_init(struct idr *idp); · line 129
Quoted 6 lines
include/linux/idr.h +1
-1-#define IDA_BITMAP_BITS (IDA_BITMAP_LONGS * sizeof(long) * 8) +#define IDA_BITMAP_BITS (IDA_BITMAP_LONGS * sizeof(long) * 8)struct ida_bitmap {long nr_busy;
---
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***
PATCH 1/2 ida: document IDA_BITMAP_LONGS calculation
IDA_BITMAP_LONGS value is calculated take into account struct ida_bitmap not to waste memory space. Comment it.
--- include/linux/idr.h | 5 ++++- 1 files changed, 4 insertions(+), 1 deletions(-)
include/linux/idr.h +5 -2
@@ -117,10 +117,13 @@ void idr_init(struct idr *idp);/* * IDA - IDR based id allocator, use when translation from id to * pointer isn't necessary. +* +* IDA_BITMAP_LONGS is calculated to be one less to accommodate +* ida_bitmap->nr_busy so that the whole struct fits in 128 bytes. */ #define IDA_CHUNK_SIZE 128/* 128 bytes per chunk */ -#define IDA_BITMAP_LONGS (128 / sizeof(long) - 1) -#define IDA_BITMAP_BITS (IDA_BITMAP_LONGS * sizeof(long) * 8) +#define IDA_BITMAP_LONGS (IDA_CHUNK_SIZE / sizeof(long) - 1) +#define IDA_BITMAP_BITS (IDA_BITMAP_LONGS * sizeof(long) * 8)struct ida_bitmap {long nr_busy;
Signature · 1 line
1.7.2.2
Quoted 5 lines · On Thu, 16 Sep 2010 01:30:19 +0900 Namhyung Kim wrote:
IDA_BITMAP_LONGSvalue is calculated take into account structida_bitmapnot to waste memory space. Comment it.Signed-off-by Namhyung Kim <[email protected]>Acked-by Tejun Heo <[email protected]>
Thanks.
Quoted 15 lines
--- include/linux/idr.h | 5 ++++- 1 files changed, 4 insertions(+), 1 deletions(-)include/linux/idr.h +2
-0@@ -117,10 +117,13 @@ void idr_init(struct idr *idp);/* * IDA - IDR based id allocator, use when translation from id to * pointer isn't necessary. +* +* IDA_BITMAP_LONGS is calculated to be one less to accommodate
include/linux/idr.h void idr_init(struct idr *idp); · line 129
Quoted 10 lines
include/linux/idr.h +3
-2+* ida_bitmap->nr_busy so that the whole struct fits in 128 bytes. */ #define IDA_CHUNK_SIZE 128/* 128 bytes per chunk */ -#define IDA_BITMAP_LONGS (128 / sizeof(long) - 1) -#define IDA_BITMAP_BITS (IDA_BITMAP_LONGS * sizeof(long) * 8) +#define IDA_BITMAP_LONGS (IDA_CHUNK_SIZE / sizeof(long) - 1) +#define IDA_BITMAP_BITS (IDA_BITMAP_LONGS * sizeof(long) * 8)struct ida_bitmap {long nr_busy;
---
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***