wext: fix potential private ioctl memory content leak
Johannes Berg
maintainerPATCH 1/1 wext: fix potential private ioctl memory content leak
From: Johannes Berg <[email protected]>
When a driver doesn't fill the entire buffer, old heap contents may remain, and if it also doesn't update the length properly, this old heap content will be copied back to userspace.
It is very unlikely that this happens in any of the drivers using private ioctls since it would show up as junk being reported by iwpriv, but it seems better to be safe here, so use kzalloc.
Reported-by Jeff Mahoney <[email protected]>
Signed-off-by Johannes Berg <[email protected]>
--- net/wireless/wext-priv.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
net/wireless/wext-priv.c +1 -1
@@ -152,7 +152,7 @@ static int ioctl_private_iw_point(struct }else if (!iwp->pointer)return -EFAULT ; - extra =kmalloc (extra_size,GFP_KERNEL ); + extra =kzalloc (extra_size,GFP_KERNEL );if (!extra)return -ENOMEM ;