Skip to contentSkip to conversation

qla4xxx: Remove host_lock unlock() + lock() from qla4xxx_queuecommand()

PATCH In review Nicholas A. Bellinger 2 participants 2 messages Sep 17, 2010 – Oct 26, 2010

Subsystems (2)
SCSI QLogic QLA4XXX iSCSI driver
lore
Share & tools
lore

Nicholas A. Bellinger

author
#0 lore raw

PATCH v2 8/11 qla4xxx: Remove host_lock unlock() + lock() from qla4xxx_queuecommand()

From: Nicholas Bellinger <[email protected]>

This patch removes the now legacy host_lock unlock() + lock() optimization from ql4_os.c:qla4xxx_queuecommand()

Signed-off-by Nicholas A. Bellinger <[email protected]>
---
 drivers/scsi/qla4xxx/ql4_os.c |    8 +-------
 1 files changed, 1 insertions(+), 7 deletions(-)
drivers/scsi/qla4xxx/ql4_os.c +1 -7
index 370d40f..cfbe8b5 100644
@@ -511,26 +511,20 @@ static int qla4xxx_queuecommand(struct scsi_cmnd *cmd,
 	    test_bit(DPC_RESET_HA_FW_CONTEXT, &ha->dpc_flags))
 		goto qc_host_busy;
 
-	spin_unlock_irq(ha->host->host_lock);
-
 	srb = qla4xxx_get_new_srb(ha, ddb_entry, cmd, done);
 	if (!srb)
-		goto qc_host_busy_lock;
+		goto qc_host_busy;
 
 	rval = qla4xxx_send_command_to_isp(ha, srb);
 	if (rval != QLA_SUCCESS)
 		goto qc_host_busy_free_sp;
 
-	spin_lock_irq(ha->host->host_lock);
 	return 0;
 
 qc_host_busy_free_sp:
 	qla4xxx_srb_free_dma(ha, srb);
 	mempool_free(srb, ha->srb_mempool);
 
-qc_host_busy_lock:
-	spin_lock_irq(ha->host->host_lock);
-
 qc_host_busy:
 	return SCSI_MLQUEUE_HOST_BUSY;
Signature · 1 line
1.7.2.3
Acked-by on v2 8/11
#1 lore raw
Quoted 32 lines · Nicholas A. Bellinger

From: Nicholas Bellinger <[email protected]>

This patch removes the now legacy host_lock unlock() + lock() optimization from ql4_os.c:qla4xxx_queuecommand()

Signed-off-by Nicholas A. Bellinger <[email protected]>
---
 drivers/scsi/qla4xxx/ql4_os.c |    8 +-------
 1 files changed, 1 insertions(+), 7 deletions(-)
drivers/scsi/qla4xxx/ql4_os.c +1 -4
index 370d40f..cfbe8b5 100644
@@ -511,26 +511,20 @@ static int qla4xxx_queuecommand(struct scsi_cmnd *cmd,
 	    test_bit(DPC_RESET_HA_FW_CONTEXT, &ha->dpc_flags))
 		goto qc_host_busy;
 
-	spin_unlock_irq(ha->host->host_lock);
-
 	srb = qla4xxx_get_new_srb(ha, ddb_entry, cmd, done);
 	if (!srb)
-		goto qc_host_busy_lock;
+		goto qc_host_busy;
 
 	rval = qla4xxx_send_command_to_isp(ha, srb);
 	if (rval != QLA_SUCCESS)
 		goto qc_host_busy_free_sp;
 
-	spin_lock_irq(ha->host->host_lock);
 	return 0;

drivers/scsi/qla4xxx/ql4_os.c static int qla4xxx_queuecommand(struct scsi_cmnd *cmd, · line 530

Quoted 10 lines
drivers/scsi/qla4xxx/ql4_os.c +0 -3
 qc_host_busy_free_sp:
 	qla4xxx_srb_free_dma(ha, srb);
 	mempool_free(srb, ha->srb_mempool);
 
-qc_host_busy_lock:
-	spin_lock_irq(ha->host->host_lock);
-
 qc_host_busy:
 	return SCSI_MLQUEUE_HOST_BUSY;

Let us know if you want us to send it to James
as part of our patch posting. Thanks.

Acked-by Ravi Anand <[email protected]>
Quoted 9 lines
Signature · 6 lines
1.7.2.3

--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html