Skip to contentSkip to conversation

selftests/bpf: Fix const qualifier warning in fexit_bpf2bpf.c

PATCH Applied Varun R Mallya 4 participants 7 messages Mar 5 – Mar 11

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 selftests/bpf: Fix const qualifier warning in fexit_bpf2bpf.c

Building selftests with
clang 23.0.0 (6fae863eba8a72cdd82f37e7111a46a70be525e0) triggers the following error:

tools/testing/selftests/bpf/prog_tests/fexit_bpf2bpf.c:117:12:
error: assigning to 'char *' from 'const char *' discards qualifiers [-Werror,-Wincompatible-pointer-types-discards-qualifiers]

The variable tgt_name is declared as char *, but it stores the result of strstr(prog_name[i], "/"). Since prog_name[i] is a const char *, the returned pointer should also be treated as const-qualified.

Update tgt_name to const char * to match the type of the underlying string and silence the compiler warning.

---
 tools/testing/selftests/bpf/prog_tests/fexit_bpf2bpf.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
tools/testing/selftests/bpf/prog_tests/fexit_bpf2bpf.c +1 -1
index 23d933f1aec6..92c20803ea76 100644
@@ -111,7 +111,7 @@ static void test_fexit_bpf2bpf_common(const char *obj_file,
 		struct bpf_link_info link_info;
 		struct bpf_program *pos;
 		const char *pos_sec_name;
-		char *tgt_name;
+		const char *tgt_name;
 		__s32 btf_id;
 
 		tgt_name = strstr(prog_name[i], "/");
Signature · 1 line
2.53.0
Acked-by on v1 1/1
#1 lore raw

On 2026/3/6 06:21 Varun R Mallya <[email protected]> write:

Quoted 26 lines

Building selftests with
clang 23.0.0 (6fae863eba8a72cdd82f37e7111a46a70be525e0) triggers the following error:

tools/testing/selftests/bpf/prog_tests/fexit_bpf2bpf.c:117:12:
error: assigning to 'char *' from 'const char *' discards qualifiers [-Werror,-Wincompatible-pointer-types-discards-qualifiers]

The variable tgt_name is declared as char *, but it stores the result of strstr(prog_name[i], "/"). Since prog_name[i] is a const char *, the returned pointer should also be treated as const-qualified.

Update tgt_name to const char * to match the type of the underlying string and silence the compiler warning.

---
 tools/testing/selftests/bpf/prog_tests/fexit_bpf2bpf.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
tools/testing/selftests/bpf/prog_tests/fexit_bpf2bpf.c +0 -0
index 23d933f1aec6..92c20803ea76 100644

tools/testing/selftests/bpf/prog_tests/fexit_bpf2bpf.c static void test_fexit_bpf2bpf_common(const char *obj_file, · line 114

Quoted 5 lines
tools/testing/selftests/bpf/prog_tests/fexit_bpf2bpf.c +1 -1
@@ -111,7 +111,7 @@ static void test_fexit_bpf2bpf_common(const char *obj_file,
 		struct bpf_link_info link_info;
 		struct bpf_program *pos;
 		const char *pos_sec_name;
-		char *tgt_name;
+		const char *tgt_name;

I have been suffering from this build error too. So,

Quoted 8 lines
tools/testing/selftests/bpf/prog_tests/fexit_bpf2bpf.c +0 -0
 		__s32 btf_id;
 
 		tgt_name = strstr(prog_name[i], "/");
Signature · 1 line
2.53.0
#2 lore raw
Quoted 36 lines · Menglong Dong

On 2026/3/6 06:21 Varun R Mallya <[email protected]> write:

Quoted 26 lines

Building selftests with
clang 23.0.0 (6fae863eba8a72cdd82f37e7111a46a70be525e0) triggers the following error:

tools/testing/selftests/bpf/prog_tests/fexit_bpf2bpf.c:117:12:
error: assigning to 'char *' from 'const char *' discards qualifiers [-Werror,-Wincompatible-pointer-types-discards-qualifiers]

The variable tgt_name is declared as char *, but it stores the result of strstr(prog_name[i], "/"). Since prog_name[i] is a const char *, the returned pointer should also be treated as const-qualified.

Update tgt_name to const char * to match the type of the underlying string and silence the compiler warning.

---
 tools/testing/selftests/bpf/prog_tests/fexit_bpf2bpf.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
tools/testing/selftests/bpf/prog_tests/fexit_bpf2bpf.c +0 -0
index 23d933f1aec6..92c20803ea76 100644

tools/testing/selftests/bpf/prog_tests/fexit_bpf2bpf.c static void test_fexit_bpf2bpf_common(const char *obj_file, · line 114

Quoted 5 lines
tools/testing/selftests/bpf/prog_tests/fexit_bpf2bpf.c +1 -1
@@ -111,7 +111,7 @@ static void test_fexit_bpf2bpf_common(const char *obj_file,
              struct bpf_link_info link_info;
              struct bpf_program *pos;
              const char *pos_sec_name;
-             char *tgt_name;
+             const char *tgt_name;

I have been suffering from this build error too. So,

Quoted 1 line

Looks like this patch was lost. Pls resend.

#3 lore raw
Quoted 38 lines · Alexei Starovoitov
Quoted 36 lines · Menglong Dong

On 2026/3/6 06:21 Varun R Mallya <[email protected]> write:

Quoted 26 lines

Building selftests with
clang 23.0.0 (6fae863eba8a72cdd82f37e7111a46a70be525e0) triggers the following error:

tools/testing/selftests/bpf/prog_tests/fexit_bpf2bpf.c:117:12:
error: assigning to 'char *' from 'const char *' discards qualifiers [-Werror,-Wincompatible-pointer-types-discards-qualifiers]

The variable tgt_name is declared as char *, but it stores the result of strstr(prog_name[i], "/"). Since prog_name[i] is a const char *, the returned pointer should also be treated as const-qualified.

Update tgt_name to const char * to match the type of the underlying string and silence the compiler warning.

---
 tools/testing/selftests/bpf/prog_tests/fexit_bpf2bpf.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
tools/testing/selftests/bpf/prog_tests/fexit_bpf2bpf.c +0 -0
index 23d933f1aec6..92c20803ea76 100644

tools/testing/selftests/bpf/prog_tests/fexit_bpf2bpf.c static void test_fexit_bpf2bpf_common(const char *obj_file, · line 114

Quoted 5 lines
tools/testing/selftests/bpf/prog_tests/fexit_bpf2bpf.c +1 -1
@@ -111,7 +111,7 @@ static void test_fexit_bpf2bpf_common(const char *obj_file,
              struct bpf_link_info link_info;
              struct bpf_program *pos;
              const char *pos_sec_name;
-             char *tgt_name;
+             const char *tgt_name;

I have been suffering from this build error too. So,

Quoted 3 lines
Quoted 1 line

Looks like this patch was lost. Pls resend.

Ohh. I see it now. Your reply got delivered before the patch itself and the patch went to spam.
No need to resend.

#4 lore raw

On 2026/3/6 10:26 Alexei Starovoitov <[email protected]> write:

Quoted 40 lines
Quoted 38 lines · Alexei Starovoitov
Quoted 36 lines · Menglong Dong

On 2026/3/6 06:21 Varun R Mallya <[email protected]> write:

Quoted 26 lines

Building selftests with
clang 23.0.0 (6fae863eba8a72cdd82f37e7111a46a70be525e0) triggers the following error:

tools/testing/selftests/bpf/prog_tests/fexit_bpf2bpf.c:117:12:
error: assigning to 'char *' from 'const char *' discards qualifiers [-Werror,-Wincompatible-pointer-types-discards-qualifiers]

The variable tgt_name is declared as char *, but it stores the result of strstr(prog_name[i], "/"). Since prog_name[i] is a const char *, the returned pointer should also be treated as const-qualified.

Update tgt_name to const char * to match the type of the underlying string and silence the compiler warning.

---
 tools/testing/selftests/bpf/prog_tests/fexit_bpf2bpf.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
tools/testing/selftests/bpf/prog_tests/fexit_bpf2bpf.c +0 -0
index 23d933f1aec6..92c20803ea76 100644

tools/testing/selftests/bpf/prog_tests/fexit_bpf2bpf.c static void test_fexit_bpf2bpf_common(const char *obj_file, · line 114

Quoted 5 lines
tools/testing/selftests/bpf/prog_tests/fexit_bpf2bpf.c +1 -1
@@ -111,7 +111,7 @@ static void test_fexit_bpf2bpf_common(const char *obj_file,
              struct bpf_link_info link_info;
              struct bpf_program *pos;
              const char *pos_sec_name;
-             char *tgt_name;
+             const char *tgt_name;

I have been suffering from this build error too. So,

Quoted 7 lines
Quoted 3 lines
Quoted 1 line

Looks like this patch was lost. Pls resend.

Ohh. I see it now. Your reply got delivered before the patch itself and the patch went to spam.
No need to resend.

Okay!

#5 lore raw
In reply to Varun R Mallya

Looks like the CI failed on this:

Quoted 10 lines

CI has tested the following submission:

Status:     FAILURE
Name:       [bpf-next] selftests/bpf: Fix const qualifier warning in fexit_bpf2bpf.c
Patchwork:  https://patchwork.kernel.org/project/netdevbpf/list/?series=1062212&state=*
Matrix:     https://github.com/kernel-patches/bpf/actions/runs/22741682920

Failed jobs:
test_progs_parallel-x86_64-gcc-15: https://github.com/kernel-patches/bpf/actions/runs/22741682920/job/65957069283

The CI Failure seems to be unrelated, though:

```
With the provided path, there will be 109 files uploaded

Artifact name is valid!
Root directory input is valid!
Error: The path for one of the files in artifact is not valid:
/packets-135-10-net_timestamping__INET4:_bpf_timestamping-net_timestamping_ns.log.
Contains the following character:  Colon :

Invalid characters include:  Double quote ", Colon :, Less than <, Greater than >,
Vertical bar |, Asterisk *, Question mark ?, Carriage return \r, Line feed \n

The following characters are not allowed in files that are uploaded due to
limitations with certain file systems such as NTFS. To maintain file system
agnostic behavior, these characters are intentionally not allowed to prevent
potential problems with downloads on different file systems.
```

The selftests did pass.

#6 lore raw
In reply to Varun R Mallya
This patch was applied to bpf/bpf-next.git (master) by Andrii Nakryiko <[email protected]>:

Hello:

This patch was applied to bpf/bpf-next.git (master) by Andrii Nakryiko <[email protected]>:

Quoted 9 lines · On Fri, 6 Mar 2026 03:51:32 +0530 you wrote:

Building selftests with
clang 23.0.0 (6fae863eba8a72cdd82f37e7111a46a70be525e0) triggers the following error:

tools/testing/selftests/bpf/prog_tests/fexit_bpf2bpf.c:117:12:
error: assigning to 'char *' from 'const char *' discards qualifiers [-Werror,-Wincompatible-pointer-types-discards-qualifiers]

[...]

Here is the summary with links:
- [bpf-next] selftests/bpf: Fix const qualifier warning in fexit_bpf2bpf.c

    https://git.kernel.org/bpf/bpf-next/c/ca0f39a369c5

You are awesome, thank you!

Signature · 2 lines
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html