Skip to contentSkip to conversation

uwb: fix device_register() error handling

PATCH Applied Vasiliy Kulikov 2 participants 2 messages Sep 19, 2010 – Sep 22, 2010 Kernel janitors

lore
Share & tools
lore

Vasiliy Kulikov

author
#0 lore raw

PATCH 13/14 uwb: fix device_register() error handling

If device_register() fails then call put_device(). See comment to device_register.

Signed-off-by Vasiliy Kulikov <[email protected]>

---
compile tested.

 drivers/uwb/umc-dev.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)
drivers/uwb/umc-dev.c +1 -0
index 43ea998..e8e06ee 100644
@@ -68,6 +68,7 @@ int umc_device_register(struct umc_dev *umc)
 	return 0;
 
 error_device_register:
+	put_device(&umc->dev);
 	release_resource(&umc->resource);
 error_request_resource:
 	return err;
Signature · 1 line
1.7.0.4
Acked-by on v1 13/14
#1 lore raw
Quoted 4 lines · Vasiliy Kulikov

If device_register() fails then call put_device(). See comment to device_register.

Signed-off-by Vasiliy Kulikov <[email protected]>
Acked-by David Vrabel <[email protected]>

What's the preferred way of handling these sorts of patch sets? Merged via some kernel-janitor tree or is it expected that subsystem maintainers pick up the individual patches?

David

Signature · 6 lines
David Vrabel, Senior Software Engineer, Drivers
CSR, Churchill House, Cambridge Business Park,  Tel: +44 (0)1223 692562
Cowley Road, Cambridge, CB4 0WZ                 http://www.csr.com/


Member of the CSR plc group of companies. CSR plc registered in England and Wales, registered number 4187346, registered office Churchill House, Cambridge Business Park, Cowley Road, Cambridge, CB4 0WZ, United Kingdom