ARM: s3c2440: various fixes in Kconfig file
Subsystems (2)
PATCH RESEND v2 1/1 ARM: s3c2440: various fixes in Kconfig file
* kconfig symbols defined in arch/arm/mach-s3c2440/Kconfig are only available
when ARCH_S3C2410 is selected, so no need to make some of them depend
on ARCH_S3C2410.
* CPU_S3C24405B is used nowhere in the whole source tree, so remove it from
"config S3C2440_DMA".
* mini2440: select SND_S3C24XX_SOC as it is needed in order be able to select
SND_S3C24XX_SOC_S3C24XX_UDA134X.
Those fixes avoid the following warnings at make time:scripts/kconfig/qconf arch/arm/Kconfig
warning: (MACH_MINI2440 && ARCH_S3C2410) selects SND_S3C24XX_SOC_S3C24XX_UDA134X which has unmet direct dependencies (SND_S3C24XX_SOC && ARCH_S3C2410)
warning: (CPU_S3C2440 && ARCH_S3C2410 && S3C2410_DMA) selects S3C2440_DMA which has unmet direct dependencies (ARCH_S3C2410 && CPU_S3C24405B)
warning: (CPU_S3C2440 && ARCH_S3C2410 || CPU_S3C2442 && ARCH_S3C2410) selects CPU_S3C244X which has unmet direct dependencies (!ARCH_S3C2410)
---
changes since v1:
include warnings observed without this patch
arch/arm/mach-s3c2440/Kconfig | 6 ++---- 1 files changed, 2 insertions(+), 4 deletions(-)
arch/arm/mach-s3c2440/Kconfig +2 -4
@@ -4,7 +4,6 @@ config CPU_S3C2440 bool - depends on ARCH_S3C2410 select CPU_ARM920T select S3C_GPIO_PULL_UP select S3C2410_CLOCK
@@ -18,7 +17,6 @@ config CPU_S3C2440 config CPU_S3C2442 bool - depends on ARCH_S3C2410 select CPU_ARM920T select S3C2410_CLOCK select S3C2410_GPIO
@@ -30,7 +28,7 @@ config CPU_S3C2442 config CPU_S3C244X bool - depends on ARCH_S3C2410 && (CPU_S3C2440 || CPU_S3C2442) + depends on CPU_S3C2440 || CPU_S3C2442 help Support for S3C2440 and S3C2442 Samsung Mobile CPU based systems.
@@ -72,7 +70,6 @@ config S3C2440_PLL_16934400 config S3C2440_DMA bool - depends on ARCH_S3C2410 && CPU_S3C24405B help Support for S3C2440 specific DMA code5A
@@ -181,6 +178,7 @@ config MACH_MINI2440 select CPU_S3C2440 select EEPROM_AT24 select LEDS_TRIGGER_BACKLIGHT + select SND_S3C24XX_SOC select SND_S3C24XX_SOC_S3C24XX_UDA134X select S3C_DEV_NAND select S3C_DEV_USB_HOST
Signature · 1 line
1.7.0.4
PATCH RESEND v2 1/1 ARM: s3c2440: various fixes in Kconfig file
Quoted 52 lines · Abdoulaye Walsimou Gaye
* kconfig symbols defined in
arch/arm/mach-s3c2440/Kconfigare only available
whenARCH_S3C2410is selected, so no need to make some of them depend
onARCH_S3C2410.
*CPU_S3C24405Bis used nowhere in the whole source tree, so remove it from
"configS3C2440_DMA".
* mini2440: selectSND_S3C24XX_SOCas it is needed in order be able to select
SND_S3C24XX_SOC_S3C24XX_UDA134X.
Those fixes avoid the following warnings at make time:scripts/kconfig/qconfarch/arm/Kconfig
warning: (MACH_MINI2440&&ARCH_S3C2410) selectsSND_S3C24XX_SOC_S3C24XX_UDA134Xwhich has unmet direct dependencies (SND_S3C24XX_SOC&&ARCH_S3C2410)
warning: (CPU_S3C2440&&ARCH_S3C2410&&S3C2410_DMA) selectsS3C2440_DMAwhich has unmet direct dependencies (ARCH_S3C2410&&CPU_S3C24405B)
warning: (CPU_S3C2440&&ARCH_S3C2410||CPU_S3C2442&&ARCH_S3C2410) selectsCPU_S3C244Xwhich has unmet direct dependencies (!ARCH_S3C2410)Signed-off-by Abdoulaye Walsimou Gaye <[email protected]>---
changes since v1:
include warnings observed without this patcharch/arm/mach-s3c2440/Kconfig | 6 ++---- 1 files changed, 2 insertions(+), 4 deletions(-)arch/arm/mach-s3c2440/Kconfig +1
-3@@ -4,7 +4,6 @@ config CPU_S3C2440 bool - depends on ARCH_S3C2410 select CPU_ARM920T select S3C_GPIO_PULL_UP select S3C2410_CLOCK@@ -18,7 +17,6 @@ config CPU_S3C2440 config CPU_S3C2442 bool - depends on ARCH_S3C2410 select CPU_ARM920T select S3C2410_CLOCK select S3C2410_GPIO@@ -30,7 +28,7 @@ config CPU_S3C2442 config CPU_S3C244X bool - depends on ARCH_S3C2410 && (CPU_S3C2440 || CPU_S3C2442) + depends on CPU_S3C2440 || CPU_S3C2442 help Support for S3C2440 and S3C2442 Samsung Mobile CPU based systems.
arch/arm/mach-s3c2440/Kconfig config S3C2440_PLL_16934400 · line 75
Quoted 4 lines
arch/arm/mach-s3c2440/Kconfig +0
-1@@ -72,7 +70,6 @@ config S3C2440_PLL_16934400 config S3C2440_DMA bool - depends on ARCH_S3C2410 && CPU_S3C24405B
i think the CPU_S3C24405B should be changed to CPU_S3C2440
arch/arm/mach-s3c2440/Kconfig config MACH_MINI2440 · line 184
Quoted 11 lines
arch/arm/mach-s3c2440/Kconfig +1
-0help Support for S3C2440 specific DMA code5A@@ -181,6 +178,7 @@ config MACH_MINI2440 select CPU_S3C2440 select EEPROM_AT24 select LEDS_TRIGGER_BACKLIGHT + select SND_S3C24XX_SOC select SND_S3C24XX_SOC_S3C24XX_UDA134X select S3C_DEV_NAND select S3C_DEV_USB_HOST
I don't like things forcing other kconfig stuff on if it is not required for the system to build and function minimally.
c
PATCH v3 1/1 ARM: s3c2440: various fixes in Kconfig file
* kconfig symbols defined in arch/arm/mach-s3c2440/Kconfig are only available when ARCH_S3C2410 is selected, so no need to make some of them depend on ARCH_S3C2410.
* fix CPU_S3C24405B typo in "config S3C2440_DMA".
* mini2440: remove unconditionally select of SND_S3C24XX_SOC_S3C24XX_UDA134X. Those fixes avoid the following warnings at make time:
scripts/kconfig/qconf arch/arm/Kconfig
warning: (MACH_MINI2440 && ARCH_S3C2410) selects SND_S3C24XX_SOC_S3C24XX_UDA134X which has unmet direct dependencies (SND_S3C24XX_SOC && ARCH_S3C2410)
warning: (CPU_S3C2440 && ARCH_S3C2410 && S3C2410_DMA) selects S3C2440_DMA which has unmet direct dependencies (ARCH_S3C2410 && CPU_S3C24405B)
warning: (CPU_S3C2440 && ARCH_S3C2410 || CPU_S3C2442 && ARCH_S3C2410) selects CPU_S3C244X which has unmet direct dependencies (!ARCH_S3C2410)
---
changes since v1:
include warnings observed without this patch
changes since v2:
take into account comments from Ben about unconditional select of some kconfig symbols
arch/arm/mach-s3c2440/Kconfig | 7 ++----- 1 files changed, 2 insertions(+), 5 deletions(-)
arch/arm/mach-s3c2440/Kconfig +2 -5
@@ -4,7 +4,6 @@ config CPU_S3C2440 bool - depends on ARCH_S3C2410 select CPU_ARM920T select S3C_GPIO_PULL_UP select S3C2410_CLOCK
@@ -18,7 +17,6 @@ config CPU_S3C2440 config CPU_S3C2442 bool - depends on ARCH_S3C2410 select CPU_ARM920T select S3C2410_CLOCK select S3C2410_GPIO
@@ -30,7 +28,7 @@ config CPU_S3C2442 config CPU_S3C244X bool - depends on ARCH_S3C2410 && (CPU_S3C2440 || CPU_S3C2442) + depends on CPU_S3C2440 || CPU_S3C2442 help Support for S3C2440 and S3C2442 Samsung Mobile CPU based systems.
@@ -72,7 +70,7 @@ config S3C2440_PLL_16934400 config S3C2440_DMA bool - depends on ARCH_S3C2410 && CPU_S3C24405B + depends on CPU_S3C2440 help Support for S3C2440 specific DMA code5A
@@ -181,7 +179,6 @@ config MACH_MINI2440 select CPU_S3C2440 select EEPROM_AT24 select LEDS_TRIGGER_BACKLIGHT - select SND_S3C24XX_SOC_S3C24XX_UDA134X select S3C_DEV_NAND select S3C_DEV_USB_HOST help
Signature · 1 line
1.7.0.4