Skip to contentSkip to conversation

ASoC: Select DMA driver for Samsung DAIs

PATCH In review Mark Brown 4 participants 5 messages Sep 20, 2010 – Sep 22, 2010

Subsystems (2)
lore
Share & tools
lore

Mark Brown

author
#0 lore raw

PATCH 1/1 ASoC: Select DMA driver for Samsung DAIs

Kconfig got smart enough to do dependencies through selects so let's make use of that.

---
 sound/soc/s3c24xx/Kconfig |    4 ++++
 1 files changed, 4 insertions(+), 0 deletions(-)
sound/soc/s3c24xx/Kconfig +4 -0
index 7d8235d..1142d3e 100644
@@ -10,6 +10,7 @@ config SND_S3C24XX_SOC
 config SND_S3C24XX_SOC_I2S
 	tristate
 	select S3C2410_DMA
+	select SND_S3C_SOC_PCM
 
 config SND_S3C_I2SV2_SOC
 	tristate
@@ -18,16 +19,19 @@ config SND_S3C2412_SOC_I2S
 	tristate
 	select SND_S3C_I2SV2_SOC
 	select S3C2410_DMA
+	select SND_S3C_SOC_PCM
 
 config SND_S3C64XX_SOC_I2S
 	tristate
 	select SND_S3C_I2SV2_SOC
 	select S3C64XX_DMA
+	select SND_S3C_SOC_PCM
 
 config SND_S3C64XX_SOC_I2S_V4
 	tristate
 	select SND_S3C_I2SV2_SOC
 	select S3C64XX_DMA
+	select SND_S3C_SOC_PCM
 
 config SND_S3C_SOC_PCM
 	tristate
Signature · 1 line
1.7.1
#1 lore raw
Quoted 38 lines · Mark Brown

Kconfig got smart enough to do dependencies through selects so let's make use of that.

---
 sound/soc/s3c24xx/Kconfig |    4 ++++

 1 files changed, 4 insertions(+), 0 deletions(-)
sound/soc/s3c24xx/Kconfig +0 -0
index 7d8235d..1142d3e 100644
@@ -10,6 +10,7 @@ config SND_S3C24XX_SOC

 config SND_S3C24XX_SOC_I2S
       tristate
       select S3C2410_DMA
+       select SND_S3C_SOC_PCM

 config SND_S3C_I2SV2_SOC
       tristate

sound/soc/s3c24xx/Kconfig +0 -0
@@ -18,16 +19,19 @@ config SND_S3C2412_SOC_I2S

       tristate
       select SND_S3C_I2SV2_SOC
       select S3C2410_DMA
+       select SND_S3C_SOC_PCM

 config SND_S3C64XX_SOC_I2S
       tristate
       select SND_S3C_I2SV2_SOC
       select S3C64XX_DMA
+       select SND_S3C_SOC_PCM

 config SND_S3C64XX_SOC_I2S_V4
       tristate
       select SND_S3C_I2SV2_SOC
       select S3C64XX_DMA
+       select SND_S3C_SOC_PCM

Quoted 3 lines

 config SND_S3C_SOC_PCM
       tristate
--

SND_S3C_SOC_PCM builds s3c-pcm.c, which is the PCM controller's CPU driver.

s3c-dma.c is the DMA driver for Samsung SoCs, which is already built as the first
thing for Samsung ASoC.
_______________________________________________
Alsa-devel mailing list
[email protected]
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel

author
#2 lore raw
Quoted 5 lines · Jassi Brar

SND_S3C_SOC_PCM builds s3c-pcm.c, which is the PCM controller's CPU driver.

s3c-dma.c is the DMA driver for Samsung SoCs, which is already built as the first
thing for Samsung ASoC.

Gah, yeah. Wonder what my actual problem was then...

Acked-by on v1 1/1
#3 lore raw
In reply to Mark Brown
Quoted 30 lines · Mark Brown

Kconfig got smart enough to do dependencies through selects so let's make use of that.

---
 sound/soc/s3c24xx/Kconfig |    4 ++++
 1 files changed, 4 insertions(+), 0 deletions(-)
sound/soc/s3c24xx/Kconfig +2 -0
index 7d8235d..1142d3e 100644
@@ -10,6 +10,7 @@ config SND_S3C24XX_SOC
 config SND_S3C24XX_SOC_I2S
 	tristate
 	select S3C2410_DMA
+	select SND_S3C_SOC_PCM
 
 config SND_S3C_I2SV2_SOC
 	tristate
@@ -18,16 +19,19 @@ config SND_S3C2412_SOC_I2S
 	tristate
 	select SND_S3C_I2SV2_SOC
 	select S3C2410_DMA
+	select SND_S3C_SOC_PCM
 
 config SND_S3C64XX_SOC_I2S
 	tristate
 	select SND_S3C_I2SV2_SOC
 	select S3C64XX_DMA

sound/soc/s3c24xx/Kconfig config SND_S3C2412_SOC_I2S · line 37

Quoted 10 lines
sound/soc/s3c24xx/Kconfig +2 -0
+	select SND_S3C_SOC_PCM
 
 config SND_S3C64XX_SOC_I2S_V4
 	tristate
 	select SND_S3C_I2SV2_SOC
 	select S3C64XX_DMA
+	select SND_S3C_SOC_PCM
 
 config SND_S3C_SOC_PCM
 	tristate
Signature · 3 lines
Freelance Developer, SlimLogic Ltd
ASoC and Voltage Regulator Maintainer.
http://www.slimlogic.co.uk
#4 lore raw
In reply to Mark Brown
Quoted 13 lines · On 20 of September 2010 22:38:28 Mark Brown wrote:

Kconfig got smart enough to do dependencies through selects so let's make use of that.

---
 sound/soc/s3c24xx/Kconfig |    4 ++++
 1 files changed, 4 insertions(+), 0 deletions(-)
sound/soc/s3c24xx/Kconfig +0 -0
index 7d8235d..1142d3e 100644

sound/soc/s3c24xx/Kconfig config SND_S3C24XX_SOC · line 13

Quoted 4 lines
sound/soc/s3c24xx/Kconfig +1 -0
@@ -10,6 +10,7 @@ config SND_S3C24XX_SOC
 config SND_S3C24XX_SOC_I2S
 	tristate
 	select S3C2410_DMA
+	select SND_S3C_SOC_PCM

SND_S3C_SOC_PCM is not necessary for SND_S3C24XX_SOC, actually it works fine without it on my rx1950 (s3c2442-based)

Quoted 12 lines
sound/soc/s3c24xx/Kconfig +1 -0
 config SND_S3C_I2SV2_SOC
 	tristate
@@ -18,16 +19,19 @@ config SND_S3C2412_SOC_I2S
 	tristate
 	select SND_S3C_I2SV2_SOC
 	select S3C2410_DMA
+	select SND_S3C_SOC_PCM
 
 config SND_S3C64XX_SOC_I2S
 	tristate
 	select SND_S3C_I2SV2_SOC
 	select S3C64XX_DMA

sound/soc/s3c24xx/Kconfig config SND_S3C2412_SOC_I2S · line 37

Quoted 10 lines
sound/soc/s3c24xx/Kconfig +2 -0
+	select SND_S3C_SOC_PCM
 
 config SND_S3C64XX_SOC_I2S_V4
 	tristate
 	select SND_S3C_I2SV2_SOC
 	select S3C64XX_DMA
+	select SND_S3C_SOC_PCM
 
 config SND_S3C_SOC_PCM
 	tristate

Regards
Vasily